112129 2013-03-12 03:49:38 -0700 [Chromium] Rename android_build_type to android_webview_build in .gyp files 2013-03-13 07:15:32 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Android Android RESOLVED FIXED P2 Normal --- 1 mnaganov mnaganov abarth benm dglazkov peter peter+ews webkit.review.bot oldest_to_newest 853296 0 mnaganov 2013-03-12 03:49:38 -0700 Following Chromium http://src.chromium.org/viewvc/chrome?view=rev&revision=187556 this is being renamed to better explain what it does. 853300 1 192702 mnaganov 2013-03-12 03:53:24 -0700 Created attachment 192702 Patch Adam, please take a look! 853302 2 benm 2013-03-12 04:02:55 -0700 lgtm thanks Mikhail! 853315 3 192702 peter+ews 2013-03-12 04:16:53 -0700 Comment on attachment 192702 Patch Attachment 192702 did not pass cr-android-ews (chromium-android): Output: http://webkit-commit-queue.appspot.com/results/17008708 853327 4 peter 2013-03-12 04:21:51 -0700 Please be sure that WebKit rolls Chromium to or beyond r187556 before landing this patch, to avoid breaking the bots. All four changes LGTM. 853545 5 mnaganov 2013-03-12 09:24:43 -0700 Yes, sure. We are not in a rush. 853670 6 192702 abarth 2013-03-12 11:37:02 -0700 Comment on attachment 192702 Patch rs=me 854279 7 192702 webkit.review.bot 2013-03-13 07:15:28 -0700 Comment on attachment 192702 Patch Clearing flags on attachment: 192702 Committed r145714: <http://trac.webkit.org/changeset/145714> 854280 8 webkit.review.bot 2013-03-13 07:15:32 -0700 All reviewed patches have been landed. Closing bug. 192702 2013-03-12 03:53:24 -0700 2013-03-13 07:15:28 -0700 Patch wk-112129.patch text/plain 3638 mnaganov MGQxMWJhOTY2ZmYzZjk0NTRhYjY2NGJkOWFlMTI3NDI3ZGVjNjM3MSBbQ2hyb21pdW1dIFJlbmFt ZSBhbmRyb2lkX2J1aWxkX3R5cGUgdG8gYW5kcm9pZF93ZWJ2aWV3X2J1aWxkIGluIC5neXAgZmls ZXMuIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTIxMjkKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9j aHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXggMmY4MmI2OC4uZDViNzUwMSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1 bS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMy0wMy0xMiAgTWlraGFpbCBOYWdhbm92 ICA8bW5hZ2Fub3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtDaHJvbWl1bV0gUmVuYW1lIGFu ZHJvaWRfYnVpbGRfdHlwZSB0byBhbmRyb2lkX3dlYnZpZXdfYnVpbGQgaW4gLmd5cCBmaWxlcy4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMjEyOQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZvbGxvd2lu ZyBDaHJvbWl1bQorICAgICAgICBodHRwOi8vc3JjLmNocm9taXVtLm9yZy92aWV3dmMvY2hyb21l P3ZpZXc9cmV2JnJldmlzaW9uPTE4NzU1NgorICAgICAgICB0aGlzIGlzIGJlaW5nIHJlbmFtZWQg dG8gYmV0dGVyIGV4cGxhaW4gd2hhdCBpdCBkb2VzLgorCisgICAgICAgICogV2ViS2l0VW5pdFRl c3RzLmd5cDoKKwogMjAxMy0wMy0xMSAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBn bWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjE0NTQ2Mi4KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vV2ViS2l0VW5pdFRlc3RzLmd5cCBiL1Nv dXJjZS9XZWJLaXQvY2hyb21pdW0vV2ViS2l0VW5pdFRlc3RzLmd5cAppbmRleCA0NTkwZDllLi45 NzVhM2RmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL1dlYktpdFVuaXRUZXN0 cy5neXAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9XZWJLaXRVbml0VGVzdHMuZ3lwCkBA IC0xNDQsNyArMTQ0LDcgQEAKICAgICAgICAgICAgICAgICAnY2ZsYWdzX2NjJzogWyctV25vLWMr KzB4LWNvbXBhdCddLAogICAgICAgICAgICAgfSwKICAgICAgICAgfV0sCi0gICAgICAgIFsnT1M9 PSJhbmRyb2lkIiBhbmQgYW5kcm9pZF9idWlsZF90eXBlPT0wIGFuZCBndGVzdF90YXJnZXRfdHlw ZSA9PSAic2hhcmVkX2xpYnJhcnkiJywgeworICAgICAgICBbJ09TPT0iYW5kcm9pZCIgYW5kIGFu ZHJvaWRfd2Vidmlld19idWlsZD09MCBhbmQgZ3Rlc3RfdGFyZ2V0X3R5cGUgPT0gInNoYXJlZF9s aWJyYXJ5IicsIHsKICAgICAgICAgICAgICMgV3JhcCBsaWJ3ZWJraXRfdW5pdF90ZXN0cy5zbyBp bnRvIGFuIGFuZHJvaWQgYXBrIGZvciBleGVjdXRpb24uCiAgICAgICAgICAgICAndGFyZ2V0cyc6 IFt7CiAgICAgICAgICAgICAgICAgJ3RhcmdldF9uYW1lJzogJ3dlYmtpdF91bml0X3Rlc3RzX2Fw aycsCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXgg ZThjZGFkZi4uZDA0MWIzNiAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTAzLTEyICBNaWtoYWlsIE5hZ2Fub3Yg IDxtbmFnYW5vdkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW0Nocm9taXVtXSBSZW5hbWUgYW5k cm9pZF9idWlsZF90eXBlIHRvIGFuZHJvaWRfd2Vidmlld19idWlsZCBpbiAuZ3lwIGZpbGVzLgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEyMTI5CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRm9sbG93aW5n IENocm9taXVtCisgICAgICAgIGh0dHA6Ly9zcmMuY2hyb21pdW0ub3JnL3ZpZXd2Yy9jaHJvbWU/ dmlldz1yZXYmcmV2aXNpb249MTg3NTU2CisgICAgICAgIHRoaXMgaXMgYmVpbmcgcmVuYW1lZCB0 byBiZXR0ZXIgZXhwbGFpbiB3aGF0IGl0IGRvZXMuCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJl ZS9EdW1wUmVuZGVyVHJlZS5neXAvRHVtcFJlbmRlclRyZWUuZ3lwOgorCiAyMDEzLTAzLTExICBB bmRyZWFzIEtsaW5nICA8YWtsaW5nQGFwcGxlLmNvbT4KIAogICAgICAgICBbTWFjXVtXSzFdIEFk ZCBzdXBwb3J0IGZvciBhbGVydCgpIGluIE1pbmlCcm93c2VyLgpkaWZmIC0tZ2l0IGEvVG9vbHMv RHVtcFJlbmRlclRyZWUvRHVtcFJlbmRlclRyZWUuZ3lwL0R1bXBSZW5kZXJUcmVlLmd5cCBiL1Rv b2xzL0R1bXBSZW5kZXJUcmVlL0R1bXBSZW5kZXJUcmVlLmd5cC9EdW1wUmVuZGVyVHJlZS5neXAK aW5kZXggMmU2NWUxZC4uZTgxNjg2MyAxMDA2NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUv RHVtcFJlbmRlclRyZWUuZ3lwL0R1bXBSZW5kZXJUcmVlLmd5cAorKysgYi9Ub29scy9EdW1wUmVu ZGVyVHJlZS9EdW1wUmVuZGVyVHJlZS5neXAvRHVtcFJlbmRlclRyZWUuZ3lwCkBAIC02OSwxMiAr NjksMTIgQEAKICAgICAgICAgICAgICAgICAnPCh0b29sc19kaXIpL0R1bXBSZW5kZXJUcmVlL2No cm9taXVtL0ltYWdlRGlmZi5jcHAnLAogICAgICAgICAgICAgXSwKICAgICAgICAgICAgICdjb25k aXRpb25zJzogWwotICAgICAgICAgICAgICAgIFsnT1M9PSJhbmRyb2lkIiBhbmQgYW5kcm9pZF9i dWlsZF90eXBlPT0wJywgeworICAgICAgICAgICAgICAgIFsnT1M9PSJhbmRyb2lkIiBhbmQgYW5k cm9pZF93ZWJ2aWV3X2J1aWxkPT0wJywgewogICAgICAgICAgICAgICAgICAgICAjIFRoZSBDaHJv bWl1bSBBbmRyb2lkIHBvcnQgd2lsbCBjb21wYXJlIGltYWdlcyBvbiBob3N0IHJhdGhlcgogICAg ICAgICAgICAgICAgICAgICAjIHRoYW4gdGFyZ2V0IChhIGRldmljZSBvciBlbXVsYXRvcikgZm9y IHBlcmZvcm1hbmNlIHJlYXNvbnMuCiAgICAgICAgICAgICAgICAgICAgICd0b29sc2V0cyc6IFsn aG9zdCddLAogICAgICAgICAgICAgICAgIH1dLAotICAgICAgICAgICAgICAgIFsnT1M9PSJhbmRy b2lkIiBhbmQgYW5kcm9pZF9idWlsZF90eXBlIT0wJywgeworICAgICAgICAgICAgICAgIFsnT1M9 PSJhbmRyb2lkIiBhbmQgYW5kcm9pZF93ZWJ2aWV3X2J1aWxkPT0xJywgewogICAgICAgICAgICAg ICAgICAgICAndHlwZSc6ICdub25lJywKICAgICAgICAgICAgICAgICB9XSwKICAgICAgICAgICAg IF0sCkBAIC0yMTksNyArMjE5LDcgQEAKICAgICAgICAgICAgICAgICAgICAgICAgIF0KICAgICAg ICAgICAgICAgICAgICAgfV0sCiAgICAgICAgICAgICAgICAgfV0sCi0gICAgICAgICAgICAgICAg WydPUz09ImFuZHJvaWQiIGFuZCBhbmRyb2lkX2J1aWxkX3R5cGU9PTAnLCB7CisgICAgICAgICAg ICAgICAgWydPUz09ImFuZHJvaWQiIGFuZCBhbmRyb2lkX3dlYnZpZXdfYnVpbGQ9PTAnLCB7CiAg ICAgICAgICAgICAgICAgICAgICdkZXBlbmRlbmNpZXMnOiBbCiAgICAgICAgICAgICAgICAgICAg ICAgICAnSW1hZ2VEaWZmI2hvc3QnLAogICAgICAgICAgICAgICAgICAgICBdLAo=