112123 2013-03-12 02:54:43 -0700 Web Inspector: add html canvas memory details to the native memory overview 2013-03-12 07:37:47 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 yurys yurys apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs yurys oldest_to_newest 853254 0 yurys 2013-03-12 02:54:43 -0700 In addition to cached images we can show memory occupied by HTMLCanvasElements under Image category. 853256 1 192687 yurys 2013-03-12 02:56:03 -0700 Created attachment 192687 Patch 853321 2 192687 apavlov 2013-03-12 04:20:36 -0700 Comment on attachment 192687 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=192687&action=review > Source/WebCore/inspector/front-end/NativeHeapSnapshot.js:82 > + var canvases = aggregatesByClassName["WebCore::HTMLCanvasElement"]; Please add a blank line above to separate the two types of "images". > Source/WebCore/inspector/front-end/NativeHeapSnapshot.js:85 > + return "HTMLCanvasElement"; node.name() above returns something akin to "IMG", which is an HTML name of the tag, as opposed to "HTMLCanvasElement", which is a DOM type name. Inconsistency ensues. 853442 3 yurys 2013-03-12 07:35:27 -0700 (In reply to comment #2) > (From update of attachment 192687 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=192687&action=review > > > Source/WebCore/inspector/front-end/NativeHeapSnapshot.js:82 > > + var canvases = aggregatesByClassName["WebCore::HTMLCanvasElement"]; > > Please add a blank line above to separate the two types of "images". > Done. > > Source/WebCore/inspector/front-end/NativeHeapSnapshot.js:85 > > + return "HTMLCanvasElement"; > > node.name() above returns something akin to "IMG", which is an HTML name of the tag, as opposed to "HTMLCanvasElement", which is a DOM type name. Inconsistency ensues. No, node.name() returns URL of the cached image. We don't have user-friendly name yet so return generic name. 853443 4 yurys 2013-03-12 07:37:47 -0700 Committed r145540: <http://trac.webkit.org/changeset/145540> 192687 2013-03-12 02:56:03 -0700 2013-03-12 04:20:36 -0700 Patch bug-112123-20130312135202.patch text/plain 2917 yurys U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1NDkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWE5ODQxZGJlMGJkNTMw NDlmNmY3NDFhYzJkYjg0Zjk4NjE2N2MxZi4uYTFhMTUwZTRmOTdkNjU2ZjhlNmY5Yzg2MDBkODY5 ZWNkNTVjNjRlZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIxIEBACiAyMDEzLTAzLTEyICBZdXJ5 IFNlbWlraGF0c2t5ICA8eXVyeXNAY2hyb21pdW0ub3JnPgogCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IGFkZCBodG1sIGNhbnZhcyBtZW1vcnkgZGV0YWlscyB0byB0aGUgbmF0aXZlIG1lbW9yeSBv dmVydmlldworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTEyMTIzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg U2hvdyBtZW1vcnkgb2NjdXBpZWQgdmJ5IEhUTUxDYW52YXNFbGVtZW50cyB1bmRlciBJbWFnZSBj YXRlZ29yeQorICAgICAgICBpbiB0aGUgbmF0aXZlIG1lbW9yeSBvdmVydmlldy4KKworICAgICAg ICAqIGluc3BlY3Rvci9mcm9udC1lbmQvTmF0aXZlSGVhcFNuYXBzaG90LmpzOgorICAgICAgICAo V2ViSW5zcGVjdG9yLk5hdGl2ZUhlYXBTbmFwc2hvdC5wcm90b3R5cGUuaW1hZ2VzLmdldEltYWdl TmFtZSk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuTmF0aXZlSGVhcFNuYXBzaG90LnByb3RvdHlw ZS5pbWFnZXMuZ2V0Q2FudmFzTmFtZSk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuTmF0aXZlSGVh cFNuYXBzaG90LnByb3RvdHlwZS5pbWFnZXMpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLk5hdGl2 ZUhlYXBTbmFwc2hvdC5wcm90b3R5cGUuX2FkZE5vZGVzKToKKworMjAxMy0wMy0xMiAgWXVyeSBT ZW1pa2hhdHNreSAgPHl1cnlzQGNocm9taXVtLm9yZz4KKwogICAgICAgICBXZWIgSW5zcGVjdG9y OiBhZGQgbWVtb3J5IGluc3RydW1lbnRhdGlvbiBmb3IgSW1hZ2VMb2FkZXIKICAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMjExNQogCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL05hdGl2ZUhlYXBTbmFwc2hvdC5q cyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvTmF0aXZlSGVhcFNuYXBzaG90 LmpzCmluZGV4IDVjYzFmZmIyZTM0YzQ1NGY0ZjdjOTkwM2Q1YzFkZGIwMWZmMmE3ZmIuLjk4Y2Zk N2FjMjAyZTU4MzUxM2U0MmViN2Q0M2Q3MzgxMTJjNWNhOTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvTmF0aXZlSGVhcFNuYXBzaG90LmpzCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvTmF0aXZlSGVhcFNuYXBzaG90LmpzCkBA IC03MiwxOSArNzIsMzQgQEAgV2ViSW5zcGVjdG9yLk5hdGl2ZUhlYXBTbmFwc2hvdC5wcm90b3R5 cGUgPSB7CiAgICAgaW1hZ2VzOiBmdW5jdGlvbigpCiAgICAgewogICAgICAgICB2YXIgYWdncmVn YXRlc0J5Q2xhc3NOYW1lID0gdGhpcy5hZ2dyZWdhdGVzKGZhbHNlLCAiYWxsT2JqZWN0cyIpOwot ICAgICAgICB2YXIgaW1hZ2VzID0gYWdncmVnYXRlc0J5Q2xhc3NOYW1lWyJXZWJDb3JlOjpDYWNo ZWRJbWFnZSJdOwogICAgICAgICB2YXIgcmVzdWx0ID0gW107Ci0gICAgICAgIGlmICghaW1hZ2Vz KQotICAgICAgICAgICAgcmV0dXJuIHJlc3VsdDsKKyAgICAgICAgdmFyIGNhY2hlZEltYWdlcyA9 IGFnZ3JlZ2F0ZXNCeUNsYXNzTmFtZVsiV2ViQ29yZTo6Q2FjaGVkSW1hZ2UiXTsKKyAgICAgICAg ZnVuY3Rpb24gZ2V0SW1hZ2VOYW1lKG5vZGUpCisgICAgICAgIHsKKyAgICAgICAgICAgIHJldHVy biBub2RlLm5hbWUoKTsKKyAgICAgICAgfQorICAgICAgICB0aGlzLl9hZGROb2RlcyhjYWNoZWRJ bWFnZXMsIGdldEltYWdlTmFtZSwgcmVzdWx0KTsKKyAgICAgICAgdmFyIGNhbnZhc2VzID0gYWdn cmVnYXRlc0J5Q2xhc3NOYW1lWyJXZWJDb3JlOjpIVE1MQ2FudmFzRWxlbWVudCJdOworICAgICAg ICBmdW5jdGlvbiBnZXRDYW52YXNOYW1lKG5vZGUpCisgICAgICAgIHsKKyAgICAgICAgICAgIHJl dHVybiAiSFRNTENhbnZhc0VsZW1lbnQiOworICAgICAgICB9CisgICAgICAgIHRoaXMuX2FkZE5v ZGVzKGNhbnZhc2VzLCBnZXRDYW52YXNOYW1lLCByZXN1bHQpOworICAgICAgICByZXR1cm4gcmVz dWx0OworICAgIH0sCisKKyAgICBfYWRkTm9kZXM6IGZ1bmN0aW9uKGNsYXNzRGF0YSwgbmFtZVJl c29sdmVyLCByZXN1bHQpCisgICAgeworICAgICAgICBpZiAoIWNsYXNzRGF0YSkKKyAgICAgICAg ICAgIHJldHVybjsKICAgICAgICAgdmFyIG5vZGUgPSB0aGlzLnJvb3ROb2RlKCk7Ci0gICAgICAg IGZvciAodmFyIGkgPSAwOyBpIDwgaW1hZ2VzLmlkeHMubGVuZ3RoOyBpKyspIHsKLSAgICAgICAg ICAgIG5vZGUubm9kZUluZGV4ID0gaW1hZ2VzLmlkeHNbaV07CisgICAgICAgIGZvciAodmFyIGkg PSAwOyBpIDwgY2xhc3NEYXRhLmlkeHMubGVuZ3RoOyBpKyspIHsKKyAgICAgICAgICAgIG5vZGUu bm9kZUluZGV4ID0gY2xhc3NEYXRhLmlkeHNbaV07CiAgICAgICAgICAgICByZXN1bHQucHVzaCh7 Ci0gICAgICAgICAgICAgICAgbmFtZTogbm9kZS5uYW1lKCksCisgICAgICAgICAgICAgICAgbmFt ZTogbmFtZVJlc29sdmVyKG5vZGUpLAogICAgICAgICAgICAgICAgIHNpemU6IG5vZGUucmV0YWlu ZWRTaXplKCksCiAgICAgICAgICAgICB9KTsKICAgICAgICAgfQotICAgICAgICByZXR1cm4gcmVz dWx0OwogICAgIH0sCiAKICAgICBfX3Byb3RvX186IFdlYkluc3BlY3Rvci5IZWFwU25hcHNob3Qu cHJvdG90eXBlCg==