112119 2013-03-12 02:22:07 -0700 Web Inspector: [Elements] Unable to undo "Edit as HTML" changes in the editor 2013-03-12 05:25:55 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 apavlov apavlov apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 853222 0 apavlov 2013-03-12 02:22:07 -0700 What steps will reproduce the problem? 1. Open Web Inspector on any page 2. In Elements, drag-and-drop any element to change its position in the DOM 3. Right click any element, "Edit as HTML". Optionally, type in some text. 4. Try Ctrl + Z to undo text change. What is the expected result? Text entry is undone to restore the original HTML. What happens instead? Element DnD is undone. Upstreaming https://code.google.com/p/chromium/issues/detail?id=181157 853257 1 192688 apavlov 2013-03-12 02:56:27 -0700 Created attachment 192688 Patch 853370 2 192688 webkit.review.bot 2013-03-12 05:25:52 -0700 Comment on attachment 192688 Patch Clearing flags on attachment: 192688 Committed r145531: <http://trac.webkit.org/changeset/145531> 853371 3 webkit.review.bot 2013-03-12 05:25:55 -0700 All reviewed patches have been landed. Closing bug. 192688 2013-03-12 02:56:27 -0700 2013-03-12 05:25:52 -0700 Patch bug-112119-20130312135225.patch text/plain 3924 apavlov U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1NTAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGU3OWYxNDk2NjFmYTVi MWM4MzhhMmUyOTUwYTNlOTYzMzQ4NjA3Ny4uM2VkNzI4NTY2OGNmMDk0MWU3ZDVlYzBmNGUxMWVk MTk5NDg2NWFmNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTAzLTEyICBBbGV4 YW5kZXIgUGF2bG92ICA8YXBhdmxvdkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViIEluc3Bl Y3RvcjogW0VsZW1lbnRzXSBVbmFibGUgdG8gdW5kbyAiRWRpdCBhcyBIVE1MIiBjaGFuZ2VzIGlu IHRoZSBlZGl0b3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTExMjExOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIE5vIG5ldyB0ZXN0cywgYSBVSSBjaGFuZ2UuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJv bnQtZW5kL0VsZW1lbnRzUGFuZWwuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRWxlbWVudHNQ YW5lbC5wcm90b3R5cGUuaGFuZGxlU2hvcnRjdXQpOiBEbyBub3QgdW5kby9yZWRvIERPTS9DU1Mg Y2hhbmdlcyBpZiBlZGl0aW5nIERPTSB0ZXh0LgorICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1l bmQvRWxlbWVudHNUcmVlT3V0bGluZS5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5FbGVtZW50 c1RyZWVPdXRsaW5lLnByb3RvdHlwZS5lZGl0aW5nKTogQWRkZWQuCisKIDIwMTMtMDMtMTIgIFNo ZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2 aWV3ZWQsIHJvbGxpbmcgb3V0IHIxNDU0OTQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9p bnNwZWN0b3IvZnJvbnQtZW5kL0VsZW1lbnRzUGFuZWwuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNw ZWN0b3IvZnJvbnQtZW5kL0VsZW1lbnRzUGFuZWwuanMKaW5kZXggZjM3ZjA0YTNjOWEzY2UzMDUy MzQyZTE0NjUyZWQ5ZjBhOGRiYWMwNy4uOGIxZWMyNzUyZGYxNjk0ZTlkZjZlZDA0YWZmMGUzOTA2 NjA2NGM2NCAxMDA3NTUKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9F bGVtZW50c1BhbmVsLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQv RWxlbWVudHNQYW5lbC5qcwpAQCAtMTAxMSwxOCArMTAxMSwyNiBAQCBXZWJJbnNwZWN0b3IuRWxl bWVudHNQYW5lbC5wcm90b3R5cGUgPSB7CiAKICAgICBoYW5kbGVTaG9ydGN1dDogZnVuY3Rpb24o ZXZlbnQpCiAgICAgewotICAgICAgICBpZiAoV2ViSW5zcGVjdG9yLktleWJvYXJkU2hvcnRjdXQu ZXZlbnRIYXNDdHJsT3JNZXRhKGV2ZW50KSAmJiAhZXZlbnQuc2hpZnRLZXkgJiYgZXZlbnQua2V5 SWRlbnRpZmllciA9PT0gIlUrMDA1QSIpIHsgLy8gWiBrZXkKLSAgICAgICAgICAgIFdlYkluc3Bl Y3Rvci5kb21BZ2VudC51bmRvKHRoaXMuX3VwZGF0ZVNpZGViYXJzLmJpbmQodGhpcykpOwotICAg ICAgICAgICAgZXZlbnQuaGFuZGxlZCA9IHRydWU7Ci0gICAgICAgICAgICByZXR1cm47CisgICAg ICAgIGZ1bmN0aW9uIGhhbmRsZVVuZG9SZWRvKCkKKyAgICAgICAgeworICAgICAgICAgICAgaWYg KFdlYkluc3BlY3Rvci5LZXlib2FyZFNob3J0Y3V0LmV2ZW50SGFzQ3RybE9yTWV0YShldmVudCkg JiYgIWV2ZW50LnNoaWZ0S2V5ICYmIGV2ZW50LmtleUlkZW50aWZpZXIgPT09ICJVKzAwNUEiKSB7 IC8vIFoga2V5CisgICAgICAgICAgICAgICAgV2ViSW5zcGVjdG9yLmRvbUFnZW50LnVuZG8odGhp cy5fdXBkYXRlU2lkZWJhcnMuYmluZCh0aGlzKSk7CisgICAgICAgICAgICAgICAgZXZlbnQuaGFu ZGxlZCA9IHRydWU7CisgICAgICAgICAgICAgICAgcmV0dXJuOworICAgICAgICAgICAgfQorCisg ICAgICAgICAgICB2YXIgaXNSZWRvS2V5ID0gV2ViSW5zcGVjdG9yLmlzTWFjKCkgPyBldmVudC5t ZXRhS2V5ICYmIGV2ZW50LnNoaWZ0S2V5ICYmIGV2ZW50LmtleUlkZW50aWZpZXIgPT09ICJVKzAw NUEiIDogLy8gWiBrZXkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIGV2ZW50LmN0cmxLZXkgJiYgZXZlbnQua2V5SWRlbnRpZmllciA9PT0gIlUrMDA1 OSI7IC8vIFkga2V5CisgICAgICAgICAgICBpZiAoaXNSZWRvS2V5KSB7CisgICAgICAgICAgICAg ICAgRE9NQWdlbnQucmVkbyh0aGlzLl91cGRhdGVTaWRlYmFycy5iaW5kKHRoaXMpKTsKKyAgICAg ICAgICAgICAgICBldmVudC5oYW5kbGVkID0gdHJ1ZTsKKyAgICAgICAgICAgIH0KICAgICAgICAg fQogCi0gICAgICAgIHZhciBpc1JlZG9LZXkgPSBXZWJJbnNwZWN0b3IuaXNNYWMoKSA/IGV2ZW50 Lm1ldGFLZXkgJiYgZXZlbnQuc2hpZnRLZXkgJiYgZXZlbnQua2V5SWRlbnRpZmllciA9PT0gIlUr MDA1QSIgOiAvLyBaIGtleQotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBldmVudC5jdHJsS2V5ICYmIGV2ZW50LmtleUlkZW50aWZpZXIgPT09ICJVKzAwNTki OyAvLyBZIGtleQotICAgICAgICBpZiAoaXNSZWRvS2V5KSB7Ci0gICAgICAgICAgICBET01BZ2Vu dC5yZWRvKHRoaXMuX3VwZGF0ZVNpZGViYXJzLmJpbmQodGhpcykpOwotICAgICAgICAgICAgZXZl bnQuaGFuZGxlZCA9IHRydWU7Ci0gICAgICAgICAgICByZXR1cm47CisgICAgICAgIGlmICghdGhp cy50cmVlT3V0bGluZS5lZGl0aW5nKCkpIHsKKyAgICAgICAgICAgIGhhbmRsZVVuZG9SZWRvLmNh bGwodGhpcyk7CisgICAgICAgICAgICBpZiAoZXZlbnQuaGFuZGxlZCkKKyAgICAgICAgICAgICAg ICByZXR1cm47CiAgICAgICAgIH0KIAogICAgICAgICB0aGlzLnRyZWVPdXRsaW5lLmhhbmRsZVNo b3J0Y3V0KGV2ZW50KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9u dC1lbmQvRWxlbWVudHNUcmVlT3V0bGluZS5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9m cm9udC1lbmQvRWxlbWVudHNUcmVlT3V0bGluZS5qcwppbmRleCA4Y2U3ZjBlMjcyZDlmNGUyOTRk MTgwZTJkNjQ3ZWY3ZjM5ODhhOWVhLi44MDNhNWI3NzBhNDkwZjU1NzczYzAxNzk4NGQyODgyYjE5 ZDU2ZmIzIDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0Vs ZW1lbnRzVHJlZU91dGxpbmUuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250 LWVuZC9FbGVtZW50c1RyZWVPdXRsaW5lLmpzCkBAIC0xNjYsNiArMTY2LDIwIEBAIFdlYkluc3Bl Y3Rvci5FbGVtZW50c1RyZWVPdXRsaW5lLnByb3RvdHlwZSA9IHsKICAgICAgICAgICAgIHRoaXMu X3NlbGVjdGVkTm9kZUNoYW5nZWQoKTsKICAgICB9LAogCisgICAgLyoqCisgICAgICogQHJldHVy biB7Ym9vbGVhbn0KKyAgICAgKi8KKyAgICBlZGl0aW5nOiBmdW5jdGlvbigpCisgICAgeworICAg ICAgICB2YXIgbm9kZSA9IHRoaXMuc2VsZWN0ZWRET01Ob2RlKCk7CisgICAgICAgIGlmICghbm9k ZSkKKyAgICAgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICAgICAgdmFyIHRyZWVFbGVtZW50ID0g dGhpcy5maW5kVHJlZUVsZW1lbnQobm9kZSk7CisgICAgICAgIGlmICghdHJlZUVsZW1lbnQpCisg ICAgICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgICAgIHJldHVybiB0cmVlRWxlbWVudC5fZWRp dGluZyB8fCBmYWxzZTsKKyAgICB9LAorCiAgICAgdXBkYXRlOiBmdW5jdGlvbigpCiAgICAgewog ICAgICAgICB2YXIgc2VsZWN0ZWROb2RlID0gdGhpcy5zZWxlY3RlZFRyZWVFbGVtZW50ID8gdGhp cy5zZWxlY3RlZFRyZWVFbGVtZW50LnJlcHJlc2VudGVkT2JqZWN0IDogbnVsbDsK