112111 2013-03-12 00:48:22 -0700 Web Inspector: Several inspector tests are flaky beacuse of beforeonload event handler. 2013-03-12 01:27:37 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 vsevik vsevik apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 853151 0 vsevik 2013-03-12 00:48:22 -0700 An example of such test: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=inspector%2Fdebugger%2Fbreakpoint-manager.html I think this is caused by calling window.addEventListener("beforeunload", onBeforeUnload); without removing such listener in inspector-protocol/page/javascriptDialogEvents.html Patch to follow 853154 1 192659 vsevik 2013-03-12 00:51:12 -0700 Created attachment 192659 Patch 853155 2 192659 apavlov 2013-03-12 00:52:35 -0700 Comment on attachment 192659 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=192659&action=review > LayoutTests/ChangeLog:9 > + Beforeunload message was updated so that it is possible to find it's source from it. ...its source... 853179 3 192659 webkit.review.bot 2013-03-12 01:27:33 -0700 Comment on attachment 192659 Patch Clearing flags on attachment: 192659 Committed r145498: <http://trac.webkit.org/changeset/145498> 853180 4 webkit.review.bot 2013-03-12 01:27:37 -0700 All reviewed patches have been landed. Closing bug. 192659 2013-03-12 00:51:12 -0700 2013-03-12 01:27:33 -0700 Patch bug-112111-20130312114710.patch text/plain 2319 vsevik U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1NDkyCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNDFlZjcwZTY3MGFlMWY1M2NlMWVm Y2Y2ZTYyZDA3NTQ3MjcyNjE2YS4uMGQ2OWIxYzIzODNiZWIzOWMwZjlkZWIzODQ5NjYzYWI3Njk2 NTdjMSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDEzLTAzLTEyICBWc2V2b2xvZCBWbGFzb3Yg IDx2c2V2aWtAY2hyb21pdW0ub3JnPgogCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IFNldmVyYWwg aW5zcGVjdG9yIHRlc3RzIGFyZSBmbGFreSBiZWFjdXNlIG9mIGJlZm9yZW9ubG9hZCBldmVudCBo YW5kbGVyLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTEyMTExCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg QWRkZWQgcmVtb3ZlRXZlbnRMaXN0ZW5lciBjYWxsLgorICAgICAgICBCZWZvcmV1bmxvYWQgbWVz c2FnZSB3YXMgdXBkYXRlZCBzbyB0aGF0IGl0IGlzIHBvc3NpYmxlIHRvIGZpbmQgaXQncyBzb3Vy Y2UgZnJvbSBpdC4KKworICAgICAgICAqIGluc3BlY3Rvci1wcm90b2NvbC9wYWdlL2phdmFzY3Jp cHREaWFsb2dFdmVudHMtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGluc3BlY3Rvci1wcm90b2Nv bC9wYWdlL2phdmFzY3JpcHREaWFsb2dFdmVudHMuaHRtbDoKKworMjAxMy0wMy0xMiAgVnNldm9s b2QgVmxhc292ICA8dnNldmlrQGNocm9taXVtLm9yZz4KKwogICAgICAgICBVbnJldmlld2VkIHRl c3QgZmxha2luZXNzIGZpeC4KIAogICAgICAgICAqIGluc3BlY3Rvci9kZWJ1Z2dlci9ldmVudC1s aXN0ZW5lci1icmVha3BvaW50cy5odG1sOgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW5zcGVj dG9yLXByb3RvY29sL3BhZ2UvamF2YXNjcmlwdERpYWxvZ0V2ZW50cy1leHBlY3RlZC50eHQgYi9M YXlvdXRUZXN0cy9pbnNwZWN0b3ItcHJvdG9jb2wvcGFnZS9qYXZhc2NyaXB0RGlhbG9nRXZlbnRz LWV4cGVjdGVkLnR4dAppbmRleCA5NzIwZDg2ODZkN2M1NWQ3OTczM2ViYzQxNjhmYjlkMzQxODcw OTk5Li5hNzQ4NzJkNGU1ZWM1NDg4YmE0YmM4OTY4N2UwZGU2Yjg0M2E0Mjc0IDEwMDY0NAotLS0g YS9MYXlvdXRUZXN0cy9pbnNwZWN0b3ItcHJvdG9jb2wvcGFnZS9qYXZhc2NyaXB0RGlhbG9nRXZl bnRzLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3ItcHJvdG9jb2wvcGFn ZS9qYXZhc2NyaXB0RGlhbG9nRXZlbnRzLWV4cGVjdGVkLnR4dApAQCAtMSw4ICsxLDggQEAKLUNP TkZJUk0gTkFWSUdBVElPTjogYmVmb3JldW5sb2FkCitDT05GSVJNIE5BVklHQVRJT046IGJlZm9y ZXVubG9hZCBpbiBqYXZhc2NyaXB0RGlhbG9nRXZlbnRzCiBBTEVSVDogYWxlcnQKIENPTkZJUk06 IGNvbmZpcm0KIFBST01QVDogcHJvbXB0LCBkZWZhdWx0IHRleHQ6IAotT3BlbmluZyB3aXRoIG1l c3NhZ2U6IGJlZm9yZXVubG9hZAorT3BlbmluZyB3aXRoIG1lc3NhZ2U6IGJlZm9yZXVubG9hZCBp biBqYXZhc2NyaXB0RGlhbG9nRXZlbnRzCiBDbG9zZWQKIE9wZW5pbmcgd2l0aCBtZXNzYWdlOiBh bGVydAogQ2xvc2VkCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3ItcHJvdG9jb2wv cGFnZS9qYXZhc2NyaXB0RGlhbG9nRXZlbnRzLmh0bWwgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3It cHJvdG9jb2wvcGFnZS9qYXZhc2NyaXB0RGlhbG9nRXZlbnRzLmh0bWwKaW5kZXggMjNlNjBhZDJm YTc5NzIwM2IxNzI1OWZjOTZmMDE3MGE3ZjAyMjAyZi4uYTk0OTRhN2Y0OTVkY2I1YmQ4OGJhODc2 NDA1N2UyNjQ3MGRjNWI1ZiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9yLXByb3Rv Y29sL3BhZ2UvamF2YXNjcmlwdERpYWxvZ0V2ZW50cy5odG1sCisrKyBiL0xheW91dFRlc3RzL2lu c3BlY3Rvci1wcm90b2NvbC9wYWdlL2phdmFzY3JpcHREaWFsb2dFdmVudHMuaHRtbApAQCAtNyw3 ICs3LDggQEAgd2luZG93LmFkZEV2ZW50TGlzdGVuZXIoImJlZm9yZXVubG9hZCIsIG9uQmVmb3Jl VW5sb2FkKTsKIAogZnVuY3Rpb24gb25CZWZvcmVVbmxvYWQoKQogewotICAgIHJldHVybiAiYmVm b3JldW5sb2FkIjsKKyAgICB3aW5kb3cucmVtb3ZlRXZlbnRMaXN0ZW5lcigiYmVmb3JldW5sb2Fk Iiwgb25CZWZvcmVVbmxvYWQpOworICAgIHJldHVybiAiYmVmb3JldW5sb2FkIGluIGphdmFzY3Jp cHREaWFsb2dFdmVudHMiOwogfQogCiBmdW5jdGlvbiB0ZXN0KCkK