112089 2013-03-11 18:32:27 -0700 [chromium] Fix flaky timeouts in platform/chromium/events/fast/events/intercept-postmessage.html 2013-03-11 21:25:02 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jamesr jamesr abarth creis webkit.review.bot oldest_to_newest 852959 0 jamesr 2013-03-11 18:32:27 -0700 [chromium] Fix flaky timeouts in platform/chromium/events/fast/events/intercept-postmessage.html 852966 1 192618 jamesr 2013-03-11 18:39:30 -0700 Created attachment 192618 Patch 852968 2 jamesr 2013-03-11 18:40:32 -0700 This test has been very annoying while gardening today: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=platform%2Fchromium%2Ffast%2Fevents%2Fintercept-postmessage.html 852979 3 jamesr 2013-03-11 18:50:56 -0700 Example failure log (reason explained in the ChangeLog): -intercepted postMessage -intercepted postMessage -RECV1 +CONSOLE MESSAGE: line 7: Uncaught TypeError: Cannot call method 'appendChild' of null +FAIL: Timed out waiting for notifyDone to be called 853041 4 192618 webkit.review.bot 2013-03-11 21:24:59 -0700 Comment on attachment 192618 Patch Clearing flags on attachment: 192618 Committed r145473: <http://trac.webkit.org/changeset/145473> 853043 5 webkit.review.bot 2013-03-11 21:25:02 -0700 All reviewed patches have been landed. Closing bug. 192618 2013-03-11 18:39:30 -0700 2013-03-11 21:24:58 -0700 Patch bug-112089-20130311183529.patch text/plain 4460 jamesr U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1NDQ1CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggODkyOWY1NjJjNjYyYjNjZjVlNWI2 ZDIwMTQzMWZiNGQyMDdiNTVlYy4uMjU4OTE1MTZkZWNhMTRlMDY3NjZjODA5NTliYWJhODIzNjI4 OTkyMyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDEzLTAzLTExICBKYW1lcyBSb2JpbnNvbiAg PGphbWVzckBjaHJvbWl1bS5vcmc+CiAKKyAgICAgICAgW2Nocm9taXVtXSBGaXggZmxha3kgdGlt ZW91dHMgaW4gcGxhdGZvcm0vY2hyb21pdW0vZXZlbnRzL2Zhc3QvZXZlbnRzL2ludGVyY2VwdC1w b3N0bWVzc2FnZS5odG1sCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMTIwODkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBUaGlzIHRlc3QgaGFkIGEgZmV3IHByb2JsZW1zLiBUaGUgbW9zdCBzZXJpb3VzIGlz IGl0IHJhY2VkIGEgd2luZG93LnBvc3RNZXNzYWdlKCkgZnJvbSBhbiBpbmxpbmUgPHNjcmlwdD4g aW4gdGhlCisgICAgICAgIDxoZWFkPiB3aXRoIHRoZSBIVE1MIHBhcnNlciBwcm9jZXNzaW5nIHRo ZSByZXN0IG9mIHRoZSB0ZXN0Y2FzZS4gSWYgdGhlIEhUTUwgcGFyc2VyIHlpZWxkZWQgYmVmb3Jl IHBhcnNpbmcgb3V0CisgICAgICAgIHRoZSA8cHJlIGlkPSJjb25zb2xlIj4sIGZ1bmN0aW9uIHJl Y3ZNc2cxIHdvdWxkIGdlbmVyYXRlIGFuIGVycm9yIGFjY2Vzc2luZyB0aGUgdW5kZWZpbmVkIHBy ZS4gVGhlIHRlc3QgYWxzbworICAgICAgICBzZXQgdXAgYSBzZXRUaW1lb3V0IHdpdGggYSB0aW1l b3V0IG9mIDUwbXMgdG8gcnVuIGFmdGVyIGEgcG9zdE1lc3NhZ2UgaGFuZGxlci4gVGhlcmUncyBu byBuZWVkIHRvIHdhaXQgYWZ0ZXIKKyAgICAgICAgeWllbGRpbmcgZm9yIGEgdGltZW91dCwgdGhl c2UgZXZlbnRzIGFyZSBwcm9jZXNzZWQgaW4gb3JkZXIuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9j aHJvbWl1bS9mYXN0L2V2ZW50cy9pbnRlcmNlcHQtcG9zdG1lc3NhZ2UuaHRtbDoKKworMjAxMy0w My0xMSAgSmFtZXMgUm9iaW5zb24gIDxqYW1lc3JAY2hyb21pdW0ub3JnPgorCiAgICAgICAgIE1v cmUgY2hyb21pdW0gbGF5ZXIgdHJlZSByZWJhc2VsaW5lcyBmb3IgcjE0NTQyMgogCiAgICAgICAg ICogcGxhdGZvcm0vY2hyb21pdW0tbWFjLWxpb24vY29tcG9zaXRpbmcvbGF5ZXItY3JlYXRpb24v Zml4ZWQtcG9zaXRpb24tb3V0LW9mLXZpZXctc2NhbGVkLWV4cGVjdGVkLnR4dDogQ29waWVkIGZy b20gTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vcGxhdGZvcm0vY2hyb21pdW0vdmlydHVh bC9zb2Z0d2FyZWNvbXBvc2l0aW5nL2xheWVyLWNyZWF0aW9uL2ZpeGVkLXBvc2l0aW9uLW91dC1v Zi12aWV3LXNjYWxlZC1leHBlY3RlZC50eHQuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0 Zm9ybS9jaHJvbWl1bS9mYXN0L2V2ZW50cy9pbnRlcmNlcHQtcG9zdG1lc3NhZ2UuaHRtbCBiL0xh eW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL2Zhc3QvZXZlbnRzL2ludGVyY2VwdC1wb3N0bWVz c2FnZS5odG1sCmluZGV4IGZhZDA0M2M5Mjc2M2JkNWE2MjFjZWE5OGY5MTkxYTllODVhMDM0ZjYu LjZiM2IwMDA0MDU3NmMzY2Q5MTRmMWFmZmQ2MDU3OTc2MjY5ODZmYzMgMTAwNjQ0Ci0tLSBhL0xh eW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL2Zhc3QvZXZlbnRzL2ludGVyY2VwdC1wb3N0bWVz c2FnZS5odG1sCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL2Zhc3QvZXZlbnRz L2ludGVyY2VwdC1wb3N0bWVzc2FnZS5odG1sCkBAIC0xLDQ5ICsxLDQ0IEBACis8IURPQ1RZUEUg aHRtbD4KIDxodG1sPgotICA8aGVhZD4KLSAgICA8c2NyaXB0PgotICAgICAgZnVuY3Rpb24gd3Jp dGUoc3RyKSB7Ci0gICAgICAgIHByZSA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdjb25zb2xl Jyk7Ci0gICAgICAgIHRleHQgPSBkb2N1bWVudC5jcmVhdGVUZXh0Tm9kZShzdHIgKyAnXG4nKTsK LSAgICAgICAgcHJlLmFwcGVuZENoaWxkKHRleHQpOwotICAgICAgfQorICA8Ym9keT48cHJlIGlk PSJjb25zb2xlIj48L3ByZT48L2JvZHk+CisgIDxzY3JpcHQ+CisgICAgZnVuY3Rpb24gd3JpdGUo c3RyKSB7CisgICAgICBwcmUgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnY29uc29sZScpOwor ICAgICAgdGV4dCA9IGRvY3VtZW50LmNyZWF0ZVRleHROb2RlKHN0ciArICdcbicpOworICAgICAg cHJlLmFwcGVuZENoaWxkKHRleHQpOworICAgIH0KIAotICAgICAgZnVuY3Rpb24gcmVjdk1zZzEo ZSkgewotICAgICAgICB3cml0ZSgiUkVDVjEiKTsKLSAgICAgICAgd2luZG93LnJlbW92ZUV2ZW50 TGlzdGVuZXIoIm1lc3NhZ2UiLCByZWN2TXNnMSwgZmFsc2UpOworICAgIGZ1bmN0aW9uIHJlY3ZN c2cxKGUpIHsKKyAgICAgIHdyaXRlKCJSRUNWMSIpOworICAgICAgd2luZG93LnJlbW92ZUV2ZW50 TGlzdGVuZXIoIm1lc3NhZ2UiLCByZWN2TXNnMSwgZmFsc2UpOwogCi0gICAgICAgIGlmICh3aW5k b3cudGVzdFJ1bm5lcikKLSAgICAgICAgICB0ZXN0UnVubmVyLmludGVyY2VwdFBvc3RNZXNzYWdl ID0gdHJ1ZTsKKyAgICAgIGlmICh3aW5kb3cudGVzdFJ1bm5lcikKKyAgICAgICAgdGVzdFJ1bm5l ci5pbnRlcmNlcHRQb3N0TWVzc2FnZSA9IHRydWU7CiAKLSAgICAgICAgd2luZG93LmFkZEV2ZW50 TGlzdGVuZXIoIm1lc3NhZ2UiLCByZWN2TXNnMiwgZmFsc2UpOwotICAgICAgICB3aW5kb3cucG9z dE1lc3NhZ2UoIk1lc3NhZ2UgMiIsICIqIik7Ci0gICAgICAKLSAgICAgICAgLy8gRW5zdXJlIHRo YXQgd2UncmUgaW50ZXJjZXB0aW5nIHBvc3RNZXNzYWdlcyBiZWZvcmUgdGhlIG9yaWdpbiBjaGVj awotICAgICAgICB3aW5kb3cucG9zdE1lc3NhZ2UoIk1lc3NhZ2UgMyIsICJodHRwOi8vZXhhbXBs ZS5vcmciKTsgCisgICAgICB3aW5kb3cuYWRkRXZlbnRMaXN0ZW5lcigibWVzc2FnZSIsIHJlY3ZN c2cyLCBmYWxzZSk7CisgICAgICB3aW5kb3cucG9zdE1lc3NhZ2UoIk1lc3NhZ2UgMiIsICIqIik7 CiAKLSAgICAgICAgLy8gV2UgbmVlZCB0byBjYWxsIHNldFRpbWVvdXQgaGVyZSBiZWNhdXNlIHdl IGludGVyY2VwdCB0aGUgbmV4dCBldmVudC4KLSAgICAgICAgLy8gSWYgdGhpcyB0ZXN0IGJlY29t ZXMgZmxha3ksIHlvdSBtYXkgbmVlZCB0byBpbmNyZWFzZSB0aGlzIHRpbWVvdXQuCi0gICAgICAg IHdpbmRvdy5zZXRUaW1lb3V0KCJkb25lKCkiLCA1MCk7Ci0gICAgICB9CisgICAgICAvLyBFbnN1 cmUgdGhhdCB3ZSdyZSBpbnRlcmNlcHRpbmcgcG9zdE1lc3NhZ2VzIGJlZm9yZSB0aGUgb3JpZ2lu IGNoZWNrCisgICAgICB3aW5kb3cucG9zdE1lc3NhZ2UoIk1lc3NhZ2UgMyIsICJodHRwOi8vZXhh bXBsZS5vcmciKTsKIAotICAgICAgZnVuY3Rpb24gcmVjdk1zZzIoZSkgewotICAgICAgICB3cml0 ZSgiUkVDVjIiKTsKKyAgICAgIGlmICh3aW5kb3cudGVzdFJ1bm5lcikgeworICAgICAgICAvLyBX ZSBuZWVkIHRvIGNhbGwgc2V0VGltZW91dCBoZXJlIGJlY2F1c2Ugd2UgaW50ZXJjZXB0IHRoZSBu ZXh0IGV2ZW50LgorICAgICAgICB3aW5kb3cuc2V0VGltZW91dChmdW5jdGlvbigpIHsgdGVzdFJ1 bm5lci5ub3RpZnlEb25lKCk7IH0pOwogICAgICAgfQorICAgIH0KIAotICAgICAgZnVuY3Rpb24g ZG9uZSgpIHsKLSAgICAgICAgaWYgKHdpbmRvdy50ZXN0UnVubmVyKQotICAgICAgICAgIHdpbmRv dy50ZXN0UnVubmVyLm5vdGlmeURvbmUoKTsKLSAgICAgIH0KKyAgICBmdW5jdGlvbiByZWN2TXNn MihlKSB7CisgICAgICB3cml0ZSgiUkVDVjIiKTsKKyAgICB9CiAKLSAgICAgIHdpbmRvdy5hZGRF dmVudExpc3RlbmVyKCJtZXNzYWdlIiwgcmVjdk1zZzEsIGZhbHNlKTsKKyAgICB3aW5kb3cuYWRk RXZlbnRMaXN0ZW5lcigibWVzc2FnZSIsIHJlY3ZNc2cxLCBmYWxzZSk7CiAKLSAgICAgIGlmICh3 aW5kb3cudGVzdFJ1bm5lcikgewotICAgICAgICB3aW5kb3cudGVzdFJ1bm5lci5kdW1wQXNUZXh0 KCk7Ci0gICAgICAgIHdpbmRvdy50ZXN0UnVubmVyLndhaXRVbnRpbERvbmUoKTsKLSAgICAgIH0K KyAgICBpZiAod2luZG93LnRlc3RSdW5uZXIpIHsKKyAgICAgIHdpbmRvdy50ZXN0UnVubmVyLmR1 bXBBc1RleHQoKTsKKyAgICAgIHdpbmRvdy50ZXN0UnVubmVyLndhaXRVbnRpbERvbmUoKTsKKyAg ICB9CiAKLSAgICAgIHdpbmRvdy5wb3N0TWVzc2FnZSgiTWVzc2FnZSAxIiwgIioiKTsKLSAgICA8 L3NjcmlwdD4KLSAgPC9oZWFkPgotICA8Ym9keT48cHJlIGlkPSJjb25zb2xlIj48L3ByZT48L2Jv ZHk+CisgICAgd2luZG93LnBvc3RNZXNzYWdlKCJNZXNzYWdlIDEiLCAiKiIpOworICA8L3Njcmlw dD4KIDwvaHRtbD4KIAo=