112079 2013-03-11 16:23:39 -0700 Don't allow drags to start after a mouse press that creates a context menu 2019-02-06 22:05:26 -0800 1 1 1 Unclassified WebKit UI Events 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dcheng dcheng ap rniwa tony oldest_to_newest 852850 0 dcheng 2013-03-11 16:23:39 -0700 I did some some code archaeology. In EventHandler::sendContextMenuEvent(), we have this snippet: 2859 // Clear mouse press state to avoid initiating a drag while context menu is up. 2860 m_mousePressed = false; However, in EventHandler::handleMouseDraggedEvent(), we have: 706 bool EventHandler::handleMouseDraggedEvent(const MouseEventWithHitTestResults& event) 707 { 708 if (handleDrag(event, ShouldCheckDragHysteresis)) 709 return true; 710 711 if (!m_mousePressed) 712 return false; It's not entirely clear to me why the code in handleMouseDraggedEvent() is currently ordered this way, since the comment in sendContextMenuEvent() seems to indicate that this is supposed to prevent unintended interactions with dragging. However, this causes problems for the Chromium port on Linux (http://crbug.com/157134): The problem is this: 1. User presses LMB and holds and starts selecting text. 2. User presses RMB which creates a context menu. 3. User release RMB above a context menu item to invoke it. 4. With LMB held, user continues moving the mouse cursor. This causes the renderer to eventually invoke Chromium's DragClientImpl::startDrag() method, which in turns, sets WebViewImpl::m_doingDragAndDrop to true. For whatever reason, the browser doesn't end up initiating a drag and drop on behalf of the renderer. I've verified that flipping lines 708-709 and 711-712 fixes the issue; however, I'm also investigating why no drag is being initiated on the browser side. This causes the renderer to ignore all input events and appear to be hung. 861628 1 194586 dcheng 2013-03-22 10:27:14 -0700 Created attachment 194586 Patch 861668 2 194586 tony 2013-03-22 10:51:58 -0700 Comment on attachment 194586 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=194586&action=review > Source/WebCore/ChangeLog:13 > + Covered by existing tests since it shouldn't change normal user-observable behavior. It would be nice to make a manual test for this, if for no other reason than it would describe what should happen if you try to start a drag while a context menu is up. 862026 3 dcheng 2013-03-22 17:34:00 -0700 (In reply to comment #2) > (From update of attachment 194586 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=194586&action=review > > > Source/WebCore/ChangeLog:13 > > + Covered by existing tests since it shouldn't change normal user-observable behavior. > > It would be nice to make a manual test for this, if for no other reason than it would describe what should happen if you try to start a drag while a context menu is up. Sure. I didn't include it initially because Chromium Win still doesn't behave quite the same as the other ports... however, this patch does make the behavior consistent across the Mac and Chromium Mac/Linux ports. 862027 4 194667 dcheng 2013-03-22 17:34:16 -0700 Created attachment 194667 Patch 862857 5 dcheng 2013-03-25 09:49:27 -0700 Committed r146784: <http://trac.webkit.org/changeset/146784> 1503241 6 lforschler 2019-02-06 09:18:45 -0800 Mass move bugs into the DOM component. 194586 2013-03-22 10:27:14 -0700 2013-03-22 17:34:14 -0700 Patch bug-112079-20130322102301.patch text/plain 2019 dcheng U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ2NTA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWQ1NzNlMjZmNDNhNDYw N2I4MDUyNzRhMjA5MWY5MmFhY2I4Mzc1Yy4uZGI0NWMzMGJjMzMzYzNiMTc5Y2IzNWZkNzAzZWQ5 ZDVjN2IyN2E3NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEzLTAzLTIyICBEYW5p ZWwgQ2hlbmcgIDxkY2hlbmdAY2hyb21pdW0ub3JnPgorCisgICAgICAgIERvbid0IGFsbG93IGRy YWdzIHRvIHN0YXJ0IGFmdGVyIGEgbW91c2UgcHJlc3MgdGhhdCBjcmVhdGVzIGEgY29udGV4dCBt ZW51CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTIw NzkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlz IGFwcGVhcnMgdG8gYmUgdGhlIGludGVudCBvZiB0aGUgb3JpZ2luYWwgY29kZSBhbnl3YXkgKHRo ZSBjb21tZW50cyBpbiB0aGUgY29ycmVzcG9uZGluZworICAgICAgICBjb250ZXh0IG1lbnUgaGFu ZGxlcnMgaW5kaWNhdGUgdGhhdCB0aGV5IHNldCBtX21vdXNlUHJlc3NlZCB0byBmYWxzZSBpbiBv cmRlciB0byBzdXBwcmVzcworICAgICAgICBkcmFncyBmcm9tIHN0YXJ0aW5nKS4gU2luY2UgZXhh Y3QgcGxhdGZvcm0gYmVoYXZpb3IgZGlmZmVycyBxdWl0ZSBhIGJpdCBpbiB0aGlzIGFyZWEsIHRo aXMKKyAgICAgICAgd2lsbCBhbHNvIG1ha2UgdGhlIGJlaGF2aW9yIG1vcmUgY29uc2lzdGVudCBh Y3Jvc3MgZGlmZmVyZW50IFdlYktpdCBpbXBsZW1lbnRhdGlvbnMuCisKKyAgICAgICAgQ292ZXJl ZCBieSBleGlzdGluZyB0ZXN0cyBzaW5jZSBpdCBzaG91bGRuJ3QgY2hhbmdlIG5vcm1hbCB1c2Vy LW9ic2VydmFibGUgYmVoYXZpb3IuCisKKyAgICAgICAgKiBwYWdlL0V2ZW50SGFuZGxlci5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpFdmVudEhhbmRsZXI6OmhhbmRsZU1vdXNlRHJhZ2dlZEV2ZW50 KToKKwogMjAxMy0wMy0yMSAgSGFyYWxkIEFsdmVzdHJhbmQgIDxodGFAZ29vZ2xlLmNvbT4KIAog ICAgICAgICBFeHBvc2UgdGhlIFR5cGUgZmllbGQgb2YgYW4gUlRDU3RhdHNSZXBvcnQKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNwcCBiL1NvdXJjZS9XZWJD b3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNwcAppbmRleCBhZjAzNzI5ZTJmOWI3YzVmZTgwNjVlOWEz NjM1ODg5YjJmNjBjYTVhLi5hZjVjMTRjM2M1YjM3ODU4NGUxYTY3ODRmYzE1YjVmYzZjOTU0MWE5 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3BwCkBAIC03MDUsMTIgKzcwNSwxMiBA QCBib29sIEV2ZW50SGFuZGxlcjo6aGFuZGxlTW91c2VQcmVzc0V2ZW50KGNvbnN0IE1vdXNlRXZl bnRXaXRoSGl0VGVzdFJlc3VsdHMmIGV2ZQogI2lmIEVOQUJMRShEUkFHX1NVUFBPUlQpCiBib29s IEV2ZW50SGFuZGxlcjo6aGFuZGxlTW91c2VEcmFnZ2VkRXZlbnQoY29uc3QgTW91c2VFdmVudFdp dGhIaXRUZXN0UmVzdWx0cyYgZXZlbnQpCiB7Ci0gICAgaWYgKGhhbmRsZURyYWcoZXZlbnQsIFNo b3VsZENoZWNrRHJhZ0h5c3RlcmVzaXMpKQotICAgICAgICByZXR1cm4gdHJ1ZTsKLQogICAgIGlm ICghbV9tb3VzZVByZXNzZWQpCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAorICAgIGlmIChoYW5k bGVEcmFnKGV2ZW50LCBTaG91bGRDaGVja0RyYWdIeXN0ZXJlc2lzKSkKKyAgICAgICAgcmV0dXJu IHRydWU7CisKICAgICBOb2RlKiB0YXJnZXROb2RlID0gZXZlbnQudGFyZ2V0Tm9kZSgpOwogICAg IGlmIChldmVudC5ldmVudCgpLmJ1dHRvbigpICE9IExlZnRCdXR0b24gfHwgIXRhcmdldE5vZGUp CiAgICAgICAgIHJldHVybiBmYWxzZTsK 194667 2013-03-22 17:34:16 -0700 2013-03-25 09:41:49 -0700 Patch bug-112079-20130322173003.patch text/plain 3593 dcheng U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ2NjU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTVlYzhlNDQyZDc0YWQz MWFmZGViZDc3NGZjMTJhNGY3YWIwOTlhMy4uODZlN2M0MjBiYWEyNWM0MmFlNTdmYjNhYWRkM2M0 ZDkwYTIyYjcwYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEzLTAzLTIyICBEYW5p ZWwgQ2hlbmcgIDxkY2hlbmdAY2hyb21pdW0ub3JnPgorCisgICAgICAgIERvbid0IGFsbG93IGRy YWdzIHRvIHN0YXJ0IGFmdGVyIGEgbW91c2UgcHJlc3MgdGhhdCBjcmVhdGVzIGEgY29udGV4dCBt ZW51CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTIw NzkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlz IGFwcGVhcnMgdG8gYmUgdGhlIGludGVudCBvZiB0aGUgb3JpZ2luYWwgY29kZSBhbnl3YXkgKHRo ZSBjb21tZW50cyBpbiB0aGUgY29ycmVzcG9uZGluZworICAgICAgICBjb250ZXh0IG1lbnUgaGFu ZGxlcnMgaW5kaWNhdGUgdGhhdCB0aGV5IHNldCBtX21vdXNlUHJlc3NlZCB0byBmYWxzZSBpbiBv cmRlciB0byBzdXBwcmVzcworICAgICAgICBkcmFncyBmcm9tIHN0YXJ0aW5nKS4gU2luY2UgZXhh Y3QgcGxhdGZvcm0gYmVoYXZpb3IgZGlmZmVycyBxdWl0ZSBhIGJpdCBpbiB0aGlzIGFyZWEsIHRo aXMKKyAgICAgICAgd2lsbCBhbHNvIG1ha2UgdGhlIGJlaGF2aW9yIG1vcmUgY29uc2lzdGVudCBh Y3Jvc3MgZGlmZmVyZW50IFdlYktpdCBpbXBsZW1lbnRhdGlvbnMuCisKKyAgICAgICAgTWFudWFs bHkgdGVzdGFibGUgdXNpbmcgY29udGV4dC1tZW51LWR1cmluZy1kcmFnLXNlbGVjdGlvbi5odG1s LgorCisgICAgICAgICogcGFnZS9FdmVudEhhbmRsZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 RXZlbnRIYW5kbGVyOjpoYW5kbGVNb3VzZURyYWdnZWRFdmVudCk6CisKIDIwMTMtMDMtMjIgIFJv Z2VyIEZvbmcgIDxyb2dlcl9mb25nQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLiBG b3JjZSBraWxsIGdjYy0zLmV4ZSBkdXJpbmcgYmluZGluZ3MgZ2VuZXJhdGlvbiB0ZXN0cyB0byBh dm9pZCBwcm9jZXNzIGhhbmdzLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9FdmVu dEhhbmRsZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3BwCmluZGV4 IGFmMDM3MjllMmY5YjdjNWZlODA2NWU5YTM2MzU4ODliMmY2MGNhNWEuLmFmNWMxNGMzYzViMzc4 NTg0ZTFhNjc4NGZjMTViNWZjNmM5NTQxYTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bh Z2UvRXZlbnRIYW5kbGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxl ci5jcHAKQEAgLTcwNSwxMiArNzA1LDEyIEBAIGJvb2wgRXZlbnRIYW5kbGVyOjpoYW5kbGVNb3Vz ZVByZXNzRXZlbnQoY29uc3QgTW91c2VFdmVudFdpdGhIaXRUZXN0UmVzdWx0cyYgZXZlCiAjaWYg RU5BQkxFKERSQUdfU1VQUE9SVCkKIGJvb2wgRXZlbnRIYW5kbGVyOjpoYW5kbGVNb3VzZURyYWdn ZWRFdmVudChjb25zdCBNb3VzZUV2ZW50V2l0aEhpdFRlc3RSZXN1bHRzJiBldmVudCkKIHsKLSAg ICBpZiAoaGFuZGxlRHJhZyhldmVudCwgU2hvdWxkQ2hlY2tEcmFnSHlzdGVyZXNpcykpCi0gICAg ICAgIHJldHVybiB0cnVlOwotCiAgICAgaWYgKCFtX21vdXNlUHJlc3NlZCkKICAgICAgICAgcmV0 dXJuIGZhbHNlOwogCisgICAgaWYgKGhhbmRsZURyYWcoZXZlbnQsIFNob3VsZENoZWNrRHJhZ0h5 c3RlcmVzaXMpKQorICAgICAgICByZXR1cm4gdHJ1ZTsKKwogICAgIE5vZGUqIHRhcmdldE5vZGUg PSBldmVudC50YXJnZXROb2RlKCk7CiAgICAgaWYgKGV2ZW50LmV2ZW50KCkuYnV0dG9uKCkgIT0g TGVmdEJ1dHRvbiB8fCAhdGFyZ2V0Tm9kZSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwpkaWZmIC0t Z2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4IGU2MjQwMTgzZTg1ZWViMDViZmM1YTFl NzEyZjk5OGI0ZDdkMjgwMTMuLmZlNDQ3ZjYwZGEzMmFiMzMyYTI1NGNkMGY1ZDQ5MTdlMmI1NjRh ZmEgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBA QAorMjAxMy0wMy0yMiAgRGFuaWVsIENoZW5nICA8ZGNoZW5nQGNocm9taXVtLm9yZz4KKworICAg ICAgICBEb24ndCBhbGxvdyBkcmFncyB0byBzdGFydCBhZnRlciBhIG1vdXNlIHByZXNzIHRoYXQg Y3JlYXRlcyBhIGNvbnRleHQgbWVudQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTEyMDc5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBNYW51YWxUZXN0cy9jb250ZXh0LW1lbnUtZHVyaW5nLWRyYWctc2Vs ZWN0aW9uLmh0bWw6IEFkZGVkLgorCiAyMDEzLTAzLTIyICBZdWtpIFNla2lndWNoaSAgPHl1a2ku c2VraWd1Y2hpQGFjY2Vzcy1jb21wYW55LmNvbT4KIAogICAgICAgICBDYW5ub3QgcnVuIEFsbCBT b3VyY2UgKHRhcmdldCBXZWJQcm9jZXNzKSBvbiBYY29kZS4KZGlmZiAtLWdpdCBhL01hbnVhbFRl c3RzL2NvbnRleHQtbWVudS1kdXJpbmctZHJhZy1zZWxlY3Rpb24uaHRtbCBiL01hbnVhbFRlc3Rz L2NvbnRleHQtbWVudS1kdXJpbmctZHJhZy1zZWxlY3Rpb24uaHRtbApuZXcgZmlsZSBtb2RlIDEw MDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi40NzEw ZDg3MzdiYzg4ODkyMjVkZGMwMzc1NmUyZDQ1ODcwZGIyODYxCi0tLSAvZGV2L251bGwKKysrIGIv TWFudWFsVGVzdHMvY29udGV4dC1tZW51LWR1cmluZy1kcmFnLXNlbGVjdGlvbi5odG1sCkBAIC0w LDAgKzEsMTMgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8Ym9keT4KKzxwPlNpbXBsZSBt YW51YWwgYmVoYXZpb3IgdGVzdCBmb3IgdGhlIGludGVyYWN0aW9uIGJldHdlZW4gc2VsZWN0aW9u IGRyYWdzLAorY29udGV4dCBtZW51IGludm9jYXRpb24sIGFuZCBhY3R1YWwgZHJhZ2dpbmcuIElu IG9yZGVyIHRvIHRlc3QsIHNpbXBseSBzdGFydAorc2VsZWN0aW5nIGEgc3BhbiBvZiB0ZXh0IGJ5 IGNsaWNraW5nIGFuZCBkcmFnZ2luZy4gRHVyaW5nIHRleHQgc2VsZWN0aW9uLCBubworZHJhZyBz aG91bGQgc3RhcnQuIFdoaWxlIHNlbGVjdGluZyB0ZXh0LCBwcmVzcyBhbmQgaG9sZCB0aGUgcmln aHQgbW91c2UgYnV0dG9uCit0byBpbnZva2UgdGhlIGNvbnRleHQgbWVudSwgdGhlbiByZWxlYXNl IHRoZSByaWdodCBtb3VzZSBidXR0b24gb3ZlciBhIGNvbnRleHQKK21lbnUgZW50cnkgbGlrZSAi Q29weSIuIEFmdGVyIHRoaXMsIGlmIHlvdSBrZWVwIG1vdmluZyB0aGUgbW91c2UgYXJvdW5kLCBu byBkcmFnCitvZiB0aGUgc2VsZWN0ZWQgdGV4dCBzaG91bGQgc3RhcnQsIGV2ZW4gdGhvdWdoIHRo ZSBsZWZ0IG1vdXNlIGJ1dHRvbiBpcyBzdGlsbAoraGVsZCBkb3duLgorPC9ib2R5PgorPC9odG1s Pgo=