112076 2013-03-11 16:06:01 -0700 Small code cleanup in RenderFlexibleBox 2013-03-11 18:41:41 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tony tony eric esprehn+autocc ojan.autocc ojan webkit.review.bot oldest_to_newest 852825 0 tony 2013-03-11 16:06:01 -0700 Small code cleanup in RenderFlexibleBox 852829 1 192586 tony 2013-03-11 16:10:36 -0700 Created attachment 192586 Patch 852969 2 192586 webkit.review.bot 2013-03-11 18:41:38 -0700 Comment on attachment 192586 Patch Clearing flags on attachment: 192586 Committed r145457: <http://trac.webkit.org/changeset/145457> 852970 3 webkit.review.bot 2013-03-11 18:41:41 -0700 All reviewed patches have been landed. Closing bug. 192586 2013-03-11 16:10:36 -0700 2013-03-11 18:41:37 -0700 Patch bug-112076-20130311160636.patch text/plain 5649 tony U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1Mzc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjJhN2Q0YjA1NTI0MjBh MDFjN2I4ZjVmMmFlMWNiZjZmN2FlNzAwMy4uNjgwYTUzNjAzNDM1YWJmN2UxMDlmOTlhYTQyNDRk ZDVmNjIzMWE2ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEzLTAzLTExICBUb255 IENoYW5nICA8dG9ueUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgU21hbGwgY29kZSBjbGVhbnVw IGluIFJlbmRlckZsZXhpYmxlQm94CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMTIwNzYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBObyBuZXcgdGVzdHMsIHRoaXMgaXMgYSByZWZhY3RvciBhbmQgZXhpc3Rp bmcgdGVzdHMgaW4gY3NzMy9mbGV4Ym94IHNob3VsZCBwYXNzLgorCisgICAgICAgICogcmVuZGVy aW5nL1JlbmRlckZsZXhpYmxlQm94LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckZsZXhp YmxlQm94OjpsYXlvdXRCbG9jayk6IFJlbW92ZSB1bnVzZWQgcGFyYW0gZnJvbSByZXBvc2l0aW9u TG9naWNhbEhlaWdodERlcGVuZGVudEZsZXhJdGVtcy4KKyAgICAgICAgKFdlYkNvcmU6OlJlbmRl ckZsZXhpYmxlQm94OjpyZXBvc2l0aW9uTG9naWNhbEhlaWdodERlcGVuZGVudEZsZXhJdGVtcyk6 IFJlbW92ZSB1bnVzZWQgcGFyYW0gZnJvbSByZXBvc2l0aW9uTG9naWNhbEhlaWdodERlcGVuZGVu dEZsZXhJdGVtcy4KKyAgICAgICAgVGhlIGNsaWVudExvZ2ljYWxCb3R0b20gY2FuJ3QgaGF2ZSBj aGFuZ2VkIGluIHRoaXMgdGltZSAodGhlIG9ubHkgdGhpbmcgd2UndmUgZG9uZSBpcyBhbGlnbiBj aGlsZHJlbikuCisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJGbGV4aWJsZUJveDo6Y29tcHV0ZU1h aW5BeGlzUHJlZmVycmVkU2l6ZXMpOiBKdXN0IGNhbGwgbGF5b3V0KCkgaWYgd2UgbWFya2VkIHRo ZSBmbGV4aXRlbSBhcyBuZWVkaW5nIGxheW91dC4KKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckZs ZXhpYmxlQm94OjphcHBseVN0cmV0Y2hBbGlnbm1lbnRUb0NoaWxkKTogSnVzdCBjYWxsIGxheW91 dCgpIGlmIHdlIG1hcmtlZCB0aGUgZmxleGl0ZW0gYXMgbmVlZGluZyBsYXlvdXQuCisgICAgICAg ICogcmVuZGVyaW5nL1JlbmRlckZsZXhpYmxlQm94Lmg6CisgICAgICAgIChSZW5kZXJGbGV4aWJs ZUJveCk6IFJlbW92ZSB1bnVzZWQgcGFyYW0gZnJvbSByZXBvc2l0aW9uTG9naWNhbEhlaWdodERl cGVuZGVudEZsZXhJdGVtcy4KKwogMjAxMy0wMy0xMSAgUGhpbGlwIFJvZ2VycyAgPHBkckBnb29n bGUuY29tPgogCiAgICAgICAgIFJlcGxhY2UgU1ZHJ3Mgc3RhdGljX2Nhc3Q8U1ZHRWxlbWVudD4g d2l0aCB0b1NWR0VsZW1lbnQoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckZsZXhpYmxlQm94LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJG bGV4aWJsZUJveC5jcHAKaW5kZXggNGRmMGNlYmMwY2FiNjhiZmRhM2VmZGI3ZGI4ZDQzNmFhMzBh ZmMyMS4uYjkwYTNmZDVlZmRmZWE2N2UzOWE0MmVjNTRmMDFjMWU4N2UwYjcwZSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckZsZXhpYmxlQm94LmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRmxleGlibGVCb3guY3BwCkBAIC0zNTcsNyAr MzU3LDcgQEAgdm9pZCBSZW5kZXJGbGV4aWJsZUJveDo6bGF5b3V0QmxvY2soYm9vbCByZWxheW91 dENoaWxkcmVuLCBMYXlvdXRVbml0KQogCiAgICAgTGF5b3V0VW5pdCBvbGRDbGllbnRBZnRlckVk Z2UgPSBjbGllbnRMb2dpY2FsQm90dG9tKCk7CiAgICAgdXBkYXRlTG9naWNhbEhlaWdodCgpOwot ICAgIHJlcG9zaXRpb25Mb2dpY2FsSGVpZ2h0RGVwZW5kZW50RmxleEl0ZW1zKGxpbmVDb250ZXh0 cywgb2xkQ2xpZW50QWZ0ZXJFZGdlKTsKKyAgICByZXBvc2l0aW9uTG9naWNhbEhlaWdodERlcGVu ZGVudEZsZXhJdGVtcyhsaW5lQ29udGV4dHMpOwogCiAgICAgUmVuZGVyQmxvY2s6OmZpbmlzaERl bGF5VXBkYXRlU2Nyb2xsSW5mbygpOwogCkBAIC00MTcsNyArNDE3LDcgQEAgdm9pZCBSZW5kZXJG bGV4aWJsZUJveDo6cGFpbnRDaGlsZHJlbihQYWludEluZm8mIHBhaW50SW5mbywgY29uc3QgTGF5 b3V0UG9pbnQmIHAKICAgICB9CiB9CiAKLXZvaWQgUmVuZGVyRmxleGlibGVCb3g6OnJlcG9zaXRp b25Mb2dpY2FsSGVpZ2h0RGVwZW5kZW50RmxleEl0ZW1zKFZlY3RvcjxMaW5lQ29udGV4dD4mIGxp bmVDb250ZXh0cywgTGF5b3V0VW5pdCYgb2xkQ2xpZW50QWZ0ZXJFZGdlKQordm9pZCBSZW5kZXJG bGV4aWJsZUJveDo6cmVwb3NpdGlvbkxvZ2ljYWxIZWlnaHREZXBlbmRlbnRGbGV4SXRlbXMoVmVj dG9yPExpbmVDb250ZXh0PiYgbGluZUNvbnRleHRzKQogewogICAgIExheW91dFVuaXQgY3Jvc3NB eGlzU3RhcnRFZGdlID0gbGluZUNvbnRleHRzLmlzRW1wdHkoKSA/IExheW91dFVuaXQoKSA6IGxp bmVDb250ZXh0c1swXS5jcm9zc0F4aXNPZmZzZXQ7CiAgICAgYWxpZ25GbGV4TGluZXMobGluZUNv bnRleHRzKTsKQEAgLTQyOCwxMSArNDI4LDggQEAgdm9pZCBSZW5kZXJGbGV4aWJsZUJveDo6cmVw b3NpdGlvbkxvZ2ljYWxIZWlnaHREZXBlbmRlbnRGbGV4SXRlbXMoVmVjdG9yPExpbmVDb24KICAg ICAgICAgbGluZUNvbnRleHRzWzBdLmNyb3NzQXhpc0V4dGVudCA9IGNyb3NzQXhpc0NvbnRlbnRF eHRlbnQoKTsKICAgICBhbGlnbkNoaWxkcmVuKGxpbmVDb250ZXh0cyk7CiAKLSAgICBpZiAoc3R5 bGUoKS0+ZmxleFdyYXAoKSA9PSBGbGV4V3JhcFJldmVyc2UpIHsKLSAgICAgICAgaWYgKGlzSG9y aXpvbnRhbEZsb3coKSkKLSAgICAgICAgICAgIG9sZENsaWVudEFmdGVyRWRnZSA9IGNsaWVudExv Z2ljYWxCb3R0b20oKTsKKyAgICBpZiAoc3R5bGUoKS0+ZmxleFdyYXAoKSA9PSBGbGV4V3JhcFJl dmVyc2UpCiAgICAgICAgIGZsaXBGb3JXcmFwUmV2ZXJzZShsaW5lQ29udGV4dHMsIGNyb3NzQXhp c1N0YXJ0RWRnZSk7Ci0gICAgfQogCiAgICAgLy8gZGlyZWN0aW9uOnJ0bCArIGZsZXgtZGlyZWN0 aW9uOmNvbHVtbiBtZWFucyB0aGUgY3Jvc3MtYXhpcyBkaXJlY3Rpb24gaXMgZmxpcHBlZC4KICAg ICBmbGlwRm9yUmlnaHRUb0xlZnRDb2x1bW4oKTsKQEAgLTg5Myw3ICs4OTAsNyBAQCB2b2lkIFJl bmRlckZsZXhpYmxlQm94Ojpjb21wdXRlTWFpbkF4aXNQcmVmZXJyZWRTaXplcyhPcmRlckhhc2hT ZXQmIG9yZGVyVmFsdWVzKQogICAgICAgICBMZW5ndGggY2hpbGRNYWluQXhpc01pbiA9IGlzSG9y aXpvbnRhbEZsb3coKSA/IGNoaWxkLT5zdHlsZSgpLT5taW5XaWR0aCgpIDogY2hpbGQtPnN0eWxl KCktPm1pbkhlaWdodCgpOwogICAgICAgICBpZiAoaGFzT3J0aG9nb25hbEZsb3coY2hpbGQpICYm IChmbGV4QmFzaXNGb3JDaGlsZChjaGlsZCkuaXNBdXRvKCkgfHwgY2hpbGRNYWluQXhpc01pbi5p c0F1dG8oKSkpIHsKICAgICAgICAgICAgIGNoaWxkLT5zZXRDaGlsZE5lZWRzTGF5b3V0KHRydWUs IE1hcmtPbmx5VGhpcyk7Ci0gICAgICAgICAgICBjaGlsZC0+bGF5b3V0SWZOZWVkZWQoKTsKKyAg ICAgICAgICAgIGNoaWxkLT5sYXlvdXQoKTsKICAgICAgICAgfQogCiAgICAgICAgIC8vIEJlZm9y ZSBydW5uaW5nIHRoZSBmbGV4IGFsZ29yaXRobSwgJ2F1dG8nIGhhcyBhIG1hcmdpbiBvZiAwLgpA QCAtMTM4NSw3ICsxMzgyLDcgQEAgdm9pZCBSZW5kZXJGbGV4aWJsZUJveDo6YXBwbHlTdHJldGNo QWxpZ25tZW50VG9DaGlsZChSZW5kZXJCb3gqIGNoaWxkLCBMYXlvdXRVbmkKICAgICAgICAgICAg ICAgICBjaGlsZC0+c2V0T3ZlcnJpZGVMb2dpY2FsQ29udGVudEhlaWdodChkZXNpcmVkTG9naWNh bEhlaWdodCAtIGNoaWxkLT5ib3JkZXJBbmRQYWRkaW5nTG9naWNhbEhlaWdodCgpKTsKICAgICAg ICAgICAgICAgICBjaGlsZC0+c2V0TG9naWNhbEhlaWdodCgwKTsKICAgICAgICAgICAgICAgICBj aGlsZC0+c2V0Q2hpbGROZWVkc0xheW91dCh0cnVlLCBNYXJrT25seVRoaXMpOwotICAgICAgICAg ICAgICAgIGNoaWxkLT5sYXlvdXRJZk5lZWRlZCgpOworICAgICAgICAgICAgICAgIGNoaWxkLT5s YXlvdXQoKTsKICAgICAgICAgICAgIH0KICAgICAgICAgfQogICAgIH0gZWxzZSBpZiAoaXNDb2x1 bW5GbG93KCkgJiYgY2hpbGQtPnN0eWxlKCktPmxvZ2ljYWxXaWR0aCgpLmlzQXV0bygpKSB7CkBA IC0xMzk3LDcgKzEzOTQsNyBAQCB2b2lkIFJlbmRlckZsZXhpYmxlQm94OjphcHBseVN0cmV0Y2hB bGlnbm1lbnRUb0NoaWxkKFJlbmRlckJveCogY2hpbGQsIExheW91dFVuaQogICAgICAgICAgICAg aWYgKGNoaWxkV2lkdGggIT0gY2hpbGQtPmxvZ2ljYWxXaWR0aCgpKSB7CiAgICAgICAgICAgICAg ICAgY2hpbGQtPnNldE92ZXJyaWRlTG9naWNhbENvbnRlbnRXaWR0aChjaGlsZFdpZHRoIC0gY2hp bGQtPmJvcmRlckFuZFBhZGRpbmdMb2dpY2FsV2lkdGgoKSk7CiAgICAgICAgICAgICAgICAgY2hp bGQtPnNldENoaWxkTmVlZHNMYXlvdXQodHJ1ZSwgTWFya09ubHlUaGlzKTsKLSAgICAgICAgICAg ICAgICBjaGlsZC0+bGF5b3V0SWZOZWVkZWQoKTsKKyAgICAgICAgICAgICAgICBjaGlsZC0+bGF5 b3V0KCk7CiAgICAgICAgICAgICB9CiAgICAgICAgIH0KICAgICB9CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRmxleGlibGVCb3guaCBiL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJGbGV4aWJsZUJveC5oCmluZGV4IDkwNGJhMzg1NzBhZDYwZWY0ODQ5 ODYwMDdiZTkzMmZlNjI0NDJkNmQuLmNhN2RmYzE4MzUxMDhlOTk4N2VhZTI3OGZlMWQxOTU0YjVj MTNlMmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJGbGV4aWJs ZUJveC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJGbGV4aWJsZUJveC5o CkBAIC0xNDUsNyArMTQ1LDcgQEAgcHJpdmF0ZToKICAgICB2b2lkIHVwZGF0ZUF1dG9NYXJnaW5z SW5NYWluQXhpcyhSZW5kZXJCb3gqIGNoaWxkLCBMYXlvdXRVbml0IGF1dG9NYXJnaW5PZmZzZXQp OwogICAgIGJvb2wgaGFzQXV0b01hcmdpbnNJbkNyb3NzQXhpcyhSZW5kZXJCb3gqIGNoaWxkKSBj b25zdDsKICAgICBib29sIHVwZGF0ZUF1dG9NYXJnaW5zSW5Dcm9zc0F4aXMoUmVuZGVyQm94KiBj aGlsZCwgTGF5b3V0VW5pdCBhdmFpbGFibGVBbGlnbm1lbnRTcGFjZSk7Ci0gICAgdm9pZCByZXBv c2l0aW9uTG9naWNhbEhlaWdodERlcGVuZGVudEZsZXhJdGVtcyhWZWN0b3I8TGluZUNvbnRleHQ+ JiwgTGF5b3V0VW5pdCYgb2xkQ2xpZW50QWZ0ZXJFZGdlKTsKKyAgICB2b2lkIHJlcG9zaXRpb25M b2dpY2FsSGVpZ2h0RGVwZW5kZW50RmxleEl0ZW1zKFZlY3RvcjxMaW5lQ29udGV4dD4mKTsKICAg ICB2b2lkIGFwcGVuZENoaWxkRnJhbWVSZWN0cyhDaGlsZEZyYW1lUmVjdHMmKTsKICAgICB2b2lk IHJlcGFpbnRDaGlsZHJlbkR1cmluZ0xheW91dElmTW92ZWQoY29uc3QgQ2hpbGRGcmFtZVJlY3Rz Jik7CiAK