112073 2013-03-11 15:33:55 -0700 Gesture events should include AllowShadowContent in hit testing 2013-03-20 18:54:01 -0700 1 1 1 Unclassified WebKit UI Events 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 107796 112096 1 cbiesinger hayato dglazkov esprehn hayato webcomponents-bugzilla webkit.review.bot oldest_to_newest 852794 0 cbiesinger 2013-03-11 15:33:55 -0700 EventHandler::handleGestureEvent performs a hit test, currently without passing HitTestRequest::AllowShadowContent. It should pass that flag so that web components get the right events 852992 1 hayato 2013-03-11 19:04:46 -0700 Let me take a look. This might be similar to the case of Touch Events, which was fixed in http://trac.webkit.org/changeset/144877. 858045 2 hayato 2013-03-19 01:38:59 -0700 Hi Christian, Do you have any concrete test case of HTML where users can detect the behavior change between with/without AllowShadowContent? I've just started to investigate. In iOS's WebCore, users can register event listeners for 'gesturestart', 'gesturechange', or 'gesturestop'. But in WebCore, I am afraid that these events are not supported and GestureEvent itself can not be exposed to JavaScript. I appreciate if someone could show us some test cases. 858088 3 hayato 2013-03-19 02:38:40 -0700 "gesturetap" event seems to be available. (In reply to comment #2) > Hi Christian, > > Do you have any concrete test case of HTML where users can detect the behavior change between with/without AllowShadowContent? > > I've just started to investigate. In iOS's WebCore, users can register event listeners for 'gesturestart', 'gesturechange', or 'gesturestop'. > But in WebCore, I am afraid that these events are not supported and GestureEvent itself can not be exposed to JavaScript. > > I appreciate if someone could show us some test cases. 858143 4 193784 hayato 2013-03-19 04:11:18 -0700 Created attachment 193784 AllowShadowContent 859932 5 193784 webkit.review.bot 2013-03-20 18:53:57 -0700 Comment on attachment 193784 AllowShadowContent Clearing flags on attachment: 193784 Committed r146427: <http://trac.webkit.org/changeset/146427> 859933 6 webkit.review.bot 2013-03-20 18:54:01 -0700 All reviewed patches have been landed. Closing bug. 193784 2013-03-19 04:11:18 -0700 2013-03-20 18:53:57 -0700 AllowShadowContent bug-112073-20130319200708.patch text/plain 5753 hayato U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ2MDI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzYxYTU5MTU0ZDhiYWI4 YTBhOWQyZjVmNDE3N2FlYjNkMjBiNWVjNy4uMzg5ODgyYmY0ODEzYzAzZTMzYzFiNjdlYmQ5YzBl OTA3OGRjYzVkZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTAzLTE5ICBIYXlh dG8gSXRvICA8aGF5YXRvQGNocm9taXVtLm9yZz4KKworICAgICAgICBHZXN0dXJlIGV2ZW50cyBz aG91bGQgaW5jbHVkZSBBbGxvd1NoYWRvd0NvbnRlbnQgaW4gaGl0IHRlc3RpbmcKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMjA3MworCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFN1cHBvcnQgZ2VzdHVyZSBl dmVudHMgZm9yIFNoYWRvdyBET00uCisgICAgICAgIE5vdyAnZ2VzdHVyZXRhcCcgZXZlbnRzIGNh biBiZSBjb3JyZWN0bHkgZGlzcGF0Y2hlZCBpbiBzaGFkb3cgdHJlZXMuCisKKyAgICAgICAgVGVz dDogZmFzdC9kb20vc2hhZG93L2dlc3R1cmUtdGFwLmh0bWwKKworICAgICAgICAqIHBhZ2UvRXZl bnRIYW5kbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkV2ZW50SGFuZGxlcjo6aGFuZGxlR2Vz dHVyZUV2ZW50KToKKwogMjAxMy0wMy0xNyAgS2VudCBUYW11cmEgIDx0a2VudEBjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgSU5QVVRfTVVMVElQTEVfRklFTERTX1VJOiBEb24ndCB1cGRhdGUgc2hh ZG93IHRyZWUgYnkgdXBkYXRpbmcgYW55IGF0dHJpYnV0ZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhh bmRsZXIuY3BwCmluZGV4IGQ0NjkwMTE0ODhmMGM0ZjMwMmI4NTg1NDcxOWFkMjRlMjI4NjdjNTQu LjM2OTg5ZGQ4Mjk0ZDJjZTY0N2EyYjg4NmQ4MDU2NjQ4MjVkNzdiYWYgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9w YWdlL0V2ZW50SGFuZGxlci5jcHAKQEAgLTI0NjksNyArMjQ2OSw3IEBAIGJvb2wgRXZlbnRIYW5k bGVyOjpoYW5kbGVHZXN0dXJlRXZlbnQoY29uc3QgUGxhdGZvcm1HZXN0dXJlRXZlbnQmIGdlc3R1 cmVFdmVudCkKICAgICB9CiAKICAgICBJbnRQb2ludCBhZGp1c3RlZFBvaW50ID0gZ2VzdHVyZUV2 ZW50LnBvc2l0aW9uKCk7Ci0gICAgSGl0VGVzdFJlcXVlc3Q6OkhpdFRlc3RSZXF1ZXN0VHlwZSBo aXRUeXBlID0gSGl0VGVzdFJlcXVlc3Q6OlRvdWNoRXZlbnQ7CisgICAgSGl0VGVzdFJlcXVlc3Q6 OkhpdFRlc3RSZXF1ZXN0VHlwZSBoaXRUeXBlID0gSGl0VGVzdFJlcXVlc3Q6OlRvdWNoRXZlbnQg fCBIaXRUZXN0UmVxdWVzdDo6QWxsb3dTaGFkb3dDb250ZW50OwogICAgIGlmIChnZXN0dXJlRXZl bnQudHlwZSgpID09IFBsYXRmb3JtRXZlbnQ6Okdlc3R1cmVUYXBEb3duKSB7CiAjaWYgRU5BQkxF KFRPVUNIX0FESlVTVE1FTlQpCiAgICAgICAgIGFkanVzdEdlc3R1cmVQb3NpdGlvbihnZXN0dXJl RXZlbnQsIGFkanVzdGVkUG9pbnQpOwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9n IGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGU1ODNkOTM4M2NmMWMwNmRmMDFmNGRjMmVh Mjg5NzAxMWE2NjFhOTQuLjVmMDdiMWRiMjE3NDUzN2ZmY2UzZDQxYTBjOTA1OWI2OWZlZDcyZGIg MTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMy0wMy0xOSAgSGF5YXRvIEl0byAgPGhheWF0b0Bj aHJvbWl1bS5vcmc+CisKKyAgICAgICAgR2VzdHVyZSBldmVudHMgc2hvdWxkIGluY2x1ZGUgQWxs b3dTaGFkb3dDb250ZW50IGluIGhpdCB0ZXN0aW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTIwNzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIGZhc3QvZG9tL3NoYWRvdy9nZXN0dXJlLXRhcC1leHBl Y3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvZG9tL3NoYWRvdy9nZXN0dXJlLXRhcC5o dG1sOiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2RvbS9zaGFkb3cvcmVzb3VyY2VzL2V2ZW50LWRp c3BhdGNoaW5nLmpzOgorICAgICAgICAoYWRkRXZlbnRMaXN0ZW5lcnMpOgorCiAyMDEzLTAzLTE3 ICBLZW50IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KIAogICAgICAgICBJTlBVVF9NVUxU SVBMRV9GSUVMRFNfVUk6IERvbid0IHVwZGF0ZSBzaGFkb3cgdHJlZSBieSB1cGRhdGluZyBhbnkg YXR0cmlidXRlCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2RvbS9zaGFkb3cvZ2VzdHVy ZS10YXAtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vc2hhZG93L2dlc3R1cmUt dGFwLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5kOWJkYWUzYmRmOTQwNmVjNDQ4OWRlMmFhMzRk NjJiMjlkOGFkNTNhCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vc2hh ZG93L2dlc3R1cmUtdGFwLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDEwIEBACitUZXN0cyB0byBl bnN1cmUgdGhhdCBldmVudCBkaXNwYXRjaGluZyBiZWhhdmVzIGFzIHRoZSBTaGFkb3cgRE9NIHNw ZWMgZGVzY3JpYmVzLgorCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBB U1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisKKworCisgIGdlc3R1 cmV0YXAKKyAgICAgQGRpdjEgKHRhcmdldDogZGl2MSkKKyAgICAgQGRpdjEtc2hhZG93LXJvb3Qt Y2hpbGQgKHRhcmdldDogZGl2MS1zaGFkb3ctcm9vdC1jaGlsZCkKKwpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvZmFzdC9kb20vc2hhZG93L2dlc3R1cmUtdGFwLmh0bWwgYi9MYXlvdXRUZXN0cy9m YXN0L2RvbS9zaGFkb3cvZ2VzdHVyZS10YXAuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRl eCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi42NDRlYTRhNjIxZmEz MTFlODU4NmZkOTBjNjVhMzJiNGM5MWViZGQzCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVz dHMvZmFzdC9kb20vc2hhZG93L2dlc3R1cmUtdGFwLmh0bWwKQEAgLTAsMCArMSw0NCBAQAorPCFE T0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxoZWFkPgorICAgIDxzY3JpcHQgc3JjPSIuLi8uLi9qcy9y ZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgorICAgIDxzY3JpcHQgc3JjPSJyZXNv dXJjZXMvc2hhZG93LWRvbS5qcyI+PC9zY3JpcHQ+CisgICAgPHNjcmlwdCBzcmM9InJlc291cmNl cy9ldmVudC1kaXNwYXRjaGluZy5qcyI+PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKzxkaXYg aWQ9InNhbmRib3giPgorPC9kaXY+Cis8cHJlIGlkPSJjb25zb2xlIj48L3ByZT4KKzxzY3JpcHQ+ CitpZiAod2luZG93LnRlc3RSdW5uZXIpCisgICAgdGVzdFJ1bm5lci5kdW1wQXNUZXh0KCk7CisK K3NhbmRib3guYXBwZW5kQ2hpbGQoCisgICAgY3JlYXRlRE9NKCdkaXYnLCB7J2lkJzogJ2NvbnRh aW5lcid9LAorICAgICAgICAgICAgICBjcmVhdGVET00oJ2RpdicsIHsnaWQnOiAnZGl2MSd9LAor ICAgICAgICAgICAgICAgICAgICAgICAgY3JlYXRlU2hhZG93Um9vdCgKKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICBjcmVhdGVET00oJ2RpdicsIHt9LAorICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBkb2N1bWVudC5jcmVhdGVUZXh0Tm9kZSgnZm9vJykpLAorICAgICAg ICAgICAgICAgICAgICAgICAgICAgIGNyZWF0ZURPTSgnZGl2JywgeydpZCc6ICdkaXYxLXNoYWRv dy1yb290LWNoaWxkJ30sCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGRv Y3VtZW50LmNyZWF0ZVRleHROb2RlKCdmb28nKSksCisgICAgICAgICAgICAgICAgICAgICAgICAg ICAgY3JlYXRlRE9NKCdkaXYnLCB7fSwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgZG9jdW1lbnQuY3JlYXRlVGV4dE5vZGUoJ2ZvbycpKSkpKSk7CisKK3NhbmRib3gub2Zm c2V0TGVmdDsKKworZnVuY3Rpb24gZ2VzdHVyZVRhcChlbGVtZW50SWQpCit7CisgICAgdmFyIGVs ZW1lbnQgPSBnZXROb2RlSW5TaGFkb3dUcmVlU3RhY2soZWxlbWVudElkKTsKKyAgICBpZiAod2lu ZG93LmV2ZW50U2VuZGVyKSB7CisgICAgICAgIGV2ZW50U2VuZGVyLmdlc3R1cmVUYXAoZWxlbWVu dC5vZmZzZXRMZWZ0ICsgZWxlbWVudC5vZmZzZXRXaWR0aCAvIDIsIGVsZW1lbnQub2Zmc2V0VG9w ICsgZWxlbWVudC5vZmZzZXRIZWlnaHQgLyAyKTsKKyAgICAgICAgZXZlbnRTZW5kZXIubGVhcEZv cndhcmQoMTApOworICAgICAgICBldmVudFNlbmRlci5rZXlEb3duKCcgJyk7CisgICAgfQorfQor CithZGRFdmVudExpc3RlbmVycyhbJ2RpdjEnLCAnZGl2MS9kaXYxLXNoYWRvdy1yb290LWNoaWxk J10pOworZ2VzdHVyZVRhcCgnZGl2MS9kaXYxLXNoYWRvdy1yb290LWNoaWxkJyk7CitkZWJ1Z0Rp c3BhdGNoZWRFdmVudCgnZ2VzdHVyZXRhcCcpOworPC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+ CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2RvbS9zaGFkb3cvcmVzb3VyY2VzL2V2ZW50 LWRpc3BhdGNoaW5nLmpzIGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vc2hhZG93L3Jlc291cmNlcy9l dmVudC1kaXNwYXRjaGluZy5qcwppbmRleCBhM2I3ODJmZDAwZmZjMGE0YTgxNTA5MTFlNTAxNDY2 MDJlMzJmNmNlLi5kZTFjOTYwMzE1NWJkY2JiY2FjOTk0Yzk3OTkwOWYyYzQzODlkMDc3IDEwMDY0 NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L2RvbS9zaGFkb3cvcmVzb3VyY2VzL2V2ZW50LWRpc3Bh dGNoaW5nLmpzCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL3NoYWRvdy9yZXNvdXJjZXMvZXZl bnQtZGlzcGF0Y2hpbmcuanMKQEAgLTEzOCw2ICsxMzgsNyBAQCBmdW5jdGlvbiBhZGRFdmVudExp c3RlbmVycyhub2RlcykKICAgICAgICAgbm9kZS5hZGRFdmVudExpc3RlbmVyKCdtb3VzZW92ZXIn LCByZWNvcmRFdmVudCwgZmFsc2UpOwogICAgICAgICBub2RlLmFkZEV2ZW50TGlzdGVuZXIoJ21v dXNld2hlZWwnLCByZWNvcmRFdmVudCwgZmFsc2UpOwogICAgICAgICBub2RlLmFkZEV2ZW50TGlz dGVuZXIoJ3RvdWNoc3RhcnQnLCByZWNvcmRFdmVudCwgZmFsc2UpOworICAgICAgICBub2RlLmFk ZEV2ZW50TGlzdGVuZXIoJ2dlc3R1cmV0YXAnLCByZWNvcmRFdmVudCwgZmFsc2UpOwogICAgICAg ICAvLyA8Y29udGVudD4gbWlnaHQgYmUgYW4gaW5hY3RpdmUgaW5zZXJ0aW9uIHBvaW50LCBzbyBz dHlsZSBpdCBhbHNvLgogICAgICAgICBpZiAobm9kZS50YWdOYW1lID09ICdESVYnIHx8IG5vZGUu dGFnTmFtZSA9PSAnREVUQUlMUycgfHwgbm9kZS50YWdOYW1lID09ICdTVU1NQVJZJyB8fCBub2Rl LnRhZ05hbWUgPT0gJ0NPTlRFTlQnKQogICAgICAgICAgICAgbm9kZS5zZXRBdHRyaWJ1dGUoJ3N0 eWxlJywgJ3BhZGRpbmctdG9wOiAnICsgZGVmYXVsdFBhZGRpbmdTaXplICsgJ3B4OycpOwo=