112047 2013-03-11 11:59:31 -0700 Regression(r143542): -webkit-align-items: center with overflow: auto/scroll has extra bottom padding 2013-03-13 15:06:19 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 timothy tony eric esprehn+autocc esprehn ojan.autocc ojan simon.fraser tabatkins timothy tony webkit-bug-importer webkit.review.bot oldest_to_newest 852541 0 192522 timothy 2013-03-11 11:59:31 -0700 Created attachment 192522 Testcase See the attached test case and scroll down. See the empty space being allotted for the image but not being used? The image should not extend off the top into the area that can't be seen. The behavior as-is really only makes sense with overflow: visible. Is this a problem with WebKit or a problem with the spec? <rdar://problem/13392441> 852544 1 webkit-bug-importer 2013-03-11 12:00:44 -0700 <rdar://problem/13392908> 852550 2 simon.fraser 2013-03-11 12:03:45 -0700 *** Bug 112048 has been marked as a duplicate of this bug. *** 852559 3 tony 2013-03-11 12:15:48 -0700 This is how the spec is defined. center is supposed to distribute space equally between the top and the bottom, so we overflow off the top. If you want the more common behavior of "safe" centering (if there's overflow, only overflow in the scroll direction only), you can set the margin top and margin bottom to auto. It's not clear to me if that works for what you're trying to do here since that doesn't produce a scroll bar. What behavior do you want? 852561 4 tony 2013-03-11 12:16:35 -0700 To clarify safe centering: You set the margin top and margin bottom to auto on the img (flex item). 852566 5 tony 2013-03-11 12:23:22 -0700 Also, it looks like on Chrome 26, there's no extra space below the image, but in Chrome 27 and ToT there is. That seems like a regression. 852567 6 ojan 2013-03-11 12:25:01 -0700 Even in Chrome 26, we do true centering, which is kind of weird when overflow is not visible. I think we should propose changing the spec to only do true centering for overflow:visible. 852589 7 timothy 2013-03-11 12:39:26 -0700 I think it only makes sense for overflow: visible. I will try margin: auto in my original content for now. Thanks! 852625 8 timothy 2013-03-11 13:03:11 -0700 FWIW, the deprecated flexbox smartly centers in overflow: auto/scroll. 852626 9 webkit-bug-importer 2013-03-11 13:03:30 -0700 <rdar://problem/13393535> 852636 10 ojan 2013-03-11 13:09:12 -0700 Can you give a use-case for using center alignment and overflow:scroll/auto? A use-case would be helpful for making an argument on www-style. 852651 11 timothy 2013-03-11 13:25:15 -0700 The use case is to just center an image in the container when it is small. When it is large overflow where you can still see the whole image by scrolling down. Using margin: auto does work, so I'm fine with that. If the spec isn't changes then -webkit-align-items: center causing dead whitespace should be fixed. Right now it is weird you can only see the whole image if you use flex-start or stretch. The other keywords can hide content off the top and still allow you to scroll to see content at the end. Thinking about it logically, I think flex-end should set the scroll position and force you to scroll up to see the overflow. Same could be said for center, force the scroll position to be centered and you can scroll up or down in the overflow. The initial visual display is just a clipped version of the overflow: visible result. Does that make sense? I'm not sure if that would fly with the spec editors though… 852681 12 tony 2013-03-11 13:48:30 -0700 I'm going to focus this bug on fixing the extra whitespace being allotted for the image. We can file a new bug if the spec gets updated and we want to special case centering based on overflow. 853954 13 192844 tony 2013-03-12 18:08:00 -0700 Created attachment 192844 Patch 854472 14 192844 ojan 2013-03-13 12:19:33 -0700 Comment on attachment 192844 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=192844&action=review > Source/WebCore/rendering/RenderFlexibleBox.cpp:442 > + if (child->isOutOfFlowPositioned()) > + continue; Maybe add a test-case with out of flow positioned children? Or does one of the existing test cases already cover this? > Source/WebCore/rendering/RenderFlexibleBox.cpp:444 > + LayoutUnit childLogicalBottom = logicalTopForChild(child) + logicalHeightForChild(child) + marginAfterForChild(child); > + maxChildLogicalBottom = std::max(maxChildLogicalBottom, childLogicalBottom); Technically, we only need to do this if the child is aligned center or flex-end, but I suppose it's not worth the extra code. 854479 15 192844 webkit.review.bot 2013-03-13 12:31:14 -0700 Comment on attachment 192844 Patch Clearing flags on attachment: 192844 Committed r145736: <http://trac.webkit.org/changeset/145736> 854480 16 webkit.review.bot 2013-03-13 12:31:18 -0700 All reviewed patches have been landed. Closing bug. 854695 17 tony 2013-03-13 15:06:19 -0700 (In reply to comment #14) > (From update of attachment 192844 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=192844&action=review > > > Source/WebCore/rendering/RenderFlexibleBox.cpp:442 > > + if (child->isOutOfFlowPositioned()) > > + continue; > > Maybe add a test-case with out of flow positioned children? Or does one of the existing test cases already cover this? Sure, https://bugs.webkit.org/show_bug.cgi?id=112294 has a test case for this. 192522 2013-03-11 11:59:31 -0700 2013-03-11 11:59:31 -0700 Testcase Bug.html text/html 330 timothy PHN0eWxlPgpkaXYgewogICAgZGlzcGxheTogLXdlYmtpdC1mbGV4OwogICAgLXdlYmtpdC1qdXN0 aWZ5LWNvbnRlbnQ6IGNlbnRlcjsKICAgIC13ZWJraXQtYWxpZ24taXRlbXM6IGNlbnRlcjsKCiAg ICBvdmVyZmxvdzogYXV0bzsKCiAgICBoZWlnaHQ6IDIwMHB4OwogICAgd2lkdGg6IDIwMHB4OwoK ICAgIGJhY2tncm91bmQtY29sb3I6IGdyYXk7Cn0KPC9zdHlsZT4KCjxkaXY+CjxpbWcgc3JjPSJo dHRwOi8vc3VwcG9ydC1hc3NldHMubmVzdC5jb20vbzFKR21ESFkyWHdiL3NpdGUtNDQvaW1hZ2Vz L3N1cHBvcnQvc3ByaXRlc18yeC1zNjgyNTk3YjJhYi5wbmciPgo8L2Rpdj4K 192844 2013-03-12 18:08:00 -0700 2013-03-13 12:31:14 -0700 Patch bug-112047-20130312180358.patch text/plain 8419 tony U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1NTY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDkzYjcwZWIwNGI1M2Q1 OGZmMzg3YzZjZjYyZWFjZGY3M2VlNWNlOC4uZjYwMzk1ZTlhZDYyNzM0N2E3NzJjYzk5M2Y0NTc2 M2MyODI3Y2M1YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEzLTAzLTEyICBUb255 IENoYW5nICA8dG9ueUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmVncmVzc2lvbihyMTQzNTQy KTogLXdlYmtpdC1hbGlnbi1pdGVtczogY2VudGVyIHdpdGggb3ZlcmZsb3c6IGF1dG8vc2Nyb2xs IGhhcyBleHRyYSBib3R0b20gcGFkZGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTEyMDQ3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgQWRkIGEgbmV3IHBhc3MgZm9yIGNvbXB1dGluZyB0aGUgY2xpZW50 IGJvdHRvbSBlZGdlIHRoYXQgcnVucyBhZnRlciB3ZSd2ZSByZXBvc2l0aW9uZWQgY2hpbGRyZW4K KyAgICAgICAgZHVlIHRvIHdyYXAtcmV2ZXJzZSwgZmxleC1lbmQgb3IgdmVydGljYWwgY2VudGVy aW5nLgorCisgICAgICAgIFRlc3Q6IGNzczMvZmxleGJveC9uZWdhdGl2ZS1vdmVyZmxvdy5odG1s CisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyRmxleGlibGVCb3guY3BwOgorICAgICAgICAo V2ViQ29yZTo6UmVuZGVyRmxleGlibGVCb3g6OmxheW91dEJsb2NrKTogUmVtb3ZlIHRoZSBjb2Rl IHRvIHVzZSBjbGllbnRMb2dpY2FsQm90dG9tKCkgdGhhdCB3YXMgY29tcHV0ZWQgYmVmb3JlCisg ICAgICAgIHJlcG9zaXRpb25pbmcuIFRoZSByZXBvc2l0aW9uaW5nIGNhbiBjaGFuZ2UgdGhlIGVk Z2UuCisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJGbGV4aWJsZUJveDo6Y2xpZW50TG9naWNhbEJv dHRvbUFmdGVyUmVwb3NpdGlvbmluZyk6IENvbXB1dGUgdGhlIG5ldyBib3R0b20gYmFzZWQgb24g dGhlIGZpbmFsIHBvc2l0aW9uCisgICAgICAgIG9mIGZsZXggaXRlbXMuCisgICAgICAgICogcmVu ZGVyaW5nL1JlbmRlckZsZXhpYmxlQm94Lmg6CisgICAgICAgIChSZW5kZXJGbGV4aWJsZUJveCk6 CisKIDIwMTMtMDMtMTIgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAK ICAgICAgICAgS2VlcCB0cmFjayBvZiB0aGUgbnVtYmVyIG9mIEdyYXBoaWNzTGF5ZXJzIHdpdGgg dGlsZWQgYmFja2luZyBpbiBSZW5kZXJMYXllckNvbXBvc2l0b3IKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJGbGV4aWJsZUJveC5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyRmxleGlibGVCb3guY3BwCmluZGV4IGI5MGEzZmQ1ZWZkZmVhNjdl MzlhNDJlYzU0ZjAxYzFlODdlMGI3MGUuLjgyNGRjYzlkNTdjODExYTgxNDQ5ZDQyYzJhMzEwNDY0 YzIwZWZmOWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJGbGV4 aWJsZUJveC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckZsZXhpYmxl Qm94LmNwcApAQCAtMzU1LDcgKzM1NSw2IEBAIHZvaWQgUmVuZGVyRmxleGlibGVCb3g6OmxheW91 dEJsb2NrKGJvb2wgcmVsYXlvdXRDaGlsZHJlbiwgTGF5b3V0VW5pdCkKICAgICBhcHBlbmRDaGls ZEZyYW1lUmVjdHMob2xkQ2hpbGRSZWN0cyk7CiAgICAgbGF5b3V0RmxleEl0ZW1zKHJlbGF5b3V0 Q2hpbGRyZW4sIGxpbmVDb250ZXh0cyk7CiAKLSAgICBMYXlvdXRVbml0IG9sZENsaWVudEFmdGVy RWRnZSA9IGNsaWVudExvZ2ljYWxCb3R0b20oKTsKICAgICB1cGRhdGVMb2dpY2FsSGVpZ2h0KCk7 CiAgICAgcmVwb3NpdGlvbkxvZ2ljYWxIZWlnaHREZXBlbmRlbnRGbGV4SXRlbXMobGluZUNvbnRl eHRzKTsKIApAQCAtMzcwLDcgKzM2OSw3IEBAIHZvaWQgUmVuZGVyRmxleGlibGVCb3g6OmxheW91 dEJsb2NrKGJvb2wgcmVsYXlvdXRDaGlsZHJlbiwgTGF5b3V0VW5pdCkKIAogICAgIHJlcGFpbnRD aGlsZHJlbkR1cmluZ0xheW91dElmTW92ZWQob2xkQ2hpbGRSZWN0cyk7CiAgICAgLy8gRklYTUU6 IGNzczMvZmxleGJveC9yZXBhaW50LXJ0bC1jb2x1bW4uaHRtbCBzZWVtcyB0byByZXBhaW50IG1v cmUgb3ZlcmZsb3cgdGhhbiBpdCBuZWVkcyB0by4KLSAgICBjb21wdXRlT3ZlcmZsb3cob2xkQ2xp ZW50QWZ0ZXJFZGdlKTsKKyAgICBjb21wdXRlT3ZlcmZsb3coY2xpZW50TG9naWNhbEJvdHRvbUFm dGVyUmVwb3NpdGlvbmluZygpKTsKICAgICBzdGF0ZVB1c2hlci5wb3AoKTsKIAogICAgIHVwZGF0 ZUxheWVyVHJhbnNmb3JtKCk7CkBAIC00MzUsNiArNDM0LDE4IEBAIHZvaWQgUmVuZGVyRmxleGli bGVCb3g6OnJlcG9zaXRpb25Mb2dpY2FsSGVpZ2h0RGVwZW5kZW50RmxleEl0ZW1zKFZlY3RvcjxM aW5lQ29uCiAgICAgZmxpcEZvclJpZ2h0VG9MZWZ0Q29sdW1uKCk7CiB9CiAKK0xheW91dFVuaXQg UmVuZGVyRmxleGlibGVCb3g6OmNsaWVudExvZ2ljYWxCb3R0b21BZnRlclJlcG9zaXRpb25pbmco KQoreworICAgIExheW91dFVuaXQgbWF4Q2hpbGRMb2dpY2FsQm90dG9tID0gMDsKKyAgICBmb3Ig KFJlbmRlckJveCogY2hpbGQgPSBmaXJzdENoaWxkQm94KCk7IGNoaWxkOyBjaGlsZCA9IGNoaWxk LT5uZXh0U2libGluZ0JveCgpKSB7CisgICAgICAgIGlmIChjaGlsZC0+aXNPdXRPZkZsb3dQb3Np dGlvbmVkKCkpCisgICAgICAgICAgICBjb250aW51ZTsKKyAgICAgICAgTGF5b3V0VW5pdCBjaGls ZExvZ2ljYWxCb3R0b20gPSBsb2dpY2FsVG9wRm9yQ2hpbGQoY2hpbGQpICsgbG9naWNhbEhlaWdo dEZvckNoaWxkKGNoaWxkKSArIG1hcmdpbkFmdGVyRm9yQ2hpbGQoY2hpbGQpOworICAgICAgICBt YXhDaGlsZExvZ2ljYWxCb3R0b20gPSBzdGQ6Om1heChtYXhDaGlsZExvZ2ljYWxCb3R0b20sIGNo aWxkTG9naWNhbEJvdHRvbSk7CisgICAgfQorICAgIHJldHVybiBzdGQ6Om1heChjbGllbnRMb2dp Y2FsQm90dG9tKCksIG1heENoaWxkTG9naWNhbEJvdHRvbSk7Cit9CisKIGJvb2wgUmVuZGVyRmxl eGlibGVCb3g6Omhhc09ydGhvZ29uYWxGbG93KFJlbmRlckJveCogY2hpbGQpIGNvbnN0CiB7CiAg ICAgLy8gRklYTUU6IElmIHRoZSBjaGlsZCBpcyBhIGZsZXhib3gsIHRoZW4gd2UgbmVlZCB0byBj aGVjayBpc0hvcml6b250YWxGbG93LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlckZsZXhpYmxlQm94LmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy RmxleGlibGVCb3guaAppbmRleCBjYTdkZmMxODM1MTA4ZTk5ODdlYWUyNzhmZTFkMTk1NGI1YzEz ZTJhLi40Mjg0OTNiMzZiMzA1ZDFmZGYxZjA1MGFkNDYzNjFhNzNjYjNiMTcyIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRmxleGlibGVCb3guaAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRmxleGlibGVCb3guaApAQCAtMTQ2LDYgKzE0Niw3 IEBAIHByaXZhdGU6CiAgICAgYm9vbCBoYXNBdXRvTWFyZ2luc0luQ3Jvc3NBeGlzKFJlbmRlckJv eCogY2hpbGQpIGNvbnN0OwogICAgIGJvb2wgdXBkYXRlQXV0b01hcmdpbnNJbkNyb3NzQXhpcyhS ZW5kZXJCb3gqIGNoaWxkLCBMYXlvdXRVbml0IGF2YWlsYWJsZUFsaWdubWVudFNwYWNlKTsKICAg ICB2b2lkIHJlcG9zaXRpb25Mb2dpY2FsSGVpZ2h0RGVwZW5kZW50RmxleEl0ZW1zKFZlY3RvcjxM aW5lQ29udGV4dD4mKTsKKyAgICBMYXlvdXRVbml0IGNsaWVudExvZ2ljYWxCb3R0b21BZnRlclJl cG9zaXRpb25pbmcoKTsKICAgICB2b2lkIGFwcGVuZENoaWxkRnJhbWVSZWN0cyhDaGlsZEZyYW1l UmVjdHMmKTsKICAgICB2b2lkIHJlcGFpbnRDaGlsZHJlbkR1cmluZ0xheW91dElmTW92ZWQoY29u c3QgQ2hpbGRGcmFtZVJlY3RzJik7CiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxv ZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA5ZjM0ZTZmZmEwOWEyOTIzYTg1YTgwZmJj MjNjMzcyMDU3OTg0NGY0Li5kYWU2ODYyYjNiMjIyOGUzMzkxNjUyMTk4MzkzZDQzMTVjZDViOWM0 IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTMtMDMtMTIgIFRvbnkgQ2hhbmcgIDx0b255QGNo cm9taXVtLm9yZz4KKworICAgICAgICBSZWdyZXNzaW9uKHIxNDM1NDIpOiAtd2Via2l0LWFsaWdu LWl0ZW1zOiBjZW50ZXIgd2l0aCBvdmVyZmxvdzogYXV0by9zY3JvbGwgaGFzIGV4dHJhIGJvdHRv bSBwYWRkaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMTIwNDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIGNzczMvZmxleGJveC9uZWdhdGl2ZS1vdmVyZmxvdy1leHBlY3RlZC50eHQ6IEFkZGVkLgor ICAgICAgICAqIGNzczMvZmxleGJveC9uZWdhdGl2ZS1vdmVyZmxvdy5odG1sOiBBZGRlZC4KKyAg ICAgICAgKiByZXNvdXJjZXMvY2hlY2stbGF5b3V0LmpzOiBBZGQgYXR0cmlidXRlcyBmb3IgY2hl Y2tpbmcgc2Nyb2xsIHdpZHRoIGFuZCBzY3JvbGwgaGVpZ2h0LgorCiAyMDEzLTAzLTEyICBaYW4g RG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkIEdU SyBnYXJkZW5pbmcuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9jc3MzL2ZsZXhib3gvbmVnYXRp dmUtb3ZlcmZsb3ctZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvY3NzMy9mbGV4Ym94L25lZ2F0 aXZlLW92ZXJmbG93LWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5mNjE5NjZkMDMwODJhYmYwNjdm ZmFjMTI5NWM0ZDJjYmM3MTk4NWU3Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvY3Nz My9mbGV4Ym94L25lZ2F0aXZlLW92ZXJmbG93LWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDggQEAK K1BBU1MKK1BBU1MKK1BBU1MKK1BBU1MKK1BBU1MKK1BBU1MKK1BBU1MKK1BBU1MKZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL2NzczMvZmxleGJveC9uZWdhdGl2ZS1vdmVyZmxvdy5odG1sIGIvTGF5 b3V0VGVzdHMvY3NzMy9mbGV4Ym94L25lZ2F0aXZlLW92ZXJmbG93Lmh0bWwKbmV3IGZpbGUgbW9k ZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4u NjAzZGJiMzcxZjhjNGUzNmI4MDgxMWViMmVjOWI4MDIzNDA0ZTU4MQotLS0gL2Rldi9udWxsCisr KyBiL0xheW91dFRlc3RzL2NzczMvZmxleGJveC9uZWdhdGl2ZS1vdmVyZmxvdy5odG1sCkBAIC0w LDAgKzEsNzMgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8aGVhZD4KKzxsaW5rIGhyZWY9 InJlc291cmNlcy9mbGV4Ym94LmNzcyIgcmVsPSJzdHlsZXNoZWV0Ij4KKzxzdHlsZT4KKy5mbGV4 Ym94IHsKKyAgICBvdmVyZmxvdzogYXV0bzsKKyAgICBoZWlnaHQ6IDUwcHg7CisgICAgd2lkdGg6 IDUwcHg7CisgICAgYmFja2dyb3VuZC1jb2xvcjogcmVkOworfQorCisudmVydGljYWwtcGFkZGlu ZyB7CisgICAgcGFkZGluZy10b3A6IDVweDsKKyAgICBwYWRkaW5nLWJvdHRvbTogMTBweDsKKyAg ICBiYWNrZ3JvdW5kLWNvbG9yOiBsaW1lOworfQorCisuZmxleGJveCA+IGRpdiB7CisgICAgd2lk dGg6IDEwMCU7CisgICAgaGVpZ2h0OiAxMDBweDsKKyAgICBiYWNrZ3JvdW5kLWNvbG9yOiBncmVl bjsKK30KKzwvc3R5bGU+Cis8c2NyaXB0IHNyYz0iLi4vLi4vcmVzb3VyY2VzL2NoZWNrLWxheW91 dC5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0Pgord2luZG93Lm9ubG9hZCA9IGZ1bmN0aW9uKCkgewor ICAgIGNoZWNrTGF5b3V0KCcuZmxleGJveCcpOworCisgICAgLy8gTWFrZSBmYWlsdXJlcyBtb3Jl IG9idmlvdXMgYnkgc2hvd2luZyB0aGUgcmVkIGJhY2tncm91bmQgdGhhdCBzaG91bGQgaGF2ZSBi ZWVuIGNsaXBwZWQuCisgICAgQXJyYXkucHJvdG90eXBlLmZvckVhY2guY2FsbChkb2N1bWVudC5x dWVyeVNlbGVjdG9yQWxsKCIuZmxleGJveCIpLCBmdW5jdGlvbihlbGVtZW50KSB7CisgICAgICAg IGVsZW1lbnQuc2Nyb2xsVG9wID0gMTAwMDsKKyAgICB9KTsKK307Cis8L3NjcmlwdD4KKzwvaGVh ZD4KKzxib2R5PgorCis8ZGl2IGNsYXNzPSJmbGV4Ym94IGFsaWduLWl0ZW1zLWZsZXgtZW5kIiBk YXRhLWV4cGVjdGVkLXNjcm9sbC1oZWlnaHQ9IjUwIj4KKyAgICA8ZGl2PjwvZGl2PgorPC9kaXY+ CisKKzxkaXYgY2xhc3M9ImZsZXhib3ggYWxpZ24taXRlbXMtY2VudGVyIiBkYXRhLWV4cGVjdGVk LXNjcm9sbC1oZWlnaHQ9Ijc1Ij4KKyAgICA8ZGl2PjwvZGl2PgorPC9kaXY+CisKKzxkaXYgY2xh c3M9ImZsZXhib3giIGRhdGEtZXhwZWN0ZWQtc2Nyb2xsLWhlaWdodD0iMTAwIj4KKyAgICA8ZGl2 PjwvZGl2PgorPC9kaXY+CisKKzxkaXYgY2xhc3M9ImZsZXhib3ggd3JhcC1yZXZlcnNlIiBkYXRh LWV4cGVjdGVkLXNjcm9sbC1oZWlnaHQ9IjUwIj4KKyAgICA8ZGl2PjwvZGl2PgorICAgIDxkaXY+ PC9kaXY+Cis8L2Rpdj4KKworPGRpdiBjbGFzcz0iZmxleGJveCBhbGlnbi1pdGVtcy1mbGV4LWVu ZCB2ZXJ0aWNhbC1wYWRkaW5nIiBkYXRhLWV4cGVjdGVkLXNjcm9sbC1oZWlnaHQ9IjY1Ij4KKyAg ICA8ZGl2PjwvZGl2PgorPC9kaXY+CisKKzxkaXYgY2xhc3M9ImZsZXhib3ggYWxpZ24taXRlbXMt Y2VudGVyIHZlcnRpY2FsLXBhZGRpbmciIGRhdGEtZXhwZWN0ZWQtc2Nyb2xsLWhlaWdodD0iODAi PgorICAgIDxkaXY+PC9kaXY+Cis8L2Rpdj4KKworPGRpdiBjbGFzcz0iZmxleGJveCB2ZXJ0aWNh bC1wYWRkaW5nIiBkYXRhLWV4cGVjdGVkLXNjcm9sbC1oZWlnaHQ9IjEwNSI+CisgICAgPGRpdj48 L2Rpdj4KKzwvZGl2PgorCis8ZGl2IGNsYXNzPSJmbGV4Ym94IHdyYXAtcmV2ZXJzZSB2ZXJ0aWNh bC1wYWRkaW5nIiBkYXRhLWV4cGVjdGVkLXNjcm9sbC1oZWlnaHQ9IjY1Ij4KKyAgICA8ZGl2Pjwv ZGl2PgorICAgIDxkaXY+PC9kaXY+Cis8L2Rpdj4KKzwvYm9keT4KKzwvaHRtbD4KZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL3Jlc291cmNlcy9jaGVjay1sYXlvdXQuanMgYi9MYXlvdXRUZXN0cy9y ZXNvdXJjZXMvY2hlY2stbGF5b3V0LmpzCmluZGV4IDQ1YTQxOWQ1ODZjNjliMTljYjZiMDdlZjk5 OWY3ZWZkM2VkZWZjMDguLmYyMDI5Y2JhMWQ3MDcwZmI1MTM3ZGY2MGFkNmUxODdhNjUwNDhlZTUg MTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3Jlc291cmNlcy9jaGVjay1sYXlvdXQuanMKKysrIGIv TGF5b3V0VGVzdHMvcmVzb3VyY2VzL2NoZWNrLWxheW91dC5qcwpAQCAtNjIsNiArNjIsMTggQEAg ZnVuY3Rpb24gY2hlY2tFeHBlY3RlZFZhbHVlcyhub2RlLCBmYWlsdXJlcykKICAgICAgICAgICAg IGZhaWx1cmVzLnB1c2goIkV4cGVjdGVkICIgKyBleHBlY3RlZEhlaWdodCArICIgZm9yIGNsaWVu dEhlaWdodCwgYnV0IGdvdCAiICsgbm9kZS5jbGllbnRIZWlnaHQgKyAiLiAiKTsKICAgICB9CiAK KyAgICB2YXIgZXhwZWN0ZWRXaWR0aCA9IG5vZGUuZ2V0QXR0cmlidXRlICYmIG5vZGUuZ2V0QXR0 cmlidXRlKCJkYXRhLWV4cGVjdGVkLXNjcm9sbC13aWR0aCIpOworICAgIGlmIChleHBlY3RlZFdp ZHRoKSB7CisgICAgICAgIGlmIChub2RlLnNjcm9sbFdpZHRoICE9IHBhcnNlSW50KGV4cGVjdGVk V2lkdGgpKQorICAgICAgICAgICAgZmFpbHVyZXMucHVzaCgiRXhwZWN0ZWQgIiArIGV4cGVjdGVk V2lkdGggKyAiIGZvciBzY3JvbGxXaWR0aCwgYnV0IGdvdCAiICsgbm9kZS5zY3JvbGxXaWR0aCAr ICIuICIpOworICAgIH0KKworICAgIHZhciBleHBlY3RlZEhlaWdodCA9IG5vZGUuZ2V0QXR0cmli dXRlICYmIG5vZGUuZ2V0QXR0cmlidXRlKCJkYXRhLWV4cGVjdGVkLXNjcm9sbC1oZWlnaHQiKTsK KyAgICBpZiAoZXhwZWN0ZWRIZWlnaHQpIHsKKyAgICAgICAgaWYgKG5vZGUuc2Nyb2xsSGVpZ2h0 ICE9IHBhcnNlSW50KGV4cGVjdGVkSGVpZ2h0KSkKKyAgICAgICAgICAgIGZhaWx1cmVzLnB1c2go IkV4cGVjdGVkICIgKyBleHBlY3RlZEhlaWdodCArICIgZm9yIHNjcm9sbEhlaWdodCwgYnV0IGdv dCAiICsgbm9kZS5zY3JvbGxIZWlnaHQgKyAiLiAiKTsKKyAgICB9CisKICAgICB2YXIgZXhwZWN0 ZWRPZmZzZXQgPSBub2RlLmdldEF0dHJpYnV0ZSAmJiBub2RlLmdldEF0dHJpYnV0ZSgiZGF0YS10 b3RhbC14Iik7CiAgICAgaWYgKGV4cGVjdGVkT2Zmc2V0KSB7CiAgICAgICAgIHZhciB0b3RhbExl ZnQgPSBub2RlLmNsaWVudExlZnQgKyBub2RlLm9mZnNldExlZnQ7Cg==