112022 2013-03-11 08:21:31 -0700 [BlackBerry] FontCacheBlackBerry: return PassRefPtr<SimpleFontData> 2013-03-12 08:02:24 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 111729 0 berto webkit-unassigned cgarcia mifenton rwlbuis tonikitoo webkit.review.bot xan.lopez oldest_to_newest 852332 0 berto 2013-03-11 08:21:31 -0700 getFontDataForCharacters(), getSimilarFontPlatformData and getLastResortFallbackFont() now return a PassRefPtr This changed in r130160 http://trac.webkit.org/changeset/130160/trunk/Source/WebCore/platform/graphics/SimpleFontData.h 852335 1 192474 berto 2013-03-11 08:24:01 -0700 Created attachment 192474 Patch 852376 2 192474 berto 2013-03-11 08:57:13 -0700 Comment on attachment 192474 Patch Wait, I'll update a new patch with a few more changes. 853447 3 192734 berto 2013-03-12 07:41:56 -0700 Created attachment 192734 Patch 853449 4 192734 rwlbuis 2013-03-12 07:44:42 -0700 Comment on attachment 192734 Patch Ok. 853464 5 192734 webkit.review.bot 2013-03-12 08:02:19 -0700 Comment on attachment 192734 Patch Clearing flags on attachment: 192734 Committed r145544: <http://trac.webkit.org/changeset/145544> 853465 6 webkit.review.bot 2013-03-12 08:02:24 -0700 All reviewed patches have been landed. Closing bug. 192474 2013-03-11 08:24:01 -0700 2013-03-11 08:57:13 -0700 Patch 112022.diff text/plain 2346 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAyZjg0ZGZkLi5lMTkzM2E1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTMtMDMtMTEgIEFsYmVydG8gR2FyY2lhICA8YWdhcmNpYUBpZ2FsaWEuY29tPgorCisg ICAgICAgIFtCbGFja0JlcnJ5XSBGb250Q2FjaGVCbGFja0JlcnJ5OiByZXR1cm4gUGFzc1JlZlB0 cjxTaW1wbGVGb250RGF0YT4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTExMjAyMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIGdldEZvbnREYXRhRm9yQ2hhcmFjdGVycygpLCBnZXRTaW1pbGFyRm9udFBsYXRm b3JtRGF0YSgpIGFuZAorICAgICAgICBnZXRMYXN0UmVzb3J0RmFsbGJhY2tGb250KCkgcmV0dXJu IGEgUGFzc1JlZlB0ciBzaW5jZSByMTMwMTYwLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhp Y3MvYmxhY2tiZXJyeS9Gb250Q2FjaGVCbGFja0JlcnJ5LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OkZvbnRDYWNoZTo6Z2V0Rm9udERhdGFGb3JDaGFyYWN0ZXJzKToKKyAgICAgICAgKFdlYkNvcmU6 OkZvbnRDYWNoZTo6Z2V0U2ltaWxhckZvbnRQbGF0Zm9ybURhdGEpOgorICAgICAgICAoV2ViQ29y ZTo6Rm9udENhY2hlOjpnZXRMYXN0UmVzb3J0RmFsbGJhY2tGb250KToKKwogMjAxMy0wMy0xMSAg S2VudCBUYW11cmEgIDx0a2VudEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgSW5hcHByb3ByaWF0 ZSB2YWxpZGF0aW9uIG1lc3NhZ2UgZm9yIHJlcXVpcmVkIG51bWJlci9kYXRlIGlucHV0IGVsZW1l bnRzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ibGFja2Jl cnJ5L0ZvbnRDYWNoZUJsYWNrQmVycnkuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvYmxhY2tiZXJyeS9Gb250Q2FjaGVCbGFja0JlcnJ5LmNwcAppbmRleCAwOGQyZjExLi4y YWVjNmExIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ibGFj a2JlcnJ5L0ZvbnRDYWNoZUJsYWNrQmVycnkuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2JsYWNrYmVycnkvRm9udENhY2hlQmxhY2tCZXJyeS5jcHAKQEAgLTUwLDcg KzUwLDcgQEAgdm9pZCBGb250Q2FjaGU6OnBsYXRmb3JtSW5pdCgpCiAgICAgICAgIENSQVNIKCk7 CiB9CiAKLWNvbnN0IFNpbXBsZUZvbnREYXRhKiBGb250Q2FjaGU6OmdldEZvbnREYXRhRm9yQ2hh cmFjdGVycyhjb25zdCBGb250JiBmb250LCBjb25zdCBVQ2hhciogY2hhcmFjdGVycywgaW50IGxl bmd0aCkKK1Bhc3NSZWZQdHI8U2ltcGxlRm9udERhdGE+IEZvbnRDYWNoZTo6Z2V0Rm9udERhdGFG b3JDaGFyYWN0ZXJzKGNvbnN0IEZvbnQmIGZvbnQsIGNvbnN0IFVDaGFyKiBjaGFyYWN0ZXJzLCBp bnQgbGVuZ3RoKQogewogICAgIGljdTo6TG9jYWxlIGxvY2FsZSA9IGljdTo6TG9jYWxlOjpnZXRE ZWZhdWx0KCk7CiAgICAgUGxhdGZvcm1TdXBwb3J0OjpGb250RmFtaWx5IGZhbWlseTsKQEAgLTg3 LDEyICs4NywxMiBAQCBjb25zdCBTaW1wbGVGb250RGF0YSogRm9udENhY2hlOjpnZXRGb250RGF0 YUZvckNoYXJhY3RlcnMoY29uc3QgRm9udCYgZm9udCwgY29ucwogICAgIHJldHVybiBnZXRDYWNo ZWRGb250RGF0YSgmcGxhdGZvcm1EYXRhLCBEb05vdFJldGFpbik7CiB9CiAKLVNpbXBsZUZvbnRE YXRhKiBGb250Q2FjaGU6OmdldFNpbWlsYXJGb250UGxhdGZvcm1EYXRhKGNvbnN0IEZvbnQmIGZv bnQpCitQYXNzUmVmUHRyPFNpbXBsZUZvbnREYXRhPiBGb250Q2FjaGU6OmdldFNpbWlsYXJGb250 UGxhdGZvcm1EYXRhKGNvbnN0IEZvbnQmIGZvbnQpCiB7CiAgICAgcmV0dXJuIDA7CiB9CiAKLVNp bXBsZUZvbnREYXRhKiBGb250Q2FjaGU6OmdldExhc3RSZXNvcnRGYWxsYmFja0ZvbnQoY29uc3Qg Rm9udERlc2NyaXB0aW9uJiBkZXNjcmlwdGlvbiwgU2hvdWxkUmV0YWluKQorUGFzc1JlZlB0cjxT aW1wbGVGb250RGF0YT4gRm9udENhY2hlOjpnZXRMYXN0UmVzb3J0RmFsbGJhY2tGb250KGNvbnN0 IEZvbnREZXNjcmlwdGlvbiYgZGVzY3JpcHRpb24sIFNob3VsZFJldGFpbikKIHsKICAgICBERUZJ TkVfU1RBVElDX0xPQ0FMKGNvbnN0IEF0b21pY1N0cmluZywgc2Fuc1N0ciwgKCJTYW5zIikpOwog ICAgIERFRklORV9TVEFUSUNfTE9DQUwoY29uc3QgQXRvbWljU3RyaW5nLCBzZXJpZlN0ciwgKCJT ZXJpZiIpKTsK 192734 2013-03-12 07:41:56 -0700 2013-03-12 08:02:19 -0700 Patch 112022.diff text/plain 3405 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmN2I5YjFkLi5hYTFlNDk4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTMtMDMtMTIgIEFsYmVydG8gR2FyY2lhICA8YWdhcmNpYUBpZ2FsaWEuY29tPgorCisg ICAgICAgIFtCbGFja0JlcnJ5XSBGb250Q2FjaGVCbGFja0JlcnJ5OiByZXR1cm4gUGFzc1JlZlB0 cjxTaW1wbGVGb250RGF0YT4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTExMjAyMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEZvbnREYXRhIGZ1bmN0aW9ucyByZXR1cm4gUGFzc1JlZlB0ciBzaW5jZSByMTMw MTYwLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvYmxhY2tiZXJyeS9Gb250Q2FjaGVC bGFja0JlcnJ5LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZvbnRDYWNoZTo6Z2V0Rm9udERhdGFG b3JDaGFyYWN0ZXJzKToKKyAgICAgICAgKFdlYkNvcmU6OkZvbnRDYWNoZTo6Z2V0U2ltaWxhckZv bnRQbGF0Zm9ybURhdGEpOgorICAgICAgICAoV2ViQ29yZTo6Rm9udENhY2hlOjpnZXRMYXN0UmVz b3J0RmFsbGJhY2tGb250KToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9ibGFja2JlcnJ5 L1NpbXBsZUZvbnREYXRhQmxhY2tCZXJyeS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTaW1wbGVG b250RGF0YTo6Y3JlYXRlU2NhbGVkRm9udERhdGEpOgorCiAyMDEzLTAzLTEyICBWc2V2b2xvZCBW bGFzb3YgIDx2c2V2aWtAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFJl c291cmNlU2NyaXB0RmlsZSBkaXZlcmdlZCBzdGF0ZSBzaG91bGQgYmUgY29ycmVjdGx5IHJlc2V0 IGFmdGVyIGRlYnVnZ2VyIHJlc2V0LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvYmxhY2tiZXJyeS9Gb250Q2FjaGVCbGFja0JlcnJ5LmNwcCBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2JsYWNrYmVycnkvRm9udENhY2hlQmxhY2tCZXJyeS5j cHAKaW5kZXggMDhkMmYxMS4uMmFlYzZhMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvYmxhY2tiZXJyeS9Gb250Q2FjaGVCbGFja0JlcnJ5LmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ibGFja2JlcnJ5L0ZvbnRDYWNoZUJsYWNr QmVycnkuY3BwCkBAIC01MCw3ICs1MCw3IEBAIHZvaWQgRm9udENhY2hlOjpwbGF0Zm9ybUluaXQo KQogICAgICAgICBDUkFTSCgpOwogfQogCi1jb25zdCBTaW1wbGVGb250RGF0YSogRm9udENhY2hl OjpnZXRGb250RGF0YUZvckNoYXJhY3RlcnMoY29uc3QgRm9udCYgZm9udCwgY29uc3QgVUNoYXIq IGNoYXJhY3RlcnMsIGludCBsZW5ndGgpCitQYXNzUmVmUHRyPFNpbXBsZUZvbnREYXRhPiBGb250 Q2FjaGU6OmdldEZvbnREYXRhRm9yQ2hhcmFjdGVycyhjb25zdCBGb250JiBmb250LCBjb25zdCBV Q2hhciogY2hhcmFjdGVycywgaW50IGxlbmd0aCkKIHsKICAgICBpY3U6OkxvY2FsZSBsb2NhbGUg PSBpY3U6OkxvY2FsZTo6Z2V0RGVmYXVsdCgpOwogICAgIFBsYXRmb3JtU3VwcG9ydDo6Rm9udEZh bWlseSBmYW1pbHk7CkBAIC04NywxMiArODcsMTIgQEAgY29uc3QgU2ltcGxlRm9udERhdGEqIEZv bnRDYWNoZTo6Z2V0Rm9udERhdGFGb3JDaGFyYWN0ZXJzKGNvbnN0IEZvbnQmIGZvbnQsIGNvbnMK ICAgICByZXR1cm4gZ2V0Q2FjaGVkRm9udERhdGEoJnBsYXRmb3JtRGF0YSwgRG9Ob3RSZXRhaW4p OwogfQogCi1TaW1wbGVGb250RGF0YSogRm9udENhY2hlOjpnZXRTaW1pbGFyRm9udFBsYXRmb3Jt RGF0YShjb25zdCBGb250JiBmb250KQorUGFzc1JlZlB0cjxTaW1wbGVGb250RGF0YT4gRm9udENh Y2hlOjpnZXRTaW1pbGFyRm9udFBsYXRmb3JtRGF0YShjb25zdCBGb250JiBmb250KQogewogICAg IHJldHVybiAwOwogfQogCi1TaW1wbGVGb250RGF0YSogRm9udENhY2hlOjpnZXRMYXN0UmVzb3J0 RmFsbGJhY2tGb250KGNvbnN0IEZvbnREZXNjcmlwdGlvbiYgZGVzY3JpcHRpb24sIFNob3VsZFJl dGFpbikKK1Bhc3NSZWZQdHI8U2ltcGxlRm9udERhdGE+IEZvbnRDYWNoZTo6Z2V0TGFzdFJlc29y dEZhbGxiYWNrRm9udChjb25zdCBGb250RGVzY3JpcHRpb24mIGRlc2NyaXB0aW9uLCBTaG91bGRS ZXRhaW4pCiB7CiAgICAgREVGSU5FX1NUQVRJQ19MT0NBTChjb25zdCBBdG9taWNTdHJpbmcsIHNh bnNTdHIsICgiU2FucyIpKTsKICAgICBERUZJTkVfU1RBVElDX0xPQ0FMKGNvbnN0IEF0b21pY1N0 cmluZywgc2VyaWZTdHIsICgiU2VyaWYiKSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9ibGFja2JlcnJ5L1NpbXBsZUZvbnREYXRhQmxhY2tCZXJyeS5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ibGFja2JlcnJ5L1NpbXBsZUZvbnRE YXRhQmxhY2tCZXJyeS5jcHAKaW5kZXggYzY3MDA5Yi4uNmM1ZWViYiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYmxhY2tiZXJyeS9TaW1wbGVGb250RGF0YUJs YWNrQmVycnkuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2JsYWNr YmVycnkvU2ltcGxlRm9udERhdGFCbGFja0JlcnJ5LmNwcApAQCAtMTA3LDEwICsxMDcsMTAgQEAg dm9pZCBTaW1wbGVGb250RGF0YTo6cGxhdGZvcm1EZXN0cm95KCkKIHsKIH0KIAotUGFzc093blB0 cjxTaW1wbGVGb250RGF0YT4gU2ltcGxlRm9udERhdGE6OmNyZWF0ZVNjYWxlZEZvbnREYXRhKGNv bnN0IEZvbnREZXNjcmlwdGlvbiYgZm9udERlc2NyaXB0aW9uLCBmbG9hdCBzY2FsZUZhY3Rvcikg Y29uc3QKK1Bhc3NSZWZQdHI8U2ltcGxlRm9udERhdGE+IFNpbXBsZUZvbnREYXRhOjpjcmVhdGVT Y2FsZWRGb250RGF0YShjb25zdCBGb250RGVzY3JpcHRpb24mIGZvbnREZXNjcmlwdGlvbiwgZmxv YXQgc2NhbGVGYWN0b3IpIGNvbnN0CiB7CiAgICAgY29uc3QgZmxvYXQgc2NhbGVkU2l6ZSA9IGxy b3VuZGYoZm9udERlc2NyaXB0aW9uLmNvbXB1dGVkU2l6ZSgpICogc2NhbGVGYWN0b3IpOwotICAg IHJldHVybiBhZG9wdFB0cihuZXcgU2ltcGxlRm9udERhdGEoCisgICAgcmV0dXJuIGFkb3B0UmVm KG5ldyBTaW1wbGVGb250RGF0YSgKICAgICAgICAgRm9udFBsYXRmb3JtRGF0YShtX3BsYXRmb3Jt RGF0YS5mb250KCktPmN1cl9sZm50LT5uYW1lLAogICAgICAgICAgICAgc2NhbGVkU2l6ZSwKICAg ICAgICAgICAgIG1fcGxhdGZvcm1EYXRhLnN5bnRoZXRpY0JvbGQoKSwK