111980 2013-03-11 05:52:59 -0700 WebKit doesn't configure if gtk-doc-am is not installed Tools/GNUmakefile.am:419: ENABLE_GTK_DOC does not appear in AM_CONDITIONAL 2013-03-11 16:41:22 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 tobiasmue webkit-unassigned csaavedra mrobinson webkit.review.bot oldest_to_newest 852225 0 tobiasmue 2013-03-11 05:52:59 -0700 $ ./autogen.sh --prefix /opt/gnome2 --libdir /opt/gnome2/lib64 --enable-introspection --disable-silent-rules --with-gstreamer=1.0 --disable-static --disable-scrollkeeper --disable-gtk-doc --disable-docs --enable-gtk-doc=no --enable-gtk-doc-html=no --enable-gtk-doc-pdf=no --disable-webkit1 --disable-spellcheck --disable-glx --disable-egl --disable-gles2 --disable-gamepad --disable-video --disable-mediastream --enable-xslt --disable-geolocation --disable-svg --disable-svg-fonts --disable-web-audio --disable-coverage --disable-webgl --disable-gtk-doc-html --disable-accelerated-compositing autoreconf: Entering directory `.' autoreconf: configure.ac: not using Gettext autoreconf: running: aclocal -I Source/autotools autoreconf: configure.ac: tracing autoreconf: running: libtoolize --copy libtoolize: Remember to add `LT_INIT' to configure.ac. libtoolize: Consider adding `-I Source/autotools' to ACLOCAL_AMFLAGS in Makefile.am. autoreconf: running: /usr/bin/autoconf --include=Source/autotools autoreconf: running: /usr/bin/autoheader --include=Source/autotools autoreconf: running: automake --add-missing --copy --no-force Tools/GNUmakefile.am:419: ENABLE_GTK_DOC does not appear in AM_CONDITIONAL GNUmakefile.am:183: `Tools/GNUmakefile.am' included from here autoreconf: automake failed with exit status: 1 $ automake --add-missing --copy --no-force Tools/GNUmakefile.am:419: ENABLE_GTK_DOC does not appear in AM_CONDITIONAL GNUmakefile.am:183: `Tools/GNUmakefile.am' included from here $ echo $? 1 $ automake --version automake (GNU automake) 1.11.6 Copyright (C) 2011 Free Software Foundation, Inc. License GPLv2+: GNU GPL version 2 or later <http://gnu.org/licenses/gpl-2.0.html> This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Written by Tom Tromey <tromey@redhat.com> and Alexandre Duret-Lutz <adl@gnu.org>. $ automake --add-missing --copy --no-force -v automake: thread 0: reading autoconf --trace=_LT_AC_TAGCONFIG:\$f:\$l::\$d::\$n::\${::}% --trace=AC_INIT:\$f:\$l::\$d::\$n::\${::}% --trace=_AM_COND_IF:\$f:\$l::\$d::\$n::\${::}% --trace=AC_CANONICAL_TARGET:\$f:\$l::\$d::\$n::\${::}% --trace=AC_CONFIG_LIBOBJ_DIR:\$f:\$l::\$d::\$n::\${::}% --trace=AC_FC_SRCEXT:\$f:\$l::\$d::\$n::\${::}% --trace=AC_CANONICAL_HOST:\$f:\$l::\$d::\$n::\${::}% --trace=AM_INIT_AUTOMAKE:\$f:\$l::\$d::\$n::\${::}% --trace=AM_AUTOMAKE_VERSION:\$f:\$l::\$d::\$n::\${::}% --trace=AC_CONFIG_LINKS:\$f:\$l::\$d::\$n::\${::}% --trace=AC_REQUIRE_AUX_FILE:\$f:\$l::\$d::\$n::\${::}% --trace=m4_sinclude:\$f:\$l::\$d::\$n::\${::}% --trace=LT_SUPPORTED_TAG:\$f:\$l::\$d::\$n::\${::}% --trace=AM_MAINTAINER_MODE:\$f:\$l::\$d::\$n::\${::}% --trace=AM_GNU_GETTEXT_INTL_SUBDIR:\$f:\$l::\$d::\$n::\${::}% --trace=_AM_COND_ENDIF:\$f:\$l::\$d::\$n::\${::}% --trace=AM_ENABLE_MULTILIB:\$f:\$l::\$d::\$n::\${::}% --trace=AM_SILENT_RULES:\$f:\$l::\$d::\$n::\${::}% --trace=AC_CONFIG_FILES:\$f:\$l::\$d::\$n::\${::}% --trace=AM_GNU_GETTEXT:\$f:\$l::\$d::\$n::\${::}% --trace=AM_PROG_AR:\$f:\$l::\$d::\$n::\${::}% --trace=AC_LIBSOURCE:\$f:\$l::\$d::\$n::\${::}% --trace=AC_CANONICAL_BUILD:\$f:\$l::\$d::\$n::\${::}% --trace=AC_CONFIG_AUX_DIR:\$f:\$l::\$d::\$n::\${::}% --trace=_AM_SUBST_NOTMAKE:\$f:\$l::\$d::\$n::\${::}% --trace=AM_PROG_CC_C_O:\$f:\$l::\$d::\$n::\${::}% --trace=sinclude:\$f:\$l::\$d::\$n::\${::}% --trace=AM_CONDITIONAL:\$f:\$l::\$d::\$n::\${::}% --trace=AC_CONFIG_HEADERS:\$f:\$l::\$d::\$n::\${::}% --trace=m4_include:\$f:\$l::\$d::\$n::\${::}% --trace=_AM_COND_ELSE:\$f:\$l::\$d::\$n::\${::}% --trace=AC_SUBST_TRACE:\$f:\$l::\$d::\$n::\${::}% automake: thread 0: reading /usr/share/automake-1.11/am/header-vars.am automake: thread 0: reading GNUmakefile.am automake: thread 0: reading Source/WTF/GNUmakefile.am automake: thread 0: reading Source/WTF/GNUmakefile.list.am automake: thread 0: reading Source/JavaScriptCore/GNUmakefile.am automake: thread 0: reading Source/JavaScriptCore/GNUmakefile.list.am automake: thread 0: reading Source/WebCore/GNUmakefile.am automake: thread 0: reading Source/WebCore/GNUmakefile.list.am automake: thread 0: reading Source/WebCore/bindings/gobject/GNUmakefile.am automake: thread 0: reading Source/WebCore/platform/gtk/po/GNUmakefile.am automake: thread 0: Sources ending in .po become .mo automake: thread 0: Sources ending in .nop become .po-create automake: thread 0: reading Source/WebKit/gtk/GNUmakefile.am automake: thread 0: reading Tools/GNUmakefile.am Tools/GNUmakefile.am:419: ENABLE_GTK_DOC does not appear in AM_CONDITIONAL GNUmakefile.am:183: `Tools/GNUmakefile.am' included from here automake: thread 0: reading Source/WebKit2/GNUmakefile.am automake: thread 0: reading Source/WebKit2/GNUmakefile.list.am automake: thread 0: reading Source/WebKit2/UIProcess/API/gtk/tests/GNUmakefile.am automake: thread 0: reading Tools/MiniBrowser/gtk/GNUmakefile.am automake: thread 0: reading Tools/WebKitTestRunner/GNUmakefile.am automake: thread 0: reading Source/ThirdParty/gtest/GNUmakefile.am automake: thread 0: reading Tools/TestWebKitAPI/GNUmakefile.am automake: thread 0: reading /usr/share/automake-1.11/am/configure.am automake: thread 0: reading /usr/share/automake-1.11/am/remake-hdr.am automake: thread 0: reading /usr/share/automake-1.11/am/clean-hdr.am automake: thread 0: reading /usr/share/automake-1.11/am/ltlib.am automake: thread 0: reading /usr/share/automake-1.11/am/inst-vars.am automake: thread 0: reading /usr/share/automake-1.11/am/ltlibrary.am automake: thread 0: reading /usr/share/automake-1.11/am/progs.am automake: thread 0: reading /usr/share/automake-1.11/am/program.am automake: thread 0: reading /usr/share/automake-1.11/am/compile.am automake: thread 0: reading /usr/share/automake-1.11/am/depend.am automake: thread 0: reading /usr/share/automake-1.11/am/depend2.am automake: thread 0: Sources ending in .c become .o automake: thread 0: Sources ending in .c become .obj automake: thread 0: Sources ending in .c become .lo automake: thread 0: reading /usr/share/automake-1.11/am/lang-compile.am automake: thread 0: Sources ending in .cc become .o automake: thread 0: Sources ending in .cc become .obj automake: thread 0: Sources ending in .cc become .lo automake: thread 0: Sources ending in .cpp become .o automake: thread 0: Sources ending in .cpp become .obj automake: thread 0: Sources ending in .cpp become .lo automake: thread 0: reading /usr/share/automake-1.11/am/libtool.am automake: thread 0: reading /usr/share/automake-1.11/am/texinfos.am automake: thread 0: reading /usr/share/automake-1.11/am/data.am automake: thread 0: reading /usr/share/automake-1.11/am/header.am automake: thread 0: reading /usr/share/automake-1.11/am/tags.am automake: thread 0: reading /usr/share/automake-1.11/am/distdir.am automake: thread 0: reading /usr/share/automake-1.11/am/footer.am automake: thread 0: reading /usr/share/automake-1.11/am/install.am automake: thread 0: reading /usr/share/automake-1.11/am/clean.am automake: thread 0: not writing ./GNUmakefile.in because of earlier errors Looking at https://developer.gnome.org/gtk-doc-manual/unstable/settingup_autoconf.html.en the correct fix seems to be to check whether the GTK_DOC_CHECK macro exists and if not, set ENABLE_GTK_DOC to false. After applying the patch attached, I could run the ./autogen.sh 852227 1 192453 tobiasmue 2013-03-11 05:54:26 -0700 Created attachment 192453 Sets ENABLE_GTK_DOC if GTK_DOC_CHECK is not found 852270 2 csaavedra 2013-03-11 07:14:56 -0700 Thanks for the patch! Would you mind adding a ChangeLog entry as described here? https://www.webkit.org/coding/contributing.html When you do, please flip the review and commit-queue flags to '?'. Thank you! 852374 3 mrobinson 2013-03-11 08:54:37 -0700 Where does GTK_DOC_CHECK come from in this case? 852377 4 csaavedra 2013-03-11 08:58:08 -0700 It comes from gtkdoc.m4. 852383 5 mrobinson 2013-03-11 09:03:03 -0700 (In reply to comment #4) > It comes from gtkdoc.m4. Ah! This patch makes sense to me now. :) 852506 6 192517 tobiasmue 2013-03-11 11:28:57 -0700 Created attachment 192517 Same path with a changelog entry (In reply to comment #2) > Thanks for the patch! Would you mind adding a ChangeLog entry as described here? https://www.webkit.org/coding/contributing.html k. I didn't do in first place because I came from http://webkitgtk.org/?page=contribute which does not reference the website you pointed out. > When you do, please flip the review and commit-queue flags to '?'. Thank you! k. 852862 7 192517 webkit.review.bot 2013-03-11 16:41:18 -0700 Comment on attachment 192517 Same path with a changelog entry Clearing flags on attachment: 192517 Committed r145427: <http://trac.webkit.org/changeset/145427> 852863 8 webkit.review.bot 2013-03-11 16:41:22 -0700 All reviewed patches have been landed. Closing bug. 192453 2013-03-11 05:54:26 -0700 2013-03-11 11:28:57 -0700 Sets ENABLE_GTK_DOC if GTK_DOC_CHECK is not found 0001-Build-fix-to-support-configure-on-systems-with-no-gt.patch text/plain 1177 tobiasmue RnJvbSBlZjg2NTUwNGQ4Y2Y5NTQ3ZmRhYThlNTJkNjZlZWI3YjlhYTZmMDU3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUb2JpYXMgTXVlbGxlciA8dG9iaWFzbXVlQGdub21lLm9yZz4K RGF0ZTogTW9uLCAxMSBNYXIgMjAxMyAxMzo0NzoxMiArMDEwMApTdWJqZWN0OiBbUEFUQ0hdIEJ1 aWxkIGZpeCB0byBzdXBwb3J0IGNvbmZpZ3VyZSBvbiBzeXN0ZW1zIHdpdGggbm8gZ3RrLWRvYy1h bQogaW5zdGFsbGVkIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTE5 ODAKCkl0IHdvdWxkbid0IGJ1aWxkIGR1ZSB0bwoiVG9vbHMvR05VbWFrZWZpbGUuYW06NDE5OiBF TkFCTEVfR1RLX0RPQyBkb2VzIG5vdCBhcHBlYXIgaW4gQU1fQ09ORElUSU9OQUwiCgpUaGlzIGlz IHByb2JhYmx5IGNhdXNlZCBpZiB0aGUgYXV0b21ha2UgbWFjcm9zIGZvciBndGstZG9jIGFyZSBu b3QgaW5zdGFsbGVkLgpMb29raW5nIGF0Cmh0dHBzOi8vZGV2ZWxvcGVyLmdub21lLm9yZy9ndGst ZG9jLW1hbnVhbC91bnN0YWJsZS9zZXR0aW5ndXBfYXV0b2NvbmYuaHRtbC5lbgp0aGUgY29ycmVj dCBmaXggc2VlbXMgdG8gYmUgdG8gY2hlY2sgd2hldGhlciB0aGUgR1RLX0RPQ19DSEVDSyBtYWNy byBleGlzdHMgYW5kCmlmIG5vdCwgc2V0IEVOQUJMRV9HVEtfRE9DIHRvIGZhbHNlLgotLS0KIFNv dXJjZS9hdXRvdG9vbHMvRmluZERlcGVuZGVuY2llcy5tNCB8IDQgKysrKwogMSBmaWxlIGNoYW5n ZWQsIDQgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9hdXRvdG9vbHMvRmluZERl cGVuZGVuY2llcy5tNCBiL1NvdXJjZS9hdXRvdG9vbHMvRmluZERlcGVuZGVuY2llcy5tNAppbmRl eCBmODcwYjA3Li41MTdlZWYyIDEwMDY0NAotLS0gYS9Tb3VyY2UvYXV0b3Rvb2xzL0ZpbmREZXBl bmRlbmNpZXMubTQKKysrIGIvU291cmNlL2F1dG90b29scy9GaW5kRGVwZW5kZW5jaWVzLm00CkBA IC01MDksNCArNTA5LDggQEAgaWYgdGVzdCAiJGVuYWJsZV93ZWJraXQyIiA9ICJ5ZXMiOyB0aGVu CiAgICBBQ19TVUJTVChbQVRTUEkyX0xJQlNdKQogZmkKIAorbTRfaWZkZWYoW0dUS19ET0NfQ0hF Q0tdLCBbCiBHVEtfRE9DX0NIRUNLKFsxLjEwXSkKK10sWworQU1fQ09ORElUSU9OQUwoW0VOQUJM RV9HVEtfRE9DXSwgZmFsc2UpCitdKQotLSAKMS43LjExLjcKCg== 192517 2013-03-11 11:28:57 -0700 2013-03-11 16:41:18 -0700 Same path with a changelog entry 0001-Build-fix-to-support-configure-on-systems-with-no-gt.patch text/plain 1933 tobiasmue RnJvbSBkMTA1NTUxZGI4M2RjYjVhZTM2MzQ5NmFmYWNiYTUzYjBiMTAxMjNmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUb2JpYXMgTXVlbGxlciA8dG9iaWFzbXVlQGdub21lLm9yZz4K RGF0ZTogTW9uLCAxMSBNYXIgMjAxMyAxMzo0NzoxMiArMDEwMApTdWJqZWN0OiBbUEFUQ0hdIEJ1 aWxkIGZpeCB0byBzdXBwb3J0IGNvbmZpZ3VyZSBvbiBzeXN0ZW1zIHdpdGggbm8gZ3RrLWRvYy1h bQogaW5zdGFsbGVkIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTE5 ODAKCkl0IHdvdWxkbid0IGJ1aWxkIGR1ZSB0bwoiVG9vbHMvR05VbWFrZWZpbGUuYW06NDE5OiBF TkFCTEVfR1RLX0RPQyBkb2VzIG5vdCBhcHBlYXIgaW4gQU1fQ09ORElUSU9OQUwiCgpUaGlzIGlz IHByb2JhYmx5IGNhdXNlZCBpZiB0aGUgYXV0b21ha2UgbWFjcm9zIGZvciBndGstZG9jIGFyZSBu b3QgaW5zdGFsbGVkLgpMb29raW5nIGF0Cmh0dHBzOi8vZGV2ZWxvcGVyLmdub21lLm9yZy9ndGst ZG9jLW1hbnVhbC91bnN0YWJsZS9zZXR0aW5ndXBfYXV0b2NvbmYuaHRtbC5lbgp0aGUgY29ycmVj dCBmaXggc2VlbXMgdG8gYmUgdG8gY2hlY2sgd2hldGhlciB0aGUgR1RLX0RPQ19DSEVDSyBtYWNy byBleGlzdHMgYW5kCmlmIG5vdCwgc2V0IEVOQUJMRV9HVEtfRE9DIHRvIGZhbHNlLgotLS0KIENo YW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgICB8IDEyICsrKysrKysrKysrKwogU291 cmNlL2F1dG90b29scy9GaW5kRGVwZW5kZW5jaWVzLm00IHwgIDQgKysrKwogMiBmaWxlcyBjaGFu Z2VkLCAxNiBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9n CmluZGV4IDMzOWU3OGYuLmRlMDJlNmIgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMy0wMy0xMSAgVG9iaWFzIE11ZWxsZXIgIDx0b2Jp YXNtdWVAZ25vbWUub3JnPgorCisgICAgICAgIFtBdXRvdG9vbHNdIFNldCBFTkFCTEVfR1RLX0RP QyB0byBmYWxzZSBpZiBndGstZG9jIGlzIG5vdCBpbnN0YWxsZWQKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMTk4MAorICAgICAgICAKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViS2l0IGRpZCBub3QgY29u ZmlndXJlIGlmIGd0ay1kb2MtYW0gd2FzIG5vdCBpbnN0YWxsZWQgd2l0aCB0aGUgZXJyb3I6Cisg ICAgICAgIFRvb2xzL0dOVW1ha2VmaWxlLmFtOjQxOTogRU5BQkxFX0dUS19ET0MgZG9lcyBub3Qg YXBwZWFyIGluIEFNX0NPTkRJVElPTkFMCisKKyAgICAgICAgKiBTb3VyY2UvYXV0b3Rvb2xzL0Zp bmREZXBlbmRlbmNpZXMubTQ6CisKIDIwMTMtMDMtMDggIFphbiBEb2JlcnNlayAgPHpkb2JlcnNl a0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFtBdXRvdG9vbHNdIFJlbW92ZSBkZWZpbml0aW9ucyBv ZiB1bm5lY2Vzc2FyeSBBdXRvbWFrZSBjb25kaXRpb25hbHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9h dXRvdG9vbHMvRmluZERlcGVuZGVuY2llcy5tNCBiL1NvdXJjZS9hdXRvdG9vbHMvRmluZERlcGVu ZGVuY2llcy5tNAppbmRleCBmODcwYjA3Li41MTdlZWYyIDEwMDY0NAotLS0gYS9Tb3VyY2UvYXV0 b3Rvb2xzL0ZpbmREZXBlbmRlbmNpZXMubTQKKysrIGIvU291cmNlL2F1dG90b29scy9GaW5kRGVw ZW5kZW5jaWVzLm00CkBAIC01MDksNCArNTA5LDggQEAgaWYgdGVzdCAiJGVuYWJsZV93ZWJraXQy IiA9ICJ5ZXMiOyB0aGVuCiAgICBBQ19TVUJTVChbQVRTUEkyX0xJQlNdKQogZmkKIAorbTRfaWZk ZWYoW0dUS19ET0NfQ0hFQ0tdLCBbCiBHVEtfRE9DX0NIRUNLKFsxLjEwXSkKK10sWworQU1fQ09O RElUSU9OQUwoW0VOQUJMRV9HVEtfRE9DXSwgZmFsc2UpCitdKQotLSAKMS43LjExLjcKCg==