111973 2013-03-11 04:40:56 -0700 [GTK][WK2] REGRESSION(r145081): Unit tests not working if locale is not English 2013-03-12 03:09:50 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 rego webkit-unassigned cgarcia gustavo mrobinson webkit.review.bot oldest_to_newest 852185 0 rego 2013-03-11 04:40:56 -0700 Since we added support for localization in WebKit2GTK+ the unit tests didn't work if you are not using English locale. 852187 1 192439 rego 2013-03-11 04:44:20 -0700 Created attachment 192439 Patch 852191 2 webkit.review.bot 2013-03-11 04:46:54 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 852211 3 192439 cgarcia 2013-03-11 05:19:30 -0700 Comment on attachment 192439 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=192439&action=review LGTM, thanks! > Source/WebKit2/ChangeLog:8 > + Fix unit tests setting the environment variable LC_ALL to C. Please explain here that the problem is that the web process doesn't inherit the locale set in the UI process and uses the system one. In the UI process gtk_test_init call setlocale to reset the locale, but that's not inherited by the web process and we end up with a different locale used by UI and web processes. This is only a problem in some of the tests like the context menu and printing one where we compare strings from both processes. 852443 4 192499 rego 2013-03-11 10:28:05 -0700 Created attachment 192499 Patch Upload new version with a better ChangeLog explaining the problem and the solution. 853260 5 192499 cgarcia 2013-03-12 03:00:01 -0700 Comment on attachment 192499 Patch Thanks! 853265 6 192499 webkit.review.bot 2013-03-12 03:09:46 -0700 Comment on attachment 192499 Patch Clearing flags on attachment: 192499 Committed r145508: <http://trac.webkit.org/changeset/145508> 853266 7 webkit.review.bot 2013-03-12 03:09:50 -0700 All reviewed patches have been landed. Closing bug. 192439 2013-03-11 04:44:20 -0700 2013-03-11 10:27:59 -0700 Patch bug-111973-20130311124020.patch text/plain 1461 rego U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1MTgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZDIyNmNjYjg3ODViMTlj MmQ1MTNhNjY1MjNkMjg3YTgwYTEwNzFhZC4uNTk2N2Q3MTc5ZmYyZjM1MzRkMmIxNjE4Yzc3OGNm ZWQ0MzBiMTI5OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTAzLTExICBNYW51 ZWwgUmVnbyBDYXNhc25vdmFzICA8cmVnb0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdW1dL Ml0gVW5pdCB0ZXN0cyBub3Qgd29ya2luZyBpZiBsb2NhbGUgaXMgbm90IEVuZ2xpc2gKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMTk3MworCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCB1bml0IHRlc3Rz IHNldHRpbmcgdGhlIGVudmlyb25tZW50IHZhcmlhYmxlIExDX0FMTCB0byBDLgorCisgICAgICAg ICogVUlQcm9jZXNzL0FQSS9ndGsvdGVzdHMvVGVzdE1haW4uY3BwOgorICAgICAgICAobWFpbik6 IFNldCBlbnZpcm9ubWVudCB2YXJpYWJsZSBMQ19BTEwgdG8gQy4KKwogMjAxMy0wMy0wNyAgQW5k cmVhcyBLbGluZyAgPGFrbGluZ0BhcHBsZS5jb20+CiAKICAgICAgICAgUmVzaXppbmcgQ2FwcHVj Y2lubyBpcyB2ZXJ5IGxhZ2d5IG9uIFdlYktpdCBzaW5jZSBTYWZhcmkgNS4xCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay90ZXN0cy9UZXN0TWFpbi5jcHAgYi9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay90ZXN0cy9UZXN0TWFpbi5jcHAKaW5kZXgg YzFkY2U3M2E3MjBjZTliYzczZjE4ZDRiMWIxMGE4NTk3Y2QxZDZiZi4uOWYzMDk3ZDFiNzhmODQ1 MzQwNmJhNjI0MDVkYjAxNWU1MDZjMWQ5NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9ndGsvdGVzdHMvVGVzdE1haW4uY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9BUEkvZ3RrL3Rlc3RzL1Rlc3RNYWluLmNwcApAQCAtNDAsNiArNDAsNyBAQCBpbnQg bWFpbihpbnQgYXJnYywgY2hhcioqIGFyZ3YpCiAgICAgZ3RrX3Rlc3RfaW5pdCgmYXJnYywgJmFy Z3YsIDApOwogICAgIGdfc2V0ZW52KCJXRUJLSVRfRVhFQ19QQVRIIiwgV0VCS0lUX0VYRUNfUEFU SCwgRkFMU0UpOwogICAgIGdfc2V0ZW52KCJXRUJLSVRfSU5KRUNURURfQlVORExFX1BBVEgiLCBX RUJLSVRfSU5KRUNURURfQlVORExFX1BBVEgsIEZBTFNFKTsKKyAgICBnX3NldGVudigiTENfQUxM IiwgIkMiLCBUUlVFKTsKICAgICBnX3Rlc3RfYnVnX2Jhc2UoImh0dHBzOi8vYnVncy53ZWJraXQu b3JnLyIpOwogCiAgICAgcmVnaXN0ZXJHUmVzb3VyY2UoKTsK 192499 2013-03-11 10:28:05 -0700 2013-03-12 03:09:46 -0700 Patch bug-111973-20130311182404.patch text/plain 1965 rego U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1MTgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZDIyNmNjYjg3ODViMTlj MmQ1MTNhNjY1MjNkMjg3YTgwYTEwNzFhZC4uOWI2M2VjYzU4ZWEwMjRmNmUyNTlkNzNiMGJjM2Ix ZTg5NjIyZDhmMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEzLTAzLTExICBNYW51 ZWwgUmVnbyBDYXNhc25vdmFzICA8cmVnb0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdW1dL Ml0gUkVHUkVTU0lPTihyMTQ1MDgxKTogVW5pdCB0ZXN0cyBub3Qgd29ya2luZyBpZiBsb2NhbGUg aXMgbm90IEVuZ2xpc2gKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTExMTk3MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFRoZSBwcm9ibGVtIGlzIHRoYXQgdGhlIFVJUHJvY2VzcyBsb2NhbGUgaXMgcmVzZXRl ZCB0byBDIGluCisgICAgICAgIGd0a190ZXN0X2luaXQsIGhvd2V2ZXIgdGhlIFdlYlByb2Nlc3Mg ZG9lcyBub3QgaW5oZXJpdCB0aGUgbG9jYWxlIHNldCBpbgorICAgICAgICB0aGUgVUlQcm9jZXNz IGFuZCBpdCB1c2VzIHRoZSBzeXN0ZW0gb25lICh0aGF0IGNvdWxkIGJlIGRpZmZlcmVudCB0bwor ICAgICAgICBFbmdsaXNoKS4gU28sIHRoZXJlIHdlcmUgcHJvYmxlbXMgaW4gc29tZSB0ZXN0cyB0 aGF0IGFyZSBjb21wYXJpbmcKKyAgICAgICAgc3RyaW5ncyBmcm9tIGJvdGggcHJvY2Vzc2VzIGxp a2UgV2ViS2l0MkFQSVRlc3RzL1Rlc3RQcmludGluZyBhbmQKKyAgICAgICAgV2ViS2l0MkFQSVRl c3RzL1Rlc3RXZWJLaXRXZWJDb250ZXh0LiBUaGUgc29sdXRpb24gaXMgdG8gc2V0IHRoZSBsb2Nh bGUKKyAgICAgICAgZW52aXJvbm1lbnQgdmFyaWFibGUgTENfQUxMIHRvIEMgaW4gb3JkZXIgdG8g cmVzZXQgV2ViUHJvY2VzcyBsb2NhbGUKKyAgICAgICAgdG9vLgorCisgICAgICAgICogVUlQcm9j ZXNzL0FQSS9ndGsvdGVzdHMvVGVzdE1haW4uY3BwOgorICAgICAgICAobWFpbik6IFNldCBlbnZp cm9ubWVudCB2YXJpYWJsZSBMQ19BTEwgdG8gQy4KKwogMjAxMy0wMy0wNyAgQW5kcmVhcyBLbGlu ZyAgPGFrbGluZ0BhcHBsZS5jb20+CiAKICAgICAgICAgUmVzaXppbmcgQ2FwcHVjY2lubyBpcyB2 ZXJ5IGxhZ2d5IG9uIFdlYktpdCBzaW5jZSBTYWZhcmkgNS4xCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay90ZXN0cy9UZXN0TWFpbi5jcHAgYi9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay90ZXN0cy9UZXN0TWFpbi5jcHAKaW5kZXggYzFkY2U3M2E3 MjBjZTliYzczZjE4ZDRiMWIxMGE4NTk3Y2QxZDZiZi4uOWYzMDk3ZDFiNzhmODQ1MzQwNmJhNjI0 MDVkYjAxNWU1MDZjMWQ5NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9ndGsvdGVzdHMvVGVzdE1haW4uY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvZ3RrL3Rlc3RzL1Rlc3RNYWluLmNwcApAQCAtNDAsNiArNDAsNyBAQCBpbnQgbWFpbihpbnQg YXJnYywgY2hhcioqIGFyZ3YpCiAgICAgZ3RrX3Rlc3RfaW5pdCgmYXJnYywgJmFyZ3YsIDApOwog ICAgIGdfc2V0ZW52KCJXRUJLSVRfRVhFQ19QQVRIIiwgV0VCS0lUX0VYRUNfUEFUSCwgRkFMU0Up OwogICAgIGdfc2V0ZW52KCJXRUJLSVRfSU5KRUNURURfQlVORExFX1BBVEgiLCBXRUJLSVRfSU5K RUNURURfQlVORExFX1BBVEgsIEZBTFNFKTsKKyAgICBnX3NldGVudigiTENfQUxMIiwgIkMiLCBU UlVFKTsKICAgICBnX3Rlc3RfYnVnX2Jhc2UoImh0dHBzOi8vYnVncy53ZWJraXQub3JnLyIpOwog CiAgICAgcmVnaXN0ZXJHUmVzb3VyY2UoKTsK