111962 2013-03-11 01:30:36 -0700 RenderSnapshottedPlugIn paints in PaintPhaseBlockBackground instead of PaintPhaseForeground 2013-03-11 01:45:53 -0700 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton dino simon.fraser oldest_to_newest 852114 0 thorton 2013-03-11 01:30:36 -0700 This doesn't make sense to me, and breaks with plugins that are display: block'd (http://www.earslap.com/projectslab/otomata). Plugins normally (see RenderWidget::paint) paint in the foreground phase. There might be a good reason things are as they are now, so I'd like Dino to review this. <rdar://problem/13289335> 852115 1 192424 thorton 2013-03-11 01:32:03 -0700 Created attachment 192424 patch 852119 2 192424 dino 2013-03-11 01:43:27 -0700 Comment on attachment 192424 patch Nope - you're right! This explains the disappearing snapshots :) 852120 3 thorton 2013-03-11 01:45:53 -0700 Excellent. http://trac.webkit.org/changeset/145346 192424 2013-03-11 01:32:03 -0700 2013-03-11 01:43:27 -0700 patch ps-foreground.diff text/plain 1643 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBkMmM3ZWY1Li5jNjhlMWQ1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTMtMDMtMTEgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgUmVuZGVyU25hcHNob3R0ZWRQbHVnSW4gcGFpbnRzIGluIFBhaW50UGhhc2VCbG9j a0JhY2tncm91bmQgaW5zdGVhZCBvZiBQYWludFBoYXNlRm9yZWdyb3VuZAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTExOTYyCisgICAgICAgIDxyZGFy Oi8vcHJvYmxlbS8xMzI4OTMzNT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBSZW5kZXJTbmFwc2hvdHRlZFBsdWdJbiBzaG91bGQgcGFpbnQgaXRzIHNu YXBzaG90IGR1cmluZyB0aGUgZm9yZWdyb3VuZAorICAgICAgICBwYWludGluZyBwaGFzZSwgaW5z dGVhZCBvZiBCbG9ja0JhY2tncm91bmQsIHRvIG1hdGNoIG5vcm1hbCBwbHVnaW4gcGFpbnRpbmcu CisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyU25hcHNob3R0ZWRQbHVnSW4uY3BwOgorICAg ICAgICAoV2ViQ29yZTo6UmVuZGVyU25hcHNob3R0ZWRQbHVnSW46OnBhaW50KToKKwogMjAxMy0w My0xMCAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CiAKICAgICAgICAgTmV0d29ya1N0 b3JhZ2VTZXNzaW9uIGxlYWtzIGl0cyBDRlVSTFN0b3JhZ2VTZXNzaW9uUmVmCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyU25hcHNob3R0ZWRQbHVnSW4uY3BwIGIv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclNuYXBzaG90dGVkUGx1Z0luLmNwcAppbmRl eCA0ODVmMjU4Li5mNDFlMTk5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyU25hcHNob3R0ZWRQbHVnSW4uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJTbmFwc2hvdHRlZFBsdWdJbi5jcHAKQEAgLTg4LDcgKzg4LDcgQEAgdm9pZCBSZW5k ZXJTbmFwc2hvdHRlZFBsdWdJbjo6dXBkYXRlU25hcHNob3QoUGFzc1JlZlB0cjxJbWFnZT4gaW1h Z2UpCiAKIHZvaWQgUmVuZGVyU25hcHNob3R0ZWRQbHVnSW46OnBhaW50KFBhaW50SW5mbyYgcGFp bnRJbmZvLCBjb25zdCBMYXlvdXRQb2ludCYgcGFpbnRPZmZzZXQpCiB7Ci0gICAgaWYgKHBhaW50 SW5mby5waGFzZSA9PSBQYWludFBoYXNlQmxvY2tCYWNrZ3JvdW5kICYmIHBsdWdJbkltYWdlRWxl bWVudCgpLT5kaXNwbGF5U3RhdGUoKSA8IEhUTUxQbHVnSW5FbGVtZW50OjpQbGF5aW5nV2l0aFBl bmRpbmdNb3VzZUNsaWNrKSB7CisgICAgaWYgKHBhaW50SW5mby5waGFzZSA9PSBQYWludFBoYXNl Rm9yZWdyb3VuZCAmJiBwbHVnSW5JbWFnZUVsZW1lbnQoKS0+ZGlzcGxheVN0YXRlKCkgPCBIVE1M UGx1Z0luRWxlbWVudDo6UGxheWluZ1dpdGhQZW5kaW5nTW91c2VDbGljaykgewogICAgICAgICBw YWludFNuYXBzaG90KHBhaW50SW5mbywgcGFpbnRPZmZzZXQpOwogICAgIH0KIAo=