111957 2013-03-10 23:49:05 -0700 Make sure that CSSSelector::setValue() is never called after parsing its pseudoType(). 2013-03-11 03:38:38 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 hayato hayato allan.jensen esprehn+autocc macpherson menard ojan.autocc webcomponents-bugzilla webkit.review.bot oldest_to_newest 852067 0 hayato 2013-03-10 23:49:05 -0700 It'd be nice to have an assertion here since CSSParserSelector::pseudoType() has an side effect. 852069 1 192408 hayato 2013-03-10 23:52:56 -0700 Created attachment 192408 Add an assertion. 852070 2 192409 hayato 2013-03-10 23:56:15 -0700 Created attachment 192409 Add an assertion. 852093 3 192409 morrita 2013-03-11 00:55:48 -0700 Comment on attachment 192409 Add an assertion. View in context: https://bugs.webkit.org/attachment.cgi?id=192409&action=review > Source/WebCore/ChangeLog:9 > + CSSSelector::pseudoType() has an side effect. Could you elaborate? Tightening ASSERT()ion up is fine in general. But it's hard to see the connectio between pseudoType() and setValue(), and ASSERT() and the side effect. 852095 4 hayato 2013-03-11 00:59:17 -0700 Thank you for the review. Let me land this after adding more description. (In reply to comment #3) > (From update of attachment 192409 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=192409&action=review > > > Source/WebCore/ChangeLog:9 > > + CSSSelector::pseudoType() has an side effect. > > Could you elaborate? > Tightening ASSERT()ion up is fine in general. > But it's hard to see the connectio between pseudoType() and setValue(), and ASSERT() and the side effect. 852097 5 192418 hayato 2013-03-11 01:06:42 -0700 Created attachment 192418 Patch for landing 852103 6 192420 hayato 2013-03-11 01:15:35 -0700 Created attachment 192420 Patch for landing 852165 7 192420 webkit.review.bot 2013-03-11 03:38:34 -0700 Comment on attachment 192420 Patch for landing Clearing flags on attachment: 192420 Committed r145352: <http://trac.webkit.org/changeset/145352> 852166 8 webkit.review.bot 2013-03-11 03:38:38 -0700 All reviewed patches have been landed. Closing bug. 192408 2013-03-10 23:52:56 -0700 2013-03-10 23:56:08 -0700 Add an assertion. bug-111957-20130311154856.patch text/plain 1473 hayato U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1MzMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWYzODIxMDBmZmZmYzVl NjVkNmViNDMwNjViYzQ2MmYxYjY2YzZkMi4uYmUwMDliNjc4MWUyNzJiZGU2MTIxM2ZlZGZiMzc4 ZmRlN2QyNjNiZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTAzLTEwICBIYXlh dG8gSXRvICA8aGF5YXRvQGNocm9taXVtLm9yZz4KKworICAgICAgICBNYWtlIHN1cmUgdGhhdCBD U1NQYXJzZXJTZWxlY3Rvcjo6c2V0VmFsdWUoKSBpcyBuZXZlciBjYWxsZWQgYWZ0ZXIgcGFyaW5n IGl0cyBwc2V1ZG9UeXBlKCkuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMTE5NTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBJdCdkIGJlIG5pY2UgdG8gaGF2ZSBhbiBhc3NlcnRpb24gaGVyZSBzaW5jZQor ICAgICAgICBDU1NQYXJzZXJTZWxlY3Rvcjo6cHNldWRvVHlwZSgpIGhhcyBhbiBzaWRlIGVmZmVj dC4KKworICAgICAgICBObyBuZXcgdGVzdHMgKG5vIGNoYW5nZSBpbiBiZWhhdmlvdXIpLgorCisg ICAgICAgICogY3NzL0NTU1NlbGVjdG9yLmg6CisgICAgICAgIChXZWJDb3JlOjpDU1NTZWxlY3Rv cjo6c2V0VmFsdWUpOgorCiAyMDEzLTAzLTEwICBBbmRyZWFzIEtsaW5nICA8YWtsaW5nQGFwcGxl LmNvbT4KIAogICAgICAgICBTVkdEb2N1bWVudEV4dGVuc2lvbnMgc2hvdWxkIHVzZSBPd25QdHIg Zm9yIHBlbmRpbmcgcmVzb3VyY2UgbWFwcy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nz cy9DU1NTZWxlY3Rvci5oIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1NlbGVjdG9yLmgKaW5kZXgg NzUwNzhjMTY3MDRhNGYzOWEwZDhjZDhlYWQ1NTM5NTk4MGNiZThkMi4uZDYxYjk2NjMzODMzNjJm ODZhNDg0YWY4NGRiZmZkODEzYmYzOWQzYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3Nz L0NTU1NlbGVjdG9yLmgKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1NlbGVjdG9yLmgKQEAg LTM1Nyw2ICszNTcsNyBAQCBpbmxpbmUgYm9vbCBDU1NTZWxlY3Rvcjo6aXNTaGFkb3dEaXN0cmli dXRlZCgpIGNvbnN0CiBpbmxpbmUgdm9pZCBDU1NTZWxlY3Rvcjo6c2V0VmFsdWUoY29uc3QgQXRv bWljU3RyaW5nJiB2YWx1ZSkKIHsKICAgICBBU1NFUlQobV9tYXRjaCAhPSBUYWcpOworICAgIEFT U0VSVChtX3BzZXVkb1R5cGUgPT0gUHNldWRvTm90UGFyc2VkKTsKICAgICAvLyBOZWVkIHRvIGRv IHJlZiBjb3VudGluZyBtYW51YWxseSBmb3IgdGhlIHVuaW9uLgogICAgIGlmIChtX2hhc1JhcmVE YXRhKSB7CiAgICAgICAgIGlmIChtX2RhdGEubV9yYXJlRGF0YS0+bV92YWx1ZSkK 192409 2013-03-10 23:56:15 -0700 2013-03-11 01:06:37 -0700 Add an assertion. bug-111957-20130311155214.patch text/plain 1461 hayato U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1MzMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWYzODIxMDBmZmZmYzVl NjVkNmViNDMwNjViYzQ2MmYxYjY2YzZkMi4uY2U2ZWVjOGFiNzU0MDBkMzRmZGNjMzM1MDUxMGNm Yjg4MmJmYmFjNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTAzLTEwICBIYXlh dG8gSXRvICA8aGF5YXRvQGNocm9taXVtLm9yZz4KKworICAgICAgICBNYWtlIHN1cmUgdGhhdCBD U1NTZWxlY3Rvcjo6c2V0VmFsdWUoKSBpcyBuZXZlciBjYWxsZWQgYWZ0ZXIgcGFyaW5nIGl0cyBw c2V1ZG9UeXBlKCkuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMTE5NTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBJdCdkIGJlIG5pY2UgdG8gaGF2ZSBhbiBhc3NlcnRpb24gaGVyZSBzaW5jZQorICAgICAg ICBDU1NTZWxlY3Rvcjo6cHNldWRvVHlwZSgpIGhhcyBhbiBzaWRlIGVmZmVjdC4KKworICAgICAg ICBObyBuZXcgdGVzdHMgKG5vIGNoYW5nZSBpbiBiZWhhdmlvdXIpLgorCisgICAgICAgICogY3Nz L0NTU1NlbGVjdG9yLmg6CisgICAgICAgIChXZWJDb3JlOjpDU1NTZWxlY3Rvcjo6c2V0VmFsdWUp OgorCiAyMDEzLTAzLTEwICBBbmRyZWFzIEtsaW5nICA8YWtsaW5nQGFwcGxlLmNvbT4KIAogICAg ICAgICBTVkdEb2N1bWVudEV4dGVuc2lvbnMgc2hvdWxkIHVzZSBPd25QdHIgZm9yIHBlbmRpbmcg cmVzb3VyY2UgbWFwcy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NTZWxlY3Rv ci5oIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1NlbGVjdG9yLmgKaW5kZXggNzUwNzhjMTY3MDRh NGYzOWEwZDhjZDhlYWQ1NTM5NTk4MGNiZThkMi4uZDYxYjk2NjMzODMzNjJmODZhNDg0YWY4NGRi ZmZkODEzYmYzOWQzYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1NlbGVjdG9y LmgKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1NlbGVjdG9yLmgKQEAgLTM1Nyw2ICszNTcs NyBAQCBpbmxpbmUgYm9vbCBDU1NTZWxlY3Rvcjo6aXNTaGFkb3dEaXN0cmlidXRlZCgpIGNvbnN0 CiBpbmxpbmUgdm9pZCBDU1NTZWxlY3Rvcjo6c2V0VmFsdWUoY29uc3QgQXRvbWljU3RyaW5nJiB2 YWx1ZSkKIHsKICAgICBBU1NFUlQobV9tYXRjaCAhPSBUYWcpOworICAgIEFTU0VSVChtX3BzZXVk b1R5cGUgPT0gUHNldWRvTm90UGFyc2VkKTsKICAgICAvLyBOZWVkIHRvIGRvIHJlZiBjb3VudGlu ZyBtYW51YWxseSBmb3IgdGhlIHVuaW9uLgogICAgIGlmIChtX2hhc1JhcmVEYXRhKSB7CiAgICAg ICAgIGlmIChtX2RhdGEubV9yYXJlRGF0YS0+bV92YWx1ZSkK 192418 2013-03-11 01:06:42 -0700 2013-03-11 01:15:31 -0700 Patch for landing bug-111957-20130311170241.patch text/plain 1551 hayato U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1MzMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWYzODIxMDBmZmZmYzVl NjVkNmViNDMwNjViYzQ2MmYxYjY2YzZkMi4uNWU2MTFhMTlhMmFmZWExYjVmYjVmMzNhZTcyZDYz NDlkOWExZDdjNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTAzLTEwICBIYXlh dG8gSXRvICA8aGF5YXRvQGNocm9taXVtLm9yZz4KKworICAgICAgICBNYWtlIHN1cmUgdGhhdCBD U1NTZWxlY3Rvcjo6c2V0VmFsdWUoKSBpcyBuZXZlciBjYWxsZWQgYWZ0ZXIgcGFyaW5nIGl0cyBw c2V1ZG9UeXBlKCkuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMTE5NTcKKworICAgICAgICBSZXZpZXdlZCBieSBIYWppbWUgTW9ycml0YS4KKworICAg ICAgICBJdCdkIGJlIG5pY2UgdG8gaGF2ZSBhbiBhc3NlcnRpb24gaGVyZSBzaW5jZQorICAgICAg ICBDU1NTZWxlY3Rvcjo6cHNldWRvVHlwZSgpIHdpbGwgbmV2ZXIgcGFyc2UgYSBuZXcgdmFsdWUg YWZ0ZXIgaXQKKyAgICAgICAgcGFyc2VzIGEgdmFsdWUgYW5kIG1fcHNldWRvVHlwZSBpcyBzZXQg dG8gbm9uLVBzZXVkb05vdFBhcnNlZC4KKworICAgICAgICBObyBuZXcgdGVzdHMgKG5vIGNoYW5n ZSBpbiBiZWhhdmlvdXIpLgorCisgICAgICAgICogY3NzL0NTU1NlbGVjdG9yLmg6CisgICAgICAg IChXZWJDb3JlOjpDU1NTZWxlY3Rvcjo6c2V0VmFsdWUpOgorCiAyMDEzLTAzLTEwICBBbmRyZWFz IEtsaW5nICA8YWtsaW5nQGFwcGxlLmNvbT4KIAogICAgICAgICBTVkdEb2N1bWVudEV4dGVuc2lv bnMgc2hvdWxkIHVzZSBPd25QdHIgZm9yIHBlbmRpbmcgcmVzb3VyY2UgbWFwcy4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NTZWxlY3Rvci5oIGIvU291cmNlL1dlYkNvcmUvY3Nz L0NTU1NlbGVjdG9yLmgKaW5kZXggNzUwNzhjMTY3MDRhNGYzOWEwZDhjZDhlYWQ1NTM5NTk4MGNi ZThkMi4uZDYxYjk2NjMzODMzNjJmODZhNDg0YWY4NGRiZmZkODEzYmYzOWQzYiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1NlbGVjdG9yLmgKKysrIGIvU291cmNlL1dlYkNvcmUv Y3NzL0NTU1NlbGVjdG9yLmgKQEAgLTM1Nyw2ICszNTcsNyBAQCBpbmxpbmUgYm9vbCBDU1NTZWxl Y3Rvcjo6aXNTaGFkb3dEaXN0cmlidXRlZCgpIGNvbnN0CiBpbmxpbmUgdm9pZCBDU1NTZWxlY3Rv cjo6c2V0VmFsdWUoY29uc3QgQXRvbWljU3RyaW5nJiB2YWx1ZSkKIHsKICAgICBBU1NFUlQobV9t YXRjaCAhPSBUYWcpOworICAgIEFTU0VSVChtX3BzZXVkb1R5cGUgPT0gUHNldWRvTm90UGFyc2Vk KTsKICAgICAvLyBOZWVkIHRvIGRvIHJlZiBjb3VudGluZyBtYW51YWxseSBmb3IgdGhlIHVuaW9u LgogICAgIGlmIChtX2hhc1JhcmVEYXRhKSB7CiAgICAgICAgIGlmIChtX2RhdGEubV9yYXJlRGF0 YS0+bV92YWx1ZSkK 192420 2013-03-11 01:15:35 -0700 2013-03-11 03:38:34 -0700 Patch for landing bug-111957-20130311171135.patch text/plain 1550 hayato U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1MzMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWYzODIxMDBmZmZmYzVl NjVkNmViNDMwNjViYzQ2MmYxYjY2YzZkMi4uOWVlYjM3OTdkYmU4Zjg4NTBkODRjYTQxNTcyNmFj Yjk0YTllZDBiNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTAzLTEwICBIYXlh dG8gSXRvICA8aGF5YXRvQGNocm9taXVtLm9yZz4KKworICAgICAgICBNYWtlIHN1cmUgdGhhdCBD U1NTZWxlY3Rvcjo6c2V0VmFsdWUoKSBpcyBuZXZlciBjYWxsZWQgYWZ0ZXIgcGFyc2luZyBpdHMg cHNldWRvVHlwZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTExMTk1NworCisgICAgICAgIFJldmlld2VkIGJ5IEhhamltZSBNb3JyaXRhLgorCisgICAg ICAgIEl0J2QgYmUgbmljZSB0byBoYXZlIGFuIGFzc2VydGlvbiBoZXJlIHNpbmNlCisgICAgICAg IENTU1NlbGVjdG9yOjpwc2V1ZG9UeXBlKCkgd2lsbCBuZXZlciBwYXJzZSBhIG5ldyB2YWx1ZSBh ZnRlciBpdAorICAgICAgICBwYXJzZXMgYSB2YWx1ZSBhbmQgbV9wc2V1ZG9UeXBlIGlzIHNldCB0 byBub24tUHNldWRvTm90UGFyc2VkLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyAobm8gY2hhbmdl IGluIGJlaGF2aW91cikuCisKKyAgICAgICAgKiBjc3MvQ1NTU2VsZWN0b3IuaDoKKyAgICAgICAg KFdlYkNvcmU6OkNTU1NlbGVjdG9yOjpzZXRWYWx1ZSk6CisKIDIwMTMtMDMtMTAgIEFuZHJlYXMg S2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgogCiAgICAgICAgIFNWR0RvY3VtZW50RXh0ZW5zaW9u cyBzaG91bGQgdXNlIE93blB0ciBmb3IgcGVuZGluZyByZXNvdXJjZSBtYXBzLgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1NlbGVjdG9yLmggYi9Tb3VyY2UvV2ViQ29yZS9jc3Mv Q1NTU2VsZWN0b3IuaAppbmRleCA3NTA3OGMxNjcwNGE0ZjM5YTBkOGNkOGVhZDU1Mzk1OTgwY2Jl OGQyLi5kNjFiOTY2MzM4MzM2MmY4NmE0ODRhZjg0ZGJmZmQ4MTNiZjM5ZDNiIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTU2VsZWN0b3IuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9j c3MvQ1NTU2VsZWN0b3IuaApAQCAtMzU3LDYgKzM1Nyw3IEBAIGlubGluZSBib29sIENTU1NlbGVj dG9yOjppc1NoYWRvd0Rpc3RyaWJ1dGVkKCkgY29uc3QKIGlubGluZSB2b2lkIENTU1NlbGVjdG9y OjpzZXRWYWx1ZShjb25zdCBBdG9taWNTdHJpbmcmIHZhbHVlKQogewogICAgIEFTU0VSVChtX21h dGNoICE9IFRhZyk7CisgICAgQVNTRVJUKG1fcHNldWRvVHlwZSA9PSBQc2V1ZG9Ob3RQYXJzZWQp OwogICAgIC8vIE5lZWQgdG8gZG8gcmVmIGNvdW50aW5nIG1hbnVhbGx5IGZvciB0aGUgdW5pb24u CiAgICAgaWYgKG1faGFzUmFyZURhdGEpIHsKICAgICAgICAgaWYgKG1fZGF0YS5tX3JhcmVEYXRh LT5tX3ZhbHVlKQo=