111938 2013-03-10 08:34:22 -0700 [GTK] Add webkit_web_page_get_id() to WebKit2 GTK+ API 2013-04-17 00:37:32 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned andersca benjamin gustavo gyuyoung.kim mrobinson rakuco webkit.review.bot xan.lopez oldest_to_newest 851900 0 cgarcia 2013-03-10 08:34:22 -0700 Add API to the web extensions API to get the identifier of a web page. 851902 1 192375 cgarcia 2013-03-10 08:36:38 -0700 Created attachment 192375 Patch 851903 2 cgarcia 2013-03-10 08:37:18 -0700 Adding webkit2 owners to CC 851906 3 webkit.review.bot 2013-03-10 08:41:00 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 851974 4 192375 benjamin 2013-03-10 14:08:20 -0700 Comment on attachment 192375 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=192375&action=review > Source/WebKit2/ChangeLog:9 > + Add API to the web extensions API to get the identifier of a web > + page. What for? 852094 5 cgarcia 2013-03-11 00:59:05 -0700 (In reply to comment #4) > (From update of attachment 192375 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=192375&action=review > > > Source/WebKit2/ChangeLog:9 > > + Add API to the web extensions API to get the identifier of a web > > + page. > > What for? To be able to match the page id of a WebKitWebView (UI process), we have webkit_web_view_get_page_id(), but it's not possible to know the id of a given WebKitWebPage (Web process) 875484 6 cgarcia 2013-04-15 00:46:34 -0700 Ping owners, this is trivial patch. 875895 7 192375 andersca 2013-04-15 10:49:03 -0700 Comment on attachment 192375 Patch I don’t think it’s a good idea to expose identifiers in the API like this, and I think the webkit_web_view_get_page_id() function should be removed. Why is it needed at all? 875902 8 cgarcia 2013-04-15 10:55:03 -0700 (In reply to comment #7) > (From update of attachment 192375 [details]) > I don’t think it’s a good idea to expose identifiers in the API like this, and I think the webkit_web_view_get_page_id() function should be removed. Why is it needed at all? Because in our web process extension system we haven't exposed any communication API, we use the injected bundle custom messages for internal communication, but we leave the apps to use whatever they want to communicate their web process extensions with their UI process. So, we need a way to match a page from UI and Web processes. 876600 9 cgarcia 2013-04-16 10:24:56 -0700 (In reply to comment #8) > (In reply to comment #7) > > (From update of attachment 192375 [details] [details]) > > I don’t think it’s a good idea to expose identifiers in the API like this, and I think the webkit_web_view_get_page_id() function should be removed. Why is it needed at all? > > Because in our web process extension system we haven't exposed any communication API, we use the injected bundle custom messages for internal communication, but we leave the apps to use whatever they want to communicate their web process extensions with their UI process. So, we need a way to match a page from UI and Web processes. This is only available in the web extensions API for GTK+. In Epiphany we use D-Bus to communicate the web extension with the app, so that we can expose GObjects and use signals, properties, etc. We need a way to match between WebKitWebView (UI) and WebKitWebPage (Web) and we used the page id just for convenience. 876620 10 192375 andersca 2013-04-16 11:12:42 -0700 Comment on attachment 192375 Patch Fair enough, r=me. 876627 11 cgarcia 2013-04-16 11:20:56 -0700 (In reply to comment #10) > (From update of attachment 192375 [details]) > Fair enough, r=me. Thank you very much :-) 877058 12 cgarcia 2013-04-17 00:37:32 -0700 Committed r148592: <http://trac.webkit.org/changeset/148592> 192375 2013-03-10 08:36:38 -0700 2013-04-16 11:12:41 -0700 Patch wk2-web-page-id.diff text/plain 3640 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA5NzJhYzM2Li4zYTk1NDZiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEg QEAKKzIwMTMtMDMtMTAgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdIEFkZCB3ZWJraXRfd2ViX3BhZ2VfZ2V0X2lkKCkgdG8gV2ViS2l0 MiBHVEsrIEFQSQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTExOTM4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgQWRkIEFQSSB0byB0aGUgd2ViIGV4dGVuc2lvbnMgQVBJIHRvIGdldCB0aGUgaWRlbnRpZmll ciBvZiBhIHdlYgorICAgICAgICBwYWdlLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9ndGsv ZG9jcy93ZWJraXQyZ3RrLXNlY3Rpb25zLnR4dDogQWRkIG5ldyBzeW1ib2wuCisgICAgICAgICog VUlQcm9jZXNzL0FQSS9ndGsvdGVzdHMvV2ViRXh0ZW5zaW9uVGVzdC5jcHA6CisgICAgICAgICht ZXRob2RDYWxsQ2FsbGJhY2spOiBDaGVjayB0aGUgcGFnZSBJRCBtYXRjaGVzIHRoZSBvbmUgcmV0 dXJuZWQKKyAgICAgICAgYnkgd2Via2l0X3dlYl9wYWdlX2dldF9pZCgpLgorICAgICAgICAqIFdl YlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL2d0ay9XZWJLaXRXZWJQYWdlLmNwcDoKKyAgICAg ICAgKHdlYmtpdF93ZWJfcGFnZV9nZXRfaWQpOgorICAgICAgICAqIFdlYlByb2Nlc3MvSW5qZWN0 ZWRCdW5kbGUvQVBJL2d0ay9XZWJLaXRXZWJQYWdlLmg6CisKIDIwMTMtMDMtMDkgIE1hbnVlbCBS ZWdvIENhc2Fzbm92YXMgIDxyZWdvQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS11bV0syXSBG aXggY29tcGlsYXRpb24gd2FybmluZyBtaXNzaW5nLWZpZWxkLWluaXRpYWxpemVycyBpbiB3ZWJr aXQtMi4wIHN0YWJsZSBicmFuY2gKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvZ3RrL2RvY3Mvd2Via2l0Mmd0ay1zZWN0aW9ucy50eHQgYi9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL2d0ay9kb2NzL3dlYmtpdDJndGstc2VjdGlvbnMudHh0CmluZGV4IGY2ZThh ODQuLmNlYWNkYjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3Rr L2RvY3Mvd2Via2l0Mmd0ay1zZWN0aW9ucy50eHQKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9ndGsvZG9jcy93ZWJraXQyZ3RrLXNlY3Rpb25zLnR4dApAQCAtOTU0LDYgKzk1NCw3 IEBAIHdlYmtpdF93ZWJfZXh0ZW5zaW9uX2dldF90eXBlCiA8RklMRT5XZWJLaXRXZWJQYWdlPC9G SUxFPgogV2ViS2l0V2ViUGFnZQogd2Via2l0X3dlYl9wYWdlX2dldF9kb21fZG9jdW1lbnQKK3dl YmtpdF93ZWJfcGFnZV9nZXRfaWQKIAogPFNVQlNFQ1RJT04gU3RhbmRhcmQ+CiBXZWJLaXRXZWJQ YWdlQ2xhc3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL3Rl c3RzL1dlYkV4dGVuc2lvblRlc3QuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9n dGsvdGVzdHMvV2ViRXh0ZW5zaW9uVGVzdC5jcHAKaW5kZXggZWFmNjhjNS4uNDQ2ZTBhZCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvdGVzdHMvV2ViRXh0ZW5z aW9uVGVzdC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvdGVzdHMv V2ViRXh0ZW5zaW9uVGVzdC5jcHAKQEAgLTUwLDYgKzUwLDcgQEAgc3RhdGljIHZvaWQgbWV0aG9k Q2FsbENhbGxiYWNrKEdEQnVzQ29ubmVjdGlvbiosIGNvbnN0IGNoYXIqIHNlbmRlciwgY29uc3Qg Y2hhcioKICAgICAgICAgICAgICAgICAiSW52YWxpZCBwYWdlIElEOiAlIkdfR1VJTlQ2NF9GT1JN QVQsIHBhZ2VJRCk7CiAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgIH0KKyAgICAgICAgZ19h c3NlcnRfY21wdWludCh3ZWJraXRfd2ViX3BhZ2VfZ2V0X2lkKHBhZ2UpLCA9PSwgcGFnZUlEKTsK IAogICAgICAgICBXZWJLaXRET01Eb2N1bWVudCogZG9jdW1lbnQgPSB3ZWJraXRfd2ViX3BhZ2Vf Z2V0X2RvbV9kb2N1bWVudChwYWdlKTsKICAgICAgICAgR093blB0cjxjaGFyPiB0aXRsZSh3ZWJr aXRfZG9tX2RvY3VtZW50X2dldF90aXRsZShkb2N1bWVudCkpOwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvZ3RrL1dlYktpdFdlYlBhZ2Uu Y3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvZ3RrL1dl YktpdFdlYlBhZ2UuY3BwCmluZGV4IDFhY2ExN2QuLjVjZmU0MDAgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL2d0ay9XZWJLaXRXZWJQYWdl LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9n dGsvV2ViS2l0V2ViUGFnZS5jcHAKQEAgLTE0MywzICsxNDMsMTggQEAgV2ViS2l0RE9NRG9jdW1l bnQqIHdlYmtpdF93ZWJfcGFnZV9nZXRfZG9tX2RvY3VtZW50KFdlYktpdFdlYlBhZ2UqIHdlYlBh Z2UpCiAKICAgICByZXR1cm4ga2l0KGNvcmVGcmFtZS0+ZG9jdW1lbnQoKSk7CiB9CisKKy8qKgor ICogd2Via2l0X3dlYl9wYWdlX2dldF9pZDoKKyAqIEB3ZWJfcGFnZTogYSAjV2ViS2l0V2ViUGFn ZQorICoKKyAqIEdldCB0aGUgaWRlbnRpZmllciBvZiB0aGUgI1dlYktpdFdlYlBhZ2UKKyAqCisg KiBSZXR1cm5zOiB0aGUgaWRlbnRpZmllciBvZiBAd2ViX3BhZ2UKKyAqLworZ3VpbnQ2NCB3ZWJr aXRfd2ViX3BhZ2VfZ2V0X2lkKFdlYktpdFdlYlBhZ2UqIHdlYlBhZ2UpCit7CisgICAgZ19yZXR1 cm5fdmFsX2lmX2ZhaWwoV0VCS0lUX0lTX1dFQl9QQUdFKHdlYlBhZ2UpLCAwKTsKKworICAgIHJl dHVybiB3ZWJQYWdlLT5wcml2LT53ZWJQYWdlLT5wYWdlSUQoKTsKK30KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL2d0ay9XZWJLaXRXZWJQ YWdlLmggYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9ndGsv V2ViS2l0V2ViUGFnZS5oCmluZGV4IGQ4ZjYyMzYuLmExNWIxYzkgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL2d0ay9XZWJLaXRXZWJQYWdl LmgKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvZ3Rr L1dlYktpdFdlYlBhZ2UuaApAQCAtNTcsNiArNTcsOSBAQCB3ZWJraXRfd2ViX3BhZ2VfZ2V0X3R5 cGUgICAgICAgICAodm9pZCk7CiBXRUJLSVRfQVBJIFdlYktpdERPTURvY3VtZW50ICoKIHdlYmtp dF93ZWJfcGFnZV9nZXRfZG9tX2RvY3VtZW50IChXZWJLaXRXZWJQYWdlICp3ZWJfcGFnZSk7CiAK K1dFQktJVF9BUEkgZ3VpbnQ2NAord2Via2l0X3dlYl9wYWdlX2dldF9pZCAgICAgICAgICAgKFdl YktpdFdlYlBhZ2UgKndlYl9wYWdlKTsKKwogR19FTkRfREVDTFMKIAogI2VuZGlmCg==