111937 2013-03-10 07:55:45 -0700 GlyphMetricsMap should use OwnPtr. 2013-03-10 09:48:31 -0700 1 1 1 Unclassified WebKit Text 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling webkit.review.bot oldest_to_newest 851897 0 kling 2013-03-10 07:55:45 -0700 GlyphMetricsMap should use OwnPtr. 851898 1 192374 kling 2013-03-10 07:57:46 -0700 Created attachment 192374 Patch 851924 2 192374 webkit.review.bot 2013-03-10 09:48:28 -0700 Comment on attachment 192374 Patch Clearing flags on attachment: 192374 Committed r145327: <http://trac.webkit.org/changeset/145327> 851925 3 webkit.review.bot 2013-03-10 09:48:31 -0700 All reviewed patches have been landed. Closing bug. 192374 2013-03-10 07:57:46 -0700 2013-03-10 09:48:28 -0700 Patch bug-111937.diff text/plain 2223 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAyYmNlNzJiLi4zNDJhNjczIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTMtMDMtMTAgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgorCisgICAg ICAgIEdseXBoTWV0cmljc01hcCBzaG91bGQgdXNlIE93blB0ci4KKyAgICAgICAgPGh0dHA6Ly93 ZWJraXQub3JnL2IvMTExOTM3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFVzZSBPd25QdHIgaW5zdGVhZCBvZiByYXcgcG9pbnRlciArIGRlbGV0ZUFs bFZhbHVlcygpLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvR2x5cGhNZXRyaWNzTWFw Lmg6CisgICAgICAgIChHbHlwaE1ldHJpY3NNYXApOgorICAgICAgICAoV2ViQ29yZTo6Ojpsb2Nh dGVQYWdlU2xvd0Nhc2UpOgorCiAyMDEzLTAzLTA5ICBTZWJhc3RpYW4gRHLDtmdlICA8c2ViYXN0 aWFuLmRyb2VnZUBjb2xsYWJvcmEuY28udWs+CiAKICAgICAgICAgRml4IG9mZnNldCBoYW5kbGlu ZyBpbiBHU3RyZWFtZXIgV2ViS2l0V2ViU291cmNlLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvR2x5cGhNZXRyaWNzTWFwLmggYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9HbHlwaE1ldHJpY3NNYXAuaAppbmRleCBlNWFhOTIyLi5mMjBhZGNl IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HbHlwaE1ldHJp Y3NNYXAuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HbHlwaE1ldHJp Y3NNYXAuaApAQCAtNDMsMTIgKzQzLDYgQEAgdGVtcGxhdGU8Y2xhc3MgVD4gY2xhc3MgR2x5cGhN ZXRyaWNzTWFwIHsKICAgICBXVEZfTUFLRV9OT05DT1BZQUJMRShHbHlwaE1ldHJpY3NNYXApOwog cHVibGljOgogICAgIEdseXBoTWV0cmljc01hcCgpIDogbV9maWxsZWRQcmltYXJ5UGFnZShmYWxz ZSkgeyB9Ci0gICAgfkdseXBoTWV0cmljc01hcCgpCi0gICAgeyAKLSAgICAgICAgaWYgKG1fcGFn ZXMpCi0gICAgICAgICAgICBkZWxldGVBbGxWYWx1ZXMoKm1fcGFnZXMpOwotICAgIH0KLQogICAg IFQgbWV0cmljc0ZvckdseXBoKEdseXBoIGdseXBoKQogICAgIHsKICAgICAgICAgcmV0dXJuIGxv Y2F0ZVBhZ2UoZ2x5cGggLyBHbHlwaE1ldHJpY3NQYWdlOjpzaXplKS0+bWV0cmljc0ZvckdseXBo KGdseXBoKTsKQEAgLTg4LDcgKzgyLDcgQEAgcHJpdmF0ZToKIAogICAgIGJvb2wgbV9maWxsZWRQ cmltYXJ5UGFnZTsKICAgICBHbHlwaE1ldHJpY3NQYWdlIG1fcHJpbWFyeVBhZ2U7IC8vIFdlIG9w dGltaXplIGZvciB0aGUgcGFnZSB0aGF0IGNvbnRhaW5zIGdseXBoIGluZGljZXMgMC0yNTUuCi0g ICAgT3duUHRyPEhhc2hNYXA8aW50LCBHbHlwaE1ldHJpY3NQYWdlKj4gPiBtX3BhZ2VzOworICAg IE93blB0cjxIYXNoTWFwPGludCwgT3duUHRyPEdseXBoTWV0cmljc1BhZ2U+ID4gPiBtX3BhZ2Vz OwogfTsKIAogdGVtcGxhdGU8PiBpbmxpbmUgZmxvYXQgR2x5cGhNZXRyaWNzTWFwPGZsb2F0Pjo6 dW5rbm93bk1ldHJpY3MoKQpAQCAtMTEzLDkgKzEwNyw5IEBAIHRlbXBsYXRlPGNsYXNzIFQ+IHR5 cGVuYW1lIEdseXBoTWV0cmljc01hcDxUPjo6R2x5cGhNZXRyaWNzUGFnZSogR2x5cGhNZXRyaWNz TWFwCiAgICAgICAgICAgICBpZiAoKHBhZ2UgPSBtX3BhZ2VzLT5nZXQocGFnZU51bWJlcikpKQog ICAgICAgICAgICAgICAgIHJldHVybiBwYWdlOwogICAgICAgICB9IGVsc2UKLSAgICAgICAgICAg IG1fcGFnZXMgPSBhZG9wdFB0cihuZXcgSGFzaE1hcDxpbnQsIEdseXBoTWV0cmljc1BhZ2UqPik7 CisgICAgICAgICAgICBtX3BhZ2VzID0gYWRvcHRQdHIobmV3IEhhc2hNYXA8aW50LCBPd25QdHI8 R2x5cGhNZXRyaWNzUGFnZT4gPik7CiAgICAgICAgIHBhZ2UgPSBuZXcgR2x5cGhNZXRyaWNzUGFn ZTsKLSAgICAgICAgbV9wYWdlcy0+c2V0KHBhZ2VOdW1iZXIsIHBhZ2UpOworICAgICAgICBtX3Bh Z2VzLT5zZXQocGFnZU51bWJlciwgYWRvcHRQdHIocGFnZSkpOwogICAgIH0KIAogICAgIC8vIEZp bGwgaW4gdGhlIHdob2xlIHBhZ2Ugd2l0aCB0aGUgdW5rbm93biBnbHlwaCBpbmZvcm1hdGlvbi4K