111927 2013-03-09 12:53:16 -0800 Style updates are not propagated to <use> elements after creation 2025-10-16 17:42:31 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) All All RESOLVED CONFIGURATION CHANGED https://bugs.webkit.org/show_bug.cgi?id=255114 InRadar, LayerBasedSVGEngine P2 Normal --- 1 stuart tasak ahmad.saleem792 ajvincent bfulgham dglazkov d-r esprehn+autocc fmalita koivisto macpherson maggotfish menard ojan.autocc pdr sabouhallawa schenney simon.fraser tanaka.toshiyuki tasak webkit-bug-importer webkit.review.bot zimmermann oldest_to_newest 851814 0 192349 stuart 2013-03-09 12:53:16 -0800 Created attachment 192349 Testcase Changing the style of an element through the DOM does not update the style of any <use> elements referencing that element if the style is updated after creation. Repro: See test case. The change of the <circle>'s fill from green to navy that happens at initialization is copied by the <use> element, but the change on the timeout from navy to blue is not. 851828 1 stuart 2013-03-09 14:34:36 -0800 Expected testcase behavior: Both circles turn blue (#00F). Actual testcase behavior: The original circle on the left turns blue (#00F), while the <use> element referencing it on the right remains navy (#008). <use> elements do currently update when the corresponding attributes are updated, so scripts setting style properties (ie. `element.style.fill = '#foo'`) can be rewritten to set attributes (ie. `element.setAttribute('fill','#foo')`) as a workaround. Original bug: https://code.google.com/p/chromium/issues/detail?id=166438 852110 2 192422 tasak 2013-03-11 01:25:20 -0700 Created attachment 192422 Patch 852132 3 192422 webkit.review.bot 2013-03-11 02:29:33 -0700 Comment on attachment 192422 Patch Attachment 192422 did not pass chromium-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/17024155 New failing tests: html5lib/generated/run-tests16-data.html 852294 4 192422 schenney 2013-03-11 07:33:32 -0700 Comment on attachment 192422 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=192422&action=review Basically good. Just fix the build for SVG disabled. The EWS chromium bot failure is a flake, not of any concern. > Source/WebCore/css/PropertySetCSSStyleDeclaration.cpp:31 > +#include "SVGElementInstance.h" This needs to be protected with #if ENABLE(SVG) > Source/WebCore/css/PropertySetCSSStyleDeclaration.cpp:403 > + SVGElementInstance::invalidateAllInstancesOfElement(toSVGElement(m_parentElement), false); This also needs #if ENABLE(SVG) protection. 852296 5 192422 schenney 2013-03-11 07:35:03 -0700 Comment on attachment 192422 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=192422&action=review Oops, overlooked the test colors. Please fix to make it obvious what is pass and fail. > LayoutTests/svg/custom/use-modify-target-style-property-expected.svg:3 > +<circle cx="50" cy="50" r="50" style="fill:blue;" id="circle" /> The "good" color should be green. > LayoutTests/svg/custom/use-modify-target-style-property.svg:12 > + c.style.fill= "blue"; Change it to green. > LayoutTests/svg/custom/use-modify-target-style-property.svg:17 > +<circle cx="50" cy="50" r="50" style="fill:green;" id="circle" /> Start it red. 853202 6 192671 tasak 2013-03-12 01:55:59 -0700 Created attachment 192671 Patch 853203 7 192422 tasak 2013-03-12 01:57:09 -0700 Comment on attachment 192422 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=192422&action=review Thank you for reviewing. >> Source/WebCore/css/PropertySetCSSStyleDeclaration.cpp:31 >> +#include "SVGElementInstance.h" > > This needs to be protected with #if ENABLE(SVG) Done. >> Source/WebCore/css/PropertySetCSSStyleDeclaration.cpp:403 >> + SVGElementInstance::invalidateAllInstancesOfElement(toSVGElement(m_parentElement), false); > > This also needs #if ENABLE(SVG) protection. Done. >> LayoutTests/svg/custom/use-modify-target-style-property-expected.svg:3 >> +<circle cx="50" cy="50" r="50" style="fill:blue;" id="circle" /> > > The "good" color should be green. Done. >> LayoutTests/svg/custom/use-modify-target-style-property.svg:12 >> + c.style.fill= "blue"; > > Change it to green. Done. >> LayoutTests/svg/custom/use-modify-target-style-property.svg:17 >> +<circle cx="50" cy="50" r="50" style="fill:green;" id="circle" /> > > Start it red. Done. 853357 8 192671 schenney 2013-03-12 05:09:46 -0700 Comment on attachment 192671 Patch Thanks. R=me. 868207 9 pdr 2013-04-02 13:28:41 -0700 It looks like this was a good change but it never ended up landing. Takashi, can you update this patch and land it? 1872618 10 ahmad.saleem792 2022-05-29 08:07:44 -0700 I am still able to reproduce this bug using Safari 15.4 and Safari TP 146 based on attached Test case. Thanks! 1884370 11 webkit-bug-importer 2022-07-15 16:09:40 -0700 <rdar://problem/97099415> 2014224 12 ahmad.saleem792 2024-02-15 16:53:49 -0800 We might have to do changes here: https://searchfox.org/wubkat/rev/c40451f6052e2805fb1c6abfb61fa322c67caf5b/Source/WebCore/css/PropertySetCSSStyleDeclaration.cpp#443 I tried: if (m_parentElement->isSVGElement()) invalidateInstances(); and if (m_parentElement->isSVGElement()) SVGElement::invalidateInstances(); __ But get compiler error - invalidateInstances' is a private member of 'WebCore::SVGElement' Added `SVGElement.h` header as well. 2014253 13 ahmad.saleem792 2024-02-15 17:51:36 -0800 (In reply to Ahmad Saleem from comment #12) > We might have to do changes here: > > https://searchfox.org/wubkat/rev/c40451f6052e2805fb1c6abfb61fa322c67caf5b/ > Source/WebCore/css/PropertySetCSSStyleDeclaration.cpp#443 > > I tried: > > if (m_parentElement->isSVGElement()) > invalidateInstances(); > > and > > if (m_parentElement->isSVGElement()) > SVGElement::invalidateInstances(); > > __ > > But get compiler error - invalidateInstances' is a private member of > 'WebCore::SVGElement' > > Added `SVGElement.h` header as well. Tried this as well: auto invalidateSVGInstance = SVGElement::invalidateInstances(); if (m_parentElement->isSVGElement()) invalidateSVGInstance; ____ but still got error about `private` member. If I move `void invalidateInstances()` to even Public, it still not work. :-( 2151900 14 ahmad.saleem792 2025-10-16 17:42:31 -0700 It seems to work fine now in Safari Technology Preview 230 (Tahoe). 192349 2013-03-09 12:53:16 -0800 2013-03-09 12:53:16 -0800 Testcase testcase.svg image/svg+xml 371 stuart PHN2ZyB2ZXJzaW9uPSIxLjEiIHhtbG5zPSJodHRwOi8vd3d3LnczLm9yZy8yMDAwL3N2ZyIgeG1s bnM6eGxpbms9Imh0dHA6Ly93d3cudzMub3JnLzE5OTkveGxpbmsiPg0KICAgIDxjaXJjbGUgY3g9 IjUwIiBjeT0iNTAiIHI9IjUwIiBzdHlsZT0iZmlsbDpncmVlbjsiIGlkPSJjaXJjbGUiIC8+DQog ICAgPHVzZSB4PSIxMDAiIHhsaW5rOmhyZWY9IiNjaXJjbGUiIC8+DQoJPHNjcmlwdD4NCgl2YXIg YyA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJjaXJjbGUiKQ0KCWMuc3R5bGUuZmlsbD0gIm5h dnkiOw0KCXNldFRpbWVvdXQoZnVuY3Rpb24oKSB7DQoJCWMuc3R5bGUuZmlsbD0gImJsdWUiOw0K CX0sNTApOw0KCTwvc2NyaXB0Pg0KPC9zdmc+DQo= 192422 2013-03-11 01:25:20 -0700 2013-03-12 01:57:09 -0700 Patch bug-111927-20130311172120.patch text/plain 6427 tasak U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1MzQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTBkNjM0MGRhZGJiOTc2 OTZkMDJlMjYxYmZlOWU4ZjVjNzc3YjM3Ni4uNTE5OTRhMjA4YzdhNzc5MDdmZDQ3NDMzZWRhNTVj MjkwYzRjZGQ2ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDEzLTAzLTExICBUYWth c2hpIFNha2Ftb3RvICA8dGFzYWtAZ29vZ2xlLmNvbT4KKworICAgICAgICBTdHlsZSB1cGRhdGVz IGFyZSBub3QgcHJvcGFnYXRlZCB0byA8dXNlPiBlbGVtZW50cyBhZnRlciBjcmVhdGlvbgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTExOTI3CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW5saW5lQ1NTU3R5 bGVEZWNsYXJhdGlvbiBkb2Vzbid0IG5vdGlmeSB1c2UgZWxlbWVudHMgd2hlbgorICAgICAgICBh IGNvcnJlc3BvbmRpbmcgZWxlbWVudCdzIGlubGluZSBzdHlsZSBpcyB1cGRhdGVkLiBOZWVkIHRv IHVwZGF0ZQorICAgICAgICBhbGwgaW5zdGFuY2VzIG9mIGEgZ2l2ZW4gZWxlbWVudCB3aG9zZSBp bmxpbmUgc3R5bGUgaXMgY2hhbmdlZC4KKworICAgICAgICBUZXN0czogc3ZnL2N1c3RvbS91c2Ut bW9kaWZ5LXRhcmdldC1zdHlsZS1wcm9wZXJ0eS1leHBlY3RlZC5zdmcKKyAgICAgICAgICAgICAg IHN2Zy9jdXN0b20vdXNlLW1vZGlmeS10YXJnZXQtc3R5bGUtcHJvcGVydHkuc3ZnCisKKyAgICAg ICAgKiBjc3MvUHJvcGVydHlTZXRDU1NTdHlsZURlY2xhcmF0aW9uLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OklubGluZUNTU1N0eWxlRGVjbGFyYXRpb246OmRpZE11dGF0ZSk6CisgICAgICAgIElm IGEgZ2l2ZW4gZWxlbWVudCBpcyBhIHN2ZyBlbGVtZW50LCBpbnZva2UKKyAgICAgICAgU1ZHRWxl bWVudEluc3RhbmNlOjppbnZhbGlkYXRlQWxsSW5zdGFuY2VzT2ZFbGVtZW50IGZvciB1c2UgZWxl bWVudHMuCisgICAgICAgICogc3ZnL1NWR0VsZW1lbnRJbnN0YW5jZS5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpTVkdFbGVtZW50SW5zdGFuY2U6OmludmFsaWRhdGVBbGxJbnN0YW5jZXNPZkVsZW1l bnQpOgorICAgICAgICBBZGRlZCBhIG5ldyBib29sIHBhcmFtZXRlciB0byBzcGVjaWZ5IHdoZXRo ZXIgdXBkYXRlIHN0eWxlcyBvciBub3QuCisgICAgICAgICogc3ZnL1NWR0VsZW1lbnRJbnN0YW5j ZS5oOgorICAgICAgICAoU1ZHRWxlbWVudEluc3RhbmNlKToKKwogMjAxMy0wMy0xMCAgTWF0dCBG YWxrZW5oYWdlbiAgPGZhbGtlbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgSW1wbGVtZW50IGlu ZXJ0IHN1YnRyZWVzIG5lZWRlZCBmb3IgbW9kYWwgPGRpYWxvZz4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2Nzcy9Qcm9wZXJ0eVNldENTU1N0eWxlRGVjbGFyYXRpb24uY3BwIGIvU291cmNl L1dlYkNvcmUvY3NzL1Byb3BlcnR5U2V0Q1NTU3R5bGVEZWNsYXJhdGlvbi5jcHAKaW5kZXggNTZk OTIxNWE4Njk3ZjkxNTQyNDBkZDgxNmQxNDk3YWYyZmZhYThmZS4uN2QxNDBjY2UwMzkzMzVkMjcw NDY1OGVhOWRjMGQ2NmUyOTFkMjQwMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL1By b3BlcnR5U2V0Q1NTU3R5bGVEZWNsYXJhdGlvbi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3Nz L1Byb3BlcnR5U2V0Q1NTU3R5bGVEZWNsYXJhdGlvbi5jcHAKQEAgLTI4LDYgKzI4LDcgQEAKICNp bmNsdWRlICJJbnNwZWN0b3JJbnN0cnVtZW50YXRpb24uaCIKICNpbmNsdWRlICJNdXRhdGlvbk9i c2VydmVySW50ZXJlc3RHcm91cC5oIgogI2luY2x1ZGUgIk11dGF0aW9uUmVjb3JkLmgiCisjaW5j bHVkZSAiU1ZHRWxlbWVudEluc3RhbmNlLmgiCiAjaW5jbHVkZSAiU3R5bGVQcm9wZXJ0eVNldC5o IgogI2luY2x1ZGUgIlN0eWxlZEVsZW1lbnQuaCIKICNpbmNsdWRlICJXZWJDb3JlTWVtb3J5SW5z dHJ1bWVudGF0aW9uLmgiCkBAIC0zOTgsNiArMzk5LDggQEAgdm9pZCBJbmxpbmVDU1NTdHlsZURl Y2xhcmF0aW9uOjpkaWRNdXRhdGUoTXV0YXRpb25UeXBlIHR5cGUpCiAKICAgICBtX3BhcmVudEVs ZW1lbnQtPnNldE5lZWRzU3R5bGVSZWNhbGMoSW5saW5lU3R5bGVDaGFuZ2UpOwogICAgIG1fcGFy ZW50RWxlbWVudC0+aW52YWxpZGF0ZVN0eWxlQXR0cmlidXRlKCk7CisgICAgaWYgKG1fcGFyZW50 RWxlbWVudC0+aXNTVkdFbGVtZW50KCkpCisgICAgICAgIFNWR0VsZW1lbnRJbnN0YW5jZTo6aW52 YWxpZGF0ZUFsbEluc3RhbmNlc09mRWxlbWVudCh0b1NWR0VsZW1lbnQobV9wYXJlbnRFbGVtZW50 KSwgZmFsc2UpOwogICAgIFN0eWxlQXR0cmlidXRlTXV0YXRpb25TY29wZSh0aGlzKS5kaWRJbnZh bGlkYXRlU3R5bGVBdHRyKCk7CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9T VkdFbGVtZW50SW5zdGFuY2UuY3BwIGIvU291cmNlL1dlYkNvcmUvc3ZnL1NWR0VsZW1lbnRJbnN0 YW5jZS5jcHAKaW5kZXggYTMyMjdhZjBhM2FjNTg1ZjZlZDczNzU0MTc2ZDVlZTQ2Yzk5ZjNiOC4u Yjk2Yzk2ZWU3NDlmNGU2YWVhMWMxM2MyMTQwMGExYjc3MGYwNWZjYSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvc3ZnL1NWR0VsZW1lbnRJbnN0YW5jZS5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvc3ZnL1NWR0VsZW1lbnRJbnN0YW5jZS5jcHAKQEAgLTEyMCw3ICsxMjAsNyBAQCB2b2lkIFNW R0VsZW1lbnRJbnN0YW5jZTo6YXBwZW5kQ2hpbGQoUGFzc1JlZlB0cjxTVkdFbGVtZW50SW5zdGFu Y2U+IGNoaWxkKQogICAgIGFwcGVuZENoaWxkVG9Db250YWluZXI8U1ZHRWxlbWVudEluc3RhbmNl LCBTVkdFbGVtZW50SW5zdGFuY2U+KGNoaWxkLmdldCgpLCB0aGlzKTsKIH0KIAotdm9pZCBTVkdF bGVtZW50SW5zdGFuY2U6OmludmFsaWRhdGVBbGxJbnN0YW5jZXNPZkVsZW1lbnQoU1ZHRWxlbWVu dCogZWxlbWVudCkKK3ZvaWQgU1ZHRWxlbWVudEluc3RhbmNlOjppbnZhbGlkYXRlQWxsSW5zdGFu Y2VzT2ZFbGVtZW50KFNWR0VsZW1lbnQqIGVsZW1lbnQsIGJvb2wgdXBkYXRlU3R5bGUpCiB7CiAg ICAgaWYgKCFlbGVtZW50IHx8ICFlbGVtZW50LT5pbkRvY3VtZW50KCkpCiAgICAgICAgIHJldHVy bjsKQEAgLTE0Nyw3ICsxNDcsOCBAQCB2b2lkIFNWR0VsZW1lbnRJbnN0YW5jZTo6aW52YWxpZGF0 ZUFsbEluc3RhbmNlc09mRWxlbWVudChTVkdFbGVtZW50KiBlbGVtZW50KQogICAgICAgICB9CiAg ICAgfQogCi0gICAgZWxlbWVudC0+ZG9jdW1lbnQoKS0+dXBkYXRlU3R5bGVJZk5lZWRlZCgpOwor ICAgIGlmICh1cGRhdGVTdHlsZSkKKyAgICAgICAgZWxlbWVudC0+ZG9jdW1lbnQoKS0+dXBkYXRl U3R5bGVJZk5lZWRlZCgpOwogfQogCiBjb25zdCBBdG9taWNTdHJpbmcmIFNWR0VsZW1lbnRJbnN0 YW5jZTo6aW50ZXJmYWNlTmFtZSgpIGNvbnN0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9z dmcvU1ZHRWxlbWVudEluc3RhbmNlLmggYi9Tb3VyY2UvV2ViQ29yZS9zdmcvU1ZHRWxlbWVudElu c3RhbmNlLmgKaW5kZXggODkzZjZmMWE2N2I3MGQ5MmU3YTY4YmVkYzc4ZGY5ZTBmOWJjNjNiNy4u YzYyZDZiZDQ1OTc4MjBmMGJhODkxNDlkYjM0MGNhYzhiNzI5MGZhZSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvc3ZnL1NWR0VsZW1lbnRJbnN0YW5jZS5oCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3N2Zy9TVkdFbGVtZW50SW5zdGFuY2UuaApAQCAtOTYsNyArOTYsNyBAQCBwdWJsaWM6CiAgICAg ICAgIFNWR1N0eWxlZEVsZW1lbnQqIG1fdGFyZ2V0RWxlbWVudDsKICAgICB9OwogICAgIAotICAg IHN0YXRpYyB2b2lkIGludmFsaWRhdGVBbGxJbnN0YW5jZXNPZkVsZW1lbnQoU1ZHRWxlbWVudCop OworICAgIHN0YXRpYyB2b2lkIGludmFsaWRhdGVBbGxJbnN0YW5jZXNPZkVsZW1lbnQoU1ZHRWxl bWVudCosIGJvb2wgdXBkYXRlU3R5bGUgPSB0cnVlKTsKIAogICAgIHVzaW5nIFRyZWVTaGFyZWQ8 U1ZHRWxlbWVudEluc3RhbmNlPjo6cmVmOwogICAgIHVzaW5nIFRyZWVTaGFyZWQ8U1ZHRWxlbWVu dEluc3RhbmNlPjo6ZGVyZWY7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9M YXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZWZiYTkyNjJlODc4YmNjNDg4ZDI4ODAxNzgyN2I0 YzIzZjVhNjkwNS4uZTY3NzQyMDg3NjYxYzEyNTI2Y2NlYmYyNjk5ZjE4ZmY5YjQyOTI2NSAxMDA2 NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDEzIEBACisyMDEzLTAzLTExICBUYWthc2hpIFNha2Ftb3RvICA8dGFzYWtA Z29vZ2xlLmNvbT4KKworICAgICAgICBTdHlsZSB1cGRhdGVzIGFyZSBub3QgcHJvcGFnYXRlZCB0 byA8dXNlPiBlbGVtZW50cyBhZnRlciBjcmVhdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTExOTI3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBzdmcvY3VzdG9tL3VzZS1tb2RpZnktdGFyZ2V0LXN0 eWxlLXByb3BlcnR5LWV4cGVjdGVkLnN2ZzogQWRkZWQuCisgICAgICAgICogc3ZnL2N1c3RvbS91 c2UtbW9kaWZ5LXRhcmdldC1zdHlsZS1wcm9wZXJ0eS5zdmc6IEFkZGVkLgorCiAyMDEzLTAzLTEw ICBNYXR0IEZhbGtlbmhhZ2VuICA8ZmFsa2VuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBJbXBs ZW1lbnQgaW5lcnQgc3VidHJlZXMgbmVlZGVkIGZvciBtb2RhbCA8ZGlhbG9nPgpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvc3ZnL2N1c3RvbS91c2UtbW9kaWZ5LXRhcmdldC1zdHlsZS1wcm9wZXJ0 eS1leHBlY3RlZC5zdmcgYi9MYXlvdXRUZXN0cy9zdmcvY3VzdG9tL3VzZS1tb2RpZnktdGFyZ2V0 LXN0eWxlLXByb3BlcnR5LWV4cGVjdGVkLnN2ZwpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5lYjUyMzE5NThkMDc0YmY1 ZTA1NDRhOWQ0M2FjNGYxYmQwNjhmNjc2Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMv c3ZnL2N1c3RvbS91c2UtbW9kaWZ5LXRhcmdldC1zdHlsZS1wcm9wZXJ0eS1leHBlY3RlZC5zdmcK QEAgLTAsMCArMSw3IEBACis8P3htbCB2ZXJzaW9uPSIxLjAiIGVuY29kaW5nPSJ1dGYtOCI/Pgor PHN2ZyB2ZXJzaW9uPSIxLjEiIHhtbG5zPSJodHRwOi8vd3d3LnczLm9yZy8yMDAwL3N2ZyIgeG1s bnM6eGxpbms9Imh0dHA6Ly93d3cudzMub3JnLzE5OTkveGxpbmsiPgorPGNpcmNsZSBjeD0iNTAi IGN5PSI1MCIgcj0iNTAiIHN0eWxlPSJmaWxsOmJsdWU7IiBpZD0iY2lyY2xlIiAvPgorPHVzZSB4 PSIxMDAiIHhsaW5rOmhyZWY9IiNjaXJjbGUiIC8+Cis8c2NyaXB0PgorPC9zY3JpcHQ+Cis8L3N2 Zz4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3N2Zy9jdXN0b20vdXNlLW1vZGlmeS10YXJnZXQt c3R5bGUtcHJvcGVydHkuc3ZnIGIvTGF5b3V0VGVzdHMvc3ZnL2N1c3RvbS91c2UtbW9kaWZ5LXRh cmdldC1zdHlsZS1wcm9wZXJ0eS5zdmcKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uMTg5ZWE3YTBjYzNlNzVkZmE3ZjAy ZGJlYmMzZDI0YWJmZmMxZTEzZgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL3N2Zy9j dXN0b20vdXNlLW1vZGlmeS10YXJnZXQtc3R5bGUtcHJvcGVydHkuc3ZnCkBAIC0wLDAgKzEsMjEg QEAKKzw/eG1sIHZlcnNpb249IjEuMCIgZW5jb2Rpbmc9InV0Zi04Ij8+Cis8c3ZnIHZlcnNpb249 IjEuMSIgeG1sbnM9Imh0dHA6Ly93d3cudzMub3JnLzIwMDAvc3ZnIiB4bWxuczp4bGluaz0iaHR0 cDovL3d3dy53My5vcmcvMTk5OS94bGluayIgb25sb2FkPSJydW5UZXN0KCkiPgorPHNjcmlwdD4K K2lmICh3aW5kb3cudGVzdFJ1bm5lcikKKyAgICAgdGVzdFJ1bm5lci53YWl0VW50aWxEb25lKCk7 CisKK2Z1bmN0aW9uIHJ1blRlc3QoKSB7CisgICAgdmFyIGMgPSBkb2N1bWVudC5nZXRFbGVtZW50 QnlJZCgiY2lyY2xlIikKKyAgICBjLnN0eWxlLmZpbGw9ICJuYXZ5IjsKKyAgICBzZXRUaW1lb3V0 KGZ1bmN0aW9uKCkgeworICAgICAgICBpbnRlcm5hbHMuYWRkcmVzcyhjKTsKKyAgICAgICAgYy5z dHlsZS5maWxsPSAiYmx1ZSI7CisgICAgICAgIHRlc3RSdW5uZXIubm90aWZ5RG9uZSgpOworICAg IH0sIDUwKTsKK30KKzwvc2NyaXB0PgorPGNpcmNsZSBjeD0iNTAiIGN5PSI1MCIgcj0iNTAiIHN0 eWxlPSJmaWxsOmdyZWVuOyIgaWQ9ImNpcmNsZSIgLz4KKzx1c2UgeD0iMTAwIiB4bGluazpocmVm PSIjY2lyY2xlIiAvPgorPHNjcmlwdD4KKzwvc2NyaXB0PgorPC9zdmc+Cg== 192671 2013-03-12 01:55:59 -0700 2013-03-12 05:09:46 -0700 Patch bug-111927-20130312175158.patch text/plain 6495 tasak U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1NDk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmU2NWQ1OTgxYTliY2Ni YzM0MGRmOWU0NTUyNWY3ODk1ZTA5M2Q2ZS4uZmMxNWRmZTk5YTAyMTBjYzRlMDJiYThiZjU2MzRm ODQyMzFmOGMwZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDEzLTAzLTExICBUYWth c2hpIFNha2Ftb3RvICA8dGFzYWtAZ29vZ2xlLmNvbT4KKworICAgICAgICBTdHlsZSB1cGRhdGVz IGFyZSBub3QgcHJvcGFnYXRlZCB0byA8dXNlPiBlbGVtZW50cyBhZnRlciBjcmVhdGlvbgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTExOTI3CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW5saW5lQ1NTU3R5 bGVEZWNsYXJhdGlvbiBkb2Vzbid0IG5vdGlmeSB1c2UgZWxlbWVudHMgd2hlbgorICAgICAgICBh IGNvcnJlc3BvbmRpbmcgZWxlbWVudCdzIGlubGluZSBzdHlsZSBpcyB1cGRhdGVkLiBOZWVkIHRv IHVwZGF0ZQorICAgICAgICBhbGwgaW5zdGFuY2VzIG9mIGEgZ2l2ZW4gZWxlbWVudCB3aG9zZSBp bmxpbmUgc3R5bGUgaXMgY2hhbmdlZC4KKworICAgICAgICBUZXN0czogc3ZnL2N1c3RvbS91c2Ut bW9kaWZ5LXRhcmdldC1zdHlsZS1wcm9wZXJ0eS1leHBlY3RlZC5zdmcKKyAgICAgICAgICAgICAg IHN2Zy9jdXN0b20vdXNlLW1vZGlmeS10YXJnZXQtc3R5bGUtcHJvcGVydHkuc3ZnCisKKyAgICAg ICAgKiBjc3MvUHJvcGVydHlTZXRDU1NTdHlsZURlY2xhcmF0aW9uLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OklubGluZUNTU1N0eWxlRGVjbGFyYXRpb246OmRpZE11dGF0ZSk6CisgICAgICAgIElm IGEgZ2l2ZW4gZWxlbWVudCBpcyBhIHN2ZyBlbGVtZW50LCBpbnZva2UKKyAgICAgICAgU1ZHRWxl bWVudEluc3RhbmNlOjppbnZhbGlkYXRlQWxsSW5zdGFuY2VzT2ZFbGVtZW50IGZvciB1c2UgZWxl bWVudHMuCisgICAgICAgICogc3ZnL1NWR0VsZW1lbnRJbnN0YW5jZS5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpTVkdFbGVtZW50SW5zdGFuY2U6OmludmFsaWRhdGVBbGxJbnN0YW5jZXNPZkVsZW1l bnQpOgorICAgICAgICBBZGRlZCBhIG5ldyBib29sIHBhcmFtZXRlciB0byBzcGVjaWZ5IHdoZXRo ZXIgdXBkYXRlIHN0eWxlcyBvciBub3QuCisgICAgICAgICogc3ZnL1NWR0VsZW1lbnRJbnN0YW5j ZS5oOgorICAgICAgICAoU1ZHRWxlbWVudEluc3RhbmNlKToKKwogMjAxMy0wMy0xMiAgRXVnZW5l IEtseXVjaG5pa292ICA8ZXVzdGFzQGNocm9taXVtLm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVj dG9yOiBbVGltZWxpbmVdIEZpbGUgc2VsZWN0b3IgY29udHJvbCBiZWNvbWVzIHZpc2libGUgb24g InRhYiIgbmF2aWdhdGlvbi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9Qcm9wZXJ0 eVNldENTU1N0eWxlRGVjbGFyYXRpb24uY3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL1Byb3BlcnR5 U2V0Q1NTU3R5bGVEZWNsYXJhdGlvbi5jcHAKaW5kZXggNTZkOTIxNWE4Njk3ZjkxNTQyNDBkZDgx NmQxNDk3YWYyZmZhYThmZS4uOGM4MzQxY2I0YTNjY2RmNmY2NDU2N2RmMjEzMWUzN2I2OTU5Yzlm NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL1Byb3BlcnR5U2V0Q1NTU3R5bGVEZWNs YXJhdGlvbi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL1Byb3BlcnR5U2V0Q1NTU3R5bGVE ZWNsYXJhdGlvbi5jcHAKQEAgLTI4LDYgKzI4LDkgQEAKICNpbmNsdWRlICJJbnNwZWN0b3JJbnN0 cnVtZW50YXRpb24uaCIKICNpbmNsdWRlICJNdXRhdGlvbk9ic2VydmVySW50ZXJlc3RHcm91cC5o IgogI2luY2x1ZGUgIk11dGF0aW9uUmVjb3JkLmgiCisjaWYgRU5BQkxFKFNWRykKKyNpbmNsdWRl ICJTVkdFbGVtZW50SW5zdGFuY2UuaCIKKyNlbmRpZgogI2luY2x1ZGUgIlN0eWxlUHJvcGVydHlT ZXQuaCIKICNpbmNsdWRlICJTdHlsZWRFbGVtZW50LmgiCiAjaW5jbHVkZSAiV2ViQ29yZU1lbW9y eUluc3RydW1lbnRhdGlvbi5oIgpAQCAtMzk4LDYgKzQwMSwxMCBAQCB2b2lkIElubGluZUNTU1N0 eWxlRGVjbGFyYXRpb246OmRpZE11dGF0ZShNdXRhdGlvblR5cGUgdHlwZSkKIAogICAgIG1fcGFy ZW50RWxlbWVudC0+c2V0TmVlZHNTdHlsZVJlY2FsYyhJbmxpbmVTdHlsZUNoYW5nZSk7CiAgICAg bV9wYXJlbnRFbGVtZW50LT5pbnZhbGlkYXRlU3R5bGVBdHRyaWJ1dGUoKTsKKyNpZiBFTkFCTEUo U1ZHKQorICAgIGlmIChtX3BhcmVudEVsZW1lbnQtPmlzU1ZHRWxlbWVudCgpKQorICAgICAgICBT VkdFbGVtZW50SW5zdGFuY2U6OmludmFsaWRhdGVBbGxJbnN0YW5jZXNPZkVsZW1lbnQodG9TVkdF bGVtZW50KG1fcGFyZW50RWxlbWVudCksIGZhbHNlKTsKKyNlbmRpZgogICAgIFN0eWxlQXR0cmli dXRlTXV0YXRpb25TY29wZSh0aGlzKS5kaWRJbnZhbGlkYXRlU3R5bGVBdHRyKCk7CiB9CiAKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdFbGVtZW50SW5zdGFuY2UuY3BwIGIvU291 cmNlL1dlYkNvcmUvc3ZnL1NWR0VsZW1lbnRJbnN0YW5jZS5jcHAKaW5kZXggODJlYzM1MTQ4NTRi ZDI4ODg0Yzg1ZGVjMjcxYjMzMWNiZTg2MmViMC4uYzkxODA3N2QzZTVkYzcyOWVkZjdhM2RjY2E5 ZmEyMDNlYWQ1YTJlNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvc3ZnL1NWR0VsZW1lbnRJ bnN0YW5jZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvc3ZnL1NWR0VsZW1lbnRJbnN0YW5jZS5j cHAKQEAgLTEyMCw3ICsxMjAsNyBAQCB2b2lkIFNWR0VsZW1lbnRJbnN0YW5jZTo6YXBwZW5kQ2hp bGQoUGFzc1JlZlB0cjxTVkdFbGVtZW50SW5zdGFuY2U+IGNoaWxkKQogICAgIGFwcGVuZENoaWxk VG9Db250YWluZXI8U1ZHRWxlbWVudEluc3RhbmNlLCBTVkdFbGVtZW50SW5zdGFuY2U+KGNoaWxk LmdldCgpLCB0aGlzKTsKIH0KIAotdm9pZCBTVkdFbGVtZW50SW5zdGFuY2U6OmludmFsaWRhdGVB bGxJbnN0YW5jZXNPZkVsZW1lbnQoU1ZHRWxlbWVudCogZWxlbWVudCkKK3ZvaWQgU1ZHRWxlbWVu dEluc3RhbmNlOjppbnZhbGlkYXRlQWxsSW5zdGFuY2VzT2ZFbGVtZW50KFNWR0VsZW1lbnQqIGVs ZW1lbnQsIGJvb2wgdXBkYXRlU3R5bGUpCiB7CiAgICAgaWYgKCFlbGVtZW50IHx8ICFlbGVtZW50 LT5pbkRvY3VtZW50KCkpCiAgICAgICAgIHJldHVybjsKQEAgLTE0Nyw3ICsxNDcsOCBAQCB2b2lk IFNWR0VsZW1lbnRJbnN0YW5jZTo6aW52YWxpZGF0ZUFsbEluc3RhbmNlc09mRWxlbWVudChTVkdF bGVtZW50KiBlbGVtZW50KQogICAgICAgICB9CiAgICAgfQogCi0gICAgZWxlbWVudC0+ZG9jdW1l bnQoKS0+dXBkYXRlU3R5bGVJZk5lZWRlZCgpOworICAgIGlmICh1cGRhdGVTdHlsZSkKKyAgICAg ICAgZWxlbWVudC0+ZG9jdW1lbnQoKS0+dXBkYXRlU3R5bGVJZk5lZWRlZCgpOwogfQogCiBjb25z dCBBdG9taWNTdHJpbmcmIFNWR0VsZW1lbnRJbnN0YW5jZTo6aW50ZXJmYWNlTmFtZSgpIGNvbnN0 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9zdmcvU1ZHRWxlbWVudEluc3RhbmNlLmggYi9T b3VyY2UvV2ViQ29yZS9zdmcvU1ZHRWxlbWVudEluc3RhbmNlLmgKaW5kZXggODkzZjZmMWE2N2I3 MGQ5MmU3YTY4YmVkYzc4ZGY5ZTBmOWJjNjNiNy4uYzYyZDZiZDQ1OTc4MjBmMGJhODkxNDlkYjM0 MGNhYzhiNzI5MGZhZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvc3ZnL1NWR0VsZW1lbnRJ bnN0YW5jZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdFbGVtZW50SW5zdGFuY2UuaApA QCAtOTYsNyArOTYsNyBAQCBwdWJsaWM6CiAgICAgICAgIFNWR1N0eWxlZEVsZW1lbnQqIG1fdGFy Z2V0RWxlbWVudDsKICAgICB9OwogICAgIAotICAgIHN0YXRpYyB2b2lkIGludmFsaWRhdGVBbGxJ bnN0YW5jZXNPZkVsZW1lbnQoU1ZHRWxlbWVudCopOworICAgIHN0YXRpYyB2b2lkIGludmFsaWRh dGVBbGxJbnN0YW5jZXNPZkVsZW1lbnQoU1ZHRWxlbWVudCosIGJvb2wgdXBkYXRlU3R5bGUgPSB0 cnVlKTsKIAogICAgIHVzaW5nIFRyZWVTaGFyZWQ8U1ZHRWxlbWVudEluc3RhbmNlPjo6cmVmOwog ICAgIHVzaW5nIFRyZWVTaGFyZWQ8U1ZHRWxlbWVudEluc3RhbmNlPjo6ZGVyZWY7CmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXgg NDFlZjcwZTY3MGFlMWY1M2NlMWVmY2Y2ZTYyZDA3NTQ3MjcyNjE2YS4uMDJjZGNjMmMyM2M4MWE0 MTgzNzNlMzdmN2RmODY4ODZlNWJkYTU0NCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEzLTAz LTExICBUYWthc2hpIFNha2Ftb3RvICA8dGFzYWtAZ29vZ2xlLmNvbT4KKworICAgICAgICBTdHls ZSB1cGRhdGVzIGFyZSBub3QgcHJvcGFnYXRlZCB0byA8dXNlPiBlbGVtZW50cyBhZnRlciBjcmVh dGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEx OTI3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBz dmcvY3VzdG9tL3VzZS1tb2RpZnktdGFyZ2V0LXN0eWxlLXByb3BlcnR5LWV4cGVjdGVkLnN2Zzog QWRkZWQuCisgICAgICAgICogc3ZnL2N1c3RvbS91c2UtbW9kaWZ5LXRhcmdldC1zdHlsZS1wcm9w ZXJ0eS5zdmc6IEFkZGVkLgorCiAyMDEzLTAzLTEyICBWc2V2b2xvZCBWbGFzb3YgIDx2c2V2aWtA Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQgdGVzdCBmbGFraW5lc3MgZml4Lgpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvc3ZnL2N1c3RvbS91c2UtbW9kaWZ5LXRhcmdldC1zdHls ZS1wcm9wZXJ0eS1leHBlY3RlZC5zdmcgYi9MYXlvdXRUZXN0cy9zdmcvY3VzdG9tL3VzZS1tb2Rp ZnktdGFyZ2V0LXN0eWxlLXByb3BlcnR5LWV4cGVjdGVkLnN2ZwpuZXcgZmlsZSBtb2RlIDEwMDY0 NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4xNWYzMTY4 NjIxMDRhMWYyMmYwZjJmM2RlYTEwNmJhOWZiYWViYTRiCi0tLSAvZGV2L251bGwKKysrIGIvTGF5 b3V0VGVzdHMvc3ZnL2N1c3RvbS91c2UtbW9kaWZ5LXRhcmdldC1zdHlsZS1wcm9wZXJ0eS1leHBl Y3RlZC5zdmcKQEAgLTAsMCArMSw3IEBACis8P3htbCB2ZXJzaW9uPSIxLjAiIGVuY29kaW5nPSJ1 dGYtOCI/PgorPHN2ZyB2ZXJzaW9uPSIxLjEiIHhtbG5zPSJodHRwOi8vd3d3LnczLm9yZy8yMDAw L3N2ZyIgeG1sbnM6eGxpbms9Imh0dHA6Ly93d3cudzMub3JnLzE5OTkveGxpbmsiPgorPGNpcmNs ZSBjeD0iNTAiIGN5PSI1MCIgcj0iNTAiIHN0eWxlPSJmaWxsOmdyZWVuOyIgaWQ9ImNpcmNsZSIg Lz4KKzx1c2UgeD0iMTAwIiB4bGluazpocmVmPSIjY2lyY2xlIiAvPgorPHNjcmlwdD4KKzwvc2Ny aXB0PgorPC9zdmc+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9zdmcvY3VzdG9tL3VzZS1tb2Rp ZnktdGFyZ2V0LXN0eWxlLXByb3BlcnR5LnN2ZyBiL0xheW91dFRlc3RzL3N2Zy9jdXN0b20vdXNl LW1vZGlmeS10YXJnZXQtc3R5bGUtcHJvcGVydHkuc3ZnCm5ldyBmaWxlIG1vZGUgMTAwNjQ0Cmlu ZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjc5NmE2ZmIzNTE4 ZDdhODJjZGMyNTQxMWNlYzE2YTlmZmYzM2E4NWMKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRU ZXN0cy9zdmcvY3VzdG9tL3VzZS1tb2RpZnktdGFyZ2V0LXN0eWxlLXByb3BlcnR5LnN2ZwpAQCAt MCwwICsxLDIxIEBACis8P3htbCB2ZXJzaW9uPSIxLjAiIGVuY29kaW5nPSJ1dGYtOCI/PgorPHN2 ZyB2ZXJzaW9uPSIxLjEiIHhtbG5zPSJodHRwOi8vd3d3LnczLm9yZy8yMDAwL3N2ZyIgeG1sbnM6 eGxpbms9Imh0dHA6Ly93d3cudzMub3JnLzE5OTkveGxpbmsiIG9ubG9hZD0icnVuVGVzdCgpIj4K KzxzY3JpcHQ+CitpZiAod2luZG93LnRlc3RSdW5uZXIpCisgICAgIHRlc3RSdW5uZXIud2FpdFVu dGlsRG9uZSgpOworCitmdW5jdGlvbiBydW5UZXN0KCkgeworICAgIHZhciBjID0gZG9jdW1lbnQu Z2V0RWxlbWVudEJ5SWQoImNpcmNsZSIpCisgICAgYy5zdHlsZS5maWxsPSAieWVsbG93IjsKKyAg ICBzZXRUaW1lb3V0KGZ1bmN0aW9uKCkgeworICAgICAgICBpbnRlcm5hbHMuYWRkcmVzcyhjKTsK KyAgICAgICAgYy5zdHlsZS5maWxsPSAiZ3JlZW4iOworICAgICAgICB0ZXN0UnVubmVyLm5vdGlm eURvbmUoKTsKKyAgICB9LCA1MCk7Cit9Cis8L3NjcmlwdD4KKzxjaXJjbGUgY3g9IjUwIiBjeT0i NTAiIHI9IjUwIiBzdHlsZT0iZmlsbDpyZWQ7IiBpZD0iY2lyY2xlIiAvPgorPHVzZSB4PSIxMDAi IHhsaW5rOmhyZWY9IiNjaXJjbGUiIC8+Cis8c2NyaXB0PgorPC9zY3JpcHQ+Cis8L3N2Zz4K