11188 2006-10-06 02:06:31 -0700 Setting hspace on a table overrides align=center 2008-01-11 10:27:53 -0800 1 1 1 Unclassified WebKit Tables 420+ Mac OS X 10.4 RESOLVED FIXED http://www.iloveindia.com/astrology/index.html P2 Normal --- 1 mitz hyatt eric oldest_to_newest 53993 0 mitz 2006-10-06 02:06:31 -0700 A table with align=center is not centered if it also specifies hspace. See attached test case. 53994 1 10945 mitz 2006-10-06 02:07:23 -0700 Created attachment 10945 Test case 66768 2 eric 2008-01-10 11:23:35 -0800 An example of this on a real website: http://www.iloveindia.com/astrology/index.html 66770 3 hyatt 2008-01-10 11:46:58 -0800 Interesting. Firefox appears to be somehow giving some mapped attributes a higher precedence than others. In particular, it makes sure hspace gets mapped in before align does. 66772 4 hyatt 2008-01-10 11:56:06 -0800 The bug is that we implemented align=center in the CSS file. This created a situation where hspace would always win (instead of allowing attribute order to determine the winner). 66773 5 18368 hyatt 2008-01-10 11:57:41 -0800 Created attachment 18368 Patch that moves align=center into code instead of CSS This patch will also improve the style sharing performance of tables, since the attribute selector rule in html4.css prevented tables from sharing style with one another. 66774 6 18368 mitz 2008-01-10 12:03:40 -0800 Comment on attachment 18368 Patch that moves align=center into code instead of CSS r=me. Add a test case if not covered by an existing one. 66922 7 hyatt 2008-01-11 10:27:53 -0800 Fixed in r29409. 10945 2006-10-06 02:07:23 -0700 2006-10-06 02:07:23 -0700 Test case 11188 testcase.html text/html 134 mitz PHRhYmxlIGFsaWduPSJjZW50ZXIiIGhzcGFjZT0iMCI+DQogICAgPHRyPiANCiAgICAgICAgPHRk PiANCiAgICAgICAgICAgIFRoaXMgc2hvdWxkIGJlIGNlbnRlcmVkDQogICAgICAgIDwvdGQ+DQog ICAgPC90cj4NCjwvdGFibGU+DQo= 18368 2008-01-10 11:57:41 -0800 2008-01-10 12:03:40 -0800 Patch that moves align=center into code instead of CSS patch.txt text/plain 1419 hyatt SW5kZXg6IGNzcy9odG1sNC5jc3MKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gY3NzL2h0bWw0LmNzcwkocmV2aXNp b24gMjkzMTYpCisrKyBjc3MvaHRtbDQuY3NzCSh3b3JraW5nIGNvcHkpCkBAIC0xNjksMTEgKzE2 OSw2IEBAIHRhYmxlIHsKICAgICBib3JkZXItY29sb3I6IGdyYXkKIH0KIAotdGFibGVbYWxpZ249 ImNlbnRlciJdIHsKLSAgICBtYXJnaW4tbGVmdDogYXV0bzsKLSAgICBtYXJnaW4tcmlnaHQ6IGF1 dG8KLX0KLQogdGhlYWQgewogICAgIGRpc3BsYXk6IHRhYmxlLWhlYWRlci1ncm91cDsKICAgICB2 ZXJ0aWNhbC1hbGlnbjogbWlkZGxlOwpJbmRleDogaHRtbC9IVE1MVGFibGVFbGVtZW50LmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBodG1sL0hUTUxUYWJsZUVsZW1lbnQuY3BwCShyZXZpc2lvbiAyOTMxNikK KysrIGh0bWwvSFRNTFRhYmxlRWxlbWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQzOCw4ICs0 MzgsMTMgQEAgdm9pZCBIVE1MVGFibGVFbGVtZW50OjpwYXJzZU1hcHBlZEF0dHJpYgogICAgICAg ICBhZGRDU1NMZW5ndGgoYXR0ciwgQ1NTX1BST1BfTUFSR0lOX0xFRlQsIGF0dHItPnZhbHVlKCkp OwogICAgICAgICBhZGRDU1NMZW5ndGgoYXR0ciwgQ1NTX1BST1BfTUFSR0lOX1JJR0hULCBhdHRy LT52YWx1ZSgpKTsKICAgICB9IGVsc2UgaWYgKGF0dHItPm5hbWUoKSA9PSBhbGlnbkF0dHIpIHsK LSAgICAgICAgaWYgKCFhdHRyLT52YWx1ZSgpLmlzRW1wdHkoKSkKLSAgICAgICAgICAgIGFkZENT U1Byb3BlcnR5KGF0dHIsIENTU19QUk9QX0ZMT0FULCBhdHRyLT52YWx1ZSgpKTsKKyAgICAgICAg aWYgKCFhdHRyLT52YWx1ZSgpLmlzRW1wdHkoKSkgeworICAgICAgICAgICAgaWYgKGVxdWFsSWdu b3JpbmdDYXNlKGF0dHItPnZhbHVlKCksICJjZW50ZXIiKSkgeworICAgICAgICAgICAgICAgIGFk ZENTU1Byb3BlcnR5KGF0dHIsIENTU19QUk9QX01BUkdJTl9MRUZULCBDU1NfVkFMX0FVVE8pOwor ICAgICAgICAgICAgICAgIGFkZENTU1Byb3BlcnR5KGF0dHIsIENTU19QUk9QX01BUkdJTl9SSUdI VCwgQ1NTX1ZBTF9BVVRPKTsKKyAgICAgICAgICAgIH0gZWxzZQorICAgICAgICAgICAgICAgIGFk ZENTU1Byb3BlcnR5KGF0dHIsIENTU19QUk9QX0ZMT0FULCBhdHRyLT52YWx1ZSgpKTsKKyAgICAg ICAgfQogICAgIH0gZWxzZSBpZiAoYXR0ci0+bmFtZSgpID09IHZhbGlnbkF0dHIpIHsKICAgICAg ICAgaWYgKCFhdHRyLT52YWx1ZSgpLmlzRW1wdHkoKSkKICAgICAgICAgICAgIGFkZENTU1Byb3Bl cnR5KGF0dHIsIENTU19QUk9QX1ZFUlRJQ0FMX0FMSUdOLCBhdHRyLT52YWx1ZSgpKTsK