111879 2013-03-08 11:28:21 -0800 Don't use bash constructs in Source/autotools/FindDependencies.m4 2013-10-09 23:02:59 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Other RESOLVED DUPLICATE 117796 P2 Normal --- 0 landry webkit-unassigned berto gustavo webkit.review.bot zan oldest_to_newest 851359 0 192255 landry 2013-03-08 11:28:21 -0800 Created attachment 192255 Use a="$a foo" to append instead of using a+=" foo" https://bugs.webkit.org/show_bug.cgi?id=109246 splitted stuff from configure.ac to Source/autotools. As it is now, it doesnt build on hosts where sh is not bash, because it uses a+="foo" constructs which are not valid in posix shells. $a+="bar" ksh: a+=bar: not found 851360 1 webkit.review.bot 2013-03-08 11:32:27 -0800 Attachment 192255 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files']" exit_code: 1 Total errors found: 0 in 0 files If any of these errors are false positives, please file a bug against check-webkit-style. 938090 2 berto 2013-10-09 14:59:40 -0700 lgtm 938214 3 zan 2013-10-09 23:01:50 -0700 This was fixed under bug #117796. *** This bug has been marked as a duplicate of bug 117796 *** 938218 4 192255 zan 2013-10-09 23:02:59 -0700 Comment on attachment 192255 Use a="$a foo" to append instead of using a+=" foo" Still, thanks for reporting. 192255 2013-03-08 11:28:21 -0800 2013-10-09 23:02:59 -0700 Use a="$a foo" to append instead of using a+=" foo" patch-Source_autotools_FindDependencies_m4 text/plain 1497 landry JE9wZW5CU0QkCi0tLSBTb3VyY2UvYXV0b3Rvb2xzL0ZpbmREZXBlbmRlbmNpZXMubTQub3JpZwlG cmkgTWFyICA4IDA5OjM4OjA0IDIwMTMKKysrIFNvdXJjZS9hdXRvdG9vbHMvRmluZERlcGVuZGVu Y2llcy5tNAlGcmkgTWFyICA4IDA5OjQxOjM1IDIwMTMKQEAgLTQ0MSwxOCArNDQxLDE4IEBAIGZp CiAKIGlmIHRlc3QgIiR3aXRoX2FjY2VsZXJhdGlvbl9iYWNrZW5kIiA9ICJvcGVuZ2wiOyB0aGVu CiAgICAgaWYgdGVzdCAiJGVuYWJsZV9nbGVzMiIgPSAieWVzIjsgdGhlbgotICAgICAgICBhY2Nl bGVyYXRpb25fYmFja2VuZF9kZXNjcmlwdGlvbis9ICIoZ2xlczIiCisgICAgICAgIGFjY2VsZXJh dGlvbl9iYWNrZW5kX2Rlc2NyaXB0aW9uPSAiKGdsZXMyIgogICAgICAgICBPUEVOR0xfTElCUz0i LWxHTEVTdjIiCiAgICAgZWxzZQotICAgICAgICBhY2NlbGVyYXRpb25fYmFja2VuZF9kZXNjcmlw dGlvbis9IihnbCIKKyAgICAgICAgYWNjZWxlcmF0aW9uX2JhY2tlbmRfZGVzY3JpcHRpb249Iihn bCIKICAgICAgICAgT1BFTkdMX0xJQlM9Ii1sR0wiCiAgICAgZmkKICAgICBpZiB0ZXN0ICIkZW5h YmxlX2VnbCIgPSAieWVzIjsgdGhlbgotICAgICAgICBhY2NlbGVyYXRpb25fYmFja2VuZF9kZXNj cmlwdGlvbis9IiwgZWdsIgotICAgICAgICBPUEVOR0xfTElCUys9IiAtbEVHTCIKKyAgICAgICAg YWNjZWxlcmF0aW9uX2JhY2tlbmRfZGVzY3JpcHRpb249IiRhY2NlbGVyYXRpb25fYmFja2VuZF9k ZXNjcmlwdGlvbiwgZWdsIgorICAgICAgICBPUEVOR0xfTElCUz0iJE9QRU5HTF9MSUJTIC1sRUdM IgogICAgIGZpCiAgICAgaWYgdGVzdCAiJGVuYWJsZV9nbHgiID0gInllcyI7IHRoZW4KLSAgICAg ICAgYWNjZWxlcmF0aW9uX2JhY2tlbmRfZGVzY3JpcHRpb24rPSIsIGdseCIKKyAgICAgICAgYWNj ZWxlcmF0aW9uX2JhY2tlbmRfZGVzY3JpcHRpb249IiRhY2NlbGVyYXRpb25fYmFja2VuZF9kZXNj cmlwdGlvbiwgZ2x4IgogICAgIGZpCiAKICAgICAjIENoZWNrIHdoZXRoZXIgZGxvcGVuKCkgaXMg aW4gdGhlIGNvcmUgbGliYyBsaWtlIG9uIEZyZWVCU0QsIG9yIGluIGEgc2VwYXJhdGUKQEAgLTQ2 MCw4ICs0NjAsOCBAQCBpZiB0ZXN0ICIkd2l0aF9hY2NlbGVyYXRpb25fYmFja2VuZCIgPSAib3Bl bmdsIjsgdGhlbgogICAgIEFDX0NIRUNLX0ZVTkMoW2Rsb3Blbl0sIFtdLCBbQUNfQ0hFQ0tfTElC KFtkbF0sIFtkbG9wZW5dLCBbRExPUEVOX0xJQlM9Ii1sZGwiXSldKQogICAgIEFDX1NVQlNUKFtE TE9QRU5fTElCU10pCiAKLSAgICBPUEVOR0xfTElCUys9IiAkRExPUEVOX0xJQlMiCi0gICAgYWNj ZWxlcmF0aW9uX2JhY2tlbmRfZGVzY3JpcHRpb24rPSIpIgorICAgIE9QRU5HTF9MSUJTPSIkT1BF TkdMX0xJQlMgJERMT1BFTl9MSUJTIgorICAgIGFjY2VsZXJhdGlvbl9iYWNrZW5kX2Rlc2NyaXB0 aW9uPSIkYWNjZWxlcmF0aW9uX2JhY2tlbmRfZGVzY3JpcHRpb24pIgogZmkKIEFDX1NVQlNUKFtP UEVOR0xfTElCU10pCiAK