111863 2013-03-08 08:50:27 -0800 [Stable][GTK][WK2] Fix compilation warning missing-field-initializers in webkit-2.0 stable branch 2013-03-09 01:53:02 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 rego webkit-unassigned andersca benjamin buildbot cgarcia gustavo mrobinson rniwa sam webkit.review.bot oldest_to_newest 851225 0 rego 2013-03-08 08:50:27 -0800 The warning is: ../../Source/WebKit2/UIProcess/API/gtk/WebKitUIClient.cpp:211:5: warning: missing initializer for member 'WKPageUIClient::unavailablePluginButtonClicked' [-Wmissing-field-initializers] 851226 1 rego 2013-03-08 08:52:08 -0800 (In reply to comment #0) > The warning is: > ../../Source/WebKit2/UIProcess/API/gtk/WebKitUIClient.cpp:211:5: warning: missing initializer for member 'WKPageUIClient::unavailablePluginButtonClicked' [-Wmissing-field-initializers] Sorry this one is in master not in the stable branch, the one in the stable branch is: ../../Source/WebKit2/UIProcess/API/gtk/WebKitUIClient.cpp:211:5: warning: missing initializer for member 'WKPageUIClient::pluginLoadPolicy' [-Wmissing-field-initializers] 851227 2 192233 rego 2013-03-08 08:54:06 -0800 Created attachment 192233 Patch 851230 3 webkit.review.bot 2013-03-08 08:59:48 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 851239 4 192233 mrobinson 2013-03-08 09:09:29 -0800 Comment on attachment 192233 Patch Looks good to me. 851253 5 cgarcia 2013-03-08 09:33:17 -0800 Committed in the stable branch http://trac.webkit.org/changeset/145234 851455 6 rego 2013-03-08 13:08:04 -0800 Adding WK2 owners to CC. 851493 7 192233 benjamin 2013-03-08 13:59:40 -0800 Comment on attachment 192233 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=192233&action=review Please fix the name before landing. > Source/WebKit2/UIProcess/API/gtk/WebKitUIClient.cpp:211 > + 0, // pluginLoadPolicy In my repository, this callback is named "unavailablePluginButtonClicked" 851755 8 192233 buildbot 2013-03-09 01:26:58 -0800 Comment on attachment 192233 Patch Attachment 192233 did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-commit-queue.appspot.com/results/17060461 New failing tests: fast/css/sticky/inline-sticky.html 851762 9 192233 webkit.review.bot 2013-03-09 01:52:58 -0800 Comment on attachment 192233 Patch Clearing flags on attachment: 192233 Committed r145308: <http://trac.webkit.org/changeset/145308> 851763 10 webkit.review.bot 2013-03-09 01:53:02 -0800 All reviewed patches have been landed. Closing bug. 192233 2013-03-08 08:54:06 -0800 2013-03-09 01:52:58 -0800 Patch bug-111863-20130308175008.patch text/plain 1519 rego U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1MjA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNzM5NjljZjgzNWQ2ZmI0 NGNjOGQwODAxYTZjNzM5NTJiZDU3ZjhkZC4uNDJiNGQxNDcwZTBmYWY2ZWE2NjA3NGI2MzMyM2Ix YWUzNTJkNDRjOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEzLTAzLTA4ICBNYW51 ZWwgUmVnbyBDYXNhc25vdmFzICA8cmVnb0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdW1dL Ml0gRml4IGNvbXBpbGF0aW9uIHdhcm5pbmcgbWlzc2luZy1maWVsZC1pbml0aWFsaXplcnMgaW4g d2Via2l0LTIuMCBzdGFibGUgYnJhbmNoCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMTE4NjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFVJQ2xpZW50LmNwcDoK KyAgICAgICAgKGF0dGFjaFVJQ2xpZW50VG9WaWV3KTogSW5jbHVkZSBtaXNzaW5nIGluaXRpYWxp emVyIGZvciBwbHVnaW5Mb2FkUG9saWN5LgorCiAyMDEzLTAzLTA2ICBTdWRhcnNhbmEgTmFnaW5l bmkgIDxzdWRhcnNhbmEubmFnaW5lbmlAaW50ZWwuY29tPgogCiAgICAgICAgIFtHVEtdW1dLMl0g SW1wbGVtZW50IFdlYkluc3BlY3Rvcjo6bG9jYWxpemVkU3RyaW5nc1VSTCgpIHRvIHJldHVybiB0 aGUgZmlsZSBVUkwgb2YgbG9jYWxpemVkU3RyaW5ncy5qcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0VUlDbGllbnQuY3BwIGIvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0VUlDbGllbnQuY3BwCmluZGV4IDBmMDkxNzU1NGVm N2Q1YmYyYzFlODA3YmJhMzBmNjBkNTk5NmI4ODYuLjA4OTliODU2Mzg5NGE0MDA1YTEyODMxZjY1 ZTNmOWViMmI2NzI4YzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv Z3RrL1dlYktpdFVJQ2xpZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L2d0ay9XZWJLaXRVSUNsaWVudC5jcHAKQEAgLTIwOCw2ICsyMDgsNyBAQCB2b2lkIGF0dGFjaFVJ Q2xpZW50VG9WaWV3KFdlYktpdFdlYlZpZXcqIHdlYlZpZXcpCiAgICAgICAgIDAsIC8vIHVuYXZh aWxhYmxlUGx1Z2luQnV0dG9uQ2xpY2tlZAogICAgICAgICAwLCAvLyBzaG93Q29sb3JQaWNrZXIK ICAgICAgICAgMCwgLy8gaGlkZUNvbG9yUGlja2VyCisgICAgICAgIDAsIC8vIHBsdWdpbkxvYWRQ b2xpY3kKICAgICB9OwogICAgIFdLUGFnZVJlZiB3a1BhZ2UgPSB0b0FQSSh3ZWJraXRXZWJWaWV3 QmFzZUdldFBhZ2UoV0VCS0lUX1dFQl9WSUVXX0JBU0Uod2ViVmlldykpKTsKICAgICBXS1BhZ2VT ZXRQYWdlVUlDbGllbnQod2tQYWdlLCAmd2tVSUNsaWVudCk7Cg==