<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>111859</bug_id>
          
          <creation_ts>2013-03-08 07:28:27 -0800</creation_ts>
          <short_desc>[qt] Webkit fails to compile if EGL headers are not in default INCLUDEPATH</short_desc>
          <delta_ts>2013-03-12 02:44:03 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Floris Bos">bos</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>jturcotte</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>851184</commentid>
    <comment_count>0</comment_count>
    <who name="Floris Bos">bos</who>
    <bug_when>2013-03-08 07:28:27 -0800</bug_when>
    <thetext>[qt] Webkit fails to compile if EGL headers are not in default INCLUDEPATH</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>851187</commentid>
    <comment_count>1</comment_count>
      <attachid>192227</attachid>
    <who name="Floris Bos">bos</who>
    <bug_when>2013-03-08 07:38:12 -0800</bug_when>
    <thetext>Created attachment 192227
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>851252</commentid>
    <comment_count>2</comment_count>
      <attachid>192227</attachid>
    <who name="Jocelyn Turcotte">jturcotte</who>
    <bug_when>2013-03-08 09:29:40 -0800</bug_when>
    <thetext>Comment on attachment 192227
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=192227&amp;action=review

&gt; Source/WebCore/ChangeLog:3
&gt; +        [qt] Webkit fails to compile if EGL headers are not in default INCLUDEPATH

qt -&gt; Qt
Webkit -&gt; WebKit

&gt; Source/WebCore/ChangeLog:13
&gt; +        Reviewed by NOBODY (OOPS!).

This line should normally be kept one empty line after the bug URL.

&gt; Source/WebCore/Target.pri:4153
&gt;      contains(QT_CONFIG, opengl) | contains(QT_CONFIG, opengles2) {

I think that what you are trying to fix could all be done by qmake if you add &quot;CONFIG += opengl egl&quot; inside this block. Could you try?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>851323</commentid>
    <comment_count>3</comment_count>
    <who name="Floris Bos">bos</who>
    <bug_when>2013-03-08 10:44:58 -0800</bug_when>
    <thetext>Thanks for the feedback.


&gt;I think that what you are trying to fix could all be done by qmake if you add &quot;CONFIG += opengl egl&quot; inside this block. Could you try?

A potential problem I see with that, is that it could interfere with this section in WebCore.pri:

==
use?(3D_GRAPHICS) {
    win32: {
        win32-g++: {
            # Make sure OpenGL libs are after the webcore lib so MinGW can resolve symbols
            contains(QT_CONFIG, opengles2) {
                CONFIG(debug, debug|release):contains(QT_CONFIG, angle) {
                    LIBS += $$QMAKE_LIBS_OPENGL_ES2_DEBUG
                } else {
                    LIBS += $$QMAKE_LIBS_OPENGL_ES2
                }
            } else {
                LIBS += $$QMAKE_LIBS_OPENGL
            }
        }
    } else {
        contains(QT_CONFIG, opengles2): LIBS += -lEGL
    }
}
==

Think that if I do &quot;CONFIG += opengl&quot; it will not only handle the INCLUDEPATH, but also will also add the libraries, and that might render the MinGW workaround here invalid.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>852301</commentid>
    <comment_count>4</comment_count>
    <who name="Jocelyn Turcotte">jturcotte</who>
    <bug_when>2013-03-11 07:45:40 -0700</bug_when>
    <thetext>(In reply to comment #3)
&gt; Think that if I do &quot;CONFIG += opengl&quot; it will not only handle the INCLUDEPATH, but also will also add the libraries, and that might render the MinGW workaround here invalid.

That&apos;s a good point, I didn&apos;t think about it. To be sure I just tried with MinGW and it doesn&apos;t break.
The libs were already duplicated on the link command line with the MinGW hack, so adding CONFIG += opengl is fine.

You could probably just add it together with the current &quot;CONFIG += opengl-shims&quot; to fix your issue.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>852388</commentid>
    <comment_count>5</comment_count>
      <attachid>192482</attachid>
    <who name="Floris Bos">bos</who>
    <bug_when>2013-03-11 09:08:34 -0700</bug_when>
    <thetext>Created attachment 192482
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>852392</commentid>
    <comment_count>6</comment_count>
    <who name="Floris Bos">bos</who>
    <bug_when>2013-03-11 09:11:22 -0700</bug_when>
    <thetext>(In reply to comment #4)
&gt; (In reply to comment #3)
&gt; You could probably just add it together with the current &quot;CONFIG += opengl-shims&quot; to fix your issue.

Didn&apos;t notice that before, but opengl-shims also provides generic OpenGL ES2 headers.
So adding the OGLES2 headers in my earlier patch was redundant, the only thing that was actually necessary is the EGL headers.

Can confirm that adding just &quot;egl&quot; to CONFIG fixes my problem.

Do wonder if it wouldn&apos;t be a better long term solution to add the EGL functions to opengl-shims as well, 
so runtime detection of the presense of the library could be done.
But think that&apos;s outside the scope of this bug report, so this will do.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>852395</commentid>
    <comment_count>7</comment_count>
      <attachid>192482</attachid>
    <who name="Jocelyn Turcotte">jturcotte</who>
    <bug_when>2013-03-11 09:19:36 -0700</bug_when>
    <thetext>Comment on attachment 192482
Patch

Great, thanks for the patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>852401</commentid>
    <comment_count>8</comment_count>
      <attachid>192482</attachid>
    <who name="Jocelyn Turcotte">jturcotte</who>
    <bug_when>2013-03-11 09:27:35 -0700</bug_when>
    <thetext>Comment on attachment 192482
Patch

Cancelling the CQ to figure if we need it also without OpenGLES</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>852402</commentid>
    <comment_count>9</comment_count>
    <who name="Jocelyn Turcotte">jturcotte</who>
    <bug_when>2013-03-11 09:27:54 -0700</bug_when>
    <thetext>(In reply to comment #6)
&gt; Do wonder if it wouldn&apos;t be a better long term solution to add the EGL functions to opengl-shims as well, 
&gt; so runtime detection of the presense of the library could be done.
&gt; But think that&apos;s outside the scope of this bug report, so this will do.

I&apos;m not an expert in this area, but to me it feels like the shims are wrapping APIs needing to go through getProcAddress to be resolved dynamically. All this to handle the various function availability differences given by the installed OpenGL library on the machine.

If all the EGL calls we need can be linked at compile time through normal library linking, I think that we should keep it that way as long as possible.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>852406</commentid>
    <comment_count>10</comment_count>
    <who name="Jocelyn Turcotte">jturcotte</who>
    <bug_when>2013-03-11 09:36:28 -0700</bug_when>
    <thetext>I didn&apos;t want to bother you with this, so we can just push this patch and we&apos;ll fix the rest later, but the best way to fix this would be to remove those lines from WebCore.pri:

&gt; win32: {
&gt; ...
&gt; } else {
&gt;     contains(QT_CONFIG, opengles2): LIBS += -lEGL
&gt; }

And replace them with this line in Target.pri (not merged with the opengl-shims config):
&gt; contains(QT_CONFIG, opengles2): CONFIG += egl

So tell me if you would like to do that change properly. Else I can do that patch afterward, but that would make you patch relatively pointless so you might as well do the final fix yourself.

Sorry going back and forth with this, Allan just pointed me that we currently don&apos;t want EGL without OpenGL ES.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>852470</commentid>
    <comment_count>11</comment_count>
    <who name="Floris Bos">bos</who>
    <bug_when>2013-03-11 10:58:42 -0700</bug_when>
    <thetext>&gt; If all the EGL calls we need can be linked at compile time through normal 
&gt;library linking, I think that we should keep it that way as long as possible.

Well, I&apos;m not sure if all ARM devices have OpenGL ES/EGL libraries installed at all.
Some vendors might not supply GPU accelerated ones, and having ones doing software rendering makes little sense on such slow CPUs.

Naturally, if you are creating a build for a specific device, 3D functionality can simply be disabled at compile time.
But it would be nice if generic Linux/ARM distributions could provide a single generic QtWebkit package that works on multiple devices, and resorts to disabling 3D functionality at runtime if libEGL is not present.


&gt;I didn&apos;t want to bother you with this, so we can just push this patch and we&apos;ll &gt;fix the rest later, but the best way to fix this would be to remove those lines &gt;from WebCore.pri:
&gt;
&gt;&gt; win32: {
&gt;&gt; ...
&gt;&gt; } else {
&gt;&gt;     contains(QT_CONFIG, opengles2): LIBS += -lEGL
&gt;&gt; }


Do you mean just the non-win32 EGL section, or including the win32 section dealing with OpenGL libs?
Linking OpenGL libs there should not be necessary if shims take care of that at runtime, but do not have a Windows box to test on.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>852474</commentid>
    <comment_count>12</comment_count>
      <attachid>192510</attachid>
    <who name="Floris Bos">bos</who>
    <bug_when>2013-03-11 11:00:58 -0700</bug_when>
    <thetext>Created attachment 192510
patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>852495</commentid>
    <comment_count>13</comment_count>
    <who name="Jocelyn Turcotte">jturcotte</who>
    <bug_when>2013-03-11 11:18:39 -0700</bug_when>
    <thetext>(In reply to comment #11)
&gt; Well, I&apos;m not sure if all ARM devices have OpenGL ES/EGL libraries installed at all.
&gt; Some vendors might not supply GPU accelerated ones, and having ones doing software rendering makes little sense on such slow CPUs.
&gt; 
&gt; Naturally, if you are creating a build for a specific device, 3D functionality can simply be disabled at compile time.
&gt; But it would be nice if generic Linux/ARM distributions could provide a single generic QtWebkit package that works on multiple devices, and resorts to disabling 3D functionality at runtime if libEGL is not present.

I don&apos;t know this stuff enough to answer you, but if you face a concrete problem that is worth fixing that way we can work on shaping some patch.

&gt; &gt;&gt; win32: {
&gt; &gt;&gt; ...
&gt; &gt;&gt; } else {
&gt; &gt;&gt;     contains(QT_CONFIG, opengles2): LIBS += -lEGL
&gt; &gt;&gt; }
&gt; 
&gt; 
&gt; Do you mean just the non-win32 EGL section, or including the win32 section dealing with OpenGL libs?
&gt; Linking OpenGL libs there should not be necessary if shims take care of that at runtime, but do not have a Windows box to test on.

Some OpenGL function that are available on all implementations are linked at compile time so we still need to link with it.
You can remove the surrounding win32 block, win32-g++ is only available on win32, as its name states, so no need for the extra scope check.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>852505</commentid>
    <comment_count>14</comment_count>
    <who name="Floris Bos">bos</who>
    <bug_when>2013-03-11 11:28:30 -0700</bug_when>
    <thetext>(In reply to comment #10)
&gt; I didn&apos;t want to bother you with this, so we can just push this patch and we&apos;ll fix the rest later, but the best way to fix this would be to remove those lines from WebCore.pri:
&gt; 
&gt; &gt; win32: {
&gt; &gt; ...
&gt; &gt; } else {
&gt; &gt;     contains(QT_CONFIG, opengles2): LIBS += -lEGL
&gt; &gt; }
&gt; 
&gt; And replace them with this line in Target.pri (not merged with the opengl-shims config):
&gt; &gt; contains(QT_CONFIG, opengles2): CONFIG += egl


Hmm, after removing the &quot;LIBS += -lEGL&quot;:

==
Source/WebCore/release/libWebCore.a(Extensions3DOpenGLES.o): In function `WebCore::Extensions3DOpenGLES::supportsExtension(WTF::String const&amp;)&apos;:
Extensions3DOpenGLES.cpp:(.text._ZN7WebCore20Extensions3DOpenGLES17supportsExtensionERKN3WTF6StringE+0x14c): undefined reference to `eglGetProcAddress&apos;
Extensions3DOpenGLES.cpp:(.text._ZN7WebCore20Extensions3DOpenGLES17supportsExtensionERKN3WTF6StringE+0x160): undefined reference to `eglGetProcAddress&apos;
Extensions3DOpenGLES.cpp:(.text._ZN7WebCore20Extensions3DOpenGLES17supportsExtensionERKN3WTF6StringE+0x174): undefined reference to `eglGetProcAddress&apos;
Extensions3DOpenGLES.cpp:(.text._ZN7WebCore20Extensions3DOpenGLES17supportsExtensionERKN3WTF6StringE+0x188): undefined reference to `eglGetProcAddress&apos;
Extensions3DOpenGLES.cpp:(.text._ZN7WebCore20Extensions3DOpenGLES17supportsExtensionERKN3WTF6StringE+0x22c): undefined reference to `eglGetProcAddress&apos;
==

Should I have the &quot;CONFIG += egl&quot; in WebCore.pri as well in addition to in Target.pri?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>852514</commentid>
    <comment_count>15</comment_count>
    <who name="Jocelyn Turcotte">jturcotte</who>
    <bug_when>2013-03-11 11:35:38 -0700</bug_when>
    <thetext>(In reply to comment #14)
&gt; Should I have the &quot;CONFIG += egl&quot; in WebCore.pri as well in addition to in Target.pri?

Target.pri includes WebCore.pri, so after all maybe the fix should be to replace &quot;LIBS += -lEGL&quot; by &quot;CONFIG += egl&quot; in WebCore.pri.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>852574</commentid>
    <comment_count>16</comment_count>
    <who name="Floris Bos">bos</who>
    <bug_when>2013-03-11 12:30:28 -0700</bug_when>
    <thetext>(In reply to comment #15)
&gt;Target.pri includes WebCore.pri, so after all maybe the fix should be to replace 
&gt;&quot;LIBS += -lEGL&quot; by &quot;CONFIG += egl&quot; in WebCore.pri.

Thanks for the hint.
Yes, that does work fine.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>852575</commentid>
    <comment_count>17</comment_count>
      <attachid>192528</attachid>
    <who name="Floris Bos">bos</who>
    <bug_when>2013-03-11 12:31:14 -0700</bug_when>
    <thetext>Created attachment 192528
New patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>852597</commentid>
    <comment_count>18</comment_count>
      <attachid>192528</attachid>
    <who name="Jocelyn Turcotte">jturcotte</who>
    <bug_when>2013-03-11 12:44:35 -0700</bug_when>
    <thetext>Comment on attachment 192528
New patch

View in context: https://bugs.webkit.org/attachment.cgi?id=192528&amp;action=review

&gt; Source/WebCore/WebCore.pri:-230
&gt; -    win32: {

We should probably keep that block now that we won&apos;t be doing that logic in Target.pri.
This should avoid having different behaviors between win32-g++ and win32-msvc* regarding EGL.
Sorry I should have mentioned it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>852615</commentid>
    <comment_count>19</comment_count>
      <attachid>192533</attachid>
    <who name="Floris Bos">bos</who>
    <bug_when>2013-03-11 12:58:58 -0700</bug_when>
    <thetext>Created attachment 192533
Just patching LIBS to CONFIG</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>853231</commentid>
    <comment_count>20</comment_count>
      <attachid>192533</attachid>
    <who name="Jocelyn Turcotte">jturcotte</who>
    <bug_when>2013-03-12 02:32:59 -0700</bug_when>
    <thetext>Comment on attachment 192533
Just patching LIBS to CONFIG

r=me, thanks for holding on</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>853239</commentid>
    <comment_count>21</comment_count>
      <attachid>192533</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2013-03-12 02:43:59 -0700</bug_when>
    <thetext>Comment on attachment 192533
Just patching LIBS to CONFIG

Clearing flags on attachment: 192533

Committed r145506: &lt;http://trac.webkit.org/changeset/145506&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>853240</commentid>
    <comment_count>22</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2013-03-12 02:44:03 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>192227</attachid>
            <date>2013-03-08 07:38:12 -0800</date>
            <delta_ts>2013-03-11 09:08:29 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-111859-20130308163414.patch</filename>
            <type>text/plain</type>
            <size>1946</size>
            <attacher name="Floris Bos">bos</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1MjEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjFhYzgwNGMyNjliNzJi
MzUxY2E1YzZmOGRlZGZkOWE4ZjkyZGI2OC4uZDE3YjU3NjZlYmYzN2I4YjliMWFjOWM1NGRhYjBj
N2YxOGI3MmIzOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTAzLTA4ICBGbG9y
aXMgQm9zICA8Ym9zQGplLWVpZ2VuLWRvbWVpbi5ubD4KKworICAgICAgICBbcXRdIFdlYmtpdCBm
YWlscyB0byBjb21waWxlIGlmIEVHTCBoZWFkZXJzIGFyZSBub3QgaW4gZGVmYXVsdCBJTkNMVURF
UEFUSAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEx
ODU5CisKKyAgICAgICAgVGhlIDNEIGdyYXBoaWNzIGNvZGUgd2FudHMgdG8gaW5jbHVkZSBFR0wg
YW5kIE9wZW5HTCAoRVMyKSBoZWFkZXIgZmlsZXMuCisgICAgICAgIEJ1dCBvbiBzb21lIHBsYXRm
b3JtcyBzdWNoIGFzIHRoZSBSYXNwYmVycnkgUGkgdGhvc2UgYXJlIG5vdCBpbiAvdXNyL2luY2x1
ZGUgCisgICAgICAgIGJ1dCBpbiBhbm90aGVyIGZvbGRlci4gCisKKyAgICAgICAgRml4IGFkZHMg
JCRRTUFLRV9JTkNESVJfRUdMIGFuZCAkJFFNQUtFX0lOQ0RJUl9PUEVOR0woX0VTMikgdG8KKyAg
ICAgICAgdGhlIElOQ0xVREVQQVRICisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT
ISkuCisKKyAgICAgICAgKiBUYXJnZXQucHJpOgorCiAyMDEzLTAzLTA4ICBBbGxhbiBTYW5kZmVs
ZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5AZGlnaWEuY29tPgogCiAgICAgICAgIFtRdF0gRG9lc24n
dCBidWlsZCB3aXRoIFF0TXVsdGltZWRpYQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvVGFy
Z2V0LnByaSBiL1NvdXJjZS9XZWJDb3JlL1RhcmdldC5wcmkKaW5kZXggMWI2NTVmYmUwNTQwZGI0
M2ZhMWJhODVlMjVlZWVkYjU3YzYwNzY3OC4uNjgxM2MyOGFjMGI2MTM3NGQ3ZjAxZTdlYWJmYzQx
YzkwMGQxYTQ2MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvVGFyZ2V0LnByaQorKysgYi9T
b3VyY2UvV2ViQ29yZS9UYXJnZXQucHJpCkBAIC00MTUyLDE1ICs0MTUyLDE5IEBAIHVzZT8oM0Rf
R1JBUEhJQ1MpIHsKIAogICAgIGNvbnRhaW5zKFFUX0NPTkZJRywgb3BlbmdsKSB8IGNvbnRhaW5z
KFFUX0NPTkZJRywgb3BlbmdsZXMyKSB7CiAgICAgICAgICFjb250YWlucyhRVF9DT05GSUcsIG9w
ZW5nbGVzMikgeworICAgICAgICAgICAgSU5DTFVERVBBVEggKz0gJCRRTUFLRV9JTkNESVJfT1BF
TkdMCiAgICAgICAgICAgICBTT1VSQ0VTICs9IFwKICAgICAgICAgICAgICAgIHBsYXRmb3JtL2dy
YXBoaWNzL29wZW5nbC9HcmFwaGljc0NvbnRleHQzRE9wZW5HTC5jcHAgXAogICAgICAgICAgICAg
ICAgcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0V4dGVuc2lvbnMzRE9wZW5HTC5jcHAKICAgICAg
ICAgfSBlbHNlIHsKKyAgICAgICAgICAgIElOQ0xVREVQQVRIICs9ICQkUU1BS0VfSU5DRElSX09Q
RU5HTF9FUzIKICAgICAgICAgICAgIFNPVVJDRVMgKz0gXAogICAgICAgICAgICAgICAgcGxhdGZv
cm0vZ3JhcGhpY3Mvb3BlbmdsL0dyYXBoaWNzQ29udGV4dDNET3BlbkdMRVMuY3BwIFwKICAgICAg
ICAgICAgICAgIHBsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9FeHRlbnNpb25zM0RPcGVuR0xFUy5j
cHAKICAgICAgICAgfQogCisgICAgICAgICFpc0VtcHR5KFFNQUtFX0lOQ0RJUl9FR0wpOiBJTkNM
VURFUEFUSCArPSAkJFFNQUtFX0lOQ0RJUl9FR0wKKwogICAgICAgICBIRUFERVJTICs9IHBsYXRm
b3JtL2dyYXBoaWNzL29wZW5nbC9FeHRlbnNpb25zM0RPcGVuR0wuaAogCiAgICAgICAgIFNPVVJD
RVMgKz0gXAo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>192482</attachid>
            <date>2013-03-11 09:08:34 -0700</date>
            <delta_ts>2013-03-11 11:00:58 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-111859-20130311170433.patch</filename>
            <type>text/plain</type>
            <size>1316</size>
            <attacher name="Floris Bos">bos</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1MzYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmY4NGRmZDg0ZjQ5ZTQ5
NWJhM2M3MDA0MTAyN2IwZDc0MzU3ZWE1OC4uZGI4ZGE5NjkxNTM3MmVlY2Q2NDlkZDM2YmJlYWUw
OWViZmU3YTJjYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTAzLTExICBGbG9y
aXMgQm9zICA8Ym9zQGplLWVpZ2VuLWRvbWVpbi5ubD4KKworICAgICAgICBbUXRdIFdlYktpdCBm
YWlscyB0byBjb21waWxlIGlmIEVHTCBoZWFkZXJzIGFyZSBub3QgaW4gZGVmYXVsdCBJTkNMVURF
UEFUSAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEx
ODU5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhl
IDNEIGdyYXBoaWNzIGNvZGUgd2FudHMgdG8gaW5jbHVkZSBFR0wgaGVhZGVyIGZpbGVzLgorICAg
ICAgICBCdXQgb24gc29tZSBwbGF0Zm9ybXMgc3VjaCBhcyB0aGUgUmFzcGJlcnJ5IFBpIHRob3Nl
IGFyZSBub3QgaW4gL3Vzci9pbmNsdWRlCisgICAgICAgIGJ1dCBpbiBhbm90aGVyIGZvbGRlci4K
KyAgICAgICAgRml4IGFkZHMgImVnbCIgdG8gQ09ORklHLCBzbyB0aGUgcmlnaHQgaW5jbHVkZSBw
YXRocyBhcmUgYWRkZWQuCisKKyAgICAgICAgKiBUYXJnZXQucHJpOgorCiAyMDEzLTAzLTExICBL
ZW50IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KIAogICAgICAgICBJbmFwcHJvcHJpYXRl
IHZhbGlkYXRpb24gbWVzc2FnZSBmb3IgcmVxdWlyZWQgbnVtYmVyL2RhdGUgaW5wdXQgZWxlbWVu
dHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL1RhcmdldC5wcmkgYi9Tb3VyY2UvV2ViQ29y
ZS9UYXJnZXQucHJpCmluZGV4IDI0NGJjYjFhMzBjZjc3YTcwNmIyMTJmZmRmZjU2ZjM4OTA5MzMw
OWYuLjgzNTNlNGY5NjMxZTU4MGFiZjg2NWM4NzM2NDgyZWUxNzNjNDAyYzAgMTAwNjQ0Ci0tLSBh
L1NvdXJjZS9XZWJDb3JlL1RhcmdldC5wcmkKKysrIGIvU291cmNlL1dlYkNvcmUvVGFyZ2V0LnBy
aQpAQCAtNDE3MSw3ICs0MTcxLDcgQEAgdXNlPygzRF9HUkFQSElDUykgewogCiAgICAgV0VCS0lU
ICs9IGFuZ2xlCiAKLSAgICBDT05GSUcgKz0gb3BlbmdsLXNoaW1zCisgICAgQ09ORklHICs9IG9w
ZW5nbC1zaGltcyBlZ2wKICAgICBJTkNMVURFUEFUSCArPSBwbGF0Zm9ybS9ncmFwaGljcy9ncHUK
IH0KIAo=
</data>
<flag name="review"
          id="213729"
          type_id="1"
          status="+"
          setter="jturcotte"
    />
    <flag name="commit-queue"
          id="213730"
          type_id="3"
          status="-"
          setter="jturcotte"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>192510</attachid>
            <date>2013-03-11 11:00:58 -0700</date>
            <delta_ts>2013-03-11 11:18:44 -0700</delta_ts>
            <desc>patch</desc>
            <filename>qt5webkit-egl-fix.patch</filename>
            <type>text/plain</type>
            <size>1783</size>
            <attacher name="Floris Bos">bos</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZwppbmRleCAyZjg0ZGZkLi43NDM0OGYwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y
ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg
QEAKKzIwMTMtMDMtMTEgIEZsb3JpcyBCb3MgIDxib3NAamUtZWlnZW4tZG9tZWluLm5sPgorCisg
ICAgICAgIFtRdF0gV2ViS2l0IGZhaWxzIHRvIGNvbXBpbGUgaWYgRUdMIGhlYWRlcnMgYXJlIG5v
dCBpbiBkZWZhdWx0IElOQ0xVREVQQVRICisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn
L3Nob3dfYnVnLmNnaT9pZD0xMTE4NTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P
UFMhKS4KKworICAgICAgICBUaGUgM0QgZ3JhcGhpY3MgY29kZSB3YW50cyB0byBpbmNsdWRlIEVH
TCBoZWFkZXIgZmlsZXMuCisgICAgICAgIEJ1dCBvbiBzb21lIHBsYXRmb3JtcyBzdWNoIGFzIHRo
ZSBSYXNwYmVycnkgUGkgdGhvc2UgYXJlIG5vdCBpbiAvdXNyL2luY2x1ZGUKKyAgICAgICAgYnV0
IGluIGFub3RoZXIgZm9sZGVyLgorICAgICAgICBGaXggYWRkcyAiZWdsIiB0byBDT05GSUcgd2hl
biBPcGVuR0wgRVMyIGlzIHVzZWQsIHNvIHRoZSByaWdodCBpbmNsdWRlCisgICAgICAgIHBhdGhz
IGFyZSBhZGRlZC4KKworICAgICAgICAqIFRhcmdldC5wcmk6CisgICAgICAgICogV2ViQ29yZS5w
cmk6CisKIDIwMTMtMDMtMTEgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgogCiAg
ICAgICAgIEluYXBwcm9wcmlhdGUgdmFsaWRhdGlvbiBtZXNzYWdlIGZvciByZXF1aXJlZCBudW1i
ZXIvZGF0ZSBpbnB1dCBlbGVtZW50cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvVGFyZ2V0
LnByaSBiL1NvdXJjZS9XZWJDb3JlL1RhcmdldC5wcmkKaW5kZXggMjQ0YmNiMS4uNjY3MTExNiAx
MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvVGFyZ2V0LnByaQorKysgYi9Tb3VyY2UvV2ViQ29y
ZS9UYXJnZXQucHJpCkBAIC00MTU3LDYgKzQxNTcsNyBAQCB1c2U/KDNEX0dSQVBISUNTKSB7CiAg
ICAgICAgICAgICAgICBwbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvR3JhcGhpY3NDb250ZXh0M0RP
cGVuR0wuY3BwIFwKICAgICAgICAgICAgICAgIHBsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9FeHRl
bnNpb25zM0RPcGVuR0wuY3BwCiAgICAgICAgIH0gZWxzZSB7CisgICAgICAgICAgICBDT05GSUcg
Kz0gZWdsCiAgICAgICAgICAgICBTT1VSQ0VTICs9IFwKICAgICAgICAgICAgICAgIHBsYXRmb3Jt
L2dyYXBoaWNzL29wZW5nbC9HcmFwaGljc0NvbnRleHQzRE9wZW5HTEVTLmNwcCBcCiAgICAgICAg
ICAgICAgICBwbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvRXh0ZW5zaW9uczNET3BlbkdMRVMuY3Bw
CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLnByaSBiL1NvdXJjZS9XZWJDb3Jl
L1dlYkNvcmUucHJpCmluZGV4IDRmYmFmOWMuLjcyNDJkYTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X
ZWJDb3JlL1dlYkNvcmUucHJpCisrKyBiL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUucHJpCkBAIC0y
NDAsOCArMjQwLDYgQEAgdXNlPygzRF9HUkFQSElDUykgewogICAgICAgICAgICAgICAgIExJQlMg
Kz0gJCRRTUFLRV9MSUJTX09QRU5HTAogICAgICAgICAgICAgfQogICAgICAgICB9Ci0gICAgfSBl
bHNlIHsKLSAgICAgICAgY29udGFpbnMoUVRfQ09ORklHLCBvcGVuZ2xlczIpOiBMSUJTICs9IC1s
RUdMCiAgICAgfQogfQogCg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>192528</attachid>
            <date>2013-03-11 12:31:14 -0700</date>
            <delta_ts>2013-03-11 12:58:58 -0700</delta_ts>
            <desc>New patch</desc>
            <filename>qt5webkit-egl-fix.patch</filename>
            <type>text/plain</type>
            <size>2106</size>
            <attacher name="Floris Bos">bos</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZwppbmRleCAyZjg0ZGZkLi5kYTc2Mzk4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y
ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg
QEAKKzIwMTMtMDMtMTEgIEZsb3JpcyBCb3MgIDxib3NAamUtZWlnZW4tZG9tZWluLm5sPgorCisg
ICAgICAgIFtRdF0gV2ViS2l0IGZhaWxzIHRvIGNvbXBpbGUgaWYgRUdMIGhlYWRlcnMgYXJlIG5v
dCBpbiBkZWZhdWx0IElOQ0xVREVQQVRICisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn
L3Nob3dfYnVnLmNnaT9pZD0xMTE4NTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P
UFMhKS4KKworICAgICAgICBUaGUgM0QgZ3JhcGhpY3MgY29kZSB3YW50cyB0byBpbmNsdWRlIEVH
TCBoZWFkZXIgZmlsZXMuCisgICAgICAgIEJ1dCBvbiBzb21lIHBsYXRmb3JtcyBzdWNoIGFzIHRo
ZSBSYXNwYmVycnkgUGkgdGhvc2UgYXJlIG5vdCBpbiAvdXNyL2luY2x1ZGUKKyAgICAgICAgYnV0
IGluIGFub3RoZXIgZm9sZGVyLgorICAgICAgICBGaXggYWRkcyAiZWdsIiB0byBDT05GSUcgd2hl
biBPcGVuR0wgRVMyIGlzIHVzZWQsIHNvIHRoZSByaWdodCBpbmNsdWRlCisgICAgICAgIHBhdGhz
IGFyZSBhZGRlZC4KKworICAgICAgICAqIFdlYkNvcmUucHJpOgorCiAyMDEzLTAzLTExICBLZW50
IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KIAogICAgICAgICBJbmFwcHJvcHJpYXRlIHZh
bGlkYXRpb24gbWVzc2FnZSBmb3IgcmVxdWlyZWQgbnVtYmVyL2RhdGUgaW5wdXQgZWxlbWVudHMK
ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUucHJpIGIvU291cmNlL1dlYkNvcmUv
V2ViQ29yZS5wcmkKaW5kZXggNGZiYWY5Yy4uNDRhODYwYyAxMDA2NDQKLS0tIGEvU291cmNlL1dl
YkNvcmUvV2ViQ29yZS5wcmkKKysrIGIvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5wcmkKQEAgLTIy
NywyMSArMjI3LDE5IEBAIGVuYWJsZT8oV0VCX0FVRElPKSB7CiB9CiAKIHVzZT8oM0RfR1JBUEhJ
Q1MpIHsKLSAgICB3aW4zMjogewotICAgICAgICB3aW4zMi1nKys6IHsKLSAgICAgICAgICAgICMg
TWFrZSBzdXJlIE9wZW5HTCBsaWJzIGFyZSBhZnRlciB0aGUgd2ViY29yZSBsaWIgc28gTWluR1cg
Y2FuIHJlc29sdmUgc3ltYm9scwotICAgICAgICAgICAgY29udGFpbnMoUVRfQ09ORklHLCBvcGVu
Z2xlczIpIHsKLSAgICAgICAgICAgICAgICBDT05GSUcoZGVidWcsIGRlYnVnfHJlbGVhc2UpOmNv
bnRhaW5zKFFUX0NPTkZJRywgYW5nbGUpIHsKLSAgICAgICAgICAgICAgICAgICAgTElCUyArPSAk
JFFNQUtFX0xJQlNfT1BFTkdMX0VTMl9ERUJVRwotICAgICAgICAgICAgICAgIH0gZWxzZSB7Ci0g
ICAgICAgICAgICAgICAgICAgIExJQlMgKz0gJCRRTUFLRV9MSUJTX09QRU5HTF9FUzIKLSAgICAg
ICAgICAgICAgICB9CisgICAgd2luMzItZysrOiB7CisgICAgICAgICMgTWFrZSBzdXJlIE9wZW5H
TCBsaWJzIGFyZSBhZnRlciB0aGUgd2ViY29yZSBsaWIgc28gTWluR1cgY2FuIHJlc29sdmUgc3lt
Ym9scworICAgICAgICBjb250YWlucyhRVF9DT05GSUcsIG9wZW5nbGVzMikgeworICAgICAgICAg
ICAgQ09ORklHKGRlYnVnLCBkZWJ1Z3xyZWxlYXNlKTpjb250YWlucyhRVF9DT05GSUcsIGFuZ2xl
KSB7CisgICAgICAgICAgICAgICAgTElCUyArPSAkJFFNQUtFX0xJQlNfT1BFTkdMX0VTMl9ERUJV
RwogICAgICAgICAgICAgfSBlbHNlIHsKLSAgICAgICAgICAgICAgICBMSUJTICs9ICQkUU1BS0Vf
TElCU19PUEVOR0wKKyAgICAgICAgICAgICAgICBMSUJTICs9ICQkUU1BS0VfTElCU19PUEVOR0xf
RVMyCiAgICAgICAgICAgICB9CisgICAgICAgIH0gZWxzZSB7CisgICAgICAgICAgICBMSUJTICs9
ICQkUU1BS0VfTElCU19PUEVOR0wKICAgICAgICAgfQogICAgIH0gZWxzZSB7Ci0gICAgICAgIGNv
bnRhaW5zKFFUX0NPTkZJRywgb3BlbmdsZXMyKTogTElCUyArPSAtbEVHTAorICAgICAgICBjb250
YWlucyhRVF9DT05GSUcsIG9wZW5nbGVzMik6IENPTkZJRyArPSBlZ2wKICAgICB9CiB9CiAK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>192533</attachid>
            <date>2013-03-11 12:58:58 -0700</date>
            <delta_ts>2013-03-12 02:43:59 -0700</delta_ts>
            <desc>Just patching LIBS to CONFIG</desc>
            <filename>qt5webkit-egl-fix.patch</filename>
            <type>text/plain</type>
            <size>1222</size>
            <attacher name="Floris Bos">bos</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZwppbmRleCAyZjg0ZGZkLi5kYTc2Mzk4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y
ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg
QEAKKzIwMTMtMDMtMTEgIEZsb3JpcyBCb3MgIDxib3NAamUtZWlnZW4tZG9tZWluLm5sPgorCisg
ICAgICAgIFtRdF0gV2ViS2l0IGZhaWxzIHRvIGNvbXBpbGUgaWYgRUdMIGhlYWRlcnMgYXJlIG5v
dCBpbiBkZWZhdWx0IElOQ0xVREVQQVRICisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn
L3Nob3dfYnVnLmNnaT9pZD0xMTE4NTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P
UFMhKS4KKworICAgICAgICBUaGUgM0QgZ3JhcGhpY3MgY29kZSB3YW50cyB0byBpbmNsdWRlIEVH
TCBoZWFkZXIgZmlsZXMuCisgICAgICAgIEJ1dCBvbiBzb21lIHBsYXRmb3JtcyBzdWNoIGFzIHRo
ZSBSYXNwYmVycnkgUGkgdGhvc2UgYXJlIG5vdCBpbiAvdXNyL2luY2x1ZGUKKyAgICAgICAgYnV0
IGluIGFub3RoZXIgZm9sZGVyLgorICAgICAgICBGaXggYWRkcyAiZWdsIiB0byBDT05GSUcgd2hl
biBPcGVuR0wgRVMyIGlzIHVzZWQsIHNvIHRoZSByaWdodCBpbmNsdWRlCisgICAgICAgIHBhdGhz
IGFyZSBhZGRlZC4KKworICAgICAgICAqIFdlYkNvcmUucHJpOgorCiAyMDEzLTAzLTExICBLZW50
IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KIAogICAgICAgICBJbmFwcHJvcHJpYXRlIHZh
bGlkYXRpb24gbWVzc2FnZSBmb3IgcmVxdWlyZWQgbnVtYmVyL2RhdGUgaW5wdXQgZWxlbWVudHMK
ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUucHJpIGIvU291cmNlL1dlYkNvcmUv
V2ViQ29yZS5wcmkKaW5kZXggNGZiYWY5Yy4uZGJkY2ZjZSAxMDA2NDQKLS0tIGEvU291cmNlL1dl
YkNvcmUvV2ViQ29yZS5wcmkKKysrIGIvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5wcmkKQEAgLTI0
MSw3ICsyNDEsNyBAQCB1c2U/KDNEX0dSQVBISUNTKSB7CiAgICAgICAgICAgICB9CiAgICAgICAg
IH0KICAgICB9IGVsc2UgewotICAgICAgICBjb250YWlucyhRVF9DT05GSUcsIG9wZW5nbGVzMik6
IExJQlMgKz0gLWxFR0wKKyAgICAgICAgY29udGFpbnMoUVRfQ09ORklHLCBvcGVuZ2xlczIpOiBD
T05GSUcgKz0gZWdsCiAgICAgfQogfQogCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>