111848 2013-03-08 05:30:21 -0800 [GTK] Add webkit_web_context_set_disk_cache_directory to WebKit2 GTK+ API 2013-04-22 09:02:23 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 111845 113036 1 cgarcia webkit-unassigned andersca benjamin danw gustavo gyuyoung.kim mrobinson rakuco svillar webkit.review.bot xan.lopez oldest_to_newest 851098 0 cgarcia 2013-03-08 05:30:21 -0800 ssia 851100 1 192205 cgarcia 2013-03-08 05:32:49 -0800 Created attachment 192205 Patch 851103 2 webkit.review.bot 2013-03-08 05:38:23 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 852256 3 192205 gustavo 2013-03-11 07:03:56 -0700 Comment on attachment 192205 Patch This API looks straightforward enough for me, looks good 852261 4 cgarcia 2013-03-11 07:07:40 -0700 (In reply to comment #3) > (From update of attachment 192205 [details]) > This API looks straightforward enough for me, looks good Thanks for the review, this is useless until bug #111845 is fixed, though. 862338 5 192205 cgarcia 2013-03-24 03:36:11 -0700 Comment on attachment 192205 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=192205&action=review > Source/WebKit2/UIProcess/API/gtk/tests/TestMain.cpp:47 > + GOwnPtr<char> filePath(g_build_filename(directoryPath, fileName, 0)); Auto-review reminder :-P This should be NULL instead of 0, since it's a sentinel. 879190 6 cgarcia 2013-04-22 09:02:23 -0700 Committed r148887: <http://trac.webkit.org/changeset/148887> 192205 2013-03-08 05:32:49 -0800 2013-04-22 08:04:34 -0700 Patch wk2-set-disk-cache.diff text/plain 5062 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA3Mzk2OWNmLi45ZjVjNjNkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIg QEAKKzIwMTMtMDMtMDggIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdIEFkZCB3ZWJraXRfd2ViX2NvbnRleHRfc2V0X2Rpc2tfY2FjaGVf ZGlyZWN0b3J5IHRvIFdlYktpdDIgR1RLKyBBUEkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTExMTg0OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgYWxsb3cgYXBwbGljYXRpb25zIHRvIHNldCBhIGN1 c3RvbSBkaXJlY3RvcnkgZm9yIHRoZSBkaXNrCisgICAgICAgIGNhY2hlLgorCisgICAgICAgICog VUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViQ29udGV4dC5jcHA6CisgICAgICAgICh3ZWJraXRf d2ViX2NvbnRleHRfc2V0X2Rpc2tfY2FjaGVfZGlyZWN0b3J5KToKKyAgICAgICAgKiBVSVByb2Nl c3MvQVBJL2d0ay9XZWJLaXRXZWJDb250ZXh0Lmg6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9n dGsvZG9jcy93ZWJraXQyZ3RrLXNlY3Rpb25zLnR4dDogQWRkIG5ldyBzeW1ib2wuCisgICAgICAg ICogVUlQcm9jZXNzL0FQSS9ndGsvdGVzdHMvVGVzdE1haW4uY3BwOgorICAgICAgICAocmVtb3Zl Tm9uRW1wdHlEaXJlY3RvcnkpOgorICAgICAgICAobWFpbik6IFVzZSBhIGRpZmZlcmVudCB0ZW1w b3JhcnkgZGlzayBjYWNoZSBkaXJlY3RvcnkgZm9yIGV2ZXJ5CisgICAgICAgIHRlc3QuCisKIDIw MTMtMDMtMDYgIFN1ZGFyc2FuYSBOYWdpbmVuaSAgPHN1ZGFyc2FuYS5uYWdpbmVuaUBpbnRlbC5j b20+CiAKICAgICAgICAgW0dUS11bV0syXSBJbXBsZW1lbnQgV2ViSW5zcGVjdG9yOjpsb2NhbGl6 ZWRTdHJpbmdzVVJMKCkgdG8gcmV0dXJuIHRoZSBmaWxlIFVSTCBvZiBsb2NhbGl6ZWRTdHJpbmdz LmpzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRX ZWJDb250ZXh0LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdl YkNvbnRleHQuY3BwCmluZGV4IGJkMzg2NDguLmU5ZDMxOTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYkNvbnRleHQuY3BwCisrKyBiL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYkNvbnRleHQuY3BwCkBAIC03NzQs NiArNzc0LDIzIEBAIHZvaWQgd2Via2l0X3dlYl9jb250ZXh0X3NldF93ZWJfZXh0ZW5zaW9uc19k aXJlY3RvcnkoV2ViS2l0V2ViQ29udGV4dCogY29udGV4dCwKIH0KIAogLyoqCisgKiB3ZWJraXRf d2ViX2NvbnRleHRfc2V0X2Rpc2tfY2FjaGVfZGlyZWN0b3J5OgorICogQGNvbnRleHQ6IGEgI1dl YktpdFdlYkNvbnRleHQKKyAqIEBkaXJlY3Rvcnk6IHRoZSBkaXJlY3RvcnkgdG8gc2V0CisgKgor ICogU2V0IHRoZSBkaXJlY3Rvcnkgd2hlcmUgZGlzayBjYWNoZSBmaWxlcyB3aWxsIGJlIHN0b3Jl ZAorICogVGhpcyBtZXRob2QgbXVzdCBiZSBjYWxsZWQgYmVmb3JlIGxvYWRpbmcgYW55dGhpbmcg aW4gdGhpcyBjb250ZXh0LCBvdGhlcndpc2UKKyAqIGl0IHdpbGwgbm90IGhhdmUgYW55IGVmZmVj dC4KKyAqLwordm9pZCB3ZWJraXRfd2ViX2NvbnRleHRfc2V0X2Rpc2tfY2FjaGVfZGlyZWN0b3J5 KFdlYktpdFdlYkNvbnRleHQqIGNvbnRleHQsIGNvbnN0IGNoYXIqIGRpcmVjdG9yeSkKK3sKKyAg ICBnX3JldHVybl9pZl9mYWlsKFdFQktJVF9JU19XRUJfQ09OVEVYVChjb250ZXh0KSk7CisgICAg Z19yZXR1cm5faWZfZmFpbChkaXJlY3RvcnkpOworCisgICAgY29udGV4dC0+cHJpdi0+Y29udGV4 dC0+c2V0RGlza0NhY2hlRGlyZWN0b3J5KFdlYkNvcmU6OmZpbGVuYW1lVG9TdHJpbmcoZGlyZWN0 b3J5KSk7Cit9CisKKy8qKgogICogd2Via2l0X3dlYl9jb250ZXh0X3ByZWZldGNoX2RuczoKICAq IEBjb250ZXh0OiBhICNXZWJLaXRXZWJDb250ZXh0CiAgKiBAaG9zdG5hbWU6IGEgaG9zdG5hbWUg dG8gYmUgcmVzb2x2ZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv Z3RrL1dlYktpdFdlYkNvbnRleHQuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3Rr L1dlYktpdFdlYkNvbnRleHQuaAppbmRleCAwZjIwN2ExLi5jMjNkZDhhIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJDb250ZXh0LmgKKysrIGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViQ29udGV4dC5oCkBAIC0x OTIsNiArMTkyLDEwIEBAIFdFQktJVF9BUEkgdm9pZAogd2Via2l0X3dlYl9jb250ZXh0X3ByZWZl dGNoX2RucyAgICAgICAgICAgICAgICAgICAgIChXZWJLaXRXZWJDb250ZXh0ICAgICAgICAgICAg ICAqY29udGV4dCwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgY29uc3QgZ2NoYXIgICAgICAgICAgICAgICAgICAgKmhvc3RuYW1lKTsKIAorV0VC S0lUX0FQSSB2b2lkCit3ZWJraXRfd2ViX2NvbnRleHRfc2V0X2Rpc2tfY2FjaGVfZGlyZWN0b3J5 ICAgICAgICAgKFdlYktpdFdlYkNvbnRleHQgICAgICAgICAgICAgICpjb250ZXh0LAorICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBnY2hh ciAgICAgICAgICAgICAgICAgICAqZGlyZWN0b3J5KTsKKwogR19FTkRfREVDTFMKIAogI2VuZGlm CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9kb2NzL3dlYmtp dDJndGstc2VjdGlvbnMudHh0IGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvZG9j cy93ZWJraXQyZ3RrLXNlY3Rpb25zLnR4dAppbmRleCA1ZDhiYjQxLi5jMzg1ODM2IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9kb2NzL3dlYmtpdDJndGstc2Vj dGlvbnMudHh0CisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL2RvY3Mvd2Vi a2l0Mmd0ay1zZWN0aW9ucy50eHQKQEAgLTQ3LDYgKzQ3LDcgQEAgd2Via2l0X3dlYl9jb250ZXh0 X3NldF90bHNfZXJyb3JzX3BvbGljeQogd2Via2l0X3dlYl9jb250ZXh0X2dldF90bHNfZXJyb3Jz X3BvbGljeQogd2Via2l0X3dlYl9jb250ZXh0X3NldF93ZWJfZXh0ZW5zaW9uc19kaXJlY3RvcnkK IHdlYmtpdF93ZWJfY29udGV4dF9wcmVmZXRjaF9kbnMKK3dlYmtpdF93ZWJfY29udGV4dF9zZXRf ZGlza19jYWNoZV9kaXJlY3RvcnkKIAogPFNVQlNFQ1RJT04gVVJJIFNjaGVtZT4KIFdlYktpdFVS SVNjaGVtZVJlcXVlc3RDYWxsYmFjawpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9ndGsvdGVzdHMvVGVzdE1haW4uY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9ndGsvdGVzdHMvVGVzdE1haW4uY3BwCmluZGV4IGMxZGNlNzMuLjFjYmMyZjMgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL3Rlc3RzL1Rlc3RNYWluLmNw cAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay90ZXN0cy9UZXN0TWFpbi5j cHAKQEAgLTIwLDcgKzIwLDEwIEBACiAjaW5jbHVkZSAiY29uZmlnLmgiCiAjaW5jbHVkZSAiVGVz dE1haW4uaCIKIAorI2luY2x1ZGUgPGdsaWIvZ3N0ZGlvLmg+CiAjaW5jbHVkZSA8Z3RrL2d0ay5o PgorI2luY2x1ZGUgPHdlYmtpdDIvd2Via2l0Mi5oPgorI2luY2x1ZGUgPHd0Zi9nb2JqZWN0L0dP d25QdHIuaD4KIAogdm9pZCBiZWZvcmVBbGwoKTsKIHZvaWQgYWZ0ZXJBbGwoKTsKQEAgLTM1LDYg KzM4LDE5IEBAIHN0YXRpYyB2b2lkIHJlZ2lzdGVyR1Jlc291cmNlKHZvaWQpCiAgICAgZ19yZXNv dXJjZV91bnJlZihyZXNvdXJjZSk7CiB9CiAKK3N0YXRpYyB2b2lkIHJlbW92ZU5vbkVtcHR5RGly ZWN0b3J5KGNvbnN0IGNoYXIqIGRpcmVjdG9yeVBhdGgpCit7CisgICAgR0RpciogZGlyZWN0b3J5 ID0gZ19kaXJfb3BlbihkaXJlY3RvcnlQYXRoLCAwLCAwKTsKKyAgICBnX2Fzc2VydChkaXJlY3Rv cnkpOworICAgIGNvbnN0IGNoYXIqIGZpbGVOYW1lOworICAgIHdoaWxlICgoZmlsZU5hbWUgPSBn X2Rpcl9yZWFkX25hbWUoZGlyZWN0b3J5KSkpIHsKKyAgICAgICAgR093blB0cjxjaGFyPiBmaWxl UGF0aChnX2J1aWxkX2ZpbGVuYW1lKGRpcmVjdG9yeVBhdGgsIGZpbGVOYW1lLCAwKSk7CisgICAg ICAgIGdfdW5saW5rKGZpbGVQYXRoLmdldCgpKTsKKyAgICB9CisgICAgZ19kaXJfY2xvc2UoZGly ZWN0b3J5KTsKKyAgICBnX3JtZGlyKGRpcmVjdG9yeVBhdGgpOworfQorCiBpbnQgbWFpbihpbnQg YXJnYywgY2hhcioqIGFyZ3YpCiB7CiAgICAgZ3RrX3Rlc3RfaW5pdCgmYXJnYywgJmFyZ3YsIDAp OwpAQCAtNDQsOSArNjAsMTUgQEAgaW50IG1haW4oaW50IGFyZ2MsIGNoYXIqKiBhcmd2KQogCiAg ICAgcmVnaXN0ZXJHUmVzb3VyY2UoKTsKIAorICAgIEdPd25QdHI8Y2hhcj4gZGlza0NhY2hlVGVt cERpcmVjdG9yeShnX2Rpcl9tYWtlX3RtcCgiV2ViS2l0MlRlc3RzRGlza0NhY2hlLVhYWFhYWCIs IDApKTsKKyAgICBnX2Fzc2VydChkaXNrQ2FjaGVUZW1wRGlyZWN0b3J5LmdldCgpKTsKKyAgICB3 ZWJraXRfd2ViX2NvbnRleHRfc2V0X2Rpc2tfY2FjaGVfZGlyZWN0b3J5KHdlYmtpdF93ZWJfY29u dGV4dF9nZXRfZGVmYXVsdCgpLCBkaXNrQ2FjaGVUZW1wRGlyZWN0b3J5LmdldCgpKTsKKwogICAg IGJlZm9yZUFsbCgpOwogICAgIGludCByZXR1cm5WYWx1ZSA9IGdfdGVzdF9ydW4oKTsKICAgICBh ZnRlckFsbCgpOwogCisgICAgcmVtb3ZlTm9uRW1wdHlEaXJlY3RvcnkoZGlza0NhY2hlVGVtcERp cmVjdG9yeS5nZXQoKSk7CisKICAgICByZXR1cm4gcmV0dXJuVmFsdWU7CiB9Cg==