111844 2013-03-08 04:27:59 -0800 [Curl] POST requests sometimes fail. 2013-05-07 12:34:17 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC All RESOLVED FIXED https://bugs.webkit.org/ Curl P2 Normal --- 0 peavo webkit-unassigned ap bfulgham commit-queue peavo oldest_to_newest 851068 0 peavo 2013-03-08 04:27:59 -0800 Curl adds the header 'Expect: 100-Continue' when sending a POST request. When we receive the header 'HTTP/1.1 100 Continue' we should not call ResourceHandleClient::didReceiveResponse(), as the request might be cancelled because the MIME type is empty in this case. 851073 1 192200 peavo 2013-03-08 04:38:18 -0800 Created attachment 192200 Patch 853430 2 peavo 2013-03-12 07:14:50 -0700 A good way to reproduce this, is to create a new bug at https://bugs.webkit.org/. When clicking the commit button after filling in the various fields, the POST request sent is always failing for me. 885695 3 200899 peavo 2013-05-07 07:09:17 -0700 Created attachment 200899 Patch 885702 4 peavo 2013-05-07 07:17:38 -0700 Modified the patch slightly, inspired by the blackberry port. The blackberry port also ignores http code 100 (and other info codes), see the method NetworkJob::handleNotifyStatusReceived() in WebCore\platform\network\blackberry\NetworkJob.cpp. The blackberry port also doesn't classify http code 304 (Not modified) as a redirect. I did the same thing for Curl, now the 304 code is reported as a response (ResourceHandleClient::didReceiveResponse() is called). 885731 5 200899 bfulgham 2013-05-07 08:26:09 -0700 Comment on attachment 200899 Patch Looks great! 885745 6 200899 commit-queue 2013-05-07 08:52:47 -0700 Comment on attachment 200899 Patch Clearing flags on attachment: 200899 Committed r149672: <http://trac.webkit.org/changeset/149672> 885746 7 commit-queue 2013-05-07 08:52:49 -0700 All reviewed patches have been landed. Closing bug. 885919 8 peavo 2013-05-07 12:34:17 -0700 (In reply to comment #5) > (From update of attachment 200899 [details]) > Looks great! Thanks for the review ;) 192200 2013-03-08 04:38:18 -0800 2013-05-07 07:09:09 -0700 Patch bug-111844-20130308133347.patch text/plain 1695 peavo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0NTIwOCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEzLTAzLTA4ICBwZWF2b0Bv dXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgorCisgICAgICAgIFtDdXJsXSBQT1NUIHJl cXVlc3RzIHNvbWV0aW1lcyBmYWlsLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTExODQ0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgQ3VybCBhZGRzIHRoZSBoZWFkZXIgJ0V4cGVjdDogMTAwLUNvbnRpbnVl JyB3aGVuIHNlbmRpbmcgYSBQT1NUIHJlcXVlc3QuCisgICAgICAgIFdoZW4gd2UgcmVjZWl2ZSB0 aGUgaGVhZGVyICdIVFRQLzEuMSAxMDAgQ29udGludWUnIHdlIHNob3VsZCBub3QgY2FsbAorICAg ICAgICBSZXNvdXJjZUhhbmRsZUNsaWVudDo6ZGlkUmVjZWl2ZVJlc3BvbnNlKCksIGFzIHRoZSBy ZXF1ZXN0IG1pZ2h0IGJlCisgICAgICAgIGNhbmNlbGxlZCBiZWNhdXNlIHRoZSBNSU1FIHR5cGUg aXMgZW1wdHkgaW4gdGhpcyBjYXNlLgorICAgICAgICAKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3 b3JrL2N1cmwvUmVzb3VyY2VIYW5kbGVNYW5hZ2VyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Omhl YWRlckNhbGxiYWNrKTogSnVzdCByZXR1cm4gd2hlbiByZWNlaXZpbmcgJ0hUVFAvMS4xIDEwMCBD b250aW51ZScuCisKIDIwMTMtMDMtMDggIEh1YW5nIERvbmdzdW5nICA8bHV4dGVsbGFAY29tcGFu eTEwMC5uZXQ+CiAKICAgICAgICAgW0VGTF1bUXRdIFJFR1JFU1NJT04ocjE0NDc4Nyk6IEEgZml4 ZWQgZWxlbWVudCBsYWdzIHdoZW4gc2Nyb2xsaW5nIGFuZCB3aGVlbGluZy4KSW5kZXg6IFNvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3VybC9SZXNvdXJjZUhhbmRsZU1hbmFnZXIuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3VybC9SZXNv dXJjZUhhbmRsZU1hbmFnZXIuY3BwCShyZXZpc2lvbiAxNDUwNDIpCisrKyBTb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwvUmVzb3VyY2VIYW5kbGVNYW5hZ2VyLmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtMjk1LDYgKzI5NSwxMCBAQCBzdGF0aWMgc2l6ZV90IGhlYWRlckNhbGxiYWNr KGNoYXIqIHB0ciwKIAogICAgICAgICAgICAgICAgIHJldHVybiB0b3RhbFNpemU7CiAgICAgICAg ICAgICB9CisgICAgICAgIH0gZWxzZSBpZiAoaHR0cENvZGUgPT0gMTAwKSB7CisgICAgICAgICAg ICAvLyBKdXN0IHJldHVybiB3aGVuIHJlY2VpdmluZyBIVFRQLzEuMSAxMDAgQ29udGludWUuCisg ICAgICAgICAgICAvLyBJZiBub3QsIHRoZSByZXF1ZXN0IG1pZ2h0IGJlIGNhbmNlbGxlZCwgYmVj YXVzZSB0aGUgTUlNRSB0eXBlIHdpbGwgYmUgZW1wdHkuCisgICAgICAgICAgICByZXR1cm4gdG90 YWxTaXplOwogICAgICAgICB9CiAKICAgICAgICAgaWYgKGNsaWVudCkK 200899 2013-05-07 07:09:17 -0700 2013-05-07 08:52:47 -0700 Patch bug-111844-20130507160817.patch text/plain 4095 peavo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0OTY2NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI1IEBACisyMDEzLTA1LTA3ICBwZWF2b0Bv dXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgorCisgICAgICAgIFtDdXJsXSBQT1NUIHJl cXVlc3RzIHNvbWV0aW1lcyBmYWlsLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTExODQ0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgQ3VybCBhZGRzIHRoZSBoZWFkZXIgJ0V4cGVjdDogMTAwLUNvbnRpbnVl JyB3aGVuIHNlbmRpbmcgYSBQT1NUIHJlcXVlc3QuCisgICAgICAgIFdoZW4gd2UgcmVjZWl2ZSB0 aGUgaGVhZGVyICdIVFRQLzEuMSAxMDAgQ29udGludWUnLCB3ZSBzaG91bGQgbm90IGNhbGwKKyAg ICAgICAgUmVzb3VyY2VIYW5kbGVDbGllbnQ6OmRpZFJlY2VpdmVSZXNwb25zZSgpLCBhcyB0aGlz IHdpbGwgY2FuY2VsIHRoZSByZXF1ZXN0LAorICAgICAgICBiZWNhdXNlIHRoZSBNSU1FIHR5cGUg aXMgZW1wdHkgaW4gdGhpcyBjYXNlLCBjYXVzaW5nIHRoZSBQT1NUIHJlcXVlc3QgdG8gZmFpbC4K KyAgICAgICAgVGhpcyBoZWFkZXIgaXMgb25seSBzZW50IGFzIGFuIGluZm8gaGVhZGVyLCBvciBw cm92aXNpb25hbCByZXNwb25zZS4KKyAgICAgICAgCisgICAgICAgIEluIGFkZGl0aW9uLCB0aGlz IHBhdGNoIGNoYW5nZXMgdGhlIGNsYXNzaWZpY2F0aW9uIG9mIGh0dHAgY29kZSAzMDQgKE5vdCBt b2RpZmllZCkuCisgICAgICAgIEl0IGlzIG5vdCByZXBvcnRlZCBhcyBhIHJlZGlyZWN0IGFueW1v cmUsIGJ1dCBhcyBhIHJlc3BvbnNlCisgICAgICAgIChSZXNvdXJjZUhhbmRsZUNsaWVudDo6ZGlk UmVjZWl2ZVJlc3BvbnNlKCkgaXMgY2FsbGVkLgorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29y ay9jdXJsL1Jlc291cmNlSGFuZGxlTWFuYWdlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjppc0h0 dHBJbmZvKTogQWRkZWQgaGVscGVyIG1ldGhvZCB0byBkZXRlcm1pbmUgaWYgaHR0cCBjb2RlIGlz IGh0dHAgaW5mby4KKyAgICAgICAgKFdlYkNvcmU6OmlzSHR0cFJlZGlyZWN0KTogQWRkZWQgaGVs cGVyIG1ldGhvZCB0byBkZXRlcm1pbmUgaWYgaHR0cCBjb2RlIGlzIGh0dHAgcmVkaXJlY3QuCisg ICAgICAgIChXZWJDb3JlOjpoZWFkZXJDYWxsYmFjayk6IEp1c3QgcmV0dXJuIHdoZW4gcmVjZWl2 aW5nIHRoZSBoZWFkZXInSFRUUC8xLjEgMTAwIENvbnRpbnVlJy4KKwogMjAxMy0wNS0wNyAgTWlr aGFpbCBQb3pkbnlha292ICA8bWlraGFpbC5wb3pkbnlha292QGludGVsLmNvbT4KIAogICAgICAg ICBIYXNoVHJhaXRzPFJlZlB0cjxQPiA+OjpQZWVrVHlwZSBzaG91bGQgYmUgcmF3IHBvaW50ZXIg Zm9yIGJldHRlciBwZXJmb3JtYW5jZQpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0 d29yay9jdXJsL1Jlc291cmNlSGFuZGxlTWFuYWdlci5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJsL1Jlc291cmNlSGFuZGxlTWFuYWdlci5jcHAJ KHJldmlzaW9uIDE0OTU4NikKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3Vy bC9SZXNvdXJjZUhhbmRsZU1hbmFnZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMjYsNiArMTI2 LDE2IEBAIHN0YXRpYyB2b2lkIGN1cmxfdW5sb2NrX2NhbGxiYWNrKENVUkwqIGgKICAgICAgICAg bXV0ZXgtPnVubG9jaygpOwogfQogCitpbmxpbmUgc3RhdGljIGJvb2wgaXNIdHRwSW5mbyhpbnQg c3RhdHVzQ29kZSkKK3sKKyAgICByZXR1cm4gMTAwIDw9IHN0YXR1c0NvZGUgJiYgc3RhdHVzQ29k ZSA8IDIwMDsKK30KKworaW5saW5lIHN0YXRpYyBib29sIGlzSHR0cFJlZGlyZWN0KGludCBzdGF0 dXNDb2RlKQoreworICAgIHJldHVybiAzMDAgPD0gc3RhdHVzQ29kZSAmJiBzdGF0dXNDb2RlIDwg NDAwICYmIHN0YXR1c0NvZGUgIT0gMzA0OworfQorCiBSZXNvdXJjZUhhbmRsZU1hbmFnZXI6OlJl c291cmNlSGFuZGxlTWFuYWdlcigpCiAgICAgOiBtX2Rvd25sb2FkVGltZXIodGhpcywgJlJlc291 cmNlSGFuZGxlTWFuYWdlcjo6ZG93bmxvYWRUaW1lckNhbGxiYWNrKQogICAgICwgbV9jb29raWVK YXJGaWxlTmFtZShjb29raWVKYXJQYXRoKCkpCkBAIC0yNjQsNiArMjc0LDE1IEBAIHN0YXRpYyBz aXplX3QgaGVhZGVyQ2FsbGJhY2soY2hhciogcHRyLAogICAgICAgICBDVVJMKiBoID0gZC0+bV9o YW5kbGU7CiAgICAgICAgIENVUkxjb2RlIGVycjsKIAorICAgICAgICBsb25nIGh0dHBDb2RlID0g MDsKKyAgICAgICAgZXJyID0gY3VybF9lYXN5X2dldGluZm8oaCwgQ1VSTElORk9fUkVTUE9OU0Vf Q09ERSwgJmh0dHBDb2RlKTsKKworICAgICAgICBpZiAoaXNIdHRwSW5mbyhodHRwQ29kZSkpIHsK KyAgICAgICAgICAgIC8vIEp1c3QgcmV0dXJuIHdoZW4gcmVjZWl2aW5nIGh0dHAgaW5mbywgZS5n LiBIVFRQLzEuMSAxMDAgQ29udGludWUuCisgICAgICAgICAgICAvLyBJZiBub3QsIHRoZSByZXF1 ZXN0IG1pZ2h0IGJlIGNhbmNlbGxlZCwgYmVjYXVzZSB0aGUgTUlNRSB0eXBlIHdpbGwgYmUgZW1w dHkgZm9yIHRoaXMgcmVzcG9uc2UuCisgICAgICAgICAgICByZXR1cm4gdG90YWxTaXplOworICAg ICAgICB9CisKICAgICAgICAgZG91YmxlIGNvbnRlbnRMZW5ndGggPSAwOwogICAgICAgICBlcnIg PSBjdXJsX2Vhc3lfZ2V0aW5mbyhoLCBDVVJMSU5GT19DT05URU5UX0xFTkdUSF9ET1dOTE9BRCwg JmNvbnRlbnRMZW5ndGgpOwogICAgICAgICBkLT5tX3Jlc3BvbnNlLnNldEV4cGVjdGVkQ29udGVu dExlbmd0aChzdGF0aWNfY2FzdDxsb25nIGxvbmcgaW50Pihjb250ZW50TGVuZ3RoKSk7CkBAIC0y NzIsMTYgKzI5MSwxMyBAQCBzdGF0aWMgc2l6ZV90IGhlYWRlckNhbGxiYWNrKGNoYXIqIHB0ciwK ICAgICAgICAgZXJyID0gY3VybF9lYXN5X2dldGluZm8oaCwgQ1VSTElORk9fRUZGRUNUSVZFX1VS TCwgJmhkcik7CiAgICAgICAgIGQtPm1fcmVzcG9uc2Uuc2V0VVJMKEtVUkwoUGFyc2VkVVJMU3Ry aW5nLCBoZHIpKTsKIAotICAgICAgICBsb25nIGh0dHBDb2RlID0gMDsKLSAgICAgICAgZXJyID0g Y3VybF9lYXN5X2dldGluZm8oaCwgQ1VSTElORk9fUkVTUE9OU0VfQ09ERSwgJmh0dHBDb2RlKTsK ICAgICAgICAgZC0+bV9yZXNwb25zZS5zZXRIVFRQU3RhdHVzQ29kZShodHRwQ29kZSk7Ci0KICAg ICAgICAgZC0+bV9yZXNwb25zZS5zZXRNaW1lVHlwZShleHRyYWN0TUlNRVR5cGVGcm9tTWVkaWFU eXBlKGQtPm1fcmVzcG9uc2UuaHR0cEhlYWRlckZpZWxkKCJDb250ZW50LVR5cGUiKSkpOwogICAg ICAgICBkLT5tX3Jlc3BvbnNlLnNldFRleHRFbmNvZGluZ05hbWUoZXh0cmFjdENoYXJzZXRGcm9t TWVkaWFUeXBlKGQtPm1fcmVzcG9uc2UuaHR0cEhlYWRlckZpZWxkKCJDb250ZW50LVR5cGUiKSkp OwogICAgICAgICBkLT5tX3Jlc3BvbnNlLnNldFN1Z2dlc3RlZEZpbGVuYW1lKGZpbGVuYW1lRnJv bUhUVFBDb250ZW50RGlzcG9zaXRpb24oZC0+bV9yZXNwb25zZS5odHRwSGVhZGVyRmllbGQoIkNv bnRlbnQtRGlzcG9zaXRpb24iKSkpOwogCiAgICAgICAgIC8vIEhUVFAgcmVkaXJlY3Rpb24KLSAg ICAgICAgaWYgKGh0dHBDb2RlID49IDMwMCAmJiBodHRwQ29kZSA8IDQwMCkgeworICAgICAgICBp ZiAoaXNIdHRwUmVkaXJlY3QoaHR0cENvZGUpKSB7CiAgICAgICAgICAgICBTdHJpbmcgbG9jYXRp b24gPSBkLT5tX3Jlc3BvbnNlLmh0dHBIZWFkZXJGaWVsZCgibG9jYXRpb24iKTsKICAgICAgICAg ICAgIGlmICghbG9jYXRpb24uaXNFbXB0eSgpKSB7CiAgICAgICAgICAgICAgICAgS1VSTCBuZXdV UkwgPSBLVVJMKGpvYi0+Zmlyc3RSZXF1ZXN0KCkudXJsKCksIGxvY2F0aW9uKTsK