111835 2013-03-08 02:24:50 -0800 Coordinated Graphics: Remove CoordinatedGraphicsLayer::setRootLayer(). 2013-03-12 18:53:32 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 111829 1 dongseong.hwang dongseong.hwang benjamin cmarcelo luiz noam webkit.review.bot zeno oldest_to_newest 851019 0 dongseong.hwang 2013-03-08 02:24:50 -0800 This patch removes CoordinatedGraphicsLayer::setRootLayer() because CoordinatedGraphicsScene already knows which layer is root. 851022 1 192186 dongseong.hwang 2013-03-08 02:27:16 -0800 Created attachment 192186 Patch 851024 2 dongseong.hwang 2013-03-08 02:28:40 -0800 I think WK2 part is trivial change that Sam mentioned. Do you think WK2 owner sign is needed? 851029 3 192186 noam 2013-03-08 02:35:35 -0800 Comment on attachment 192186 Patch LGTM, still needs a WK2 owner review. 853952 4 192186 benjamin 2013-03-12 18:06:05 -0700 Comment on attachment 192186 Patch Signed off by me. 853986 5 192186 webkit.review.bot 2013-03-12 18:53:29 -0700 Comment on attachment 192186 Patch Clearing flags on attachment: 192186 Committed r145670: <http://trac.webkit.org/changeset/145670> 853987 6 webkit.review.bot 2013-03-12 18:53:32 -0700 All reviewed patches have been landed. Closing bug. 192186 2013-03-08 02:27:16 -0800 2013-03-12 18:53:28 -0700 Patch bug-111835-20130308192237.patch text/plain 6707 dongseong.hwang U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1MTc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTIwZmM5MTA2YjVhNTEy MGFhYjExZWUyYzcxODgzNTQxODgwNzhlNi4uYjQ2YzVmNjVkZmZmNjhmNzhkMTE1YzJiZDRhZjMz ZjhjYWMyNTAwNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEzLTAzLTA4ICBIdWFu ZyBEb25nc3VuZyAgPGx1eHRlbGxhQGNvbXBhbnkxMDAubmV0PgorCisgICAgICAgIENvb3JkaW5h dGVkIEdyYXBoaWNzOiBSZW1vdmUgQ29vcmRpbmF0ZWRHcmFwaGljc0xheWVyOjpzZXRSb290TGF5 ZXIoKS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEx MTgzNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRo aXMgcGF0Y2ggcmVtb3ZlcyBDb29yZGluYXRlZEdyYXBoaWNzTGF5ZXI6OnNldFJvb3RMYXllcigp IGJlY2F1c2UKKyAgICAgICAgQ29vcmRpbmF0ZWRHcmFwaGljc1NjZW5lIGFscmVhZHkga25vd3Mg d2hpY2ggbGF5ZXIgaXMgcm9vdC4KKworICAgICAgICBObyBuZXcgdGVzdHMsIG5vIGJlaGF2aW9y IGNoYW5nZS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9jb29yZGluYXRl ZC9Db29yZGluYXRlZEdyYXBoaWNzTGF5ZXIuY3BwOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBo aWNzL3RleG1hcC9jb29yZGluYXRlZC9Db29yZGluYXRlZEdyYXBoaWNzTGF5ZXIuaDoKKyAgICAg ICAgKENvb3JkaW5hdGVkR3JhcGhpY3NMYXllcik6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhp Y3MvdGV4bWFwL2Nvb3JkaW5hdGVkL0Nvb3JkaW5hdGVkR3JhcGhpY3NTY2VuZS5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpDb29yZGluYXRlZEdyYXBoaWNzU2NlbmU6OnNldExheWVyU3RhdGUpOgor ICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9jb29yZGluYXRlZC9Db29yZGluYXRl ZEdyYXBoaWNzU3RhdGUuaDoKKyAgICAgICAgKFdlYkNvcmU6OkNvb3JkaW5hdGVkR3JhcGhpY3NM YXllclN0YXRlOjpDb29yZGluYXRlZEdyYXBoaWNzTGF5ZXJTdGF0ZSk6CisKIDIwMTMtMDMtMDYg IEh1YW5nIERvbmdzdW5nICA8bHV4dGVsbGFAY29tcGFueTEwMC5uZXQ+CiAKICAgICAgICAgQ2xh cmlmeSB0aGUgc2l6ZSBvZiBhIGRvY3VtZW50IHZpZXcgdGhhdCBjYXVzZXMgRnJhbWVWaWV3IHRv IGVtaXQgdGhlIHJlc2l6ZSBldmVudC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCBlN2M5NjdhZTU5NTA5MjYwOWRk OTExMmZlOTY5NDZkNDdmNzY5ZjkyLi42NjBjYjIwYmU2NDBjNWEwNDVmOWI1ZmZhMDdjYWYxZjgx ZGNkOTc5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNl L1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTMtMDMtMDggIEh1YW5nIERv bmdzdW5nICA8bHV4dGVsbGFAY29tcGFueTEwMC5uZXQ+CisKKyAgICAgICAgQ29vcmRpbmF0ZWQg R3JhcGhpY3M6IFJlbW92ZSBDb29yZGluYXRlZEdyYXBoaWNzTGF5ZXI6OnNldFJvb3RMYXllcigp LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTExODM1 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQW1lbmQg Q29vcmRpbmF0ZWRMYXllclRyZWVIb3N0IGJlY2F1c2UKKyAgICAgICAgQ29vcmRpbmF0ZWRHcmFw aGljc0xheWVyOjpzZXRSb290TGF5ZXIoKSBpcyByZW1vdmVkLgorCisgICAgICAgICogV2ViUHJv Y2Vzcy9XZWJQYWdlL0Nvb3JkaW5hdGVkR3JhcGhpY3MvQ29vcmRpbmF0ZWRMYXllclRyZWVIb3N0 LmNwcDoKKyAgICAgICAgKFdlYktpdDo6Q29vcmRpbmF0ZWRMYXllclRyZWVIb3N0OjpDb29yZGlu YXRlZExheWVyVHJlZUhvc3QpOgorCiAyMDEzLTAzLTA0ICBIdWFuZyBEb25nc3VuZyAgPGx1eHRl bGxhQGNvbXBhbnkxMDAubmV0PgogCiAgICAgICAgIFtXSzJdIFVzZSBjYW5IYXZlU2Nyb2xsYmFy cygpIG9yIHVzZUZpeGVkTGF5b3V0KCkgaW5zdGVhZCBvZiBkZWxlZ2F0ZXNTY3JvbGxpbmcoKS4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9jb29y ZGluYXRlZC9Db29yZGluYXRlZEdyYXBoaWNzTGF5ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvdGV4bWFwL2Nvb3JkaW5hdGVkL0Nvb3JkaW5hdGVkR3JhcGhpY3NMYXll ci5jcHAKaW5kZXggNTQzN2FjNTU0MzhjYzU0MTRmMTc2YjkzYTBlM2ZlOWZmMThlZTRhZC4uMWYx MTZlMDlkMjZjYWU0N2VjMjRjZTUwZmY1NmUyZGE4M2I3NjE1YiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL2Nvb3JkaW5hdGVkL0Nvb3JkaW5hdGVk R3JhcGhpY3NMYXllci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv dGV4bWFwL2Nvb3JkaW5hdGVkL0Nvb3JkaW5hdGVkR3JhcGhpY3NMYXllci5jcHAKQEAgLTc4Nywx MyArNzg3LDYgQEAgdm9pZCBDb29yZGluYXRlZEdyYXBoaWNzTGF5ZXI6OnRpbGVkQmFja2luZ1N0 b3JlUGFpbnRCZWdpbigpCiB7CiB9CiAKLXZvaWQgQ29vcmRpbmF0ZWRHcmFwaGljc0xheWVyOjpz ZXRSb290TGF5ZXIoYm9vbCBpc1Jvb3QpCi17Ci0gICAgbV9sYXllclN0YXRlLmlzUm9vdExheWVy ID0gaXNSb290OwotICAgIG1fbGF5ZXJTdGF0ZS5mbGFnc0NoYW5nZWQgPSB0cnVlOwotICAgIGRp ZENoYW5nZUxheWVyU3RhdGUoKTsKLX0KLQogdm9pZCBDb29yZGluYXRlZEdyYXBoaWNzTGF5ZXI6 OnNldFZpc2libGVDb250ZW50UmVjdFRyYWplY3RvcnlWZWN0b3IoY29uc3QgRmxvYXRQb2ludCYg dHJhamVjdG9yeVZlY3RvcikKIHsKICAgICBpZiAoIW1fbWFpbkJhY2tpbmdTdG9yZSkKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9jb29yZGluYXRl ZC9Db29yZGluYXRlZEdyYXBoaWNzTGF5ZXIuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL3RleG1hcC9jb29yZGluYXRlZC9Db29yZGluYXRlZEdyYXBoaWNzTGF5ZXIuaAppbmRl eCBhMDcwOGRjNTRhMTNjZjM0NThlZWJlNjRmODMwZTIwZGJmMWQ1ZGUyLi40NWJmYjI3M2QxZGQ0 NDdkYWMxYTZkMDAxOGQwYzMwOTBmNzRlMGEwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvY29vcmRpbmF0ZWQvQ29vcmRpbmF0ZWRHcmFwaGljc0xh eWVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL2Nvb3Jk aW5hdGVkL0Nvb3JkaW5hdGVkR3JhcGhpY3NMYXllci5oCkBAIC0xMTQsOCArMTE0LDYgQEAgcHVi bGljOgogCiAgICAgdm9pZCBzZXRWaXNpYmxlQ29udGVudFJlY3RUcmFqZWN0b3J5VmVjdG9yKGNv bnN0IEZsb2F0UG9pbnQmKTsKIAotICAgIHZvaWQgc2V0Um9vdExheWVyKGJvb2wpOwotCiAgICAg dm9pZCBzZXRTY3JvbGxhYmxlQXJlYShTY3JvbGxhYmxlQXJlYSopOwogICAgIGJvb2wgaXNTY3Jv bGxhYmxlKCkgY29uc3QgeyByZXR1cm4gISFtX3Njcm9sbGFibGVBcmVhOyB9CiAgICAgdm9pZCBj b21taXRTY3JvbGxPZmZzZXQoY29uc3QgSW50U2l6ZSYpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL2Nvb3JkaW5hdGVkL0Nvb3JkaW5hdGVkR3Jh cGhpY3NTY2VuZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAv Y29vcmRpbmF0ZWQvQ29vcmRpbmF0ZWRHcmFwaGljc1NjZW5lLmNwcAppbmRleCBhZmMxMWQ5YTdj ZTAzNDEwZGFiZDE3ZjQyYmVlZDk2MjMzYjgyNjAxLi4zMzE3N2Q2MGYzYTllOGRlODdhYjAwMGQ4 NmE1MDU4YTVkODc4OTZiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy90ZXhtYXAvY29vcmRpbmF0ZWQvQ29vcmRpbmF0ZWRHcmFwaGljc1NjZW5lLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvY29vcmRpbmF0ZWQvQ29v cmRpbmF0ZWRHcmFwaGljc1NjZW5lLmNwcApAQCAtMzQ3LDcgKzM0Nyw3IEBAIHZvaWQgQ29vcmRp bmF0ZWRHcmFwaGljc1NjZW5lOjpzZXRMYXllclN0YXRlKENvb3JkaW5hdGVkTGF5ZXJJRCBpZCwg Y29uc3QgQ29vcmRpCiAgICAgICAgIGxheWVyLT5zZXRCYWNrZmFjZVZpc2liaWxpdHkobGF5ZXJT dGF0ZS5iYWNrZmFjZVZpc2libGUpOwogCiAgICAgICAgIC8vIE5ldmVyIGNsaXAgdGhlIHJvb3Qg bGF5ZXIuCi0gICAgICAgIGxheWVyLT5zZXRNYXNrc1RvQm91bmRzKGxheWVyU3RhdGUuaXNSb290 TGF5ZXIgPyBmYWxzZSA6IGxheWVyU3RhdGUubWFza3NUb0JvdW5kcyk7CisgICAgICAgIGxheWVy LT5zZXRNYXNrc1RvQm91bmRzKGlkID09IG1fcm9vdExheWVySUQgPyBmYWxzZSA6IGxheWVyU3Rh dGUubWFza3NUb0JvdW5kcyk7CiAgICAgICAgIGxheWVyLT5zZXRQcmVzZXJ2ZXMzRChsYXllclN0 YXRlLnByZXNlcnZlczNEKTsKIAogICAgICAgICB0b0dyYXBoaWNzTGF5ZXJUZXh0dXJlTWFwcGVy KGxheWVyKS0+c2V0Rml4ZWRUb1ZpZXdwb3J0KGxheWVyU3RhdGUuZml4ZWRUb1ZpZXdwb3J0KTsK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9jb29y ZGluYXRlZC9Db29yZGluYXRlZEdyYXBoaWNzU3RhdGUuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL3RleG1hcC9jb29yZGluYXRlZC9Db29yZGluYXRlZEdyYXBoaWNzU3RhdGUu aAppbmRleCAyOWM4ZTQ1YzdiZDI1OWM5NTAwMWZkZjQyMmEzMGU1ODc0OTcwZGFmLi4wMjVlYzg5 NTgwM2M4MmMzYTEwN2Y2ZWNjNDI1NTE4NTk5MjU5M2Q2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvY29vcmRpbmF0ZWQvQ29vcmRpbmF0ZWRHcmFw aGljc1N0YXRlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFw L2Nvb3JkaW5hdGVkL0Nvb3JkaW5hdGVkR3JhcGhpY3NTdGF0ZS5oCkBAIC0xMDMsNyArMTAzLDYg QEAgc3RydWN0IENvb3JkaW5hdGVkR3JhcGhpY3NMYXllclN0YXRlIHsKICAgICAgICAgICAgIGJv b2wgYmFja2ZhY2VWaXNpYmxlIDogMTsKICAgICAgICAgICAgIGJvb2wgbWFza3NUb0JvdW5kcyA6 IDE7CiAgICAgICAgICAgICBib29sIHByZXNlcnZlczNEIDogMTsKLSAgICAgICAgICAgIGJvb2wg aXNSb290TGF5ZXI6IDE7CiAgICAgICAgICAgICBib29sIGZpeGVkVG9WaWV3cG9ydCA6IDE7CiAg ICAgICAgICAgICBib29sIHNob3dEZWJ1Z0JvcmRlcnMgOiAxOwogICAgICAgICAgICAgYm9vbCBz aG93UmVwYWludENvdW50ZXIgOiAxOwpAQCAtMTIwLDcgKzExOSw2IEBAIHN0cnVjdCBDb29yZGlu YXRlZEdyYXBoaWNzTGF5ZXJTdGF0ZSB7CiAgICAgICAgICwgYmFja2ZhY2VWaXNpYmxlKHRydWUp CiAgICAgICAgICwgbWFza3NUb0JvdW5kcyhmYWxzZSkKICAgICAgICAgLCBwcmVzZXJ2ZXMzRChm YWxzZSkKLSAgICAgICAgLCBpc1Jvb3RMYXllcihmYWxzZSkKICAgICAgICAgLCBmaXhlZFRvVmll d3BvcnQoZmFsc2UpCiAgICAgICAgICwgc2hvd0RlYnVnQm9yZGVycyhmYWxzZSkKICAgICAgICAg LCBzaG93UmVwYWludENvdW50ZXIoZmFsc2UpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9X ZWJQcm9jZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9Db29yZGluYXRlZExheWVyVHJl ZUhvc3QuY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0Nvb3JkaW5hdGVk R3JhcGhpY3MvQ29vcmRpbmF0ZWRMYXllclRyZWVIb3N0LmNwcAppbmRleCA1M2Q3MTQyNjYxYWQw MzllZDAyZThkZGM1NTZlMWM0MmE1OGFlNjJiLi5kYTM5ODEwMGIzZWZjNTZiOTdhNTRmNmZkMzhj ZDk2NThjMWJkMzRlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBh Z2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9Db29yZGluYXRlZExheWVyVHJlZUhvc3QuY3BwCisrKyBi L1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9Db29yZGluYXRlZEdyYXBoaWNzL0Nv b3JkaW5hdGVkTGF5ZXJUcmVlSG9zdC5jcHAKQEAgLTEwMCw3ICsxMDAsNiBAQCBDb29yZGluYXRl ZExheWVyVHJlZUhvc3Q6OkNvb3JkaW5hdGVkTGF5ZXJUcmVlSG9zdChXZWJQYWdlKiB3ZWJQYWdl KQogICAgIC8vIENyZWF0ZSBhIHJvb3QgbGF5ZXIuCiAgICAgbV9yb290TGF5ZXIgPSBHcmFwaGlj c0xheWVyOjpjcmVhdGUodGhpcywgdGhpcyk7CiAgICAgQ29vcmRpbmF0ZWRHcmFwaGljc0xheWVy KiBjb29yZGluYXRlZFJvb3RMYXllciA9IHRvQ29vcmRpbmF0ZWRHcmFwaGljc0xheWVyKG1fcm9v dExheWVyLmdldCgpKTsKLSAgICBjb29yZGluYXRlZFJvb3RMYXllci0+c2V0Um9vdExheWVyKHRy dWUpOwogI2lmbmRlZiBOREVCVUcKICAgICBtX3Jvb3RMYXllci0+c2V0TmFtZSgiQ29vcmRpbmF0 ZWRMYXllclRyZWVIb3N0IHJvb3QgbGF5ZXIiKTsKICNlbmRpZgo=