111826 2013-03-07 23:32:54 -0800 RenderTextControlSingleLine should not assume that its text element has a renderer 2013-03-14 23:31:30 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dominicc dominicc dglazkov eric esprehn+autocc inferno leviw mifenton ojan.autocc ojan tkent webkit.review.bot oldest_to_newest 850925 0 dominicc 2013-03-07 23:32:54 -0800 RenderTextControlSingleLine dereferences innerTextElement()->renderBox() during layout, hit testing and scrolling. However that element may not have a renderer, for example if ::-webkit-textfield-decoration-controller is used to set it to display: none;. 850927 1 192161 dominicc 2013-03-07 23:35:24 -0800 Created attachment 192161 Patch 851287 2 192161 ojan 2013-03-08 10:09:36 -0800 Comment on attachment 192161 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=192161&action=review > Source/WebCore/rendering/RenderTextControlSingleLine.cpp:176 > + ASSERT(innerTextRenderer); Having a placeholderBox always means you'll also have a innerTextRenderer? 851293 3 192161 webkit.review.bot 2013-03-08 10:14:46 -0800 Comment on attachment 192161 Patch Clearing flags on attachment: 192161 Committed r145239: <http://trac.webkit.org/changeset/145239> 851294 4 webkit.review.bot 2013-03-08 10:14:50 -0800 All reviewed patches have been landed. Closing bug. 854622 5 192161 cbiesinger 2013-03-13 14:26:29 -0700 Comment on attachment 192161 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=192161&action=review > Source/WebCore/rendering/RenderTextControlSingleLine.cpp:134 > + if (innerTextRenderer) this check is not necessary, because just above you added innerTextRenderer to the if... 855715 6 dominicc 2013-03-14 22:53:35 -0700 (In reply to comment #2) > Having a placeholderBox always means you'll also have a innerTextRenderer? I thought so, but now digging into TextFieldInputType::createShadowDOM I am not so sure. I will investigate. (In reply to comment #5) > (From update of attachment 192161 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=192161&action=review > > > Source/WebCore/rendering/RenderTextControlSingleLine.cpp:134 > > + if (innerTextRenderer) > > this check is not necessary, because just above you added innerTextRenderer to the if... Oops. Code blindness. I filed bug 112406. 855734 7 dominicc 2013-03-14 23:31:30 -0700 (In reply to comment #6) > (In reply to comment #2) > > Having a placeholderBox always means you'll also have a innerTextRenderer? > > I thought so, but now digging into TextFieldInputType::createShadowDOM I am not so sure. I will investigate. I have filed bug 112410 for this. I think HTMLTextFormControlElement::fixPlaceholderRenderer makes this assumption too, but the assumption is wrong. 192161 2013-03-07 23:35:24 -0800 2013-03-13 14:26:29 -0700 Patch bug-111826-20130308163127.patch text/plain 11415 dominicc U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1MTgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2M4ZTM1MGVhNDg5NWE1 YzE3YzcwZGI1MDY3NjlmNTQ5MGJlYjZjZi4uYmI3OWQxZGNlMWE4ZmU5NDMzY2U3ZjJmYTJjZTAy NWQyMzU3ZGUyNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEzLTAzLTA3ICBEb21p bmljIENvb25leSAgPGRvbWluaWNjQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZW5kZXJUZXh0 Q29udHJvbFNpbmdsZUxpbmUgc2hvdWxkIG5vdCBhc3N1bWUgdGhhdCBpdHMgdGV4dCBlbGVtZW50 IGhhcyBhIHJlbmRlcmVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMTE4MjYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBUZXN0czogZmFzdC9mb3Jtcy9zZWFyY2gvc2VhcmNoLWF1dG9zY3JvbGwtaGlkZGVu LWRlY29yYXRpb24tY29udGFpbmVyLWNyYXNoLmh0bWwKKyAgICAgICAgICAgICAgIGZhc3QvZm9y bXMvc2VhcmNoL3NlYXJjaC1oaWRlLWRlY29yYXRpb24tY29udGFpbmVyLWNyYXNoLmh0bWwKKyAg ICAgICAgICAgICAgIGZhc3QvZm9ybXMvc2VhcmNoL3NlYXJjaC1zY3JvbGwtaGlkZGVuLWRlY29y YXRpb24tY29udGFpbmVyLWNyYXNoLmh0bWwKKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJU ZXh0Q29udHJvbFNpbmdsZUxpbmUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVGV4dENv bnRyb2xTaW5nbGVMaW5lOjpsYXlvdXQpOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVGV4dENv bnRyb2xTaW5nbGVMaW5lOjpjb250cm9sQ2xpcFJlY3QpOgorICAgICAgICAoV2ViQ29yZTo6UmVu ZGVyVGV4dENvbnRyb2xTaW5nbGVMaW5lOjphdXRvc2Nyb2xsKToKKyAgICAgICAgKFdlYkNvcmU6 OlJlbmRlclRleHRDb250cm9sU2luZ2xlTGluZTo6c2Nyb2xsKToKKwogMjAxMy0wMy0wNyAgU2hl cmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZp ZXdlZCwgcm9sbGluZyBvdXQgcjE0NTE2Ni4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJUZXh0Q29udHJvbFNpbmdsZUxpbmUuY3BwIGIvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlclRleHRDb250cm9sU2luZ2xlTGluZS5jcHAKaW5kZXggYjA1NTUyNmE0 MTJjMDMyZTNmMjI5OGVhOWE0YjMyMmI1NzJiYTBlMC4uZWM4NGUyMTJkYzljYzc0ZWE5ZjIzYjI0 YTZlYmQyNDQ2ZjhiMmMzYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlclRleHRDb250cm9sU2luZ2xlTGluZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlclRleHRDb250cm9sU2luZ2xlTGluZS5jcHAKQEAgLTExMCwxMSArMTEwLDExIEBA IHZvaWQgUmVuZGVyVGV4dENvbnRyb2xTaW5nbGVMaW5lOjpsYXlvdXQoKQogICAgIC8vIGJlY2F1 c2Ugb2YgY29tcGFiaWxpdHkuCiAKICAgICBSZW5kZXJCb3gqIGlubmVyVGV4dFJlbmRlcmVyID0g aW5uZXJUZXh0RWxlbWVudCgpLT5yZW5kZXJCb3goKTsKLSAgICBBU1NFUlQoaW5uZXJUZXh0UmVu ZGVyZXIpOwogICAgIFJlbmRlckJveCogaW5uZXJCbG9ja1JlbmRlcmVyID0gaW5uZXJCbG9ja0Vs ZW1lbnQoKSA/IGlubmVyQmxvY2tFbGVtZW50KCktPnJlbmRlckJveCgpIDogMDsKIAogICAgIC8v IFRvIGVuc3VyZSBjb25zaXN0ZW5jeSBiZXR3ZWVuIGxheW91dHMsIHdlIG5lZWQgdG8gcmVzZXQg YW55IGNvbmRpdGlvbmFsbHkgb3ZlcnJpZGVuIGhlaWdodC4KLSAgICBpbm5lclRleHRSZW5kZXJl ci0+c3R5bGUoKS0+c2V0SGVpZ2h0KExlbmd0aChBdXRvKSk7CisgICAgaWYgKGlubmVyVGV4dFJl bmRlcmVyKQorICAgICAgICBpbm5lclRleHRSZW5kZXJlci0+c3R5bGUoKS0+c2V0SGVpZ2h0KExl bmd0aChBdXRvKSk7CiAgICAgaWYgKGlubmVyQmxvY2tSZW5kZXJlcikKICAgICAgICAgaW5uZXJC bG9ja1JlbmRlcmVyLT5zdHlsZSgpLT5zZXRIZWlnaHQoTGVuZ3RoKEF1dG8pKTsKIApAQCAtMTI1 LDE1ICsxMjUsMTQgQEAgdm9pZCBSZW5kZXJUZXh0Q29udHJvbFNpbmdsZUxpbmU6OmxheW91dCgp CiAKICAgICAvLyBTZXQgdGhlIHRleHQgYmxvY2sgaGVpZ2h0CiAgICAgTGF5b3V0VW5pdCBkZXNp cmVkSGVpZ2h0ID0gdGV4dEJsb2NrSGVpZ2h0KCk7Ci0gICAgTGF5b3V0VW5pdCBjdXJyZW50SGVp Z2h0ID0gaW5uZXJUZXh0UmVuZGVyZXItPmhlaWdodCgpOwotCiAgICAgTGF5b3V0VW5pdCBoZWln aHRMaW1pdCA9IGNvbXB1dGVIZWlnaHRMaW1pdCgpOwotICAgIGlmIChjdXJyZW50SGVpZ2h0ID4g aGVpZ2h0TGltaXQpIHsKLSAgICAgICAgaWYgKGRlc2lyZWRIZWlnaHQgIT0gY3VycmVudEhlaWdo dCkKKyAgICBpZiAoaW5uZXJUZXh0UmVuZGVyZXIgJiYgaW5uZXJUZXh0UmVuZGVyZXItPmhlaWdo dCgpID4gaGVpZ2h0TGltaXQpIHsKKyAgICAgICAgaWYgKGRlc2lyZWRIZWlnaHQgIT0gaW5uZXJU ZXh0UmVuZGVyZXItPmhlaWdodCgpKQogICAgICAgICAgICAgc2V0TmVlZHNMYXlvdXQodHJ1ZSwg TWFya09ubHlUaGlzKTsKIAotICAgICAgICBpbm5lclRleHRSZW5kZXJlci0+c3R5bGUoKS0+c2V0 SGVpZ2h0KExlbmd0aChkZXNpcmVkSGVpZ2h0LCBGaXhlZCkpOwogICAgICAgICBtX2Rlc2lyZWRJ bm5lclRleHRIZWlnaHQgPSBkZXNpcmVkSGVpZ2h0OworICAgICAgICBpZiAoaW5uZXJUZXh0UmVu ZGVyZXIpCisgICAgICAgICAgICBpbm5lclRleHRSZW5kZXJlci0+c3R5bGUoKS0+c2V0SGVpZ2h0 KExlbmd0aChkZXNpcmVkSGVpZ2h0LCBGaXhlZCkpOwogICAgICAgICBpZiAoaW5uZXJCbG9ja1Jl bmRlcmVyKQogICAgICAgICAgICAgaW5uZXJCbG9ja1JlbmRlcmVyLT5zdHlsZSgpLT5zZXRIZWln aHQoTGVuZ3RoKGRlc2lyZWRIZWlnaHQsIEZpeGVkKSk7CiAgICAgfQpAQCAtMTU2LDkgKzE1NSw4 IEBAIHZvaWQgUmVuZGVyVGV4dENvbnRyb2xTaW5nbGVMaW5lOjpsYXlvdXQoKQogICAgICAgICBS ZW5kZXJCbG9jazo6bGF5b3V0QmxvY2sodHJ1ZSk7CiAKICAgICAvLyBDZW50ZXIgdGhlIGNoaWxk IGJsb2NrIHZlcnRpY2FsbHkKLSAgICBjdXJyZW50SGVpZ2h0ID0gaW5uZXJUZXh0UmVuZGVyZXIt PmhlaWdodCgpOwotICAgIGlmICghY29udGFpbmVyICYmIGN1cnJlbnRIZWlnaHQgIT0gY29udGVu dEhlaWdodCgpKSB7Ci0gICAgICAgIExheW91dFVuaXQgaGVpZ2h0RGlmZiA9IGN1cnJlbnRIZWln aHQgLSBjb250ZW50SGVpZ2h0KCk7CisgICAgaWYgKCFjb250YWluZXIgJiYgaW5uZXJUZXh0UmVu ZGVyZXIgJiYgaW5uZXJUZXh0UmVuZGVyZXItPmhlaWdodCgpICE9IGNvbnRlbnRIZWlnaHQoKSkg eworICAgICAgICBMYXlvdXRVbml0IGhlaWdodERpZmYgPSBpbm5lclRleHRSZW5kZXJlci0+aGVp Z2h0KCkgLSBjb250ZW50SGVpZ2h0KCk7CiAgICAgICAgIGlubmVyVGV4dFJlbmRlcmVyLT5zZXRZ KGlubmVyVGV4dFJlbmRlcmVyLT55KCkgLSAoaGVpZ2h0RGlmZiAvIDIgKyBsYXlvdXRNb2QoaGVp Z2h0RGlmZiwgMikpKTsKICAgICB9IGVsc2UKICAgICAgICAgY2VudGVyQ29udGFpbmVySWZOZWVk ZWQoY29udGFpbmVyUmVuZGVyZXIpOwpAQCAtMTc1LDYgKzE3Myw3IEBAIHZvaWQgUmVuZGVyVGV4 dENvbnRyb2xTaW5nbGVMaW5lOjpsYXlvdXQoKQogCiAgICAgSFRNTEVsZW1lbnQqIHBsYWNlaG9s ZGVyRWxlbWVudCA9IGlucHV0RWxlbWVudCgpLT5wbGFjZWhvbGRlckVsZW1lbnQoKTsKICAgICBp ZiAoUmVuZGVyQm94KiBwbGFjZWhvbGRlckJveCA9IHBsYWNlaG9sZGVyRWxlbWVudCA/IHBsYWNl aG9sZGVyRWxlbWVudC0+cmVuZGVyQm94KCkgOiAwKSB7CisgICAgICAgIEFTU0VSVChpbm5lclRl eHRSZW5kZXJlcik7CiAgICAgICAgIHBsYWNlaG9sZGVyQm94LT5zdHlsZSgpLT5zZXRXaWR0aChM ZW5ndGgoaW5uZXJUZXh0UmVuZGVyZXItPndpZHRoKCkgLSBwbGFjZWhvbGRlckJveC0+Ym9yZGVy QW5kUGFkZGluZ1dpZHRoKCksIEZpeGVkKSk7CiAgICAgICAgIHBsYWNlaG9sZGVyQm94LT5zdHls ZSgpLT5zZXRIZWlnaHQoTGVuZ3RoKGlubmVyVGV4dFJlbmRlcmVyLT5oZWlnaHQoKSAtIHBsYWNl aG9sZGVyQm94LT5ib3JkZXJBbmRQYWRkaW5nSGVpZ2h0KCksIEZpeGVkKSk7CiAgICAgICAgIGJv b2wgbmVlZGVkTGF5b3V0ID0gcGxhY2Vob2xkZXJCb3gtPm5lZWRzTGF5b3V0KCk7CkBAIC0yNzcs NyArMjc2LDkgQEAgYm9vbCBSZW5kZXJUZXh0Q29udHJvbFNpbmdsZUxpbmU6Omhhc0NvbnRyb2xD bGlwKCkgY29uc3QKIExheW91dFJlY3QgUmVuZGVyVGV4dENvbnRyb2xTaW5nbGVMaW5lOjpjb250 cm9sQ2xpcFJlY3QoY29uc3QgTGF5b3V0UG9pbnQmIGFkZGl0aW9uYWxPZmZzZXQpIGNvbnN0CiB7 CiAgICAgQVNTRVJUKGhhc0NvbnRyb2xDbGlwKCkpOwotICAgIExheW91dFJlY3QgY2xpcFJlY3Qg PSB1bmlvblJlY3QoY29udGVudEJveFJlY3QoKSwgY29udGFpbmVyRWxlbWVudCgpLT5yZW5kZXJC b3goKS0+ZnJhbWVSZWN0KCkpOworICAgIExheW91dFJlY3QgY2xpcFJlY3QgPSBjb250ZW50Qm94 UmVjdCgpOworICAgIGlmIChjb250YWluZXJFbGVtZW50KCktPnJlbmRlckJveCgpKQorICAgICAg ICBjbGlwUmVjdCA9IHVuaW9uUmVjdChjbGlwUmVjdCwgY29udGFpbmVyRWxlbWVudCgpLT5yZW5k ZXJCb3goKS0+ZnJhbWVSZWN0KCkpOwogICAgIGNsaXBSZWN0Lm1vdmVCeShhZGRpdGlvbmFsT2Zm c2V0KTsKICAgICByZXR1cm4gY2xpcFJlY3Q7CiB9CkBAIC0zODgsNyArMzg5LDEwIEBAIGJvb2wg UmVuZGVyVGV4dENvbnRyb2xTaW5nbGVMaW5lOjp0ZXh0U2hvdWxkQmVUcnVuY2F0ZWQoKSBjb25z dAogCiB2b2lkIFJlbmRlclRleHRDb250cm9sU2luZ2xlTGluZTo6YXV0b3Njcm9sbChjb25zdCBJ bnRQb2ludCYgcG9zaXRpb24pCiB7Ci0gICAgUmVuZGVyTGF5ZXIqIGxheWVyID0gaW5uZXJUZXh0 RWxlbWVudCgpLT5yZW5kZXJCb3goKS0+bGF5ZXIoKTsKKyAgICBSZW5kZXJCb3gqIHJlbmRlcmVy ID0gaW5uZXJUZXh0RWxlbWVudCgpLT5yZW5kZXJCb3goKTsKKyAgICBpZiAoIXJlbmRlcmVyKQor ICAgICAgICByZXR1cm47CisgICAgUmVuZGVyTGF5ZXIqIGxheWVyID0gcmVuZGVyZXItPmxheWVy KCk7CiAgICAgaWYgKGxheWVyKQogICAgICAgICBsYXllci0+YXV0b3Njcm9sbChwb3NpdGlvbik7 CiB9CkBAIC00MzUsNyArNDM5LDEwIEBAIHZvaWQgUmVuZGVyVGV4dENvbnRyb2xTaW5nbGVMaW5l OjpzZXRTY3JvbGxUb3AoaW50IG5ld1RvcCkKIAogYm9vbCBSZW5kZXJUZXh0Q29udHJvbFNpbmds ZUxpbmU6OnNjcm9sbChTY3JvbGxEaXJlY3Rpb24gZGlyZWN0aW9uLCBTY3JvbGxHcmFudWxhcml0 eSBncmFudWxhcml0eSwgZmxvYXQgbXVsdGlwbGllciwgTm9kZSoqIHN0b3BOb2RlKQogewotICAg IFJlbmRlckxheWVyKiBsYXllciA9IGlubmVyVGV4dEVsZW1lbnQoKS0+cmVuZGVyQm94KCktPmxh eWVyKCk7CisgICAgUmVuZGVyQm94KiByZW5kZXJlciA9IGlubmVyVGV4dEVsZW1lbnQoKS0+cmVu ZGVyQm94KCk7CisgICAgaWYgKCFyZW5kZXJlcikKKyAgICAgICAgcmV0dXJuIGZhbHNlOworICAg IFJlbmRlckxheWVyKiBsYXllciA9IHJlbmRlcmVyLT5sYXllcigpOwogICAgIGlmIChsYXllciAm JiBsYXllci0+c2Nyb2xsKGRpcmVjdGlvbiwgZ3JhbnVsYXJpdHksIG11bHRpcGxpZXIpKQogICAg ICAgICByZXR1cm4gdHJ1ZTsKICAgICByZXR1cm4gUmVuZGVyQmxvY2s6OnNjcm9sbChkaXJlY3Rp b24sIGdyYW51bGFyaXR5LCBtdWx0aXBsaWVyLCBzdG9wTm9kZSk7CmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMDBjYmFlY2Q1 NmExODE4MTE3OTI3YzBlNGNkYTFhZDRiZWIwNmY0Yi4uNDJiZDU1NWZkMTk2MmUyMzAzMmI0NTU3 NDA1MmRmOWE4OWQwYjU2OSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBi L0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTAzLTA3ICBEb21p bmljIENvb25leSAgPGRvbWluaWNjQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZW5kZXJUZXh0 Q29udHJvbFNpbmdsZUxpbmUgc2hvdWxkIG5vdCBhc3N1bWUgdGhhdCBpdHMgdGV4dCBlbGVtZW50 IGhhcyBhIHJlbmRlcmVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMTE4MjYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIGZhc3QvZm9ybXMvc2VhcmNoL3NlYXJjaC1hdXRvc2Nyb2xsLWhpZGRlbi1kZWNv cmF0aW9uLWNvbnRhaW5lci1jcmFzaC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZh c3QvZm9ybXMvc2VhcmNoL3NlYXJjaC1hdXRvc2Nyb2xsLWhpZGRlbi1kZWNvcmF0aW9uLWNvbnRh aW5lci1jcmFzaC5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2Zvcm1zL3NlYXJjaC9zZWFy Y2gtaGlkZS1kZWNvcmF0aW9uLWNvbnRhaW5lci1jcmFzaC1leHBlY3RlZC50eHQ6IEFkZGVkLgor ICAgICAgICAqIGZhc3QvZm9ybXMvc2VhcmNoL3NlYXJjaC1oaWRlLWRlY29yYXRpb24tY29udGFp bmVyLWNyYXNoLmh0bWw6IEFkZGVkLgorICAgICAgICAqIGZhc3QvZm9ybXMvc2VhcmNoL3NlYXJj aC1zY3JvbGwtaGlkZGVuLWRlY29yYXRpb24tY29udGFpbmVyLWNyYXNoLWV4cGVjdGVkLnR4dDog QWRkZWQuCisgICAgICAgICogZmFzdC9mb3Jtcy9zZWFyY2gvc2VhcmNoLXNjcm9sbC1oaWRkZW4t ZGVjb3JhdGlvbi1jb250YWluZXItY3Jhc2guaHRtbDogQWRkZWQuCisKIDIwMTMtMDMtMDcgIEhh eWF0byBJdG8gIDxoYXlhdG9AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQgZ2Fy ZGVuaW5nLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9zZWFyY2gvc2VhcmNo LWF1dG9zY3JvbGwtaGlkZGVuLWRlY29yYXRpb24tY29udGFpbmVyLWNyYXNoLWV4cGVjdGVkLnR4 dCBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvc2VhcmNoL3NlYXJjaC1hdXRvc2Nyb2xsLWhpZGRl bi1kZWNvcmF0aW9uLWNvbnRhaW5lci1jcmFzaC1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAx MDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNzU3 NGQ0OWI2ZmRjNmYwMmMzYTdhNWZjN2IxMmIyNmUxMWFiNmM5NgotLS0gL2Rldi9udWxsCisrKyBi L0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvc2VhcmNoL3NlYXJjaC1hdXRvc2Nyb2xsLWhpZGRlbi1k ZWNvcmF0aW9uLWNvbnRhaW5lci1jcmFzaC1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwyIEBACitN b3ZlIHRoZSBtb3VzZSBvdmVyIHRoZSBpbnB1dCBlbGVtZW50IGFuZCBjbGljayBhbmQgZHJhZyB1 cHdhcmRzIHRvIG91dHNpZGUgdGhlIGJvdW5kcyBvZiB0aGUgaW5wdXQgZWxlbWVudC4gSWYgdGhp cyBkb2VzIG5vdCBjcmFzaCwgdGhlIHRlc3QgcGFzc2VkLgorIFBBU1MKZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL2Zhc3QvZm9ybXMvc2VhcmNoL3NlYXJjaC1hdXRvc2Nyb2xsLWhpZGRlbi1kZWNv cmF0aW9uLWNvbnRhaW5lci1jcmFzaC5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9zZWFy Y2gvc2VhcmNoLWF1dG9zY3JvbGwtaGlkZGVuLWRlY29yYXRpb24tY29udGFpbmVyLWNyYXNoLmh0 bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMC4uNTQzYzgwZGYwZjA0YWRkNjZjYTViYzNmYjc4YzQ4OWI3YWNkNjM0Mwot LS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvc2VhcmNoL3NlYXJjaC1h dXRvc2Nyb2xsLWhpZGRlbi1kZWNvcmF0aW9uLWNvbnRhaW5lci1jcmFzaC5odG1sCkBAIC0wLDAg KzEsMjkgQEAKKzwhRE9DVFlQRSBodG1sPgorPGRpdj4KK01vdmUgdGhlIG1vdXNlIG92ZXIgdGhl IGlucHV0IGVsZW1lbnQgYW5kIGNsaWNrIGFuZCBkcmFnIHVwd2FyZHMgdG8KK291dHNpZGUgdGhl IGJvdW5kcyBvZiB0aGUgaW5wdXQgZWxlbWVudC4gSWYgdGhpcyBkb2VzIG5vdCBjcmFzaCwgdGhl Cit0ZXN0IHBhc3NlZC4KKzwvZGl2PgorCis8c3R5bGU+CitpbnB1dDo6LXdlYmtpdC10ZXh0Zmll bGQtZGVjb3JhdGlvbi1jb250YWluZXIgeworICAgIGRpc3BsYXk6IG5vbmU7Cit9Cis8L3N0eWxl PgorPGlucHV0IHR5cGU9InNlYXJjaCI+Cis8c2NyaXB0PgoraWYgKHdpbmRvdy50ZXN0UnVubmVy KQorICAgIHRlc3RSdW5uZXIuZHVtcEFzVGV4dCgpOworCitpZiAod2luZG93LmV2ZW50U2VuZGVy KSB7CisgICAgdmFyIGlucHV0ID0gZG9jdW1lbnQucXVlcnlTZWxlY3RvcignaW5wdXQnKTsKKyAg ICB2YXIgeCA9IGlucHV0Lm9mZnNldExlZnQgKyBpbnB1dC5vZmZzZXRXaWR0aCAvIDI7CisgICAg dmFyIHkgPSBpbnB1dC5vZmZzZXRUb3AgKyBpbnB1dC5vZmZzZXRIZWlnaHQgLyAyOworICAgIGV2 ZW50U2VuZGVyLm1vdXNlTW92ZVRvKHgsIHkpOworICAgIGV2ZW50U2VuZGVyLm1vdXNlRG93bigp OworICAgIGV2ZW50U2VuZGVyLmxlYXBGb3J3YXJkKDIwKTsKKyAgICBldmVudFNlbmRlci5tb3Vz ZU1vdmVUbyh4LCAwKTsKKyAgICBldmVudFNlbmRlci5tb3VzZVVwKCk7CisgICAgZG9jdW1lbnQu d3JpdGUoJ1BBU1MnKTsKK30KKzwvc2NyaXB0PgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFz dC9mb3Jtcy9zZWFyY2gvc2VhcmNoLWhpZGUtZGVjb3JhdGlvbi1jb250YWluZXItY3Jhc2gtZXhw ZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9zZWFyY2gvc2VhcmNoLWhpZGUtZGVj b3JhdGlvbi1jb250YWluZXItY3Jhc2gtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0 CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjY2MGI0MGY0 NDBiYjI5OTMzYzdkYTAxYTY4N2U3ZDFjYWE1NTQ2MTYKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlv dXRUZXN0cy9mYXN0L2Zvcm1zL3NlYXJjaC9zZWFyY2gtaGlkZS1kZWNvcmF0aW9uLWNvbnRhaW5l ci1jcmFzaC1leHBlY3RlZC50eHQKQEAgLTAsMCArMSBAQAorIFBBU1MKZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL2Zhc3QvZm9ybXMvc2VhcmNoL3NlYXJjaC1oaWRlLWRlY29yYXRpb24tY29udGFp bmVyLWNyYXNoLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3NlYXJjaC9zZWFyY2gtaGlk ZS1kZWNvcmF0aW9uLWNvbnRhaW5lci1jcmFzaC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0Cmlu ZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmUzZDg2ZGZiZmQw N2I4YTZhZTUwYjkxOTVjNDg0MGMxZTViNjZkYzgKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRU ZXN0cy9mYXN0L2Zvcm1zL3NlYXJjaC9zZWFyY2gtaGlkZS1kZWNvcmF0aW9uLWNvbnRhaW5lci1j cmFzaC5odG1sCkBAIC0wLDAgKzEsMTIgQEAKKzwhRE9DVFlQRSBodG1sPgorPHNjcmlwdD4KK2lm ICh3aW5kb3cudGVzdFJ1bm5lcikKKyAgICB0ZXN0UnVubmVyLmR1bXBBc1RleHQoKTsKKzwvc2Ny aXB0PgorPHN0eWxlPgoraW5wdXQ6Oi13ZWJraXQtdGV4dGZpZWxkLWRlY29yYXRpb24tY29udGFp bmVyIHsKKyAgICBkaXNwbGF5OiBub25lOworfQorPC9zdHlsZT4KKzxpbnB1dCB0eXBlPSJzZWFy Y2giPgorUEFTUwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9zZWFyY2gvc2Vh cmNoLXNjcm9sbC1oaWRkZW4tZGVjb3JhdGlvbi1jb250YWluZXItY3Jhc2gtZXhwZWN0ZWQudHh0 IGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9zZWFyY2gvc2VhcmNoLXNjcm9sbC1oaWRkZW4tZGVj b3JhdGlvbi1jb250YWluZXItY3Jhc2gtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0 CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmMwNWI5NTk2 ZjRmN2MxY2FkNzg0MGNhYTU5YmM3NTkzMTU5YWFjODgKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlv dXRUZXN0cy9mYXN0L2Zvcm1zL3NlYXJjaC9zZWFyY2gtc2Nyb2xsLWhpZGRlbi1kZWNvcmF0aW9u LWNvbnRhaW5lci1jcmFzaC1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwyIEBACitNb3ZlIHRoZSBt b3VzZSBvdmVyIHRoZSBpbnB1dCBlbGVtZW50IGFuZCBzY3JvbGwgdXNpbmcgdGhlIG1vdXNlIHdo ZWVsLiBJZiB0aGlzIGRvZXMgbm90IGNyYXNoLCB0aGUgdGVzdCBwYXNzZWQuCisgUEFTUwpkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9zZWFyY2gvc2VhcmNoLXNjcm9sbC1oaWRk ZW4tZGVjb3JhdGlvbi1jb250YWluZXItY3Jhc2guaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZm9y bXMvc2VhcmNoL3NlYXJjaC1zY3JvbGwtaGlkZGVuLWRlY29yYXRpb24tY29udGFpbmVyLWNyYXNo Lmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMC4uZGYxYTI5NmExZDQ2ODk2NmZkYTAyZDVmNmY3ZTRjYjUwNzViNjNl NgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvc2VhcmNoL3NlYXJj aC1zY3JvbGwtaGlkZGVuLWRlY29yYXRpb24tY29udGFpbmVyLWNyYXNoLmh0bWwKQEAgLTAsMCAr MSwyNSBAQAorPCFET0NUWVBFIGh0bWw+Cis8ZGl2PgorTW92ZSB0aGUgbW91c2Ugb3ZlciB0aGUg aW5wdXQgZWxlbWVudCBhbmQgc2Nyb2xsIHVzaW5nIHRoZSBtb3VzZQord2hlZWwuIElmIHRoaXMg ZG9lcyBub3QgY3Jhc2gsIHRoZSB0ZXN0IHBhc3NlZC4KKzwvZGl2PgorCis8c3R5bGU+CitpbnB1 dDo6LXdlYmtpdC10ZXh0ZmllbGQtZGVjb3JhdGlvbi1jb250YWluZXIgeworICAgIGRpc3BsYXk6 IG5vbmU7Cit9Cis8L3N0eWxlPgorPGlucHV0IHR5cGU9InNlYXJjaCI+Cis8c2NyaXB0PgoraWYg KHdpbmRvdy50ZXN0UnVubmVyKQorICAgIHRlc3RSdW5uZXIuZHVtcEFzVGV4dCgpOworCitpZiAo d2luZG93LmV2ZW50U2VuZGVyKSB7CisgICAgdmFyIGlucHV0ID0gZG9jdW1lbnQucXVlcnlTZWxl Y3RvcignaW5wdXQnKTsKKyAgICB2YXIgeCA9IGlucHV0Lm9mZnNldExlZnQgKyBpbnB1dC5vZmZz ZXRXaWR0aCAvIDI7CisgICAgdmFyIHkgPSBpbnB1dC5vZmZzZXRUb3AgKyBpbnB1dC5vZmZzZXRI ZWlnaHQgLyAyOworICAgIGV2ZW50U2VuZGVyLm1vdXNlTW92ZVRvKHgsIHkpOworICAgIGV2ZW50 U2VuZGVyLm1vdXNlU2Nyb2xsQnkoMCwgMTApOworICAgIGRvY3VtZW50LndyaXRlKCdQQVNTJyk7 Cit9Cis8L3NjcmlwdD4K