111822 2013-03-07 22:49:07 -0800 Infinite loop due to bad use tree cycle detection 2013-03-08 06:40:10 -0800 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pdr pdr d-r fmalita schenney webkit.review.bot zimmermann oldest_to_newest 850891 0 pdr 2013-03-07 22:49:07 -0800 We can infinite loop during use tree cycle detection with ids containing capital letters. The bug is conveniently labeled with a fixme! http://trac.webkit.org/browser/trunk/Source/WebCore/svg/SVGUseElement.cpp?annotate=blame#L672 Testcase: <svg> <g id="R"> <use id="test" xlink:href="#R"> </svg> Original bug: crbug.com/181016 850915 1 192158 pdr 2013-03-07 23:22:16 -0800 Created attachment 192158 Prevent infinite loop 851135 2 192158 schenney 2013-03-08 06:34:25 -0800 Comment on attachment 192158 Prevent infinite loop Look good to me. R=me. 851144 3 192158 webkit.review.bot 2013-03-08 06:40:07 -0800 Comment on attachment 192158 Prevent infinite loop Clearing flags on attachment: 192158 Committed r145216: <http://trac.webkit.org/changeset/145216> 851145 4 webkit.review.bot 2013-03-08 06:40:10 -0800 All reviewed patches have been landed. Closing bug. 192158 2013-03-07 23:22:16 -0800 2013-03-08 06:40:06 -0800 Prevent infinite loop 111822.1.patch text/plain 3527 pdr SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0NTE4MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDEzLTAzLTA3ICBQaGlsaXAg Um9nZXJzICA8cGRyQGdvb2dsZS5jb20+CisKKyAgICAgICAgUHJldmVudCBpbmZpbml0ZSBsb29w IGluIFNWRyB1c2UgY3ljbGUgZGV0ZWN0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMTE4MjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBTVkcgdXNlIGN5Y2xlIGRldGVjdGlvbiBkZXBlbmRlZCBvbiBp ZEZvclN0eWxlUmVzb2x1dGlvbigpIHdoaWNoIGRpZmZlcnMgZnJvbQorICAgICAgICBnZXRJZEF0 dHJpYnV0ZSgpIGluIHF1aXJrcyBtb2RlLiBEdXJpbmcgdXNlIHRyZWUgY3ljbGUgZGV0ZWN0aW9u LCB0aGlzIGRpZmZlcmVuY2UKKyAgICAgICAgcmVzdWx0ZWQgaW4gYW4gaW5maW5pdGUgbG9vcCBi ZWNhdXNlIGlkRm9yU3R5bGVSZXNvbHV0aW9uKCkgdXNlZCBsb3dlci1jYXNlZCBpZAorICAgICAg ICBhdHRyaWJ1dGVzLiBUaGlzIHBhdGNoIHJlbW92ZXMgYW4gZXhpc3RpbmcgZml4bWUgZm9yIHRo aXMgYW5kIHN3aXRjaGVzIHRvIHVzaW5nCisgICAgICAgIGdldElkQXR0cmlidXRlKCkuCisKKyAg ICAgICAgVGVzdDogc3ZnL2N1c3RvbS91c2UtY3ljbGUtZGV0ZWN0aW9uLmh0bWwKKworICAgICAg ICAqIHN2Zy9TVkdVc2VFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNWR1VzZUVsZW1l bnQ6Omhhc0N5Y2xlVXNlUmVmZXJlbmNpbmcpOgorCiAyMDEzLTAzLTA3ICBTZW9ranUgS3dvbiAg PHNlb2tqdS5rd29uQGdtYWlsLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBSZW1vdmUg dW51c2VkIHJldHVybiB2YWx1ZSBhZnRlciByMTIyOTYyCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9z dmcvU1ZHVXNlRWxlbWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvc3ZnL1NW R1VzZUVsZW1lbnQuY3BwCShyZXZpc2lvbiAxNDQ4MTgpCisrKyBTb3VyY2UvV2ViQ29yZS9zdmcv U1ZHVXNlRWxlbWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTY2OSw4ICs2NjksNyBAQCBib29s IFNWR1VzZUVsZW1lbnQ6Omhhc0N5Y2xlVXNlUmVmZXJlbmNpCiAgICAgd2hpbGUgKGluc3RhbmNl KSB7CiAgICAgICAgIFNWR0VsZW1lbnQqIGVsZW1lbnQgPSBpbnN0YW5jZS0+Y29ycmVzcG9uZGlu Z0VsZW1lbnQoKTsKIAotICAgICAgICAvLyBGSVhNRTogVGhpcyBzaG91bGQgcHJvYmFibHkgYmUg dXNpbmcgZ2V0SWRBdHRyaWJ1dGUgaW5zdGVhZCBvZiBpZEZvclN0eWxlUmVzb2x1dGlvbi4KLSAg ICAgICAgaWYgKGVsZW1lbnQtPmhhc0lEKCkgJiYgZWxlbWVudC0+aWRGb3JTdHlsZVJlc29sdXRp b24oKSA9PSB0YXJnZXRJZCAmJiBlbGVtZW50LT5kb2N1bWVudCgpID09IG5ld1RhcmdldC0+ZG9j dW1lbnQoKSkKKyAgICAgICAgaWYgKGVsZW1lbnQtPmhhc0lEKCkgJiYgZWxlbWVudC0+Z2V0SWRB dHRyaWJ1dGUoKSA9PSB0YXJnZXRJZCAmJiBlbGVtZW50LT5kb2N1bWVudCgpID09IG5ld1Rhcmdl dC0+ZG9jdW1lbnQoKSkKICAgICAgICAgICAgIHJldHVybiB0cnVlOwogCiAgICAgICAgIGluc3Rh bmNlID0gaW5zdGFuY2UtPnBhcmVudE5vZGUoKTsKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxv Zwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0NTE4MykK KysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDEzLTAzLTA3ICBQaGlsaXAgUm9nZXJzICA8cGRyQGdvb2dsZS5jb20+CisKKyAgICAgICAg UHJldmVudCBpbmZpbml0ZSBsb29wIGluIFNWRyB1c2UgY3ljbGUgZGV0ZWN0aW9uCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTE4MjIKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHN2Zy9jdXN0b20vdXNl LWN5Y2xlLWRldGVjdGlvbi1leHBlY3RlZC5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBzdmcvY3Vz dG9tL3VzZS1jeWNsZS1kZXRlY3Rpb24uaHRtbDogQWRkZWQuCisKIDIwMTMtMDMtMDcgIEhheWF0 byBJdG8gIDxoYXlhdG9AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQgZ2FyZGVu aW5nLgpJbmRleDogTGF5b3V0VGVzdHMvc3ZnL2N1c3RvbS91c2UtY3ljbGUtZGV0ZWN0aW9uLWV4 cGVjdGVkLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvc3ZnL2N1c3RvbS91c2UtY3lj bGUtZGV0ZWN0aW9uLWV4cGVjdGVkLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9z dmcvY3VzdG9tL3VzZS1jeWNsZS1kZXRlY3Rpb24tZXhwZWN0ZWQuaHRtbAkod29ya2luZyBjb3B5 KQpAQCAtMCwwICsxLDkgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8c3ZnIHdpZHRoPSI0 MDAiIGhlaWdodD0iMjAwIj4KKyAgICA8dGV4dCB4PSIxMCIgeT0iMTUwIj5UZXN0IGZvciBXSzEx MTgyMjogVGhpcyB0ZXN0IHBhc3NlcyBpZiBpdCBkb2VzIG5vdCB0aW1lb3V0LjwvdGV4dD4KKyAg ICA8ZyBpZD0iUiI+CisgICAgICAgIDx1c2UgaWQ9InRlc3QiIHhsaW5rOmhyZWY9IiNSIiAvPgor ICAgIDwvZz4KKzwvc3ZnPgorPC9odG1sPgpJbmRleDogTGF5b3V0VGVzdHMvc3ZnL2N1c3RvbS91 c2UtY3ljbGUtZGV0ZWN0aW9uLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvc3ZnL2N1 c3RvbS91c2UtY3ljbGUtZGV0ZWN0aW9uLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0 cy9zdmcvY3VzdG9tL3VzZS1jeWNsZS1kZXRlY3Rpb24uaHRtbAkod29ya2luZyBjb3B5KQpAQCAt MCwwICsxLDkgQEAKKzwhLS0gRG9jdHlwZSBsZWZ0IG9mZiB0byBmb3JjZSBxdWlya3Ntb2RlIC0t PgorPGh0bWw+Cis8c3ZnIHdpZHRoPSI0MDAiIGhlaWdodD0iMjAwIj4KKyAgICA8dGV4dCB4PSIx MCIgeT0iMTUwIj5UZXN0IGZvciBXSzExMTgyMjogVGhpcyB0ZXN0IHBhc3NlcyBpZiBpdCBkb2Vz IG5vdCB0aW1lb3V0LjwvdGV4dD4KKyAgICA8ZyBpZD0iUiI+CisgICAgICAgIDx1c2UgaWQ9InRl c3QiIHhsaW5rOmhyZWY9IiNSIiAvPgorICAgIDwvZz4KKzwvc3ZnPgorPC9odG1sPgo=