111807 2013-03-07 19:06:04 -0800 Custom Elements: CustomElement constructor shouldn't share function instance 2013-03-09 01:09:05 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 morrita morrita abarth haraken japhet webcomponents-bugzilla webkit.review.bot oldest_to_newest 850754 0 morrita 2013-03-07 19:06:04 -0800 This is a facepalm bug... A fix will come shortly. 850771 1 192131 morrita 2013-03-07 19:22:32 -0800 Created attachment 192131 Patch 850818 2 morrita 2013-03-07 20:28:12 -0800 Committed r145175: <http://trac.webkit.org/changeset/145175> 851366 3 192131 abarth 2013-03-08 11:40:29 -0800 Comment on attachment 192131 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=192131&action=review > Source/WebCore/bindings/v8/V8AdaptorFunction.cpp:79 > - v8::Handle<v8::Function> adaptor = v8::Handle<v8::Function>::Cast(getTemplate(isolate, worldType(isolate))->GetFunction()); > + v8::Handle<v8::Function> adaptor = v8::Handle<v8::Function>::Cast(getTemplate(isolate, worldType(isolate))->GetFunction()->Clone()); Sorry for missing this in the review. 851750 4 morrita 2013-03-09 01:09:05 -0800 (In reply to comment #3) > > Sorry for missing this in the review. Well, the test should have been more comprehensive. 192131 2013-03-07 19:22:32 -0800 2013-03-08 11:40:29 -0800 Patch bug-111807-20130308121836.patch text/plain 5128 morrita U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1MTcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDhjZGUxYjdkNGFjZTc4 ODEzMTdmM2UxOTExNTk2MTI4NDY5Mjg0Ni4uNTlhNTk0YWFhMWY2OGVhNGIzZWYyNzQ5OGY2MDg2 YTM0ODVjOThjMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTAzLTA3ICBIYWpp bWUgTW9ycml0YSAgPG1vcnJpdGFAZ29vZ2xlLmNvbT4KKworICAgICAgICBDdXN0b20gRWxlbWVu dHM6IEN1c3RvbUVsZW1lbnQgY29uc3RydWN0b3Igc2hvdWxkbid0IHNoYXJlIGZ1bmN0aW9uIGlu c3RhbmNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MTE4MDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBB ZGFwdG9yIGZ1bmN0aW9ucyBvZiBjdXN0b20gZWxlbWVudHMgdW5pbnRlbnRpb25hbGx5IHNoYXJl IHRoZSBpbnN0YW5jZS4KKyAgICAgICAgVGhpcyBmaXggZ2l2ZXMgbmV3IG9uZSBmb3IgZWFjaC4K KworICAgICAgICBUZXN0OiBVcGRhdGVkIGZhc3QvZG9tL2N1c3RvbS9kb2N1bWVudC1yZWdpc3Rl ci1iYXNpYy5odG1sCisKKyAgICAgICAgKiBiaW5kaW5ncy92OC9WOEFkYXB0b3JGdW5jdGlvbi5j cHA6CisgICAgICAgIChXZWJDb3JlOjpWOEFkYXB0b3JGdW5jdGlvbjo6d3JhcCk6CisKIDIwMTMt MDMtMDcgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgogCiAgICAgICAgIFJlc2l6 aW5nIENhcHB1Y2Npbm8gaXMgdmVyeSBsYWdneSBvbiBXZWJLaXQgc2luY2UgU2FmYXJpIDUuMQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhBZGFwdG9yRnVuY3Rpb24u Y3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhBZGFwdG9yRnVuY3Rpb24uY3BwCmlu ZGV4IDA0MWY1MjliYjQ5ODg4ZDNiY2Q0NDAyOTAyYzMwMmMwZTI0YTE2ZjEuLjZiYzgwM2E0MTdk ZWEwOGZjZGY4ODM1ZDViYmUyNTlmYjMzM2UxODEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL3Y4L1Y4QWRhcHRvckZ1bmN0aW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9i aW5kaW5ncy92OC9WOEFkYXB0b3JGdW5jdGlvbi5jcHAKQEAgLTc2LDcgKzc2LDcgQEAgdjg6Okhh bmRsZTx2ODo6RnVuY3Rpb24+IFY4QWRhcHRvckZ1bmN0aW9uOjp3cmFwKHY4OjpIYW5kbGU8djg6 Ok9iamVjdD4gb2JqZWN0LAogewogICAgIGlmIChvYmplY3QuSXNFbXB0eSgpIHx8ICFvYmplY3Qt PklzT2JqZWN0KCkpCiAgICAgICAgIHJldHVybiB2ODo6SGFuZGxlPHY4OjpGdW5jdGlvbj4oKTsK LSAgICB2ODo6SGFuZGxlPHY4OjpGdW5jdGlvbj4gYWRhcHRvciA9IHY4OjpIYW5kbGU8djg6OkZ1 bmN0aW9uPjo6Q2FzdChnZXRUZW1wbGF0ZShpc29sYXRlLCB3b3JsZFR5cGUoaXNvbGF0ZSkpLT5H ZXRGdW5jdGlvbigpKTsKKyAgICB2ODo6SGFuZGxlPHY4OjpGdW5jdGlvbj4gYWRhcHRvciA9IHY4 OjpIYW5kbGU8djg6OkZ1bmN0aW9uPjo6Q2FzdChnZXRUZW1wbGF0ZShpc29sYXRlLCB3b3JsZFR5 cGUoaXNvbGF0ZSkpLT5HZXRGdW5jdGlvbigpLT5DbG9uZSgpKTsKICAgICBpZiAoYWRhcHRvci5J c0VtcHR5KCkpCiAgICAgICAgIHJldHVybiB2ODo6SGFuZGxlPHY4OjpGdW5jdGlvbj4oKTsKICAg ICBhZGFwdG9yLT5TZXROYW1lKHY4U3RyaW5nKG5hbWUuc3RyaW5nKCksIGlzb2xhdGUpKTsKZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpp bmRleCAzYTcxNjcwMDM1Y2ZhM2YwYzJjNTk5NzRlYjRmMjViZTIxZjJhYWY3Li5hN2Q5NTg2M2Vj NmY0OTUzZDkzM2JjZDVjMGI0NjNlYjFlZWFmOGI0IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9D aGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIw MTMtMDMtMDcgIEhhamltZSBNb3JyaXRhICA8bW9ycml0YUBnb29nbGUuY29tPgorCisgICAgICAg IEN1c3RvbSBFbGVtZW50czogQ3VzdG9tRWxlbWVudCBjb25zdHJ1Y3RvciBzaG91bGRuJ3Qgc2hh cmUgZnVuY3Rpb24gaW5zdGFuY2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTExMTgwNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogZmFzdC9kb20vY3VzdG9tL2RvY3VtZW50LXJlZ2lzdGVyLWJhc2ljLWV4 cGVjdGVkLnR4dDoKKyAgICAgICAgKiBmYXN0L2RvbS9jdXN0b20vZG9jdW1lbnQtcmVnaXN0ZXIt YmFzaWMuaHRtbDoKKwogMjAxMy0wMy0wNyAgQW5kcmVhcyBLbGluZyAgPGFrbGluZ0BhcHBsZS5j b20+CiAKICAgICAgICAgUmVtb3ZlIGRlc2t0b3AgdmVyc2lvbiBvZiAtd2Via2l0LXRleHQtc2l6 ZS1hZGp1c3QgcHJvcGVydHkuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2RvbS9jdXN0 b20vZG9jdW1lbnQtcmVnaXN0ZXItYmFzaWMtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFz dC9kb20vY3VzdG9tL2RvY3VtZW50LXJlZ2lzdGVyLWJhc2ljLWV4cGVjdGVkLnR4dAppbmRleCAy NmI2MjE5NGQxZTMyMGFhNDdiMjA5MzI4Yzk0NWM1Yzk5YmM4ZmI1Li5mZmI1MjgzZGFjMmE3ZGVm YjYxYzU3N2U4YTRmMWI5Y2FlYjZmMmM3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L2Rv bS9jdXN0b20vZG9jdW1lbnQtcmVnaXN0ZXItYmFzaWMtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91 dFRlc3RzL2Zhc3QvZG9tL2N1c3RvbS9kb2N1bWVudC1yZWdpc3Rlci1iYXNpYy1leHBlY3RlZC50 eHQKQEAgLTI0LDYgKzI0LDcgQEAgUEFTUyBjcmVhdGVkRm9vLmxhc3RDaGlsZCBpcyBjaGlsZERp dgogUEFTUyBwYXJzZWRGb28uX19wcm90b19fIGlzIGZvb0NvbnN0cnVjdG9yLnByb3RvdHlwZQog UEFTUyBwYXJzZWRGb28udGFnTmFtZSBpcyAnWC1GT08nCiBQQVNTIHBhcnNlZEZvby5zb21lUHJv cGVydHkgaXMgY29udGFpbmVyLmZpcnN0Q2hpbGQuc29tZVByb3BlcnR5CitQQVNTIGJhckNvbnN0 cnVjdG9yICE9PSBmb29Db25zdHJ1Y3RvciBpcyB0cnVlCiBQQVNTIGNyZWF0ZWRCYXIudGFnTmFt ZSBpcyAnWC1CQVInCiBQQVNTIGNyZWF0ZWRCYXoudGFnTmFtZSBpcyAnWC1CQVonCiBQQVNTIGNy ZWF0ZWRCYXoudGhpc0lzUHJvdG90eXBlIGlzIHRydWUKQEAgLTQwLDYgKzQxLDkgQEAgUEFTUyAo bmV3IChkb2N1bWVudC5yZWdpc3RlcigneS1iYXInLCBjcmVhdGVSZWdpc3RlclBhcmFtdGVycygp KSkoKSkudGFnTmFtZSBpcwogUEFTUyAobmV3IChkb2N1bWVudC5yZWdpc3RlcigneXotYmFyJywg Y3JlYXRlUmVnaXN0ZXJQYXJhbXRlcnMoKSkpKCkpLnRhZ05hbWUgaXMgJ1laLUJBUicKIFBBU1Mg KG5ldyAoZG9jdW1lbnQucmVnaXN0ZXIoJ3ktei1iYXInLCBjcmVhdGVSZWdpc3RlclBhcmFtdGVy cygpKSkoKSkudGFnTmFtZSBpcyAnWS1aLUJBUicKIFBBU1MgKG5ldyAoZG9jdW1lbnQucmVnaXN0 ZXIoJ3ktLWJhcicsIGNyZWF0ZVJlZ2lzdGVyUGFyYW10ZXJzKCkpKSgpKS50YWdOYW1lIGlzICdZ LS1CQVInCitQQVNTIChuZXcgZm9vQ29uc3RydWN0b3IpLnRhZ05hbWUgaXMgJ1gtRk9PJworUEFT UyAobmV3IGJhckNvbnN0cnVjdG9yKS50YWdOYW1lIGlzICdYLUJBUicKK1BBU1MgKG5ldyBiYXpD b25zdHJ1Y3RvcikudGFnTmFtZSBpcyAnWC1CQVonCiBQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBp cyB0cnVlCiAKIFRFU1QgQ09NUExFVEUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZG9t L2N1c3RvbS9kb2N1bWVudC1yZWdpc3Rlci1iYXNpYy5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9k b20vY3VzdG9tL2RvY3VtZW50LXJlZ2lzdGVyLWJhc2ljLmh0bWwKaW5kZXggMTA1Nzc4YzJjMTMy ZGUwZDE2YTQ5NTE5NDRlNzEwNzg3ODY4ZTJkOC4uZjViNzY5OWRmODNmNTBiYWZmOTU1MjI4M2Yz OGVhM2Y5Y2E0ZDU3MCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9kb20vY3VzdG9tL2Rv Y3VtZW50LXJlZ2lzdGVyLWJhc2ljLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vY3Vz dG9tL2RvY3VtZW50LXJlZ2lzdGVyLWJhc2ljLmh0bWwKQEAgLTc3LDYgKzc3LDcgQEAgc2hvdWxk QmUoInBhcnNlZEZvby5zb21lUHJvcGVydHkiLCAiY29udGFpbmVyLmZpcnN0Q2hpbGQuc29tZVBy b3BlcnR5Iik7CiAKIC8vIEhhdmluZyBhbm90aGVyIGNvbnN0cnVjdG9yCiB2YXIgYmFyQ29uc3Ry dWN0b3IgPSBkb2N1bWVudC5yZWdpc3RlcigieC1iYXIiLCBjcmVhdGVSZWdpc3RlclBhcmFtdGVy cygpKTsKK3Nob3VsZEJlVHJ1ZSgiYmFyQ29uc3RydWN0b3IgIT09IGZvb0NvbnN0cnVjdG9yIik7 CiB2YXIgY3JlYXRlZEJhciA9IG5ldyBiYXJDb25zdHJ1Y3RvcigpOwogc2hvdWxkQmUoImNyZWF0 ZWRCYXIudGFnTmFtZSIsICInWC1CQVInIik7CiAKQEAgLTEwNyw2ICsxMDgsMTEgQEAgc2hvdWxk QmUoIihuZXcgKGRvY3VtZW50LnJlZ2lzdGVyKCd5ei1iYXInLCBjcmVhdGVSZWdpc3RlclBhcmFt dGVycygpKSkoKSkudGFnTmEKIHNob3VsZEJlKCIobmV3IChkb2N1bWVudC5yZWdpc3RlcigneS16 LWJhcicsIGNyZWF0ZVJlZ2lzdGVyUGFyYW10ZXJzKCkpKSgpKS50YWdOYW1lIiwgIidZLVotQkFS JyIpOwogc2hvdWxkQmUoIihuZXcgKGRvY3VtZW50LnJlZ2lzdGVyKCd5LS1iYXInLCBjcmVhdGVS ZWdpc3RlclBhcmFtdGVycygpKSkoKSkudGFnTmFtZSIsICInWS0tQkFSJyIpOwogCisvLyBDb25z dHJ1Y3RvciBzaG91bGRuJ3QgaW50ZXJmZXJlIGVhY2ggb3RlaHIKK3Nob3VsZEJlKCIobmV3IGZv b0NvbnN0cnVjdG9yKS50YWdOYW1lIiwgIidYLUZPTyciKTsKK3Nob3VsZEJlKCIobmV3IGJhckNv bnN0cnVjdG9yKS50YWdOYW1lIiwgIidYLUJBUiciKTsKK3Nob3VsZEJlKCIobmV3IGJhekNvbnN0 cnVjdG9yKS50YWdOYW1lIiwgIidYLUJBWiciKTsKKwogPC9zY3JpcHQ+CiA8c2NyaXB0IHNyYz0i Li4vLi4vanMvcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+CiA8L2JvZHk+Cg==