111806 2013-03-07 18:37:23 -0800 Add Nils Barth and Koji Hara to committers.py as Contributor 2013-03-07 21:15:27 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 nbarth webkit-unassigned abarth dpranke eric webkit.review.bot oldest_to_newest 850737 0 nbarth 2013-03-07 18:37:23 -0800 Add Nils Barth and Koji Hara to committers.py 850738 1 192125 nbarth 2013-03-07 18:38:07 -0800 Created attachment 192125 Patch 850744 2 192125 dpranke 2013-03-07 18:46:18 -0800 Comment on attachment 192125 Patch Historically we have each committer had themselves individually and then commit the file directly (not using the cq), so that we can be sure the access controls are working. Can you please delete koji hara and have them submit their own change? 850749 3 192127 nbarth 2013-03-07 19:00:23 -0800 Created attachment 192127 Patch 850751 4 nbarth 2013-03-07 19:02:35 -0800 (In reply to comment #2) > (From update of attachment 192125 [details]) > Historically we have each committer had themselves individually and then commit the file directly (not using the cq), so that we can be sure the access controls are working. I'm only adding myself as a Contributor (for autocomplete etc.), not a Committer, so I can't commit the file myself, so I'll need a cq? as well. (Once I'll submit a separate patch to move myself to Committer instead.) > Can you please delete koji hara and have them submit their own change? Done! Thanks for explaining! 850767 5 192127 dpranke 2013-03-07 19:21:13 -0800 Comment on attachment 192127 Patch thanks! as mentioned previously, please try to land this directly rather than using the CQ. 850780 6 192127 eric 2013-03-07 19:37:27 -0800 Comment on attachment 192127 Patch The "don't use the commit-queue" concern is about adding Committers and Reviewers is my understanding. 850781 7 192125 eric 2013-03-07 19:37:41 -0800 Comment on attachment 192125 Patch This patch would have been fine too. 850783 8 192125 eric 2013-03-07 19:38:32 -0800 Comment on attachment 192125 Patch Dirk is correct in parrotting the party line. But the party line only applies to Committer/Reviewer changes is my understanding. Thank you all! 850784 9 192127 eric 2013-03-07 19:38:46 -0800 Comment on attachment 192127 Patch We'll try and land the bigger one for now. 850796 10 192125 webkit.review.bot 2013-03-07 19:55:44 -0800 Comment on attachment 192125 Patch Rejecting attachment 192125 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=gce-cq-03', 'validate-changelog', '--non-interactive', 192125, '--port=chromium-xvfb']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue /mnt/git/webkit-commit-queue/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-commit-queue.appspot.com/results/17066262 850824 11 192125 webkit.review.bot 2013-03-07 20:31:42 -0800 Comment on attachment 192125 Patch Clearing flags on attachment: 192125 Committed r145176: <http://trac.webkit.org/changeset/145176> 850825 12 webkit.review.bot 2013-03-07 20:31:46 -0800 All reviewed patches have been landed. Closing bug. 192125 2013-03-07 18:38:07 -0800 2013-03-07 20:31:42 -0800 Patch bug-111806-20130308113410.patch text/plain 1942 nbarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1MTY3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMjY2YzRmMWJlNjVmNTBiNjE4ZWYzOGMyNDQ1ZjlkNDgw NmE4NTZhYS4uZmZjYWQwYzJlZGFhNTY2MWU5ZDQ4MjBjYzg4MGRhMzA4ZjZjMzM4NSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEy IEBACisyMDEzLTAzLTA3ICBOaWxzIEJhcnRoICA8bmJhcnRoQGNocm9taXVtLm9yZz4KKworICAg ICAgICBBZGQgTmlscyBCYXJ0aCBhbmQgS29qaSBIYXJhIHRvIGNvbW1pdHRlcnMucHkKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMTgwNgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJr aXRweS9jb21tb24vY29uZmlnL2NvbW1pdHRlcnMucHk6CisKIDIwMTMtMDMtMDcgIENocmlzdGlh biBCaWVzaW5nZXIgIDxjYmllc2luZ2VyQGNocm9taXVtLm9yZz4KIAogICAgICAgICBBZGQgbXlz ZWxmIHRvIHJldmlld2Vycy5weQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9j b21tb24vY29uZmlnL2NvbW1pdHRlcnMucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1v bi9jb25maWcvY29tbWl0dGVycy5weQppbmRleCA3MDVhMGVjODI5MDQ1MjZmZmVmZDllZWQ0MWMz YmNkNTIxOTI2NzhhLi40NTk3MWI5ZjM1MWE4NDBlMjcxNjNhZDg4M2QxMTg3NDYwNjM2MzBlIDEw MDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jb25maWcvY29tbWl0dGVy cy5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jb25maWcvY29tbWl0dGVy cy5weQpAQCAtMTYyLDEyICsxNjIsMTQgQEAgY29udHJpYnV0b3JzX3dob19hcmVfbm90X2NvbW1p dHRlcnMgPSBbCiAgICAgQ29udHJpYnV0b3IoIkpvaG4gTWVsbG9yIiwgImpvaG5tZUBjaHJvbWl1 bS5vcmciLCAiam9obm1lIiksCiAgICAgQ29udHJpYnV0b3IoIkt1bGFudGhhaXZlbCBQYWxhbmlj aGFteSIsICJrdWxhbnRoYWl2ZWxAY29kZWF1cm9yYS5vcmciLCAia3ZlbCIpLAogICAgIENvbnRy aWJ1dG9yKCJLaXJhbiBNdXBwYWxhIiwgImNtdXBwYWxhQGFwcGxlLmNvbSIsICJraXJhbm0iKSwK KyAgICBDb250cmlidXRvcigiS29qaSBIYXJhIiwgImtvamloQGNocm9taXVtLm9yZyIsICJrb2pp aCIpLAogICAgIENvbnRyaWJ1dG9yKCJLb2ppIElzaGlpIiwgImtvamlpc2hpQGdtYWlsLmNvbSIp LAogICAgIENvbnRyaWJ1dG9yKCJNaWNoYWVsIFBydWV0dCIsICJtaWNoYWVsQDY4ay5vcmciLCAi bXBydWV0dCIpLAogICAgIENvbnRyaWJ1dG9yKCJNaWhhaSBCYWxhbiIsICJtaWJhbGFuQGFkb2Jl LmNvbSIsICJtaUNob3UiKSwKICAgICBDb250cmlidXRvcigiTWloYWkgTWFlcmVhbiIsICJtbWFl cmVhbkBhZG9iZS5jb20iLCAibW1hZXJlYW4iKSwKICAgICBDb250cmlidXRvcigiTWluIFFpbiIs ICJxaW5taW5AY2hyb21pdW0ub3JnIiksCiAgICAgQ29udHJpYnV0b3IoIk5hbmRvciBIdXN6a2Ei LCAiaG5hbmRvckBpbmYudS1zemVnZWQuaHUiLCAiaG5hbmRvciIpLAorICAgIENvbnRyaWJ1dG9y KCJOaWxzIEJhcnRoIiwgIm5iYXJ0aEBjaHJvbWl1bS5vcmciLCAibmJhcnRoIiksCiAgICAgQ29u dHJpYnV0b3IoIk9saXZlciBWYXJnYSIsIFsidm9saXZlckBpbmYudS1zemVnZWQuaHUiLCAiVmFy Z2EuT2xpdmVyQHN0dWQudS1zemVnZWQuaHUiXSwgIlR3aXN0TyIpLAogICAgIENvbnRyaWJ1dG9y KCJQZXRlciBHYWwiLCAiZ2FscGV0ZXJAaW5mLnUtc3plZ2VkLmh1IiwgImVsZWNybyIpLAogICAg IENvbnRyaWJ1dG9yKCJQZXRlciBMaW5zcyIsICJwZXRlci5saW5zc0BocC5jb20iLCAicGxpbnNz IiksCg== 192127 2013-03-07 19:00:23 -0800 2013-03-07 19:38:46 -0800 Patch bug-111806-20130308115627.patch text/plain 1477 nbarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1MTY3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMjY2YzRmMWJlNjVmNTBiNjE4ZWYzOGMyNDQ1ZjlkNDgw NmE4NTZhYS4uYTJiNmJmOTA4MTBmOGQyMTczZjI1ZDA5ZDk1ZTQ4MjQxOGIyYTYyMyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEy IEBACisyMDEzLTAzLTA3ICBOaWxzIEJhcnRoICA8bmJhcnRoQGNocm9taXVtLm9yZz4KKworICAg ICAgICBBZGQgTmlscyBCYXJ0aCB0byBjb21taXR0ZXJzLnB5IGFzIENvbnRyaWJ1dG9yCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTE4MDYKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvd2Vi a2l0cHkvY29tbW9uL2NvbmZpZy9jb21taXR0ZXJzLnB5OgorCiAyMDEzLTAzLTA3ICBDaHJpc3Rp YW4gQmllc2luZ2VyICA8Y2JpZXNpbmdlckBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgQWRkIG15 c2VsZiB0byByZXZpZXdlcnMucHkKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv Y29tbW9uL2NvbmZpZy9jb21taXR0ZXJzLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21t b24vY29uZmlnL2NvbW1pdHRlcnMucHkKaW5kZXggNzA1YTBlYzgyOTA0NTI2ZmZlZmQ5ZWVkNDFj M2JjZDUyMTkyNjc4YS4uMWQzZTk2NGZlMDZkODRmOWU1Yjg2M2MxYjMyOGFhMGE5YzRmODQ1MiAx MDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY29uZmlnL2NvbW1pdHRl cnMucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY29uZmlnL2NvbW1pdHRl cnMucHkKQEAgLTE2OCw2ICsxNjgsNyBAQCBjb250cmlidXRvcnNfd2hvX2FyZV9ub3RfY29tbWl0 dGVycyA9IFsKICAgICBDb250cmlidXRvcigiTWloYWkgTWFlcmVhbiIsICJtbWFlcmVhbkBhZG9i ZS5jb20iLCAibW1hZXJlYW4iKSwKICAgICBDb250cmlidXRvcigiTWluIFFpbiIsICJxaW5taW5A Y2hyb21pdW0ub3JnIiksCiAgICAgQ29udHJpYnV0b3IoIk5hbmRvciBIdXN6a2EiLCAiaG5hbmRv ckBpbmYudS1zemVnZWQuaHUiLCAiaG5hbmRvciIpLAorICAgIENvbnRyaWJ1dG9yKCJOaWxzIEJh cnRoIiwgIm5iYXJ0aEBjaHJvbWl1bS5vcmciLCAibmJhcnRoIiksCiAgICAgQ29udHJpYnV0b3Io Ik9saXZlciBWYXJnYSIsIFsidm9saXZlckBpbmYudS1zemVnZWQuaHUiLCAiVmFyZ2EuT2xpdmVy QHN0dWQudS1zemVnZWQuaHUiXSwgIlR3aXN0TyIpLAogICAgIENvbnRyaWJ1dG9yKCJQZXRlciBH YWwiLCAiZ2FscGV0ZXJAaW5mLnUtc3plZ2VkLmh1IiwgImVsZWNybyIpLAogICAgIENvbnRyaWJ1 dG9yKCJQZXRlciBMaW5zcyIsICJwZXRlci5saW5zc0BocC5jb20iLCAicGxpbnNzIiksCg==