111801 2013-03-07 17:35:31 -0800 Clean up NetworkProcess includes 2013-03-07 23:19:44 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap webkit.review.bot oldest_to_newest 850701 0 ap 2013-03-07 17:35:31 -0800 Move unnecessary includes out of headers. 850702 1 192117 ap 2013-03-07 17:37:42 -0800 Created attachment 192117 proposed patch 850706 2 webkit.review.bot 2013-03-07 17:39:35 -0800 Attachment 192117 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/NetworkProcess/HostRecord.h', u'Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.cpp', u'Source/WebKit2/NetworkProcess/NetworkProcess.cpp', u'Source/WebKit2/NetworkProcess/NetworkResourceLoadScheduler.cpp', u'Source/WebKit2/NetworkProcess/NetworkResourceLoadScheduler.h', u'Source/WebKit2/NetworkProcess/NetworkResourceLoader.h', u'Source/WebKit2/NetworkProcess/SchedulableLoader.cpp', u'Source/WebKit2/NetworkProcess/SchedulableLoader.h', u'Source/WebKit2/NetworkProcess/SyncNetworkResourceLoader.cpp']" exit_code: 1 Source/WebKit2/NetworkProcess/SyncNetworkResourceLoader.cpp:36: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style. 850791 3 192117 ggaren 2013-03-07 19:52:49 -0800 Comment on attachment 192117 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=192117&action=review r=me >> Source/WebKit2/NetworkProcess/SyncNetworkResourceLoader.cpp:36 >> #include <WebCore/ResourceResponse.h> >> +#include <WebCore/ResourceHandle.h> > > Alphabetical sorting problem. [build/include_order] [4] Switch the order here, please. 850913 4 ap 2013-03-07 23:19:44 -0800 Committed <http://trac.webkit.org/r145184>. 192117 2013-03-07 17:37:42 -0800 2013-03-07 19:52:49 -0800 proposed patch CleanupNetworkIncludes.txt text/plain 7009 ap SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0NTE2NCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDEzLTAzLTA3ICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTE4MDEKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTExMTgwMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIE1vdmUgdW5uZWNlc3NhcnkgaW5jbHVkZXMgb3V0IG9mIGhl YWRlcnMuCisKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9Ib3N0UmVjb3JkLmg6CisgICAgICAg ICogTmV0d29ya1Byb2Nlc3MvTmV0d29ya0Nvbm5lY3Rpb25Ub1dlYlByb2Nlc3MuY3BwOgorICAg ICAgICAqIE5ldHdvcmtQcm9jZXNzL05ldHdvcmtQcm9jZXNzLmNwcDoKKyAgICAgICAgKiBOZXR3 b3JrUHJvY2Vzcy9OZXR3b3JrUmVzb3VyY2VMb2FkU2NoZWR1bGVyLmNwcDoKKyAgICAgICAgKiBO ZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUmVzb3VyY2VMb2FkU2NoZWR1bGVyLmg6CisgICAgICAgICog TmV0d29ya1Byb2Nlc3MvTmV0d29ya1Jlc291cmNlTG9hZGVyLmg6CisgICAgICAgICogTmV0d29y a1Byb2Nlc3MvU2NoZWR1bGFibGVMb2FkZXIuY3BwOgorICAgICAgICAqIE5ldHdvcmtQcm9jZXNz L1NjaGVkdWxhYmxlTG9hZGVyLmg6CisgICAgICAgICogTmV0d29ya1Byb2Nlc3MvU3luY05ldHdv cmtSZXNvdXJjZUxvYWRlci5jcHA6CisKIDIwMTMtMDMtMDcgIE1hcmsgTGFtICA8bWFyay5sYW1A YXBwbGUuY29tPgogCiAgICAgICAgIFdlYlBhZ2VQcm94eTo6ZXhjZWVkZWREYXRhYmFzZVF1b3Rh KCkgbmVlZHMgdG8gYmUgc2VyaWFsaXplZC4KSW5kZXg6IFNvdXJjZS9XZWJLaXQyL05ldHdvcmtQ cm9jZXNzL0hvc3RSZWNvcmQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9OZXR3b3Jr UHJvY2Vzcy9Ib3N0UmVjb3JkLmgJKHJldmlzaW9uIDE0NTE0MSkKKysrIFNvdXJjZS9XZWJLaXQy L05ldHdvcmtQcm9jZXNzL0hvc3RSZWNvcmQuaAkod29ya2luZyBjb3B5KQpAQCAtMjgsNyArMjgs NyBAQAogCiAjaWYgRU5BQkxFKE5FVFdPUktfUFJPQ0VTUykKIAotI2luY2x1ZGUgPFdlYkNvcmUv UmVzb3VyY2VSZXF1ZXN0Lmg+CisjaW5jbHVkZSA8V2ViQ29yZS9SZXNvdXJjZUxvYWRQcmlvcml0 eS5oPgogI2luY2x1ZGUgPHd0Zi9EZXF1ZS5oPgogI2luY2x1ZGUgPHd0Zi9IYXNoU2V0Lmg+CiAj aW5jbHVkZSA8d3RmL1JlZkNvdW50ZWQuaD4KSW5kZXg6IFNvdXJjZS9XZWJLaXQyL05ldHdvcmtQ cm9jZXNzL05ldHdvcmtDb25uZWN0aW9uVG9XZWJQcm9jZXNzLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrQ29ubmVjdGlvblRvV2ViUHJvY2Vz cy5jcHAJKHJldmlzaW9uIDE0NTE0MSkKKysrIFNvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNz L05ldHdvcmtDb25uZWN0aW9uVG9XZWJQcm9jZXNzLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzEs NiArMzEsNyBAQAogI2luY2x1ZGUgIk5ldHdvcmtCbG9iUmVnaXN0cnkuaCIKICNpbmNsdWRlICJO ZXR3b3JrQ29ubmVjdGlvblRvV2ViUHJvY2Vzc01lc3NhZ2VzLmgiCiAjaW5jbHVkZSAiTmV0d29y a1Byb2Nlc3MuaCIKKyNpbmNsdWRlICJOZXR3b3JrUmVzb3VyY2VMb2FkUGFyYW1ldGVycy5oIgog I2luY2x1ZGUgIk5ldHdvcmtSZXNvdXJjZUxvYWRlci5oIgogI2luY2x1ZGUgIlJlbW90ZU5ldHdv cmtpbmdDb250ZXh0LmgiCiAjaW5jbHVkZSAiU3luY05ldHdvcmtSZXNvdXJjZUxvYWRlci5oIgpJ bmRleDogU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvTmV0d29ya1Byb2Nlc3MuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL05ldHdvcmtQcm9jZXNz LmNwcAkocmV2aXNpb24gMTQ1MTQxKQorKysgU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3Mv TmV0d29ya1Byb2Nlc3MuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zOCw2ICszOCw3IEBACiAjaW5j bHVkZSAiTmV0d29ya1Byb2Nlc3NQbGF0Zm9ybVN0cmF0ZWdpZXMuaCIKICNpbmNsdWRlICJOZXR3 b3JrUHJvY2Vzc1Byb3h5TWVzc2FnZXMuaCIKICNpbmNsdWRlICJSZW1vdGVOZXR3b3JraW5nQ29u dGV4dC5oIgorI2luY2x1ZGUgIlNjaGVkdWxhYmxlTG9hZGVyLmgiCiAjaW5jbHVkZSAiU3RhdGlz dGljc0RhdGEuaCIKICNpbmNsdWRlICJXZWJDb250ZXh0TWVzc2FnZXMuaCIKICNpbmNsdWRlICJX ZWJDb29raWVNYW5hZ2VyLmgiCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9O ZXR3b3JrUmVzb3VyY2VMb2FkU2NoZWR1bGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUmVzb3VyY2VMb2FkU2NoZWR1bGVyLmNwcAkocmV2 aXNpb24gMTQ1MTQxKQorKysgU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvTmV0d29ya1Jl c291cmNlTG9hZFNjaGVkdWxlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMsOSArMyw3IEBACiAK ICNpbmNsdWRlICJIb3N0UmVjb3JkLmgiCiAjaW5jbHVkZSAiTG9nZ2luZy5oIgotI2luY2x1ZGUg Ik5ldHdvcmtDb25uZWN0aW9uVG9XZWJQcm9jZXNzLmgiCiAjaW5jbHVkZSAiTmV0d29ya1Byb2Nl c3MuaCIKLSNpbmNsdWRlICJOZXR3b3JrUHJvY2Vzc0Nvbm5lY3Rpb25NZXNzYWdlcy5oIgogI2lu Y2x1ZGUgIk5ldHdvcmtSZXNvdXJjZUxvYWRQYXJhbWV0ZXJzLmgiCiAjaW5jbHVkZSAiTmV0d29y a1Jlc291cmNlTG9hZGVyLmgiCiAjaW5jbHVkZSAiU3luY05ldHdvcmtSZXNvdXJjZUxvYWRlci5o IgpJbmRleDogU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvTmV0d29ya1Jlc291cmNlTG9h ZFNjaGVkdWxlci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNz L05ldHdvcmtSZXNvdXJjZUxvYWRTY2hlZHVsZXIuaAkocmV2aXNpb24gMTQ1MTQxKQorKysgU291 cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvTmV0d29ya1Jlc291cmNlTG9hZFNjaGVkdWxlci5o CSh3b3JraW5nIGNvcHkpCkBAIC0yNiwxOSArMjYsMjIgQEAKICNpZm5kZWYgTmV0d29ya1Jlc291 cmNlTG9hZFNjaGVkdWxlcl9oCiAjZGVmaW5lIE5ldHdvcmtSZXNvdXJjZUxvYWRTY2hlZHVsZXJf aAogCi0jaW5jbHVkZSAiU2NoZWR1bGFibGVMb2FkZXIuaCIKLSNpbmNsdWRlIDxXZWJDb3JlL1Jl c291cmNlTG9hZGVyT3B0aW9ucy5oPgotI2luY2x1ZGUgPFdlYkNvcmUvUmVzb3VyY2VSZXF1ZXN0 Lmg+CisjaW5jbHVkZSA8V2ViQ29yZS9SZXNvdXJjZUxvYWRQcmlvcml0eS5oPgogI2luY2x1ZGUg PFdlYkNvcmUvVGltZXIuaD4KKyNpbmNsdWRlIDx3dGYvSGFzaE1hcC5oPgogI2luY2x1ZGUgPHd0 Zi9IYXNoU2V0Lmg+CisjaW5jbHVkZSA8d3RmL3RleHQvU3RyaW5nSGFzaC5oPgogCiAjaWYgRU5B QkxFKE5FVFdPUktfUFJPQ0VTUykKIAorbmFtZXNwYWNlIFdlYkNvcmUgeworY2xhc3MgS1VSTDsK K30KKwogbmFtZXNwYWNlIFdlYktpdCB7CiAKK2NsYXNzIFNjaGVkdWxhYmxlTG9hZGVyOwogY2xh c3MgSG9zdFJlY29yZDsKLWNsYXNzIE5ldHdvcmtSZXNvdXJjZUxvYWRQYXJhbWV0ZXJzOwotY2xh c3MgTmV0d29ya0Nvbm5lY3Rpb25Ub1dlYlByb2Nlc3M7CiAKIGNsYXNzIE5ldHdvcmtSZXNvdXJj ZUxvYWRTY2hlZHVsZXIgewogICAgIFdURl9NQUtFX05PTkNPUFlBQkxFKE5ldHdvcmtSZXNvdXJj ZUxvYWRTY2hlZHVsZXIpOyBXVEZfTUFLRV9GQVNUX0FMTE9DQVRFRDsKSW5kZXg6IFNvdXJjZS9X ZWJLaXQyL05ldHdvcmtQcm9jZXNzL05ldHdvcmtSZXNvdXJjZUxvYWRlci5oCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL05ldHdvcmtSZXNvdXJjZUxvYWRlci5o CShyZXZpc2lvbiAxNDUxNDEpCisrKyBTb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9OZXR3 b3JrUmVzb3VyY2VMb2FkZXIuaAkod29ya2luZyBjb3B5KQpAQCAtMjksMTkgKzI5LDE5IEBACiAj aWYgRU5BQkxFKE5FVFdPUktfUFJPQ0VTUykKIAogI2luY2x1ZGUgIk1lc3NhZ2VTZW5kZXIuaCIK LSNpbmNsdWRlICJOZXR3b3JrQ29ubmVjdGlvblRvV2ViUHJvY2Vzcy5oIgogI2luY2x1ZGUgIlNj aGVkdWxhYmxlTG9hZGVyLmgiCiAjaW5jbHVkZSA8V2ViQ29yZS9SZXNvdXJjZUhhbmRsZUNsaWVu dC5oPgogI2luY2x1ZGUgPFdlYkNvcmUvUmVzb3VyY2VMb2FkZXJPcHRpb25zLmg+Ci0jaW5jbHVk ZSA8V2ViQ29yZS9SZXNvdXJjZVJlcXVlc3QuaD4KIAogbmFtZXNwYWNlIFdlYkNvcmUgewogY2xh c3MgUmVzb3VyY2VCdWZmZXI7CiBjbGFzcyBSZXNvdXJjZUhhbmRsZTsKK2NsYXNzIFJlc291cmNl UmVxdWVzdDsKIH0KIAogbmFtZXNwYWNlIFdlYktpdCB7CiAKK2NsYXNzIE5ldHdvcmtDb25uZWN0 aW9uVG9XZWJQcm9jZXNzOwogY2xhc3MgUmVtb3RlTmV0d29ya2luZ0NvbnRleHQ7CiAKIGNsYXNz IE5ldHdvcmtSZXNvdXJjZUxvYWRlciA6IHB1YmxpYyBTY2hlZHVsYWJsZUxvYWRlciwgcHVibGlj IFdlYkNvcmU6OlJlc291cmNlSGFuZGxlQ2xpZW50LCBwdWJsaWMgQ29yZUlQQzo6TWVzc2FnZVNl bmRlcjxOZXR3b3JrUmVzb3VyY2VMb2FkZXI+IHsKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL05ldHdv cmtQcm9jZXNzL1NjaGVkdWxhYmxlTG9hZGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9OZXR3b3JrUHJvY2Vzcy9TY2hlZHVsYWJsZUxvYWRlci5jcHAJKHJldmlzaW9uIDE0NTE0 MSkKKysrIFNvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL1NjaGVkdWxhYmxlTG9hZGVyLmNw cAkod29ya2luZyBjb3B5KQpAQCAtMjksNiArMjksOCBAQAogI2lmIEVOQUJMRShORVRXT1JLX1BS T0NFU1MpCiAKICNpbmNsdWRlICJOZXR3b3JrQmxvYlJlZ2lzdHJ5LmgiCisjaW5jbHVkZSAiTmV0 d29ya0Nvbm5lY3Rpb25Ub1dlYlByb2Nlc3MuaCIKKyNpbmNsdWRlICJOZXR3b3JrUmVzb3VyY2VM b2FkUGFyYW1ldGVycy5oIgogI2luY2x1ZGUgPFdlYkNvcmUvRm9ybURhdGEuaD4KIAogdXNpbmcg bmFtZXNwYWNlIFdlYkNvcmU7CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9T Y2hlZHVsYWJsZUxvYWRlci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL05ldHdvcmtQ cm9jZXNzL1NjaGVkdWxhYmxlTG9hZGVyLmgJKHJldmlzaW9uIDE0NTE0MSkKKysrIFNvdXJjZS9X ZWJLaXQyL05ldHdvcmtQcm9jZXNzL1NjaGVkdWxhYmxlTG9hZGVyLmgJKHdvcmtpbmcgY29weSkK QEAgLTI3LDggKzI3LDggQEAKICNkZWZpbmUgU2NoZWR1bGFibGVMb2FkZXJfaAogCiAjaW5jbHVk ZSAiSG9zdFJlY29yZC5oIgotI2luY2x1ZGUgIk5ldHdvcmtDb25uZWN0aW9uVG9XZWJQcm9jZXNz LmgiCi0jaW5jbHVkZSAiTmV0d29ya1Jlc291cmNlTG9hZFBhcmFtZXRlcnMuaCIKKyNpbmNsdWRl IDxXZWJDb3JlL1Jlc291cmNlTG9hZGVyT3B0aW9ucy5oPgorI2luY2x1ZGUgPFdlYkNvcmUvUmVz b3VyY2VSZXF1ZXN0Lmg+CiAjaW5jbHVkZSA8d3RmL01haW5UaHJlYWQuaD4KICNpbmNsdWRlIDx3 dGYvUmVmQ291bnRlZC5oPgogCkBAIC0zNiw2ICszNiwxMCBAQAogCiBuYW1lc3BhY2UgV2ViS2l0 IHsKIAorY2xhc3MgTmV0d29ya0Nvbm5lY3Rpb25Ub1dlYlByb2Nlc3M7CitjbGFzcyBOZXR3b3Jr UmVzb3VyY2VMb2FkUGFyYW1ldGVyczsKK2NsYXNzIFNhbmRib3hFeHRlbnNpb247CisKIGNsYXNz IFNjaGVkdWxhYmxlTG9hZGVyIDogcHVibGljIFJlZkNvdW50ZWQ8U2NoZWR1bGFibGVMb2FkZXI+ IHsKIHB1YmxpYzoKICAgICB2aXJ0dWFsIH5TY2hlZHVsYWJsZUxvYWRlcigpOwpJbmRleDogU291 cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvU3luY05ldHdvcmtSZXNvdXJjZUxvYWRlci5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvU3luY05ldHdvcmtS ZXNvdXJjZUxvYWRlci5jcHAJKHJldmlzaW9uIDE0NTE0MSkKKysrIFNvdXJjZS9XZWJLaXQyL05l dHdvcmtQcm9jZXNzL1N5bmNOZXR3b3JrUmVzb3VyY2VMb2FkZXIuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0zMyw2ICszMyw3IEBACiAjaW5jbHVkZSAiUmVtb3RlTmV0d29ya2luZ0NvbnRleHQuaCIK ICNpbmNsdWRlIDxXZWJDb3JlL1Jlc291cmNlRXJyb3IuaD4KICNpbmNsdWRlIDxXZWJDb3JlL1Jl c291cmNlUmVzcG9uc2UuaD4KKyNpbmNsdWRlIDxXZWJDb3JlL1Jlc291cmNlSGFuZGxlLmg+CiAj aW5jbHVkZSA8d3RmL01haW5UaHJlYWQuaD4KIAogdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7Cg==