111793 2013-03-07 16:42:50 -0800 (tests) make nodesFromRect.js print a list of nodes that were found 2013-03-11 08:33:50 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cbiesinger cbiesinger allan.jensen tonikitoo webkit.review.bot oldest_to_newest 850621 0 cbiesinger 2013-03-07 16:42:50 -0800 (tests) make nodesFromRect.js print a list of nodes that were found 850625 1 192104 cbiesinger 2013-03-07 16:44:31 -0800 Created attachment 192104 Patch 850875 2 192104 tonikitoo 2013-03-07 22:05:03 -0800 Comment on attachment 192104 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=192104&action=review > LayoutTests/fast/dom/nodesFromRect/resources/nodesFromRect.js:21 > + for (var i = 0; i < nodes.length; i++) { I would have omitted the {} 851020 3 192104 allan.jensen 2013-03-08 02:25:21 -0800 Comment on attachment 192104 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=192104&action=review > LayoutTests/fast/dom/nodesFromRect/resources/nodesFromRect.js:23 > if (nodes.length != list.length) { > + var foundNodes = []; > + for (var i = 0; i < nodes.length; i++) { > + foundNodes.push(nodes[i].localName); > + } Couldn't you move the logic that makes a string out of a list of nodes from nodesFromRectAsString to a separate method, and reuse that? It would give you more than the localname. 851223 4 192104 cbiesinger 2013-03-08 08:46:08 -0800 Comment on attachment 192104 Patch Nice! I didn't notice that prettyprinting code there. I'll reuse it. 851232 5 192235 cbiesinger 2013-03-08 09:00:19 -0800 Created attachment 192235 Patch 852336 6 192235 allan.jensen 2013-03-11 08:24:07 -0700 Comment on attachment 192235 Patch LGTM 852349 7 192235 webkit.review.bot 2013-03-11 08:33:46 -0700 Comment on attachment 192235 Patch Clearing flags on attachment: 192235 Committed r145364: <http://trac.webkit.org/changeset/145364> 852350 8 webkit.review.bot 2013-03-11 08:33:50 -0700 All reviewed patches have been landed. Closing bug. 192104 2013-03-07 16:44:31 -0800 2013-03-08 09:00:17 -0800 Patch bug-111793-20130307164035.patch text/plain 1818 cbiesinger U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1MTA5CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggM2U3ZDkxYTU4NDBhYzgxOTRkYzA2 OGQwOWY0OGViZTNkMWFlNGZkYi4uMDRhMWM0NTg4MjYwYTExMGNjMzZhZDhjMTg2Zjg3MmY4NGM1 NzM1OCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEzLTAzLTA3ICBDaHJpc3RpYW4gQmllc2lu Z2VyICA8Y2JpZXNpbmdlckBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgKHRlc3RzKSBtYWtlIG5v ZGVzRnJvbVJlY3QuanMgcHJpbnQgYSBsaXN0IG9mIG5vZGVzIHRoYXQgd2VyZSBmb3VuZAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTExNzkzCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBmYXN0L2RvbS9u b2Rlc0Zyb21SZWN0L3Jlc291cmNlcy9ub2Rlc0Zyb21SZWN0LmpzOgorICAgICAgICAoY2hlY2sp OiBQcmludCBvdXQgYSBsaXN0IG9mIHRoZSBub2RlcyB0aGF0IHdlcmUgZm91bmQgaWYgdGhlcmUg aXMgYQorICAgICAgICBtaXNtYXRjaCBpbiB0aGUgbnVtYmVyIG9mIG5vZGVzLgorCiAyMDEzLTAz LTA2ICBPamFuIFZhZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmVjYWxjdWxh dGUgYm9yZGVycyBhdCB0aGUgYmVnaW5uaW5nIG9mIHRhYmxlIGxheW91dApkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvZmFzdC9kb20vbm9kZXNGcm9tUmVjdC9yZXNvdXJjZXMvbm9kZXNGcm9tUmVj dC5qcyBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL25vZGVzRnJvbVJlY3QvcmVzb3VyY2VzL25vZGVz RnJvbVJlY3QuanMKaW5kZXggMGU4OGQ5ZTJhNTRjMDkyNGRjYWJmOGRiYzJhYTQ2YjUxZDhlNjc0 MC4uZTVlOWVmNWVmNzk2MDI3MGM2ODY3NWU2NzVkYTg5NDAyMzgwMjkxMSAxMDA2NDQKLS0tIGEv TGF5b3V0VGVzdHMvZmFzdC9kb20vbm9kZXNGcm9tUmVjdC9yZXNvdXJjZXMvbm9kZXNGcm9tUmVj dC5qcworKysgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9ub2Rlc0Zyb21SZWN0L3Jlc291cmNlcy9u b2Rlc0Zyb21SZWN0LmpzCkBAIC0xNywxMSArMTcsMTUgQEAgZnVuY3Rpb24gY2hlY2soeCwgeSwg dG9wUGFkZGluZywgcmlnaHRQYWRkaW5nLCBib3R0b21QYWRkaW5nLCBsZWZ0UGFkZGluZywgbGlz dCwKICAgICByZXR1cm47CiAKICAgaWYgKG5vZGVzLmxlbmd0aCAhPSBsaXN0Lmxlbmd0aCkgewor ICAgIHZhciBmb3VuZE5vZGVzID0gW107CisgICAgZm9yICh2YXIgaSA9IDA7IGkgPCBub2Rlcy5s ZW5ndGg7IGkrKykgeworICAgICAgZm91bmROb2Rlcy5wdXNoKG5vZGVzW2ldLmxvY2FsTmFtZSk7 CisgICAgfQogICAgIHRlc3RGYWlsZWQoIkRpZmZlcmVudCBudW1iZXIgb2Ygbm9kZXMgZm9yIHJl Y3QiICsKICAgICAgICAgICAgICAgIlsiICsgeCArICIsIiArIHkgKyAiXSwgIiArCiAgICAgICAg ICAgICAgICJbIiArIHRvcFBhZGRpbmcgKyAiLCIgKyByaWdodFBhZGRpbmcgKwogICAgICAgICAg ICAgICAiLCIgKyBib3R0b21QYWRkaW5nICsgIiwiICsgbGVmdFBhZGRpbmcgKwotICAgICAgICAg ICAgICAiXTogJyIgKyBsaXN0Lmxlbmd0aCArICInIHZzICciICsgbm9kZXMubGVuZ3RoICsgIici KTsKKyAgICAgICAgICAgICAgIl06ICciICsgbGlzdC5sZW5ndGggKyAiJyB2cyAnIiArIG5vZGVz Lmxlbmd0aCArICInLCAiICsgZm91bmROb2Rlcyk7CiAgICAgcmV0dXJuOwogICB9CiAK 192235 2013-03-08 09:00:19 -0800 2013-03-11 08:33:46 -0700 Patch bug-111793-20130308085622.patch text/plain 4580 cbiesinger U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1MTA5CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggM2U3ZDkxYTU4NDBhYzgxOTRkYzA2 OGQwOWY0OGViZTNkMWFlNGZkYi4uNDcxZjhhYTlkZjk5MDk0ZDMwYjVkNWZkNzIzZWNkZWNiNzdk ZTZmYiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEzLTAzLTA4ICBDaHJpc3RpYW4gQmllc2lu Z2VyICA8Y2JpZXNpbmdlckBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgKHRlc3RzKSBtYWtlIG5v ZGVzRnJvbVJlY3QuanMgcHJpbnQgYSBsaXN0IG9mIG5vZGVzIHRoYXQgd2VyZSBmb3VuZAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTExNzkzCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBmYXN0L2RvbS9u b2Rlc0Zyb21SZWN0L3Jlc291cmNlcy9ub2Rlc0Zyb21SZWN0LmpzOgorICAgICAgICAobm9kZVRv U3RyaW5nKToKKyAgICAgICAgKG5vZGVMaXN0VG9TdHJpbmcpOgorICAgICAgICAoY2hlY2spOgor ICAgICAgICAobm9kZXNGcm9tUmVjdEFzU3RyaW5nKToKKyAgICAgICAgTW92ZSBub2RlIHByZXR0 eXByaW50aW5nIGNvZGUgZnJvbSBub2Rlc0Zyb21SZWN0QXNTdHJpbmcgdG8gbmV3CisgICAgICAg IGZ1bmN0aW9ucyBub2RlVG9TdHJpbmcgYW5kIG5vZGVMaXN0VG9TdHJpbmcsIGFuZCBtYWtlIHVz ZSBvZiBpdCBpbgorICAgICAgICBjaGVjaygpLgorICAgICAgICBJJ3ZlIGFsc28gY29udmVydGVk IHRoZSBub2RlVHlwZSBjaGVja3MgdG8gdXNlIHRoZSBjb25zdGFudHMgb24gTm9kZQorICAgICAg ICBpbnN0ZWFkIG9mIHVzaW5nIG1hZ2ljIG51bWJlcnMuCisKIDIwMTMtMDMtMDYgIE9qYW4gVmFm YWkgIDxvamFuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZWNhbGN1bGF0ZSBib3JkZXJzIGF0 IHRoZSBiZWdpbm5pbmcgb2YgdGFibGUgbGF5b3V0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9m YXN0L2RvbS9ub2Rlc0Zyb21SZWN0L3Jlc291cmNlcy9ub2Rlc0Zyb21SZWN0LmpzIGIvTGF5b3V0 VGVzdHMvZmFzdC9kb20vbm9kZXNGcm9tUmVjdC9yZXNvdXJjZXMvbm9kZXNGcm9tUmVjdC5qcwpp bmRleCAwZTg4ZDllMmE1NGMwOTI0ZGNhYmY4ZGJjMmFhNDZiNTFkOGU2NzQwLi5mZmE5ZWU0ZTJk MTc2NmRiYzEzMjZjMzE1NDc0ZDQzOGYzN2M4M2NmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9m YXN0L2RvbS9ub2Rlc0Zyb21SZWN0L3Jlc291cmNlcy9ub2Rlc0Zyb21SZWN0LmpzCisrKyBiL0xh eW91dFRlc3RzL2Zhc3QvZG9tL25vZGVzRnJvbVJlY3QvcmVzb3VyY2VzL25vZGVzRnJvbVJlY3Qu anMKQEAgLTQsNiArNCwzNiBAQAogICogICAgICogQWxsYW4gU2FuZGZlbGQgSmVuc2VuIDxhbGxh bi5qZW5zZW5AZGlnaWEuY29tPgogKiovCiAKK2Z1bmN0aW9uIG5vZGVUb1N0cmluZyhub2RlKSB7 CisgICAgdmFyIHN0ciA9ICIiOworICAgIGlmIChub2RlLm5vZGVUeXBlID09IE5vZGUuRUxFTUVO VF9OT0RFKSB7CisgICAgICAgIHN0ciArPSBub2RlLm5vZGVOYW1lOworICAgICAgICBpZiAobm9k ZS5pZCkKKyAgICAgICAgICAgIHN0ciArPSAnIycgKyBub2RlLmlkOworICAgICAgICBlbHNlIGlm IChub2RlLmNsYXNzKQorICAgICAgICAgICAgc3RyICs9ICcuJyArIG5vZGUuY2xhc3M7CisgICAg fSBlbHNlIGlmIChub2RlLm5vZGVUeXBlID09IE5vZGUuVEVYVF9OT0RFKSB7CisgICAgICAgIHN0 ciArPSAiJyIgKyBub2RlLmRhdGEgKyAiJyI7CisgICAgfSBlbHNlIGlmIChub2RlLm5vZGVUeXBl ID09IE5vZGUuRE9DVU1FTlRfTk9ERSkgeworICAgICAgICBzdHIgKz0gIiNkb2N1bWVudCI7Cisg ICAgfQorICAgIHJldHVybiBzdHI7Cit9CisKK2Z1bmN0aW9uIG5vZGVMaXN0VG9TdHJpbmcobm9k ZXMpIHsKKyAgICB2YXIgbm9kZVN0cmluZyA9ICIiOworCisgICAgZm9yICh2YXIgaSA9IDA7IGkg PCBub2Rlcy5sZW5ndGg7IGkrKykgeworICAgICAgICB2YXIgc3RyID0gbm9kZVRvU3RyaW5nKG5v ZGVzW2ldKTsKKyAgICAgICAgaWYgKCFzdHIpCisgICAgICAgICAgICBjb250aW51ZTsKKyAgICAg ICAgbm9kZVN0cmluZyArPSBzdHI7CisgICAgICAgIGlmIChpICsgMSA8IG5vZGVzLmxlbmd0aCkK KyAgICAgICAgICAgIG5vZGVTdHJpbmcgKz0gIiwgIjsKKyAgICB9CisgICAgcmV0dXJuIG5vZGVT dHJpbmc7Cit9CisKIGZ1bmN0aW9uIGNoZWNrKHgsIHksIHRvcFBhZGRpbmcsIHJpZ2h0UGFkZGlu ZywgYm90dG9tUGFkZGluZywgbGVmdFBhZGRpbmcsIGxpc3QsIGRvYykKIHsKICAgaWYgKCF3aW5k b3cuaW50ZXJuYWxzKQpAQCAtMjEsNyArNTEsOCBAQCBmdW5jdGlvbiBjaGVjayh4LCB5LCB0b3BQ YWRkaW5nLCByaWdodFBhZGRpbmcsIGJvdHRvbVBhZGRpbmcsIGxlZnRQYWRkaW5nLCBsaXN0LAog ICAgICAgICAgICAgICAiWyIgKyB4ICsgIiwiICsgeSArICJdLCAiICsKICAgICAgICAgICAgICAg IlsiICsgdG9wUGFkZGluZyArICIsIiArIHJpZ2h0UGFkZGluZyArCiAgICAgICAgICAgICAgICIs IiArIGJvdHRvbVBhZGRpbmcgKyAiLCIgKyBsZWZ0UGFkZGluZyArCi0gICAgICAgICAgICAgICJd OiAnIiArIGxpc3QubGVuZ3RoICsgIicgdnMgJyIgKyBub2Rlcy5sZW5ndGggKyAiJyIpOworICAg ICAgICAgICAgICAiXTogJyIgKyBsaXN0Lmxlbmd0aCArICInIHZzICciICsgbm9kZXMubGVuZ3Ro ICsKKyAgICAgICAgICAgICAgIicsIGZvdW5kOiAiICsgbm9kZUxpc3RUb1N0cmluZyhub2Rlcykp OwogICAgIHJldHVybjsKICAgfQogCkBAIC0zMCw3ICs2MSw4IEBAIGZ1bmN0aW9uIGNoZWNrKHgs IHksIHRvcFBhZGRpbmcsIHJpZ2h0UGFkZGluZywgYm90dG9tUGFkZGluZywgbGVmdFBhZGRpbmcs IGxpc3QsCiAgICAgICB0ZXN0RmFpbGVkKCJVbmV4cGVjdGVkIG5vZGUgIyIgKyBpICsgIiBmb3Ig cmVjdCAiICsKICAgICAgICAgICAgICAgICAiWyIgKyB4ICsgIiwiICsgeSArICJdLCAiICsKICAg ICAgICAgICAgICAgICAiWyIgKyB0b3BQYWRkaW5nICsgIiwiICsgcmlnaHRQYWRkaW5nICsKLSAg ICAgICAgICAgICAgICAiLCIgKyBib3R0b21QYWRkaW5nICsgIiwiICsgbGVmdFBhZGRpbmcgKyAi XSIgKyAiIC0gIiArIG5vZGVzW2ldKTsKKyAgICAgICAgICAgICAgICAiLCIgKyBib3R0b21QYWRk aW5nICsgIiwiICsgbGVmdFBhZGRpbmcgKyAiXSIgKworICAgICAgICAgICAgICAgICIgLSAiICsg bm9kZVRvU3RyaW5nKG5vZGVzW2ldKSk7CiAgICAgICByZXR1cm47CiAgICAgfQogICB9CkBAIC0x MTMsMzEgKzE0NSwxMSBAQCBmdW5jdGlvbiBjaGVja1BvaW50KGxlZnQsIHRvcCwgZXhwZWN0ZWRO b2RlU3RyaW5nLCBkb2MpCiAKIGZ1bmN0aW9uIG5vZGVzRnJvbVJlY3RBc1N0cmluZyhkb2MsIHgs IHksIHRvcFBhZGRpbmcsIHJpZ2h0UGFkZGluZywgYm90dG9tUGFkZGluZywgbGVmdFBhZGRpbmcp CiB7Ci0gICAgdmFyIG5vZGVTdHJpbmcgPSAiIjsKICAgICB2YXIgbm9kZXMgPSBpbnRlcm5hbHMu bm9kZXNGcm9tUmVjdChkb2MsIHgsIHksIHRvcFBhZGRpbmcsIHJpZ2h0UGFkZGluZywgYm90dG9t UGFkZGluZywgbGVmdFBhZGRpbmcsIHRydWUgLyogaWdub3JlQ2xpcHBpbmcgKi8sIGZhbHNlIC8q IGFsbG93IHNoYWRvdyBjb250ZW50ICovLCB0cnVlIC8qIGFsbG93IGNoaWxkLWZyYW1lIGNvbnRl bnQgKi8pOwogICAgIGlmICghbm9kZXMpCi0gICAgICAgIHJldHVybiBub2RlU3RyaW5nOworICAg ICAgICByZXR1cm4gIiI7CiAKLSAgICBmb3IgKHZhciBpID0gMDsgaSA8IG5vZGVzLmxlbmd0aDsg aSsrKSB7Ci0gICAgICAgIGlmIChub2Rlc1tpXS5ub2RlVHlwZSA9PSAxKSB7Ci0gICAgICAgICAg ICBub2RlU3RyaW5nICs9IG5vZGVzW2ldLm5vZGVOYW1lOwotICAgICAgICAgICAgaWYgKG5vZGVz W2ldLmlkKQotICAgICAgICAgICAgICAgIG5vZGVTdHJpbmcgKz0gJyMnICsgbm9kZXNbaV0uaWQ7 Ci0gICAgICAgICAgICBlbHNlIGlmIChub2Rlc1tpXS5jbGFzcykgewotICAgICAgICAgICAgICAg IG5vZGVTdHJpbmcgKz0gJy4nICsgbm9kZXNbaV0uY2xhc3M7Ci0gICAgICAgICAgICB9Ci0gICAg ICAgIH0gZWxzZSBpZiAobm9kZXNbaV0ubm9kZVR5cGUgPT0gMykgewotICAgICAgICAgICAgbm9k ZVN0cmluZyArPSAiJyIgKyBub2Rlc1tpXS5kYXRhICsgIiciOwotICAgICAgICB9IGVsc2UgaWYg KG5vZGVzW2ldLm5vZGVUeXBlID09IDkpIHsKLSAgICAgICAgICAgIG5vZGVTdHJpbmcgKz0gIiNk b2N1bWVudCI7Ci0gICAgICAgIH0gZWxzZSB7Ci0gICAgICAgICAgICBjb250aW51ZTsKLSAgICAg ICAgfQotICAgICAgICBpZiAoaSArIDEgPCBub2Rlcy5sZW5ndGgpIHsKLSAgICAgICAgICAgIG5v ZGVTdHJpbmcgKz0gIiwgIjsKLSAgICAgICAgfQotICAgIH0KLSAgICByZXR1cm4gbm9kZVN0cmlu ZzsKKyAgICByZXR1cm4gbm9kZUxpc3RUb1N0cmluZyhub2Rlcyk7CiB9CiAKIGZ1bmN0aW9uIGdl dENlbnRlckZvcihlbGVtZW50KQo=