111730 2013-03-07 07:42:24 -0800 Web Inspector: Add some more compilation annotations to NavigatorView 2013-03-07 08:30:36 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 vsevik vsevik apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 850084 0 vsevik 2013-03-07 07:42:24 -0800 Patch to follow. 850085 1 191997 vsevik 2013-03-07 07:45:03 -0800 Created attachment 191997 Patch 850113 2 191997 webkit.review.bot 2013-03-07 08:30:33 -0800 Comment on attachment 191997 Patch Clearing flags on attachment: 191997 Committed r145082: <http://trac.webkit.org/changeset/145082> 850114 3 webkit.review.bot 2013-03-07 08:30:36 -0800 All reviewed patches have been landed. Closing bug. 191997 2013-03-07 07:45:03 -0800 2013-03-07 08:30:32 -0800 Patch bug-111730-20130307194107.patch text/plain 3906 vsevik U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1MDc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2NkNDE3NGViZWI1NzRh OWNhYjMxNjU3Y2FiNmUwOTFmYTI4ZTQyZS4uMWY4ZjU4NmNhMWI0ZjUyMDNmMGY3NzkwYzVlYjAy YWYxZWUyMzBkZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE0IEBACiAyMDEzLTAzLTA3ICBWc2V2 b2xvZCBWbGFzb3YgIDx2c2V2aWtAY2hyb21pdW0ub3JnPgogCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IEFkZCBzb21lIG1vcmUgY29tcGlsYXRpb24gYW5ub3RhdGlvbnMgdG8gTmF2aWdhdG9yVmll dworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTExNzMw CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBpbnNw ZWN0b3IvZnJvbnQtZW5kL05hdmlnYXRvclZpZXcuanM6CisKKzIwMTMtMDMtMDcgIFZzZXZvbG9k IFZsYXNvdiAgPHZzZXZpa0BjaHJvbWl1bS5vcmc+CisKICAgICAgICAgV2ViIEluc3BlY3Rvcjog U3VwcG9ydCBhIHNob3J0Y3V0IGZvciByZWxvYWRpbmcgZnJvbnQtZW5kIGluIGRlYnVnIG1vZGUu CiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTE3MDkK IApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9OYXZpZ2F0 b3JWaWV3LmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9OYXZpZ2F0b3JW aWV3LmpzCmluZGV4IGUxN2U5NGVjNmU5YTQwY2VkZGIzMWQ2NGRkNjdlM2UwYTUwZjcxMDcuLjIy Yzk2ZWE4YzI2MTU0MjY2MDgxMWQzMmVmZTBhM2EzZWE2MmEyYmQgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvTmF2aWdhdG9yVmlldy5qcworKysgYi9Tb3Vy Y2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL05hdmlnYXRvclZpZXcuanMKQEAgLTg1LDYg Kzg1LDEwIEBAIFdlYkluc3BlY3Rvci5OYXZpZ2F0b3JWaWV3LnByb3RvdHlwZSA9IHsKICAgICAg ICAgbm9kZS5hcHBlbmRDaGlsZCh1aVNvdXJjZUNvZGVOb2RlKTsKICAgICB9LAogCisgICAgLyoq CisgICAgICogQHBhcmFtIHtXZWJJbnNwZWN0b3IuUHJvamVjdH0gcHJvamVjdAorICAgICAqIEBy ZXR1cm4ge1dlYkluc3BlY3Rvci5OYXZpZ2F0b3JUcmVlTm9kZX0KKyAgICAgKi8KICAgICBfZ2V0 UHJvamVjdE5vZGU6IGZ1bmN0aW9uKHByb2plY3QpCiAgICAgewogICAgICAgICBpZiAoIXByb2pl Y3QuZGlzcGxheU5hbWUoKSkKQEAgLTkyLDYgKzk2LDEwIEBAIFdlYkluc3BlY3Rvci5OYXZpZ2F0 b3JWaWV3LnByb3RvdHlwZSA9IHsKICAgICAgICAgcmV0dXJuIHRoaXMuX3Jvb3ROb2RlLmNoaWxk KHByb2plY3QuaWQoKSk7CiAgICAgfSwKIAorICAgIC8qKgorICAgICAqIEBwYXJhbSB7V2ViSW5z cGVjdG9yLlByb2plY3R9IHByb2plY3QKKyAgICAgKiBAcmV0dXJuIHtXZWJJbnNwZWN0b3IuTmF2 aWdhdG9yRm9sZGVyVHJlZU5vZGV9CisgICAgICovCiAgICAgX2NyZWF0ZVByb2plY3ROb2RlOiBm dW5jdGlvbihwcm9qZWN0KQogICAgIHsKICAgICAgICAgdmFyIHR5cGUgPSBwcm9qZWN0LnR5cGUo KSA9PT0gV2ViSW5zcGVjdG9yLnByb2plY3RUeXBlcy5GaWxlU3lzdGVtID8gV2ViSW5zcGVjdG9y Lk5hdmlnYXRvclRyZWVPdXRsaW5lLlR5cGVzLkZpbGVTeXN0ZW0gOiBXZWJJbnNwZWN0b3IuTmF2 aWdhdG9yVHJlZU91dGxpbmUuVHlwZXMuRG9tYWluOwpAQCAtMTAwLDE2ICsxMDgsMzAgQEAgV2Vi SW5zcGVjdG9yLk5hdmlnYXRvclZpZXcucHJvdG90eXBlID0gewogICAgICAgICByZXR1cm4gcHJv amVjdE5vZGU7CiAgICAgfSwKIAorICAgIC8qKgorICAgICAqIEBwYXJhbSB7V2ViSW5zcGVjdG9y LlByb2plY3R9IHByb2plY3QKKyAgICAgKiBAcmV0dXJuIHtXZWJJbnNwZWN0b3IuTmF2aWdhdG9y VHJlZU5vZGV9CisgICAgICovCiAgICAgX2dldE9yQ3JlYXRlUHJvamVjdE5vZGU6IGZ1bmN0aW9u KHByb2plY3QpCiAgICAgewogICAgICAgICByZXR1cm4gdGhpcy5fZ2V0UHJvamVjdE5vZGUocHJv amVjdCkgfHwgdGhpcy5fY3JlYXRlUHJvamVjdE5vZGUocHJvamVjdCk7CiAgICAgfSwKIAorICAg IC8qKgorICAgICAqIEBwYXJhbSB7V2ViSW5zcGVjdG9yLk5hdmlnYXRvclRyZWVOb2RlfSBwYXJl bnROb2RlCisgICAgICogQHBhcmFtIHtzdHJpbmd9IG5hbWUKKyAgICAgKiBAcmV0dXJuIHtXZWJJ bnNwZWN0b3IuTmF2aWdhdG9yRm9sZGVyVHJlZU5vZGV9CisgICAgICovCiAgICAgX2dldEZvbGRl ck5vZGU6IGZ1bmN0aW9uKHBhcmVudE5vZGUsIG5hbWUpCiAgICAgewogICAgICAgICByZXR1cm4g cGFyZW50Tm9kZS5jaGlsZChuYW1lKTsKICAgICB9LAogCisgICAgLyoqCisgICAgICogQHBhcmFt IHtXZWJJbnNwZWN0b3IuTmF2aWdhdG9yVHJlZU5vZGV9IHBhcmVudE5vZGUKKyAgICAgKiBAcGFy YW0ge3N0cmluZ30gbmFtZQorICAgICAqIEByZXR1cm4ge1dlYkluc3BlY3Rvci5OYXZpZ2F0b3JG b2xkZXJUcmVlTm9kZX0KKyAgICAgKi8KICAgICBfY3JlYXRlRm9sZGVyTm9kZTogZnVuY3Rpb24o cGFyZW50Tm9kZSwgbmFtZSkKICAgICB7CiAgICAgICAgIHZhciBmb2xkZXJOb2RlID0gbmV3IFdl Ykluc3BlY3Rvci5OYXZpZ2F0b3JGb2xkZXJUcmVlTm9kZSh0aGlzLCBuYW1lLCBXZWJJbnNwZWN0 b3IuTmF2aWdhdG9yVHJlZU91dGxpbmUuVHlwZXMuRm9sZGVyLCBuYW1lKTsKQEAgLTExNywxMSAr MTM5LDIwIEBAIFdlYkluc3BlY3Rvci5OYXZpZ2F0b3JWaWV3LnByb3RvdHlwZSA9IHsKICAgICAg ICAgcmV0dXJuIGZvbGRlck5vZGU7CiAgICAgfSwKIAorICAgIC8qKgorICAgICAqIEBwYXJhbSB7 V2ViSW5zcGVjdG9yLk5hdmlnYXRvclRyZWVOb2RlfSBwYXJlbnROb2RlCisgICAgICogQHBhcmFt IHtzdHJpbmd9IG5hbWUKKyAgICAgKiBAcmV0dXJuIHtXZWJJbnNwZWN0b3IuTmF2aWdhdG9yRm9s ZGVyVHJlZU5vZGV9CisgICAgICovCiAgICAgX2dldE9yQ3JlYXRlRm9sZGVyTm9kZTogZnVuY3Rp b24ocGFyZW50Tm9kZSwgbmFtZSkKICAgICB7CiAgICAgICAgIHJldHVybiB0aGlzLl9nZXRGb2xk ZXJOb2RlKHBhcmVudE5vZGUsIG5hbWUpIHx8IHRoaXMuX2NyZWF0ZUZvbGRlck5vZGUocGFyZW50 Tm9kZSwgbmFtZSk7CiAgICAgfSwKIAorICAgIC8qKgorICAgICAqIEBwYXJhbSB7V2ViSW5zcGVj dG9yLlVJU291cmNlQ29kZX0gdWlTb3VyY2VDb2RlCisgICAgICogQHJldHVybiB7V2ViSW5zcGVj dG9yLk5hdmlnYXRvclRyZWVOb2RlfQorICAgICAqLwogICAgIF9nZXRVSVNvdXJjZUNvZGVQYXJl bnROb2RlOiBmdW5jdGlvbih1aVNvdXJjZUNvZGUpCiAgICAgewogICAgICAgICB2YXIgcHJvamVj dE5vZGUgPSB0aGlzLl9nZXRQcm9qZWN0Tm9kZSh1aVNvdXJjZUNvZGUucHJvamVjdCgpKTsKQEAg LTEzNyw2ICsxNjgsMTAgQEAgV2ViSW5zcGVjdG9yLk5hdmlnYXRvclZpZXcucHJvdG90eXBlID0g ewogICAgICAgICByZXR1cm4gcGFyZW50Tm9kZTsKICAgICB9LAogCisgICAgLyoqCisgICAgICog QHBhcmFtIHtXZWJJbnNwZWN0b3IuVUlTb3VyY2VDb2RlfSB1aVNvdXJjZUNvZGUKKyAgICAgKiBA cmV0dXJuIHtXZWJJbnNwZWN0b3IuTmF2aWdhdG9yVHJlZU5vZGV9CisgICAgICovCiAgICAgX2dl dE9yQ3JlYXRlVUlTb3VyY2VDb2RlUGFyZW50Tm9kZTogZnVuY3Rpb24odWlTb3VyY2VDb2RlKQog ICAgIHsKICAgICAgICAgdmFyIHByb2plY3ROb2RlID0gdGhpcy5fZ2V0T3JDcmVhdGVQcm9qZWN0 Tm9kZSh1aVNvdXJjZUNvZGUucHJvamVjdCgpKTsK