111725 2013-03-07 06:34:39 -0800 Adding a hook to collect data for a Google UMA histogram to track when m_needsCompositedScrolling is turned on and off 2013-03-08 08:30:44 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 hartmanng webkit-unassigned eric esprehn+autocc hartmanng jchaffraix ojan.autocc simon.fraser vollick webkit.review.bot oldest_to_newest 850041 0 hartmanng 2013-03-07 06:34:39 -0800 Adding a histogram to track when m_needsCompositedScrolling is turned on and off 850042 1 191986 hartmanng 2013-03-07 06:35:14 -0800 Created attachment 191986 Patch 850472 2 191986 jchaffraix 2013-03-07 14:06:18 -0800 Comment on attachment 191986 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=191986&action=review > Source/WebCore/rendering/RenderLayer.cpp:2018 > + if (acceleratedCompositingForOverflowScrollEnabled()) > + HistogramSupport::histogramEnumeration("Renderer.NeedsCompositedScrolling", m_needsCompositedScrolling, 2); It would have been nice to explain *what* you are trying to measure as well as *why*. Without the context, it's difficult to know if this is correct or why we can't other some other mechanism like FeatureObserver. After talking with Glenn over IM, they want to measure the frequency of the feature at the layer level as a rough estimate of what could be done. They understand that this number will not be actionable but that giving the reasons for not having composited scrolling are expensive to compute and we want the overhead minimal. All in all, the code change make sense but please add the relevant bits to the ChangeLog or as a comment in the code (remember that WebKit prefers 'why' comments over 'what' comments though). 850478 3 simon.fraser 2013-03-07 14:16:20 -0800 Out of context, I've no idea what it means to "add a Histogram". How do I get to see the histogram? I think what you really mean is "add some instrumentation so that Google can collect data, which might be displayed in a histogram at some point". 851154 4 192219 hartmanng 2013-03-08 06:52:50 -0800 Created attachment 192219 Patch 851217 5 192219 webkit.review.bot 2013-03-08 08:30:41 -0800 Comment on attachment 192219 Patch Clearing flags on attachment: 192219 Committed r145229: <http://trac.webkit.org/changeset/145229> 851218 6 webkit.review.bot 2013-03-08 08:30:44 -0800 All reviewed patches have been landed. Closing bug. 191986 2013-03-07 06:35:14 -0800 2013-03-08 06:52:46 -0800 Patch bug-111725-20130307093118.patch text/plain 1712 hartmanng U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1MDY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWNjYjgxNTI3YzRlZmJl MjMyNTk3ZjI1ZDYwMjZlZmRlZmE4YTM4Zi4uMTEyMjU2MmFhMzZjMjdhNDM0MzMyM2UzNzM3ZWU4 MmUxMTEwZjRhOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTAzLTA3ICBHbGVu biBIYXJ0bWFubiAgPGhhcnRtYW5uZ0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgQWRkaW5nIGEg aGlzdG9ncmFtIHRvIHRyYWNrIHdoZW4gbV9uZWVkc0NvbXBvc2l0ZWRTY3JvbGxpbmcgaXMgdHVy bmVkIG9uIGFuZCBvZmYKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTExMTcyNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIE5vIG5ldyB0ZXN0cyAobm8gY2hhbmdlIGluIGJlaGF2aW91cikuCisKKyAgICAgICAg KiByZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5 ZXI6OnVwZGF0ZU5lZWRzQ29tcG9zaXRlZFNjcm9sbGluZyk6CisKIDIwMTMtMDMtMDcgIElhbiBW b2xsaWNrICA8dm9sbGlja0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgRml4IHBhaW50aW5nIHBo YXNlcyBmb3IgY29tcG9zaXRlZCBzY3JvbGxpbmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyTGF5ZXIuY3BwCmluZGV4IDUxMzRkZmJhOTQ5MDliZGIxN2YyMWZjMGQyNWJhZjRjZDAxMzNj NGEuLmY0OGFhOTg1YzllMWVkY2IwN2FlZmQwOThiZmI3YWFkNzFmZDYwMzUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcApAQCAtNzEsNiArNzEsNyBAQAogI2luY2x1 ZGUgIkhUTUxGcmFtZUVsZW1lbnQuaCIKICNpbmNsdWRlICJIVE1MRnJhbWVPd25lckVsZW1lbnQu aCIKICNpbmNsdWRlICJIVE1MTmFtZXMuaCIKKyNpbmNsdWRlICJIaXN0b2dyYW1TdXBwb3J0Lmgi CiAjaW5jbHVkZSAiSGl0VGVzdGluZ1RyYW5zZm9ybVN0YXRlLmgiCiAjaW5jbHVkZSAiSGl0VGVz dFJlcXVlc3QuaCIKICNpbmNsdWRlICJIaXRUZXN0UmVzdWx0LmgiCkBAIC0yMDEzLDYgKzIwMTQs OCBAQCB2b2lkIFJlbmRlckxheWVyOjp1cGRhdGVOZWVkc0NvbXBvc2l0ZWRTY3JvbGxpbmcoKQog I2Vsc2UKICAgICAgICAgbV9uZWVkc0NvbXBvc2l0ZWRTY3JvbGxpbmcgPSBmb3JjZVVzZUNvbXBv c2l0ZWRTY3JvbGxpbmc7CiAjZW5kaWYKKyAgICAgICAgaWYgKGFjY2VsZXJhdGVkQ29tcG9zaXRp bmdGb3JPdmVyZmxvd1Njcm9sbEVuYWJsZWQoKSkKKyAgICAgICAgICAgIEhpc3RvZ3JhbVN1cHBv cnQ6Omhpc3RvZ3JhbUVudW1lcmF0aW9uKCJSZW5kZXJlci5OZWVkc0NvbXBvc2l0ZWRTY3JvbGxp bmciLCBtX25lZWRzQ29tcG9zaXRlZFNjcm9sbGluZywgMik7CiAgICAgfQogCiAgICAgaWYgKG9s ZE5lZWRzQ29tcG9zaXRlZFNjcm9sbGluZyAhPSBtX25lZWRzQ29tcG9zaXRlZFNjcm9sbGluZykg ewo= 192219 2013-03-08 06:52:50 -0800 2013-03-08 08:30:41 -0800 Patch bug-111725-20130308094853.patch text/plain 3327 hartmanng U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1MDY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWNjYjgxNTI3YzRlZmJl MjMyNTk3ZjI1ZDYwMjZlZmRlZmE4YTM4Zi4uMmJlMGViNDE0NDk3M2Q5Y2JjOWZjYWNkNDQyZDU5 ODAzOTUxNDE5NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM4IEBACisyMDEzLTAzLTA4ICBHbGVu biBIYXJ0bWFubiAgPGhhcnRtYW5uZ0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICBBZGRpbmcgYSBo b29rIHRvIGNvbGxlY3QgZGF0YSBmb3IgYSBHb29nbGUgVU1BIGhpc3RvZ3JhbSB0byB0cmFjayB3 aGVuCisgICAgICAgbV9uZWVkc0NvbXBvc2l0ZWRTY3JvbGxpbmcgaXMgdHVybmVkIG9uIGFuZCBv ZmYuCisgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMTcy NQorCisgICAgICAgUmV2aWV3ZWQgYnkgSnVsaWVuIENoYWZmcmFpeC4KKworICAgICAgIFdlIHdh bnQgdG8ga2VlcCB0cmFjayBvZiB0aGlzIGluZm9ybWF0aW9uIHRvIHF1YW50aWZ5IHRoZSBlZmZl Y3RzIG9mIGEKKyAgICAgICBmZXcgcGF0Y2hlcyB0aGF0IHdpbGwgY2F1c2UgdXMgdG8gb3B0IGlu IHRvIGNvbXBvc2l0ZWQgc2Nyb2xsaW5nLgorICAgICAgIFNwZWNpZmljYWxseSwgd2Ugd2FudCB0 byBtZWFzdXJlIHRoZSBlZmZlY3RzIG9mCisgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEwOTMwMiwKKyAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTA5OTY2LAorICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMDk1OTEsIGFuZAorICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMDc2MTguCisKKyAgICAgICBXZSBkbyB0aGlzIGJ5IG1lYXN1cmlu ZyBhIHBlci1sYXllciBib29sZWFuIHZhbHVlLCBhbmQgY29tcGFyaW5nIHRoZQorICAgICAgIHJh dGlvIGJldHdlZW4gbnVtYmVyIG9mIGxheWVycyBvcHRlZCBpbiBhbmQgbnVtYmVyIG9mIGxheWVy cyB0aGF0IHJlbWFpbgorICAgICAgIHVuY29tcG9zaXRlZC4gV2UgaG9wZSB0aGUgcmVsYXRpdmUg bnVtYmVyIG9mIGxheWVycyBvcHRpbmcgaW4gd2lsbAorICAgICAgIGluY3JlYXNlIGFmdGVyIHRo ZSByZWxldmFudCBwYXRjaGVzIGxhbmQgYW5kIGFyZSBlbmFibGVkLgorCisgICAgICAgVW5mb3J0 dW5hdGVseSBpbXBsZW1lbnRpbmcgZXh0cmEgc3RhdGlzdGljcyBpcyBpbXByYWN0aWNhbCBhdCB0 aGUKKyAgICAgICBtb21lbnQgc2luY2UgbW9zdCBvZiB0aGUgYWN0aW9uYWJsZSByZWxldmFudCBk YXRhIGlzIGV4cGVuc2l2ZSB0bworICAgICAgIGNvbXB1dGUuIEZvciBleGFtcGxlLCBpdCB3b3Vs ZCBiZSB1c2VmdWwgdG8ga25vdyBpZiB0aGUgbGF5ZXJzIHRoYXQgb3B0CisgICAgICAgb3V0IGRv IHNvIGJlY2F1c2Ugb2YgaW52aXNpYmxlIG9yIG5vbi1vdmVybGFwcGluZyBsYXllcnMgdGhhdCBj YXVzZSBhCisgICAgICAgcG90ZW50aWFsIHN0YWNraW5nIGNvbnRhaW5lcidzIGNoaWxkcmVuIHRv IGJlIGRpc2NvbnRpZ3VvdXMsIGJlY2F1c2Ugd2UKKyAgICAgICB3b3VsZCBwb3RlbnRpYWxseSBi ZSBhYmxlIHRvIG1pdGlnYXRlIHRoZSBwcm9ibGVtLiBIb3dldmVyLCB0aGlzIHdvdWxkCisgICAg ICAgYWRkIGNvbnNpZGVyYWJsZSBvdmVyaGVhZCB0byBwZXJmb3JtIG92ZXJsYXAgdGVzdGluZyBq dXN0IHRvIGdhdGhlcgorICAgICAgIGRhdGEuCisKKyAgICAgICBObyBuZXcgdGVzdHMgKG5vIGNo YW5nZSBpbiBiZWhhdmlvdXIpLgorCisgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3Bw OgorICAgICAgIChXZWJDb3JlOjpSZW5kZXJMYXllcjo6dXBkYXRlTmVlZHNDb21wb3NpdGVkU2Ny b2xsaW5nKToKKwogMjAxMy0wMy0wNyAgSWFuIFZvbGxpY2sgIDx2b2xsaWNrQGNocm9taXVtLm9y Zz4KIAogICAgICAgICBGaXggcGFpbnRpbmcgcGhhc2VzIGZvciBjb21wb3NpdGVkIHNjcm9sbGlu ZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcCBi L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAKaW5kZXggNTEzNGRmYmE5 NDkwOWJkYjE3ZjIxZmMwZDI1YmFmNGNkMDEzM2M0YS4uNWU3NDc3OGMzMTJlNzVhNmFkYzg1ZjA1 NWY4MjQyNjZhMTJhMGQ4NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlckxheWVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIu Y3BwCkBAIC03MSw2ICs3MSw3IEBACiAjaW5jbHVkZSAiSFRNTEZyYW1lRWxlbWVudC5oIgogI2lu Y2x1ZGUgIkhUTUxGcmFtZU93bmVyRWxlbWVudC5oIgogI2luY2x1ZGUgIkhUTUxOYW1lcy5oIgor I2luY2x1ZGUgIkhpc3RvZ3JhbVN1cHBvcnQuaCIKICNpbmNsdWRlICJIaXRUZXN0aW5nVHJhbnNm b3JtU3RhdGUuaCIKICNpbmNsdWRlICJIaXRUZXN0UmVxdWVzdC5oIgogI2luY2x1ZGUgIkhpdFRl c3RSZXN1bHQuaCIKQEAgLTIwMTMsNiArMjAxNCwxMiBAQCB2b2lkIFJlbmRlckxheWVyOjp1cGRh dGVOZWVkc0NvbXBvc2l0ZWRTY3JvbGxpbmcoKQogI2Vsc2UKICAgICAgICAgbV9uZWVkc0NvbXBv c2l0ZWRTY3JvbGxpbmcgPSBmb3JjZVVzZUNvbXBvc2l0ZWRTY3JvbGxpbmc7CiAjZW5kaWYKKyAg ICAgICAgLy8gV2UgZ2F0aGVyIGEgYm9vbGVhbiB2YWx1ZSBmb3IgdXNlIHdpdGggR29vZ2xlIFVN QSBoaXN0b2dyYW1zIHRvCisgICAgICAgIC8vIHF1YW50aWZ5IHRoZSBhY3R1YWwgZWZmZWN0cyBv ZiBhIHNldCBvZiBwYXRjaGVzIGF0dGVtcHRpbmcgdG8KKyAgICAgICAgLy8gcmVsYXggY29tcG9z aXRlZCBzY3JvbGxpbmcgcmVxdWlyZW1lbnRzLCB0aGVyZWJ5IGluY3JlYXNpbmcgdGhlCisgICAg ICAgIC8vIG51bWJlciBvZiBjb21wb3NpdGVkIG92ZXJmbG93IGRpdnMuCisgICAgICAgIGlmIChh Y2NlbGVyYXRlZENvbXBvc2l0aW5nRm9yT3ZlcmZsb3dTY3JvbGxFbmFibGVkKCkpCisgICAgICAg ICAgICBIaXN0b2dyYW1TdXBwb3J0OjpoaXN0b2dyYW1FbnVtZXJhdGlvbigiUmVuZGVyZXIuTmVl ZHNDb21wb3NpdGVkU2Nyb2xsaW5nIiwgbV9uZWVkc0NvbXBvc2l0ZWRTY3JvbGxpbmcsIDIpOwog ICAgIH0KIAogICAgIGlmIChvbGROZWVkc0NvbXBvc2l0ZWRTY3JvbGxpbmcgIT0gbV9uZWVkc0Nv bXBvc2l0ZWRTY3JvbGxpbmcpIHsK