111717 2013-03-07 05:58:06 -0800 Web Inspector: [CodeMirror] set indentation size according to devtools settings 2013-03-11 08:51:45 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 lushnikov lushnikov apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 850009 0 lushnikov 2013-03-07 05:58:06 -0800 Set indentation size in CodeMirror experiment according to devtools settings. 850015 1 191982 lushnikov 2013-03-07 06:00:48 -0800 Created attachment 191982 Patch 850104 2 191982 vsevik 2013-03-07 08:09:57 -0800 Comment on attachment 191982 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=191982&action=review > Source/WebCore/inspector/front-end/CodeMirrorTextEditor.js:59 > + if (indent === WebInspector.TextUtils.Indent.TabCharacter) { WebInspector.TextUtils.Indent is undefined 850183 3 191982 lushnikov 2013-03-07 09:49:33 -0800 Comment on attachment 191982 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=191982&action=review >> Source/WebCore/inspector/front-end/CodeMirrorTextEditor.js:59 >> + if (indent === WebInspector.TextUtils.Indent.TabCharacter) { > > WebInspector.TextUtils.Indent is undefined It was introduced here: https://bugs.webkit.org/show_bug.cgi?id=111715 852367 4 191982 webkit.review.bot 2013-03-11 08:51:42 -0700 Comment on attachment 191982 Patch Clearing flags on attachment: 191982 Committed r145368: <http://trac.webkit.org/changeset/145368> 852368 5 webkit.review.bot 2013-03-11 08:51:45 -0700 All reviewed patches have been landed. Closing bug. 191982 2013-03-07 06:00:48 -0800 2013-03-11 08:51:42 -0700 Patch bug-111717-20130307175652.patch text/plain 2053 lushnikov U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1MDU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjY2ZGIxZWIwMWY3YTc0 YTFiNzBmYjVkOTYyZmFjZTkyYTYxYzhlMy4uMzE3MTYzZmViYjFmNWIzMTk4MTYyOTBiMGIwMjA4 YzBhYzIxNTdhZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDEzLTAzLTA3ICBBbmRy ZXkgTHVzaG5pa292ICA8bHVzaG5pa292QGNocm9taXVtLm9yZz4KIAorICAgICAgICBXZWIgSW5z cGVjdG9yOiBbQ29kZU1pcnJvcl0gc2V0IGluZGVudGF0aW9uIHNpemUgYWNjb3JkaW5nIHRvIGRl dnRvb2xzIHNldHRpbmdzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMTE3MTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBTZXQgdXAgY29kZW1pcnJvciBpbmRlbnQgc2l6ZSBhY2NvcmRpbmcgdG8gZGV2dG9v bHMgc2V0dGluZ3MuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLgorCisgICAgICAgICogaW5zcGVj dG9yL2Zyb250LWVuZC9Db2RlTWlycm9yVGV4dEVkaXRvci5qczoKKyAgICAgICAgKC5nZXQgaWYp OgorICAgICAgICAoV2ViSW5zcGVjdG9yLkNvZGVNaXJyb3JUZXh0RWRpdG9yKToKKworMjAxMy0w My0wNyAgQW5kcmV5IEx1c2huaWtvdiAgPGx1c2huaWtvdkBjaHJvbWl1bS5vcmc+CisKICAgICAg ICAgV2ViIEluc3BlY3RvcjogcmVmYWN0b3Jpbmc6IG1vdmUgVGV4dEVkaXRvck1vZGVsLkluZGVu dCBlbnVtIGludG8gVGV4dFV0aWxzCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMTE3MTUKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVj dG9yL2Zyb250LWVuZC9Db2RlTWlycm9yVGV4dEVkaXRvci5qcyBiL1NvdXJjZS9XZWJDb3JlL2lu c3BlY3Rvci9mcm9udC1lbmQvQ29kZU1pcnJvclRleHRFZGl0b3IuanMKaW5kZXggZDc0NTBhMWM4 ZTBiNWVkZDg2ODRmZmNiYTEwNjEwM2U1OWZlMTkxNS4uMGNjMjhhYzEyYzcwNTM2ZWIyMTZjM2E2 OGZlYjAzMTc0NzA4NDk3YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zy b250LWVuZC9Db2RlTWlycm9yVGV4dEVkaXRvci5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNw ZWN0b3IvZnJvbnQtZW5kL0NvZGVNaXJyb3JUZXh0RWRpdG9yLmpzCkBAIC01NSw2ICs1NSwxNSBA QCBXZWJJbnNwZWN0b3IuQ29kZU1pcnJvclRleHRFZGl0b3IgPSBmdW5jdGlvbih1cmwsIGRlbGVn YXRlKQogICAgICAgICBndXR0ZXJzOiBbIkNvZGVNaXJyb3ItbGluZW51bWJlcnMiLCAiYnJlYWtw b2ludHMiXQogICAgIH0pOwogCisgICAgdmFyIGluZGVudCA9IFdlYkluc3BlY3Rvci5zZXR0aW5n cy50ZXh0RWRpdG9ySW5kZW50LmdldCgpOworICAgIGlmIChpbmRlbnQgPT09IFdlYkluc3BlY3Rv ci5UZXh0VXRpbHMuSW5kZW50LlRhYkNoYXJhY3RlcikgeworICAgICAgICB0aGlzLl9jb2RlTWly cm9yLnNldE9wdGlvbigiaW5kZW50V2l0aFRhYnMiLCB0cnVlKTsKKyAgICAgICAgdGhpcy5fY29k ZU1pcnJvci5zZXRPcHRpb24oImluZGVudFVuaXQiLCA0KTsKKyAgICB9IGVsc2UgeworICAgICAg ICB0aGlzLl9jb2RlTWlycm9yLnNldE9wdGlvbigiaW5kZW50V2l0aFRhYnMiLCBmYWxzZSk7Cisg ICAgICAgIHRoaXMuX2NvZGVNaXJyb3Iuc2V0T3B0aW9uKCJpbmRlbnRVbml0IiwgaW5kZW50Lmxl bmd0aCk7CisgICAgfQorCiAgICAgdGhpcy5fY29kZU1pcnJvci5vbigiY2hhbmdlIiwgdGhpcy5f Y2hhbmdlLmJpbmQodGhpcykpOwogICAgIHRoaXMuX2NvZGVNaXJyb3Iub24oImd1dHRlckNsaWNr IiwgdGhpcy5fZ3V0dGVyQ2xpY2suYmluZCh0aGlzKSk7CiAgICAgdGhpcy5lbGVtZW50LmFkZEV2 ZW50TGlzdGVuZXIoImNvbnRleHRtZW51IiwgdGhpcy5fY29udGV4dE1lbnUuYmluZCh0aGlzKSk7 Cg==