111714 2013-03-07 05:29:06 -0800 [GTK][Regression] webkit_dom_html_table_element_insert_row returns value that doesn't pass WEBKIT_DOM_IS_HTML_TABLE_ROW_ELEMENT macro 2013-07-09 06:16:46 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 tpopela webkit-unassigned abarth cgarcia gustavo haraken japhet webkit.review.bot xan.lopez oldest_to_newest 849989 0 tpopela 2013-03-07 05:29:06 -0800 webkit_dom_html_table_element_insert_row returns value that doesn't pass WEBKIT_DOM_IS_HTML_TABLE_ROW_ELEMENT macro. It is caused by https://trac.webkit.org/changeset/137074 (git bisect get me to this). Here is some example code: WebKitDOMElement* table = webkit_dom_document_get_element_by_id ( dom_document, table_id); WebKitDOMHTMLElement* row = webkit_dom_html_table_element_insert_row ( WEBKIT_DOM_HTML_TABLE_ELEMENT (table), -1, NULL); ASSERT (!WEBKIT_DOM_IS_HTML_TABLE_ROW_ELEMENT ((WebKitDOMHTMLTableRowElement *) row)) -> if you call this instead of ASSERT WebKitDOMHTMLElement* cell = webkit_dom_html_table_row_element_insert_cell ( (WebKitDOMHTMLTableRowElement*) row, -1, NULL) -> you get ** (evolution:16227): CRITICAL **: WebKitDOMHTMLElement* webkit_dom_html_table_row_element_insert_cell(WebKitDOMHTMLTableRowElement*, glong, GError**): assertion `WEBKIT_DOM_IS_HTML_TABLE_ROW_ELEMENT(self)' failed Here is some code that is used in evolution: https://git.gnome.org/browse/evolution/tree/modules/itip-formatter/itip-view.c?h=gnome-3-6#n909 Also this patch introduced another thing. When you receive invitation to some event in Evolution you will see TEXTAREA where you can comment this event. After this patch, when you are typing the comment and you will hit SPACE key it doesn't put space into TEXTAREA but instead it just goes to the next unread message (which is normal when you don't have focus on that TEXTAREA). Before this patchset everything was working fine. 861348 1 xan.lopez 2013-03-22 04:44:20 -0700 This is odd because the GObject wrapping should be using the actual type of C++ object to create the wrapper, as told by the whatever localName is returning in the C++ instance. So if the function is creating a table row the GObject type should be a table row, independently of what the IDL or WebCore method says. To debug this you can go to Source/Webcore/bindings/gobject/WebKitDOMBinding.cpp and Source/Webcore/bindings/gobject/WebKitHTMLElementWrappingFactory.cpp and see what specific type is being assigned to the instance you care about. 861772 2 cgarcia 2013-03-22 12:44:36 -0700 It actually affects all the cases where we are creating DOM object from a polymorphic object using a base class. I'm currently working on it. For the stable branch I'll probably use a quick workaround to cover the HTMLElement cases, but for trunk we need to rework the way we create the objects, I have an initial patch already. 862178 3 194698 cgarcia 2013-03-23 04:36:26 -0700 Created attachment 194698 Patch 862182 4 cgarcia 2013-03-23 04:49:12 -0700 This patch is a simple workaround to cover the HTML elements case, so that we can apply it to the stable branch before releasing without much risk. But the real problem affects all polymorphic objects and requires a lot more work. See bug #113132. 862218 5 194698 mrobinson 2013-03-23 10:43:39 -0700 Comment on attachment 194698 Patch Yeah, this seems like something we need to fix more generally. :( 862219 6 194698 webkit.review.bot 2013-03-23 10:50:03 -0700 Comment on attachment 194698 Patch Clearing flags on attachment: 194698 Committed r146721: <http://trac.webkit.org/changeset/146721> 862220 7 webkit.review.bot 2013-03-23 10:50:07 -0700 All reviewed patches have been landed. Closing bug. 862221 8 xan.lopez 2013-03-23 10:52:41 -0700 (In reply to comment #4) > This patch is a simple workaround to cover the HTML elements case, so that we can apply it to the stable branch before releasing without much risk. But the real problem affects all polymorphic objects and requires a lot more work. See bug #113132. As we have discussed at length I don't see the point of doing a patch that purely fixes the HTMLElement case, since all HTMLElement subclasses are also broken. As I suggested I think the simple fix for the stable branch is to change the ::kit implementation in CodeGeneratorGObject for all HTMLElement subclasses (including HTMLElement itself) to do what your patch does only for HTMLElement. This is obviously correct and IMHO low risk, and fixes a giant bug that we should not have in 2.0. What we can do after 2.0 is fix the completely general case, which would be still broken with the patch I suggest. 862224 9 xan.lopez 2013-03-23 11:16:35 -0700 A few more comments after grepping some code: - I think the only case where we have intermediate HTMLElement subclasses that could trigger this bug is HTMLMediaElement subclasses (Audio and Video element). So adding those to the manually generated ::kit methods would be enough, but I think is a must for 2.0 (in fact they can just proxy HTMLElement, which IMHO should also just proxy Element). - Our Node ::kit method just calls createWrapper, which in turn just does the right thing for Element, HTMLElement, etc, so all our manual ::kit implementations can be reduced to just this one method IMHO. Depending on the amount on non Node objects we ship it might be easier to just have a manual list of those and give everything else a ::kit method like the one we use in Node right now, but we can discuss that in the other bug. 862226 10 cgarcia 2013-03-23 11:25:13 -0700 (In reply to comment #8) > (In reply to comment #4) > > This patch is a simple workaround to cover the HTML elements case, so that we can apply it to the stable branch before releasing without much risk. But the real problem affects all polymorphic objects and requires a lot more work. See bug #113132. > > As we have discussed at length I don't see the point of doing a patch that purely fixes the HTMLElement case, since all HTMLElement subclasses are also broken. > > As I suggested I think the simple fix for the stable branch is to change the ::kit implementation in CodeGeneratorGObject for all HTMLElement subclasses (including HTMLElement itself) to do what your patch does only for HTMLElement. This is obviously correct and IMHO low risk, and fixes a giant bug that we should not have in 2.0. I used the approach I thought it had the lowest risk to be applied in the stable branch two days before the release. > What we can do after 2.0 is fix the completely general case, which would be still broken with the patch I suggest. It has always been broken and nobody has noticed it until now, so I don't think it's that important. We can fix the general case in master and try it out for a while, so that when we are sure it works fine, we can merge it into the stable branch for 2.0.1. 862227 11 cgarcia 2013-03-23 11:27:09 -0700 (In reply to comment #9) > A few more comments after grepping some code: > > - I think the only case where we have intermediate HTMLElement subclasses that could trigger this bug is HTMLMediaElement subclasses (Audio and Video element). So adding those to the manually generated ::kit methods would be enough, but I think is a must for 2.0 (in fact they can just proxy HTMLElement, which IMHO should also just proxy Element). > > - Our Node ::kit method just calls createWrapper, which in turn just does the right thing for Element, HTMLElement, etc, so all our manual ::kit implementations can be reduced to just this one method IMHO. > > Depending on the amount on non Node objects we ship it might be easier to just have a manual list of those and give everything else a ::kit method like the one we use in Node right now, but we can discuss that in the other bug. See my patch in the other bug, it uses a different approach based on having a kit method for all objects and some custom wrap methods, more similar to what Objc bindings do. 194698 2013-03-23 04:36:26 -0700 2013-03-23 10:50:02 -0700 Patch dom-html-wrappers.diff text/plain 6764 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBkMDI2MTI3Li45ZDE1MjMwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIg QEAKKzIwMTMtMDMtMjMgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdW1JlZ3Jlc3Npb25dIHdlYmtpdF9kb21faHRtbF90YWJsZV9lbGVt ZW50X2luc2VydF9yb3cgcmV0dXJucyB2YWx1ZSB0aGF0IGRvZXNuJ3QgcGFzcyBXRUJLSVRfRE9N X0lTX0hUTUxfVEFCTEVfUk9XX0VMRU1FTlQgbWFjcm8KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMTcxNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBjdXN0b20ga2l0IGltcGxlbWVudGF0aW9uIGZv ciBIVE1MRWxlbWVudHMgc28gdGhhdCB0aGUgSFRNTAorICAgICAgICB3cmFwcGVycyBhcmUgdXNl ZCBpbiB0aGF0IGNhc2UgaW5zdGVhZCBvZiB3cmFwSFRNTEVsZW1lbnQuCisKKyAgICAgICAgKiBi aW5kaW5ncy9nb2JqZWN0L1dlYktpdERPTUJpbmRpbmcuY3BwOgorICAgICAgICAoV2ViS2l0Ojpr aXQpOgorICAgICAgICAoV2ViS2l0KToKKyAgICAgICAgKiBiaW5kaW5ncy9nb2JqZWN0L1dlYktp dERPTUJpbmRpbmcuaDoKKyAgICAgICAgKFdlYkNvcmUpOgorICAgICAgICAoV2ViS2l0KToKKyAg ICAgICAgKiBiaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JHT2JqZWN0LnBtOgorICAgICAg ICAoVXNlc01hbnVhbEtpdEltcGxlbWVudGF0aW9uKToKKwogMjAxMy0wMy0yMSAgS2lyYW4gTXVw cGFsYSAgPGNtdXBwYWxhQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgcnVudGltZSBzZXR0aW5n IGZvciBoaWRkZW4gcGFnZSBET00gdGltZXIgdGhyb3R0bGluZyBhbmQgQ1NTIGFuaW1hdGlvbiBz dXNwZW5zaW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cgYi9Tb3Vy Y2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKaW5kZXggNWYwOTNiZS4uZGNmYmFlZSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL0No YW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTAzLTIzICBDYXJsb3MgR2FyY2lhIENhbXBv cyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXVtSZWdyZXNzaW9uXSB3ZWJr aXRfZG9tX2h0bWxfdGFibGVfZWxlbWVudF9pbnNlcnRfcm93IHJldHVybnMgdmFsdWUgdGhhdCBk b2Vzbid0IHBhc3MgV0VCS0lUX0RPTV9JU19IVE1MX1RBQkxFX1JPV19FTEVNRU5UIG1hY3JvCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTE3MTQKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgdGVzdCB0 aGF0IGNoZWNrcyB3ZWJraXRfZG9tX2h0bWxfdGFibGVfZWxlbWVudF9pbnNlcnRfcm93KCkgdG8K KyAgICAgICAgYWxzbyBwcmVwcm9kdWNlIHRoaXMgaXNzdWUuCisKKyAgICAgICAgKiB0ZXN0cy90 ZXN0ZG9tZG9jdW1lbnQuYzoKKyAgICAgICAgKHRlc3RfZG9tX2RvY3VtZW50X2luc2VydF9yb3cp OgorICAgICAgICAobWFpbik6CisKIDIwMTMtMDMtMjIgIEd1c3Rhdm8gTm9yb25oYSBTaWx2YSAg PGduc0Bnbm9tZS5vcmc+CiAKICAgICAgICAgVHJpdmlhbCBmaXhlcyB0byB0aGUgZ3lwLWJ1aWxk IGF1dG9nZW4uc2ggc2NyaXB0LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv Z29iamVjdC9XZWJLaXRET01CaW5kaW5nLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2dv YmplY3QvV2ViS2l0RE9NQmluZGluZy5jcHAKaW5kZXggZDRkYjZmNi4uNjZiNzFlNCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvZ29iamVjdC9XZWJLaXRET01CaW5kaW5nLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9nb2JqZWN0L1dlYktpdERPTUJpbmRpbmcu Y3BwCkBAIC0xMDAsNiArMTAwLDE4IEBAIFdlYktpdERPTUVsZW1lbnQqIGtpdChFbGVtZW50KiBl bGVtZW50KQogICAgIHJldHVybiBzdGF0aWNfY2FzdDxXZWJLaXRET01FbGVtZW50Kj4od3JhcHBl ZEVsZW1lbnQpOwogfQogCitXZWJLaXRET01IVE1MRWxlbWVudCoga2l0KEhUTUxFbGVtZW50KiBl bGVtZW50KQoreworICAgIGlmICghZWxlbWVudCkKKyAgICAgICAgcmV0dXJuIDA7CisKKyAgICBn cG9pbnRlciBraXRFbGVtZW50ID0gRE9NT2JqZWN0Q2FjaGU6OmdldChlbGVtZW50KTsKKyAgICBp ZiAoa2l0RWxlbWVudCkKKyAgICAgICAgcmV0dXJuIHN0YXRpY19jYXN0PFdlYktpdERPTUhUTUxF bGVtZW50Kj4oa2l0RWxlbWVudCk7CisKKyAgICByZXR1cm4gc3RhdGljX2Nhc3Q8V2ViS2l0RE9N SFRNTEVsZW1lbnQqPihjcmVhdGVIVE1MRWxlbWVudFdyYXBwZXIoZWxlbWVudCkpOworfQorCiBX ZWJLaXRET01FdmVudCoga2l0KEV2ZW50KiBldmVudCkKIHsKICAgICBpZiAoIWV2ZW50KQpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvZ29iamVjdC9XZWJLaXRET01CaW5kaW5n LmggYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9nb2JqZWN0L1dlYktpdERPTUJpbmRpbmcuaApp bmRleCBhYzFmOTZhLi5jNDEyYWZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5n cy9nb2JqZWN0L1dlYktpdERPTUJpbmRpbmcuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5n cy9nb2JqZWN0L1dlYktpdERPTUJpbmRpbmcuaApAQCAtMzMsNiArMzMsNyBAQAogbmFtZXNwYWNl IFdlYkNvcmUgewogY2xhc3MgTm9kZTsKIGNsYXNzIEVsZW1lbnQ7CitjbGFzcyBIVE1MRWxlbWVu dDsKIGNsYXNzIEV2ZW50OwogY2xhc3MgRXZlbnRUYXJnZXQ7CiB9IC8vIG5hbWVzcGFjZSBXZWJD b3JlCkBAIC00MCw2ICs0MSw3IEBAIGNsYXNzIEV2ZW50VGFyZ2V0OwogbmFtZXNwYWNlIFdlYktp dCB7CiBXZWJLaXRET01Ob2RlKiBraXQoV2ViQ29yZTo6Tm9kZSogbm9kZSk7CiBXZWJLaXRET01F bGVtZW50KiBraXQoV2ViQ29yZTo6RWxlbWVudCogZWxlbWVudCk7CitXZWJLaXRET01IVE1MRWxl bWVudCoga2l0KFdlYkNvcmU6OkhUTUxFbGVtZW50Kik7CiBXZWJLaXRET01FdmVudCoga2l0KFdl YkNvcmU6OkV2ZW50KiBldmVudCk7CiBXZWJLaXRET01FdmVudFRhcmdldCoga2l0KFdlYkNvcmU6 OkV2ZW50VGFyZ2V0KiB0YXJnZXQpOwogfSAvLyBuYW1lc3BhY2UgV2ViS2l0CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JHT2JqZWN0LnBt IGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yR09iamVjdC5w bQppbmRleCA1ZmE0NzQ0Li5kNDE2ZmEyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JHT2JqZWN0LnBtCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckdPYmplY3QucG0KQEAgLTEzMTgsNyArMTMx OCw3IEBAIHN1YiBHZW5lcmF0ZUVuZEhlYWRlciB7CiBzdWIgVXNlc01hbnVhbEtpdEltcGxlbWVu dGF0aW9uIHsKICAgICBteSAkdHlwZSA9IHNoaWZ0OwogCi0gICAgcmV0dXJuIDEgaWYgJHR5cGUg ZXEgIk5vZGUiIG9yICR0eXBlIGVxICJFbGVtZW50IiBvciAkdHlwZSBlcSAiRXZlbnQiOworICAg IHJldHVybiAxIGlmICR0eXBlIGVxICJOb2RlIiBvciAkdHlwZSBlcSAiRWxlbWVudCIgb3IgJHR5 cGUgZXEgIkhUTUxFbGVtZW50IiBvciAkdHlwZSBlcSAiRXZlbnQiOwogICAgIHJldHVybiAwOwog fQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0ay90ZXN0cy90ZXN0ZG9tZG9jdW1lbnQu YyBiL1NvdXJjZS9XZWJLaXQvZ3RrL3Rlc3RzL3Rlc3Rkb21kb2N1bWVudC5jCmluZGV4IDQzZTQz OTIuLmVmZmNkYmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZ3RrL3Rlc3RzL3Rlc3Rkb21k b2N1bWVudC5jCisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL3Rlc3RzL3Rlc3Rkb21kb2N1bWVudC5j CkBAIC0zMyw2ICszMyw3IEBACiAjZGVmaW5lIEhUTUxfRE9DVU1FTlRfRUxFTUVOVFNfSUQgIjxo dG1sPjxib2R5PjxkaXYgaWQ9XCJ0ZXN0b2tcIj48L2Rpdj48ZGl2IGlkPVwidGVzdGJhZFwiPmZp cnN0PC9kaXY+PGRpdiBpZD1cInRlc3RiYWRcIj5zZWNvbmQ8L2Rpdj48L2JvZHk+PC9odG1sPiIK ICNkZWZpbmUgSFRNTF9ET0NVTUVOVF9MSU5LUyAiPGh0bWw+PGhlYWQ+PHRpdGxlPlRpdGxlPC90 aXRsZT48L2hlYWQ+PGJvZHk+PGEgaHJlZj1cImFib3V0OmJsYW5rXCI+Ymxhbms8L2E+PGEgaHJl Zj1cImh0dHA6Ly93d3cuZ29vZ2xlLmNvbVwiPmdvb2dsZTwvYT48YSBocmVmPVwiaHR0cDovL3d3 dy53ZWJraXQub3JnXCI+d2Via2l0PC9hPjwvYm9keT48L2h0bWw+IgogI2RlZmluZSBIVE1MX0RP Q1VNRU5UX0lGUkFNRSAiPGh0bWw+PGhlYWQ+PHRpdGxlPklGcmFtZTwvdGl0bGU+PC9oZWFkPjxi b2R5PjxpZnJhbWUgaWQ9J2lmcmFtZSc+PC9pZnJhbWU+PGRpdiBpZD0ndGVzdCc+PC9kaXY+PC9i b2R5PjwvaHRtbD4iCisjZGVmaW5lIEhUTUxfRE9DVU1FTlRfVEFCTEUgIjxodG1sPjxib2R5Pjx0 YWJsZSBpZD1cInRhYmxlXCI+PC90YWJsZT48L2JvZHk+PC9odG1sPiIKIAogdHlwZWRlZiBzdHJ1 Y3QgewogICAgIEd0a1dpZGdldCogd2ViVmlldzsKQEAgLTE4OCw2ICsxODksMjcgQEAgc3RhdGlj IHZvaWQgdGVzdF9kb21fZG9jdW1lbnRfZ2V0X2xpbmtzKERvbURvY3VtZW50Rml4dHVyZSogZml4 dHVyZSwgZ2NvbnN0cG9pbnQKICAgICBnX29iamVjdF91bnJlZihjb2xsZWN0aW9uKTsKIH0KIAor c3RhdGljIHZvaWQgdGVzdF9kb21fZG9jdW1lbnRfaW5zZXJ0X3JvdyhEb21Eb2N1bWVudEZpeHR1 cmUqIGZpeHR1cmUsIGdjb25zdHBvaW50ZXIgZGF0YSkKK3sKKyAgICBnX2Fzc2VydChmaXh0dXJl KTsKKyAgICBXZWJLaXRXZWJWaWV3KiB2aWV3ID0gKFdlYktpdFdlYlZpZXcqKWZpeHR1cmUtPndl YlZpZXc7CisgICAgZ19hc3NlcnQodmlldyk7CisgICAgV2ViS2l0RE9NRG9jdW1lbnQqIGRvY3Vt ZW50ID0gd2Via2l0X3dlYl92aWV3X2dldF9kb21fZG9jdW1lbnQodmlldyk7CisgICAgZ19hc3Nl cnQoV0VCS0lUX0RPTV9JU19ET0NVTUVOVChkb2N1bWVudCkpOworICAgIFdlYktpdERPTUVsZW1l bnQqIHRhYmxlID0gd2Via2l0X2RvbV9kb2N1bWVudF9nZXRfZWxlbWVudF9ieV9pZChkb2N1bWVu dCwgInRhYmxlIik7CisgICAgZ19hc3NlcnQoV0VCS0lUX0RPTV9JU19IVE1MX0VMRU1FTlQodGFi bGUpKTsKKyAgICBXZWJLaXRET01IVE1MQ29sbGVjdGlvbiogcm93cyA9IHdlYmtpdF9kb21faHRt bF90YWJsZV9lbGVtZW50X2dldF9yb3dzKFdFQktJVF9ET01fSFRNTF9UQUJMRV9FTEVNRU5UKHRh YmxlKSk7CisgICAgZ19hc3NlcnQoV0VCS0lUX0RPTV9JU19IVE1MX0NPTExFQ1RJT04ocm93cykp OworCisgICAgLy8gVGFibGUgaXMgaW5pdGlhbGx5IGVtcHR5LgorICAgIGdfYXNzZXJ0X2NtcGlu dCh3ZWJraXRfZG9tX2h0bWxfY29sbGVjdGlvbl9nZXRfbGVuZ3RoKHJvd3MpLCA9PSwgMCk7Cisg ICAgV2ViS2l0RE9NSFRNTEVsZW1lbnQqIHJvdyA9IHdlYmtpdF9kb21faHRtbF90YWJsZV9lbGVt ZW50X2luc2VydF9yb3coV0VCS0lUX0RPTV9IVE1MX1RBQkxFX0VMRU1FTlQodGFibGUpLCAtMSwg TlVMTCk7CisgICAgZ19hc3NlcnQoV0VCS0lUX0RPTV9JU19IVE1MX1RBQkxFX1JPV19FTEVNRU5U KHJvdykpOworICAgIHJvd3MgPSB3ZWJraXRfZG9tX2h0bWxfdGFibGVfZWxlbWVudF9nZXRfcm93 cyhXRUJLSVRfRE9NX0hUTUxfVEFCTEVfRUxFTUVOVCh0YWJsZSkpOworICAgIGdfYXNzZXJ0KFdF QktJVF9ET01fSVNfSFRNTF9DT0xMRUNUSU9OKHJvd3MpKTsKKyAgICBnX2Fzc2VydF9jbXBpbnQo d2Via2l0X2RvbV9odG1sX2NvbGxlY3Rpb25fZ2V0X2xlbmd0aChyb3dzKSwgPT0sIDEpOworfQor CiBzdGF0aWMgdm9pZCB3ZWFrX25vdGlmeShncG9pbnRlciBkYXRhLCBHT2JqZWN0KiB6b21iaWUp CiB7CiAgICAgZ3VpbnQqIGNvdW50ID0gKGd1aW50KilkYXRhOwpAQCAtMzU0LDYgKzM3NiwxMiBA QCBpbnQgbWFpbihpbnQgYXJnYywgY2hhcioqIGFyZ3YpCiAgICAgICAgICAgICAgICB0ZXN0X2Rv bV9kb2N1bWVudF9nZXRfbGlua3MsCiAgICAgICAgICAgICAgICBkb21fZG9jdW1lbnRfZml4dHVy ZV90ZWFyZG93bik7CiAKKyAgICBnX3Rlc3RfYWRkKCIvd2Via2l0L2RvbWRvY3VtZW50L3Rlc3Rf dGFibGVfaW5zZXJ0X3JvdyIsCisgICAgICAgICAgICAgICBEb21Eb2N1bWVudEZpeHR1cmUsIEhU TUxfRE9DVU1FTlRfVEFCTEUsCisgICAgICAgICAgICAgICBkb21fZG9jdW1lbnRfZml4dHVyZV9z ZXR1cCwKKyAgICAgICAgICAgICAgIHRlc3RfZG9tX2RvY3VtZW50X2luc2VydF9yb3csCisgICAg ICAgICAgICAgICBkb21fZG9jdW1lbnRfZml4dHVyZV90ZWFyZG93bik7CisKICAgICBnX3Rlc3Rf YWRkKCIvd2Via2l0L2RvbWRvY3VtZW50L3Rlc3RfZ2FyYmFnZV9jb2xsZWN0aW9uIiwKICAgICAg ICAgICAgICAgIERvbURvY3VtZW50Rml4dHVyZSwgSFRNTF9ET0NVTUVOVF9MSU5LUywKICAgICAg ICAgICAgICAgIGRvbV9kb2N1bWVudF9maXh0dXJlX3NldHVwLAo=