111689 2013-03-06 23:14:01 -0800 [WK2] SandboxExtension::createHandle raises an uncaught Objective-C exception if path is empty 2013-03-06 23:29:40 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap fpizlo oldest_to_newest 849773 0 ap 2013-03-06 23:14:01 -0800 Calling fileSystemRepresentation on an empty NSString results in an exception. 849776 1 191930 ap 2013-03-06 23:17:44 -0800 Created attachment 191930 proposed fix 849781 2 fpizlo 2013-03-06 23:24:11 -0800 Actually, am I allowed to review these patches? I guess I'm not a WK2 reviewer. Anyways, LGTM. 849783 3 191930 fpizlo 2013-03-06 23:24:34 -0800 Comment on attachment 191930 proposed fix Resetting r? because I'm not a WK2 reviewer. 849784 4 191930 fpizlo 2013-03-06 23:25:06 -0800 Comment on attachment 191930 proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=191930&action=review > Source/WebKit2/ChangeLog:9 > + Use a fucntion from WebCore platform layer instead of Foundation one equivalent. s/fucntion/function 849786 5 ap 2013-03-06 23:29:01 -0800 Ugh, I already committed before you undid the review. Probably not worth rolling out, as this implicitly has "WebKit2 owner approval". 849787 6 ap 2013-03-06 23:29:40 -0800 Committed <http://trac.webkit.org/r145042>. 191930 2013-03-06 23:17:44 -0800 2013-03-06 23:29:08 -0800 proposed fix EmptyPath.txt text/plain 1802 ap SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0NTA0MSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEzLTAzLTA2ICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIFNhbmRib3hFeHRlbnNpb246 OmNyZWF0ZUhhbmRsZSByYWlzZXMgYW4gdW5jYXVnaHQgT2JqZWN0aXZlLUMgZXhjZXB0aW9uIGlm IHBhdGggaXMgZW1wdHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTExMTY4OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogU2hhcmVkL21hYy9TYW5kYm94RXh0ZW5zaW9uTWFjLm1tOiAoV2ViS2l0OjpTYW5k Ym94RXh0ZW5zaW9uOjpjcmVhdGVIYW5kbGUpOgorICAgICAgICBVc2UgYSBmdWNudGlvbiBmcm9t IFdlYkNvcmUgcGxhdGZvcm0gbGF5ZXIgaW5zdGVhZCBvZiBGb3VuZGF0aW9uIG9uZSBlcXVpdmFs ZW50LgorICAgICAgICBXZSBhbHJlYWR5IGRvIHRoaXMgZWxzZXdoZXJlIGluIHRoaXMgZmlsZS4K KwogMjAxMy0wMy0wNiAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAog ICAgICAgICBbd2syXSBQYWdlIG92ZXJsYXlzIHNob3VsZG4ndCBkaXJ0eSB0aGUgZW50aXJlIGxh eWVyIHdoZW4gZmx1c2hpbmcgaWYgdGhlIG1haW4gZnJhbWUgY2FuJ3Qgc2Nyb2xsCkluZGV4OiBT b3VyY2UvV2ViS2l0Mi9TaGFyZWQvbWFjL1NhbmRib3hFeHRlbnNpb25NYWMubW0KPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYktpdDIvU2hhcmVkL21hYy9TYW5kYm94RXh0ZW5zaW9uTWFjLm1tCShy ZXZpc2lvbiAxNDUwMjIpCisrKyBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvbWFjL1NhbmRib3hFeHRl bnNpb25NYWMubW0JKHdvcmtpbmcgY29weSkKQEAgLTIxNCw3ICsyMTQsOCBAQCB2b2lkIFNhbmRi b3hFeHRlbnNpb246OmNyZWF0ZUhhbmRsZShjb25zCiB7CiAgICAgQVNTRVJUKCFoYW5kbGUubV9z YW5kYm94RXh0ZW5zaW9uKTsKIAotICAgIENTdHJpbmcgc3RhbmRhcmRpemVkUGF0aCA9IHJlc29s dmVTeW1saW5rc0luUGF0aChbWyhOU1N0cmluZyAqKXBhdGggc3RyaW5nQnlTdGFuZGFyZGl6aW5n UGF0aF0gZmlsZVN5c3RlbVJlcHJlc2VudGF0aW9uXSk7CisgICAgLy8gRklYTUU6IERvIHdlIG5l ZWQgYm90aCByZXNvbHZlU3ltbGlua3NJblBhdGgoKSBhbmQgLXN0cmluZ0J5U3RhbmRhcmRpemlu Z1BhdGg/CisgICAgQ1N0cmluZyBzdGFuZGFyZGl6ZWRQYXRoID0gcmVzb2x2ZVN5bWxpbmtzSW5Q YXRoKGZpbGVTeXN0ZW1SZXByZXNlbnRhdGlvbihbKE5TU3RyaW5nICopcGF0aCBzdHJpbmdCeVN0 YW5kYXJkaXppbmdQYXRoXSkpOwogICAgIGhhbmRsZS5tX3NhbmRib3hFeHRlbnNpb24gPSBXS1Nh bmRib3hFeHRlbnNpb25DcmVhdGUoc3RhbmRhcmRpemVkUGF0aC5kYXRhKCksIHdrU2FuZGJveEV4 dGVuc2lvblR5cGUodHlwZSkpOwogICAgIGlmICghaGFuZGxlLm1fc2FuZGJveEV4dGVuc2lvbikK ICAgICAgICAgV1RGTG9nQWx3YXlzKCJDb3VsZCBub3QgY3JlYXRlIGEgc2FuZGJveCBleHRlbnNp b24gZm9yICclcyciLCBwYXRoLnV0ZjgoKS5kYXRhKCkpOwo=