111680 2013-03-06 21:35:10 -0800 Web Inspector: Add shortcut for running a snippet. 2013-03-08 07:13:44 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 vsevik vsevik apavlov keishi loislo paulirish pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 849712 0 vsevik 2013-03-06 21:35:10 -0800 Patch to follow 849714 1 191915 vsevik 2013-03-06 21:36:32 -0800 Created attachment 191915 Patch 849723 2 191915 pfeldman 2013-03-06 21:44:23 -0800 Comment on attachment 191915 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=191915&action=review > Source/WebCore/inspector/front-end/SnippetJavaScriptSourceFrame.js:46 > + var runSnippetShortcutDescriptor = WebInspector.KeyboardShortcut.makeDescriptor(WebInspector.KeyboardShortcut.Keys.Enter, WebInspector.KeyboardShortcut.Modifiers.CtrlOrMeta) Eclipse uses Ctrl+F11, Ctrl+F10 idea. > Source/WebCore/inspector/front-end/SnippetJavaScriptSourceFrame.js:72 > + _onKeyDown: function(event) I've seen this code. Should it be moved to View.js with corresponding registerShortcut(key, modifier, handler) ? I even thing handler should be unbound for the sake of performance. 850103 3 191915 vsevik 2013-03-07 08:05:29 -0800 Comment on attachment 191915 Patch As discussed offline Ctrl+Enter is a more convenient shortcut which does not clash with anything that we already have or plan to have in near future. Shortcut handling requires a separate effort so let's keep things as is for now. 851169 4 191915 webkit.review.bot 2013-03-08 07:13:40 -0800 Comment on attachment 191915 Patch Clearing flags on attachment: 191915 Committed r145218: <http://trac.webkit.org/changeset/145218> 851170 5 webkit.review.bot 2013-03-08 07:13:44 -0800 All reviewed patches have been landed. Closing bug. 191915 2013-03-06 21:36:32 -0800 2013-03-08 07:13:40 -0800 Patch bug-111680-20130307093236.patch text/plain 2930 vsevik U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1MDM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmNlODc4YmRlNmM1YzNm NDE1NmU4YTYzNGNmZWQyNjAxYzQ0NDE3ZS4uNTRjMDIyMDU2YTk1OWMyNjBlMDJkYzdkYWY3MGRm MWNhZWJjNWYxNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTAzLTA2ICBWc2V2 b2xvZCBWbGFzb3YgIDx2c2V2aWtAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IEFkZCBzaG9ydGN1dCBmb3IgcnVubmluZyBhIHNuaXBwZXQuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTE2ODAKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRlZCBDdHJsL0NtZCtFbnRlciBhcyBh IHNob3J0Y3V0IGZvciBydW5uaW5nIGEgc25pcHBldC4KKworICAgICAgICAqIGluc3BlY3Rvci9m cm9udC1lbmQvU25pcHBldEphdmFTY3JpcHRTb3VyY2VGcmFtZS5qczoKKyAgICAgICAgKFdlYklu c3BlY3Rvci5TbmlwcGV0SmF2YVNjcmlwdFNvdXJjZUZyYW1lKToKKyAgICAgICAgKFdlYkluc3Bl Y3Rvci5TbmlwcGV0SmF2YVNjcmlwdFNvdXJjZUZyYW1lLnByb3RvdHlwZS5fcnVuQnV0dG9uQ2xp Y2tlZCk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuU25pcHBldEphdmFTY3JpcHRTb3VyY2VGcmFt ZS5wcm90b3R5cGUuX3J1blNuaXBwZXQpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlNuaXBwZXRK YXZhU2NyaXB0U291cmNlRnJhbWUucHJvdG90eXBlLl9vbktleURvd24pOgorCiAyMDEzLTAzLTA0 ICBLaW51a28gWWFzdWRhICA8a2ludWtvQGNocm9taXVtLm9yZz4KIAogICAgICAgICBGaWxlLmxh c3RNb2RpZmllZERhdGUoKSBzaG91bGQgcmV0dXJuIHRoZSBjdXJyZW50IGRhdGUvdGltZSBpZiB0 aGUgZmlsZSBkYXRlL3RpbWUgaXMgbm90IGF2YWlsYWJsZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TbmlwcGV0SmF2YVNjcmlwdFNvdXJjZUZyYW1lLmpz IGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TbmlwcGV0SmF2YVNjcmlwdFNv dXJjZUZyYW1lLmpzCmluZGV4IDJhNzA1NzBkYjdiZDhkMmIzNzI3OWY5MzQ4YzM0M2NmOTM5NTFh MDYuLjdjZjVkYmFkNjMxZWZiNGVkNDZjOWE0NWU3YTJhZDlkMDc4NGQzYWYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU25pcHBldEphdmFTY3JpcHRTb3Vy Y2VGcmFtZS5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1NuaXBw ZXRKYXZhU2NyaXB0U291cmNlRnJhbWUuanMKQEAgLTQxLDYgKzQxLDEwIEBAIFdlYkluc3BlY3Rv ci5TbmlwcGV0SmF2YVNjcmlwdFNvdXJjZUZyYW1lID0gZnVuY3Rpb24oc2NyaXB0c1BhbmVsLCB1 aVNvdXJjZUNvZGUpCiAgICAgdGhpcy5fdWlTb3VyY2VDb2RlID0gdWlTb3VyY2VDb2RlOwogICAg IHRoaXMuX3J1bkJ1dHRvbiA9IG5ldyBXZWJJbnNwZWN0b3IuU3RhdHVzQmFyQnV0dG9uKFdlYklu c3BlY3Rvci5VSVN0cmluZygiUnVuIiksICJldmFsdWF0ZS1zbmlwcGV0LXN0YXR1cy1iYXItaXRl bSIpOwogICAgIHRoaXMuX3J1bkJ1dHRvbi5hZGRFdmVudExpc3RlbmVyKCJjbGljayIsIHRoaXMu X3J1bkJ1dHRvbkNsaWNrZWQsIHRoaXMpOworICAgIHRoaXMudGV4dEVkaXRvci5lbGVtZW50LmFk ZEV2ZW50TGlzdGVuZXIoImtleWRvd24iLCB0aGlzLl9vbktleURvd24uYmluZCh0aGlzKSwgdHJ1 ZSk7CisgICAgdGhpcy5fc2hvcnRjdXRzID0ge307CisgICAgdmFyIHJ1blNuaXBwZXRTaG9ydGN1 dERlc2NyaXB0b3IgPSBXZWJJbnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dC5tYWtlRGVzY3JpcHRv cihXZWJJbnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dC5LZXlzLkVudGVyLCBXZWJJbnNwZWN0b3Iu S2V5Ym9hcmRTaG9ydGN1dC5Nb2RpZmllcnMuQ3RybE9yTWV0YSkKKyAgICB0aGlzLl9zaG9ydGN1 dHNbcnVuU25pcHBldFNob3J0Y3V0RGVzY3JpcHRvci5rZXldID0gdGhpcy5fcnVuU25pcHBldC5i aW5kKHRoaXMpOwogfQogCiBXZWJJbnNwZWN0b3IuU25pcHBldEphdmFTY3JpcHRTb3VyY2VGcmFt ZS5wcm90b3R5cGUgPSB7CkBAIC01NCw4ICs1OCwyNiBAQCBXZWJJbnNwZWN0b3IuU25pcHBldEph dmFTY3JpcHRTb3VyY2VGcmFtZS5wcm90b3R5cGUgPSB7CiAKICAgICBfcnVuQnV0dG9uQ2xpY2tl ZDogZnVuY3Rpb24oKQogICAgIHsKKyAgICAgICAgdGhpcy5fcnVuU25pcHBldCgpOworICAgIH0s CisKKyAgICBfcnVuU25pcHBldDogZnVuY3Rpb24oKQorICAgIHsKICAgICAgICAgV2ViSW5zcGVj dG9yLnNjcmlwdFNuaXBwZXRNb2RlbC5ldmFsdWF0ZVNjcmlwdFNuaXBwZXQodGhpcy5fdWlTb3Vy Y2VDb2RlKTsKICAgICB9LAogCisgICAgLyoqCisgICAgICogQHBhcmFtIHtLZXlib2FyZEV2ZW50 fSBldmVudAorICAgICAqLworICAgIF9vbktleURvd246IGZ1bmN0aW9uKGV2ZW50KQorICAgIHsK KyAgICAgICAgdmFyIHNob3J0Y3V0S2V5ID0gV2ViSW5zcGVjdG9yLktleWJvYXJkU2hvcnRjdXQu bWFrZUtleUZyb21FdmVudChldmVudCk7CisgICAgICAgIHZhciBoYW5kbGVyID0gdGhpcy5fc2hv cnRjdXRzW3Nob3J0Y3V0S2V5XTsKKyAgICAgICAgaWYgKGhhbmRsZXIpIHsKKyAgICAgICAgICAg IGhhbmRsZXIoZXZlbnQpOworICAgICAgICAgICAgZXZlbnQuaGFuZGxlZCA9IHRydWU7CisgICAg ICAgIH0KKyAgICB9LAorCiAgICAgX19wcm90b19fOiBXZWJJbnNwZWN0b3IuSmF2YVNjcmlwdFNv dXJjZUZyYW1lLnByb3RvdHlwZQogfQo=