111666 2013-03-06 19:18:07 -0800 Compute WebGL context attributes from DrawingBuffer when it is used 2013-03-07 17:08:57 -0800 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 kbr kbr bajones dino esprehn+autocc gman jamesr jbauman ojan.autocc webkit.review.bot zmo oldest_to_newest 849623 0 kbr 2013-03-06 19:18:07 -0800 On ports where WebGLRenderingContext's back buffer is managed by the DrawingBuffer class (Source/WebCore/platform/graphics/gpu/DrawingBuffer.h), WebGLRenderingContext::getContextAttributes should be implemented in terms of the DrawingBuffer, not GraphicsContext3D. This mismatch is causing conformance test failures on platforms which don't support multisampling, probably among other problems. 850395 1 kbr 2013-03-07 12:56:55 -0800 After further examination, the DrawingBuffer determines all of its context creation attributes from the GraphicsContext3D. The only flag it determines itself is whether it can support multisampling based on the presence of the framebuffer_blit and framebuffer_multisample extensions. Fixing just the computation of the antialias flag. 850399 2 192071 kbr 2013-03-07 12:58:56 -0800 Created attachment 192071 Patch 850673 3 192071 webkit.review.bot 2013-03-07 17:08:53 -0800 Comment on attachment 192071 Patch Clearing flags on attachment: 192071 Committed r145159: <http://trac.webkit.org/changeset/145159> 850674 4 webkit.review.bot 2013-03-07 17:08:57 -0800 All reviewed patches have been landed. Closing bug. 192071 2013-03-07 12:58:56 -0800 2013-03-07 17:08:53 -0800 Patch bug-111666-20130307125500.patch text/plain 2243 kbr U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1MTE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjBmNGUwNmY2MzNiMmVh NjU2MjBhZWZiYzBiNTJjMGUwNzg0NzMzNS4uYjljMmFlOTNmOWNiNWRhOGJmOTU4OTc2OGUwNDRm NmZmYmU3NzhlZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEzLTAzLTA3ICBLZW5u ZXRoIFJ1c3NlbGwgIDxrYnJAZ29vZ2xlLmNvbT4KKworICAgICAgICBDb21wdXRlIFdlYkdMIGNv bnRleHQgYXR0cmlidXRlcyBmcm9tIERyYXdpbmdCdWZmZXIgd2hlbiBpdCBpcyB1c2VkCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTE2NjYKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXhlZCBjb21wdXRh dGlvbiBvZiBhbnRpYWxpYXMgZmxhZyB3aGVuIERyYXdpbmdCdWZmZXIgaXMgdXNlZC4KKworICAg ICAgICBObyBuZXcgdGVzdHM7IGNvdmVyZWQgYnkgZXhpc3RpbmcgdGVzdHMuIFJhbiBXZWJHTCBj b25mb3JtYW5jZQorICAgICAgICB0ZXN0cyBvbiBkZXNrdG9wIExpbnV4IGFuZCBBbmRyb2lkIHRv IHRlc3QuCisKKyAgICAgICAgKiBodG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuY3Bw OgorICAgICAgICAoV2ViQ29yZSk6CisgICAgICAgIChXZWJDb3JlOjpXZWJHTFJlbmRlcmluZ0Nv bnRleHQ6OmdldENvbnRleHRBdHRyaWJ1dGVzKToKKyAgICAgICAgICAgIFF1ZXJ5IERyYXdpbmdC dWZmZXIsIHdoZW4gdXNlZCwgZm9yIGFudGlhbGlhcyBmbGFnLgorCiAyMDEzLTAzLTA3ICBDaHJp cyBGbGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CiAKICAgICAgICAgQVg6IENhbid0IGFj dGl2YXRlIGxpbmtzIHdpdGggVm9pY2VPdmVyIGluIFNhZmFyaQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0LmNwcCBiL1NvdXJjZS9X ZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5jcHAKaW5kZXggY2JmYmQz NzI2ZWVmNWY1YjgzNDg1ZjYwY2ZiMGMxYmEyOTQ4NDM2Mi4uNDk5Njk1OGJiMzM0ZWJlNTUyYzBk YWYyYmFhMTZlNTVlZTg5ZjJlOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52 YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL2Nh bnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuY3BwCkBAIC0yMzQyLDEyICsyMzQyLDE3IEBAIFBh c3NSZWZQdHI8V2ViR0xDb250ZXh0QXR0cmlidXRlcz4gV2ViR0xSZW5kZXJpbmdDb250ZXh0Ojpn ZXRDb250ZXh0QXR0cmlidXRlcygpCiAKICAgICAvLyBBbHNvLCB3ZSBuZWVkIHRvIGVuZm9yY2Ug cmVxdWVzdGVkIHZhbHVlcyBvZiAiZmFsc2UiIGZvciBkZXB0aAogICAgIC8vIGFuZCBzdGVuY2ls LCByZWdhcmRsZXNzIG9mIHRoZSBwcm9wZXJ0aWVzIG9mIHRoZSB1bmRlcmx5aW5nCi0gICAgLy8g R3JhcGhpY3NDb250ZXh0M0QuCisgICAgLy8gR3JhcGhpY3NDb250ZXh0M0Qgb3IgRHJhd2luZ0J1 ZmZlci4KICAgICBSZWZQdHI8V2ViR0xDb250ZXh0QXR0cmlidXRlcz4gYXR0cmlidXRlcyA9IFdl YkdMQ29udGV4dEF0dHJpYnV0ZXM6OmNyZWF0ZShtX2NvbnRleHQtPmdldENvbnRleHRBdHRyaWJ1 dGVzKCkpOwogICAgIGlmICghbV9hdHRyaWJ1dGVzLmRlcHRoKQogICAgICAgICBhdHRyaWJ1dGVz LT5zZXREZXB0aChmYWxzZSk7CiAgICAgaWYgKCFtX2F0dHJpYnV0ZXMuc3RlbmNpbCkKICAgICAg ICAgYXR0cmlidXRlcy0+c2V0U3RlbmNpbChmYWxzZSk7CisgICAgaWYgKG1fZHJhd2luZ0J1ZmZl cikgeworICAgICAgICAvLyBUaGUgRHJhd2luZ0J1ZmZlciBvYnRhaW5zIGl0cyBwYXJhbWV0ZXJz IGZyb20gR3JhcGhpY3NDb250ZXh0M0Q6OmdldENvbnRleHRBdHRyaWJ1dGVzKCksCisgICAgICAg IC8vIGJ1dCBpdCBtYWtlcyBpdHMgb3duIGRldGVybWluYXRpb24gb2Ygd2hldGhlciBtdWx0aXNh bXBsaW5nIGlzIHN1cHBvcnRlZC4KKyAgICAgICAgYXR0cmlidXRlcy0+c2V0QW50aWFsaWFzKG1f ZHJhd2luZ0J1ZmZlci0+bXVsdGlzYW1wbGUoKSk7CisgICAgfQogICAgIHJldHVybiBhdHRyaWJ1 dGVzLnJlbGVhc2UoKTsKIH0KIAo=