111663 2013-03-06 19:04:47 -0800 Make RuleData support up to 8191 selectors 2013-03-06 20:56:50 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Android Android RESOLVED FIXED P1 Blocker --- 0 pliard webkit-unassigned abarth esprehn+autocc kling macpherson menard ojan.autocc wangxianzhu webkit.review.bot oldest_to_newest 849611 0 pliard 2013-03-06 19:04:47 -0800 r125294 made RuleData consume less memory by replacing a pointer with an index encoded on 12 bits. This unfortunately breaks Chrome for Android when it is used with Adblock plus which injects a lot of CSS. This leads to blank pages on page load and is caused by an integer overflow when |m_selectorIndex| (encoded on 12 bits) is set. 849618 1 kling 2013-03-06 19:11:21 -0800 You can probably steal a bit from RuleData::m_position without causing much trouble. 849624 2 pliard 2013-03-06 19:20:52 -0800 Yes, I'm uploading a patch doing this right now. Thanks for the quick response. The other approach could also be to use the least significant bit of |m_rule| which is a pointer in case |m_position| cannot be shrunk (should be fine IMO). 849630 3 191896 pliard 2013-03-06 19:24:41 -0800 Created attachment 191896 Patch 849632 4 pliard 2013-03-06 19:25:40 -0800 I've just uploaded a patch. FYI, here is the corresponding Chromium bug: https://code.google.com/p/chromium/issues/detail?id=172276. 849639 5 191896 kling 2013-03-06 19:28:49 -0800 Comment on attachment 191896 Patch r=me We should look into the calculation of m_specificity at some point, it's very likely that it can be compressed to a much smaller value that won't have us scrambling for single bits like this. 849646 6 pliard 2013-03-06 19:33:00 -0800 Thanks guys, that was quick! I agree that things can probably be improved here although I'm not familiar with this code at all. 849667 7 191896 webkit.review.bot 2013-03-06 19:50:07 -0800 Comment on attachment 191896 Patch Rejecting attachment 191896 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=gce-cq-01', 'validate-changelog', '--non-interactive', 191896, '--port=chromium-xvfb']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-commit-queue.appspot.com/results/17064151 849676 8 191902 pliard 2013-03-06 20:02:33 -0800 Created attachment 191902 Patch 849677 9 pliard 2013-03-06 20:03:56 -0800 Sorry guys for the missing 'Reviewed by' line. I have just uploaded an updated patch. 849693 10 191902 webkit.review.bot 2013-03-06 20:56:46 -0800 Comment on attachment 191902 Patch Clearing flags on attachment: 191902 Committed r145034: <http://trac.webkit.org/changeset/145034> 849694 11 webkit.review.bot 2013-03-06 20:56:50 -0800 All reviewed patches have been landed. Closing bug. 191896 2013-03-06 19:24:41 -0800 2013-03-06 20:02:27 -0800 Patch bug-111663-20130307042046.patch text/plain 1865 pliard U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0OTczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2M2NzdiYjA5Y2Y0OTJm ODA2ZTI0MmI0ZjMyNTc5MjA4NmJhODA4MS4uNDIwMmIxOTlmM2JlZDVlZjA3NzlmNjExZDBmMWQ5 MWUyMTU1ZmY0YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEzLTAzLTA2ICBQaGls aXBwZSBMaWFyZCAgPHBsaWFyZEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgTWFrZSBSdWxlRGF0 YSBzdXBwb3J0IHVwIHRvIDgxOTEgc2VsZWN0b3JzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTE2NjMKKworICAgICAgICByMTI1Mjk0IG1hZGUgUnVs ZURhdGEgY29uc3VtZSBsZXNzIG1lbW9yeSBieSByZXBsYWNpbmcgYSBwb2ludGVyIHdpdGgKKyAg ICAgICAgYW4gaW5kZXggZW5jb2RlZCBvbiAxMiBiaXRzLgorICAgICAgICBUaGlzIHVuZm9ydHVu YXRlbHkgYnJlYWtzIENocm9tZSBmb3IgQW5kcm9pZCAoYW5kIG90aGVycykgd2hlbiBhIGxvdCBv ZgorICAgICAgICBDU1MgaXMgdXNlZCBvciBtb3JlIHByZWNpc2VseSB3aGVuIHNlbGVjdG9ySW5k ZXggY2Fubm90IGJlIHN0b3JlZCBvbiAxMgorICAgICAgICBiaXRzLgorCisgICAgICAgIFRocmVm b3JlIHRoaXMgY2hhbmdlIGRlY3JlYXNlcyB0aGUgbnVtYmVyIG9mIGJpdHMgdXNlZCB0byBzdG9y ZQorICAgICAgICBtX3Bvc2l0aW9uIGJ5IDEgKGZyb20gMTkgdG8gMTgpIGFuZCBhZGRzIHRoaXMg ZXh0cmEgYml0IHRvCisgICAgICAgIG1fc2VsZWN0b3JJbmRleCBzbyB0aGF0IHZhbHVlcyB1cCB0 byA4MTkxIGNhbiBiZSBzdG9yZWQgc2FmZWx5IHdpdGhvdXQKKyAgICAgICAgb3ZlcmZsb3dpbmcu CisKKyAgICAgICAgKiBjc3MvUnVsZVNldC5oOgorICAgICAgICAoUnVsZURhdGEpOgorCiAyMDEz LTAzLTA2ICBUb255IEdlbnRpbGNvcmUgIDx0b255Z0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAg VGhyZWFkZWQgSFRNTCBwYXJzZXIgc2hvdWxkIHVzZSA4IGJpdCBzdHJpbmdzIGZvciBhdHRyaWJ1 dGVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvUnVsZVNldC5oIGIvU291cmNlL1dl YkNvcmUvY3NzL1J1bGVTZXQuaAppbmRleCA0MWJlYTIxODNiODVjMWFhNTBiMjQzY2MwODdjNjYx MTk3YWZkNDExLi40MjE5MjVmMGZlZWUyMGYxM2IzNDMxOThmMDE4Njg1NzUzMzc5ZjVlIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvUnVsZVNldC5oCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2Nzcy9SdWxlU2V0LmgKQEAgLTc4LDEwICs3OCwxMCBAQCBwdWJsaWM6CiAKIHByaXZhdGU6CiAg ICAgU3R5bGVSdWxlKiBtX3J1bGU7Ci0gICAgdW5zaWduZWQgbV9zZWxlY3RvckluZGV4IDogMTI7 CisgICAgdW5zaWduZWQgbV9zZWxlY3RvckluZGV4IDogMTM7CiAgICAgLy8gVGhpcyBudW1iZXIg d2FzIHBpY2tlZCBmYWlybHkgYXJiaXRyYXJpbHkuIFdlIGNhbiBwcm9iYWJseSBsb3dlciBpdCBp ZiB3ZSBuZWVkIHRvLgogICAgIC8vIFNvbWUgc2ltcGxlIHRlc3Rpbmcgc2hvd2VkIDwxMDAsMDAw IFJ1bGVEYXRhJ3Mgb24gbGFyZ2Ugc2l0ZXMuCi0gICAgdW5zaWduZWQgbV9wb3NpdGlvbiA6IDE5 OworICAgIHVuc2lnbmVkIG1fcG9zaXRpb24gOiAxODsKICAgICB1bnNpZ25lZCBtX2hhc0Zhc3RD aGVja2FibGVTZWxlY3RvciA6IDE7CiAgICAgdW5zaWduZWQgbV9zcGVjaWZpY2l0eSA6IDI0Owog ICAgIHVuc2lnbmVkIG1faGFzTXVsdGlwYXJ0U2VsZWN0b3IgOiAxOwo= 191902 2013-03-06 20:02:33 -0800 2013-03-06 20:56:46 -0800 Patch bug-111663-20130307045837.patch text/plain 1903 pliard U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0OTczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2M2NzdiYjA5Y2Y0OTJm ODA2ZTI0MmI0ZjMyNTc5MjA4NmJhODA4MS4uYmJhOGQ1ZTY3NDZkNzRiYjFlNDFjMDY1NTNmMDYz Mjk1MmYwYTRhMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEzLTAzLTA2ICBQaGls aXBwZSBMaWFyZCAgPHBsaWFyZEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgTWFrZSBSdWxlRGF0 YSBzdXBwb3J0IHVwIHRvIDgxOTEgc2VsZWN0b3JzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTE2NjMKKworICAgICAgICBSZXZpZXdlZCBieSBBbmRy ZWFzIEtsaW5nLgorCisgICAgICAgIHIxMjUyOTQgbWFkZSBSdWxlRGF0YSBjb25zdW1lIGxlc3Mg bWVtb3J5IGJ5IHJlcGxhY2luZyBhIHBvaW50ZXIgd2l0aAorICAgICAgICBhbiBpbmRleCBlbmNv ZGVkIG9uIDEyIGJpdHMuCisgICAgICAgIFRoaXMgdW5mb3J0dW5hdGVseSBicmVha3MgQ2hyb21l IGZvciBBbmRyb2lkIChhbmQgb3RoZXJzKSB3aGVuIGEgbG90IG9mCisgICAgICAgIENTUyBpcyB1 c2VkIG9yIG1vcmUgcHJlY2lzZWx5IHdoZW4gc2VsZWN0b3JJbmRleCBjYW5ub3QgYmUgc3RvcmVk IG9uIDEyCisgICAgICAgIGJpdHMuCisKKyAgICAgICAgVGhyZWZvcmUgdGhpcyBjaGFuZ2UgZGVj cmVhc2VzIHRoZSBudW1iZXIgb2YgYml0cyB1c2VkIHRvIHN0b3JlCisgICAgICAgIG1fcG9zaXRp b24gYnkgMSAoZnJvbSAxOSB0byAxOCkgYW5kIGFkZHMgdGhpcyBleHRyYSBiaXQgdG8KKyAgICAg ICAgbV9zZWxlY3RvckluZGV4IHNvIHRoYXQgdmFsdWVzIHVwIHRvIDgxOTEgY2FuIGJlIHN0b3Jl ZCBzYWZlbHkgd2l0aG91dAorICAgICAgICBvdmVyZmxvd2luZy4KKworICAgICAgICAqIGNzcy9S dWxlU2V0Lmg6CisgICAgICAgIChSdWxlRGF0YSk6CisKIDIwMTMtMDMtMDYgIFRvbnkgR2VudGls Y29yZSAgPHRvbnlnQGNocm9taXVtLm9yZz4KIAogICAgICAgICBUaHJlYWRlZCBIVE1MIHBhcnNl ciBzaG91bGQgdXNlIDggYml0IHN0cmluZ3MgZm9yIGF0dHJpYnV0ZXMKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2Nzcy9SdWxlU2V0LmggYi9Tb3VyY2UvV2ViQ29yZS9jc3MvUnVsZVNldC5o CmluZGV4IDQxYmVhMjE4M2I4NWMxYWE1MGIyNDNjYzA4N2M2NjExOTdhZmQ0MTEuLjQyMTkyNWYw ZmVlZTIwZjEzYjM0MzE5OGYwMTg2ODU3NTMzNzlmNWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2Nzcy9SdWxlU2V0LmgKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL1J1bGVTZXQuaApAQCAt NzgsMTAgKzc4LDEwIEBAIHB1YmxpYzoKIAogcHJpdmF0ZToKICAgICBTdHlsZVJ1bGUqIG1fcnVs ZTsKLSAgICB1bnNpZ25lZCBtX3NlbGVjdG9ySW5kZXggOiAxMjsKKyAgICB1bnNpZ25lZCBtX3Nl bGVjdG9ySW5kZXggOiAxMzsKICAgICAvLyBUaGlzIG51bWJlciB3YXMgcGlja2VkIGZhaXJseSBh cmJpdHJhcmlseS4gV2UgY2FuIHByb2JhYmx5IGxvd2VyIGl0IGlmIHdlIG5lZWQgdG8uCiAgICAg Ly8gU29tZSBzaW1wbGUgdGVzdGluZyBzaG93ZWQgPDEwMCwwMDAgUnVsZURhdGEncyBvbiBsYXJn ZSBzaXRlcy4KLSAgICB1bnNpZ25lZCBtX3Bvc2l0aW9uIDogMTk7CisgICAgdW5zaWduZWQgbV9w b3NpdGlvbiA6IDE4OwogICAgIHVuc2lnbmVkIG1faGFzRmFzdENoZWNrYWJsZVNlbGVjdG9yIDog MTsKICAgICB1bnNpZ25lZCBtX3NwZWNpZmljaXR5IDogMjQ7CiAgICAgdW5zaWduZWQgbV9oYXNN dWx0aXBhcnRTZWxlY3RvciA6IDE7Cg==