111662 2013-03-06 19:01:41 -0800 [wk2] Page overlays shouldn't dirty the entire layer when flushing if the main frame can't scroll 2013-03-21 16:50:32 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 111945 1 thorton thorton andersca simon.fraser webkit.review.bot oldest_to_newest 849610 0 thorton 2013-03-06 19:01:41 -0800 We currently setNeedsDisplay() on the whole page overlay layer every time through TCADA::flushLayers. This is necessary to keep things painted in the right place when we scroll, but is quite wasteful in apps that don’t scroll. Instead, we can setNeedsDisplay() at scroll time instead. Testing with the Find overlay and other Safari overlays seems to work. <rdar://problem/13355808> 849613 1 191891 thorton 2013-03-06 19:05:00 -0800 Created attachment 191891 patch 849621 2 191891 simon.fraser 2013-03-06 19:16:41 -0800 Comment on attachment 191891 patch Yay 849734 3 thorton 2013-03-06 22:01:05 -0800 http://trac.webkit.org/changeset/145039 851958 4 webkit.review.bot 2013-03-10 12:23:44 -0700 Re-opened since this is blocked by bug 111945 860863 5 194381 thorton 2013-03-21 16:39:26 -0700 Created attachment 194381 better patch! 860865 6 194381 dino 2013-03-21 16:42:18 -0700 Comment on attachment 194381 better patch! you said you'd remove local var on irc 860877 7 thorton 2013-03-21 16:50:32 -0700 http://trac.webkit.org/changeset/146539 191891 2013-03-06 19:05:00 -0800 2013-03-21 16:39:26 -0700 patch scrolling-setneedsdisplay.diff text/plain 2478 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAyN2UxYmFjLi5kNzQwMzcwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjUg QEAKIDIwMTMtMDMtMDYgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CiAK KyAgICAgICAgW3drMl0gUGFnZSBvdmVybGF5cyBzaG91bGRuJ3QgZGlydHkgdGhlIGVudGlyZSBs YXllciB3aGVuIGZsdXNoaW5nIGlmIHRoZSBtYWluIGZyYW1lIGNhbid0IHNjcm9sbAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTExNjYyCisgICAgICAg IDxyZGFyOi8vcHJvYmxlbS8xMzM1NTgwOD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBJbnN0ZWFkIG9mIHNldE5lZWRzRGlzcGxheSgpaW5nIHRoZSB3 aG9sZSBwYWdlIG92ZXJsYXkgbGF5ZXIgZXZlcnkgdGltZSB0aHJvdWdoCisgICAgICAgIFRDQURB OjpmbHVzaExheWVycywgZG8gaXQgYXQgc2Nyb2xsIHRpbWUgaW5zdGVhZC4gUmVwYWludGluZyBv biBzY3JvbGwgaXMKKyAgICAgICAgbmVjZXNzYXJ5IHRvIGtlZXAgdGhpbmdzIHBhaW50ZWQgaW4g dGhlIHJpZ2h0IHBsYWNlIHdoZW4gd2Ugc2Nyb2xsICh0aGUgb3ZlcmxheQorICAgICAgICBpcyBm aXhlZCB0byB0aGUgc2l6ZSBvZiB0aGUgdmlldyksIGJ1dCBpcyBxdWl0ZSB3YXN0ZWZ1bCBpbiBh cHBzIHRoYXQgZG9u4oCZdCBzY3JvbGwuCisKKyAgICAgICAgVGhpcyB3b3JrcyB3aXRoIHRocmVh ZGVkIHNjcm9sbGluZyBiZWNhdXNlIG92ZXJsYXkgaW5zdGFsbGF0aW9uIGZvcmNlcyB1cworICAg ICAgICBpbnRvIG1haW4tdGhyZWFkIHNjcm9sbGluZyBtb2RlLgorCisgICAgICAgICogV2ViUHJv Y2Vzcy9XZWJQYWdlL21hYy9UaWxlZENvcmVBbmltYXRpb25EcmF3aW5nQXJlYS5tbToKKyAgICAg ICAgKFdlYktpdDo6VGlsZWRDb3JlQW5pbWF0aW9uRHJhd2luZ0FyZWE6OnNjcm9sbCk6CisgICAg ICAgIChXZWJLaXQ6OlRpbGVkQ29yZUFuaW1hdGlvbkRyYXdpbmdBcmVhOjpmbHVzaExheWVycyk6 CisKKzIwMTMtMDMtMDYgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK ICAgICAgICAgW3drMl0gUGFnZSBPdmVybGF5czogSG9vayB1cCB0aGUgbGF5ZXIgYm9yZGVyL3Jl cGFpbnQgY291bnRlciBzZXR0aW5nIHRvIHRoZSBvdmVybGF5IGxheWVyCiAgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTE1NDcKICAgICAgICAgPHJkYXI6 Ly9wcm9ibGVtLzEzMzU1ODAxPgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vz cy9XZWJQYWdlL21hYy9UaWxlZENvcmVBbmltYXRpb25EcmF3aW5nQXJlYS5tbSBiL1NvdXJjZS9X ZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMvVGlsZWRDb3JlQW5pbWF0aW9uRHJhd2luZ0Fy ZWEubW0KaW5kZXggMWYxYzJmMy4uZmY0ZGZjOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIv V2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9UaWxlZENvcmVBbmltYXRpb25EcmF3aW5nQXJlYS5tbQor KysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1RpbGVkQ29yZUFuaW1h dGlvbkRyYXdpbmdBcmVhLm1tCkBAIC0xMTAsNiArMTEwLDcgQEAgdm9pZCBUaWxlZENvcmVBbmlt YXRpb25EcmF3aW5nQXJlYTo6c2V0TmVlZHNEaXNwbGF5SW5SZWN0KGNvbnN0IEludFJlY3QmIHJl Y3QpCiAKIHZvaWQgVGlsZWRDb3JlQW5pbWF0aW9uRHJhd2luZ0FyZWE6OnNjcm9sbChjb25zdCBJ bnRSZWN0JiBzY3JvbGxSZWN0LCBjb25zdCBJbnRTaXplJiBzY3JvbGxEZWx0YSkKIHsKKyAgICBt X3BhZ2VPdmVybGF5TGF5ZXItPnNldE5lZWRzRGlzcGxheSgpOwogfQogCiB2b2lkIFRpbGVkQ29y ZUFuaW1hdGlvbkRyYXdpbmdBcmVhOjpzZXRSb290Q29tcG9zaXRpbmdMYXllcihHcmFwaGljc0xh eWVyKiBncmFwaGljc0xheWVyKQpAQCAtMzA2LDcgKzMwNyw2IEBAIGJvb2wgVGlsZWRDb3JlQW5p bWF0aW9uRHJhd2luZ0FyZWE6OmZsdXNoTGF5ZXJzKCkKICAgICB9CiAKICAgICBpZiAobV9wYWdl T3ZlcmxheUxheWVyKSB7Ci0gICAgICAgIG1fcGFnZU92ZXJsYXlMYXllci0+c2V0TmVlZHNEaXNw bGF5KCk7CiAgICAgICAgIGlmIChUaWxlZEJhY2tpbmcqIG92ZXJsYXlUaWxlZEJhY2tpbmcgPSBt X3BhZ2VPdmVybGF5TGF5ZXItPnRpbGVkQmFja2luZygpKQogICAgICAgICAgICAgb3ZlcmxheVRp bGVkQmFja2luZy0+c2V0VmlzaWJsZVJlY3QoZW5jbG9zaW5nSW50UmVjdChtX3Jvb3RMYXllci5n ZXQoKS5mcmFtZSkpOwogICAgICAgICBtX3BhZ2VPdmVybGF5TGF5ZXItPmZsdXNoQ29tcG9zaXRp bmdTdGF0ZUZvclRoaXNMYXllck9ubHkoKTsK 194381 2013-03-21 16:39:26 -0700 2013-03-21 16:42:18 -0700 better patch! page-overlay-scroll.diff text/plain 2559 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2Vi RnJhbWVMb2FkZXJDbGllbnQuY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3Jl U3VwcG9ydC9XZWJGcmFtZUxvYWRlckNsaWVudC5jcHAKaW5kZXggYWE4N2NjNi4uMTk3NzM0NCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJG cmFtZUxvYWRlckNsaWVudC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJD b3JlU3VwcG9ydC9XZWJGcmFtZUxvYWRlckNsaWVudC5jcHAKQEAgLTE1NDUsNiArMTU0NSw4IEBA IHZvaWQgV2ViRnJhbWVMb2FkZXJDbGllbnQ6OmRpZENoYW5nZVNjcm9sbE9mZnNldCgpCiAgICAg aWYgKCF3ZWJQYWdlKQogICAgICAgICByZXR1cm47CiAKKyAgICB3ZWJQYWdlLT5kcmF3aW5nQXJl YSgpLT5kaWRDaGFuZ2VTY3JvbGxPZmZzZXRGb3JBbnlGcmFtZSgpOworCiAgICAgaWYgKCFtX2Zy YW1lLT5pc01haW5GcmFtZSgpKQogICAgICAgICByZXR1cm47CiAKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMvVGlsZWRDb3JlQW5pbWF0aW9uRHJhd2lu Z0FyZWEuaCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMvVGlsZWRDb3Jl QW5pbWF0aW9uRHJhd2luZ0FyZWEuaAppbmRleCBjNDJhMzA3Li5kMTU0ZTQ4IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1RpbGVkQ29yZUFuaW1hdGlv bkRyYXdpbmdBcmVhLmgKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL21h Yy9UaWxlZENvcmVBbmltYXRpb25EcmF3aW5nQXJlYS5oCkBAIC03Nyw2ICs3Nyw4IEBAIHByaXZh dGU6CiAgICAgdmlydHVhbCB2b2lkIHNldEV4cG9zZWRSZWN0KGNvbnN0IFdlYkNvcmU6OkZsb2F0 UmVjdCYpIE9WRVJSSURFOwogICAgIHZpcnR1YWwgdm9pZCBtYWluRnJhbWVTY3JvbGxhYmlsaXR5 Q2hhbmdlZChib29sKSBPVkVSUklERTsKIAorICAgIHZpcnR1YWwgdm9pZCBkaWRDaGFuZ2VTY3Jv bGxPZmZzZXRGb3JBbnlGcmFtZSgpIE9WRVJSSURFOworCiAgICAgdmlydHVhbCB2b2lkIGRpc3Bh dGNoQWZ0ZXJFbnN1cmluZ1VwZGF0ZWRTY3JvbGxQb3NpdGlvbihjb25zdCBGdW5jdGlvbjx2b2lk ICgpPiYpIE9WRVJSSURFOwogCiAgICAgLy8gV2ViQ29yZTo6R3JhcGhpY3NMYXllckNsaWVudApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9UaWxlZENv cmVBbmltYXRpb25EcmF3aW5nQXJlYS5tbSBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2Vi UGFnZS9tYWMvVGlsZWRDb3JlQW5pbWF0aW9uRHJhd2luZ0FyZWEubW0KaW5kZXggYWQwYmYwZi4u ZWFmMGJjMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL21h Yy9UaWxlZENvcmVBbmltYXRpb25EcmF3aW5nQXJlYS5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9X ZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1RpbGVkQ29yZUFuaW1hdGlvbkRyYXdpbmdBcmVhLm1tCkBA IC0xMTMsNiArMTEzLDE0IEBAIHZvaWQgVGlsZWRDb3JlQW5pbWF0aW9uRHJhd2luZ0FyZWE6OnNj cm9sbChjb25zdCBJbnRSZWN0JiBzY3JvbGxSZWN0LCBjb25zdCBJbnRTCiB7CiB9CiAKK3ZvaWQg VGlsZWRDb3JlQW5pbWF0aW9uRHJhd2luZ0FyZWE6OmRpZENoYW5nZVNjcm9sbE9mZnNldEZvckFu eUZyYW1lKCkKK3sKKyAgICBmb3IgKFBhZ2VPdmVybGF5TGF5ZXJNYXA6Oml0ZXJhdG9yIGl0ID0g bV9wYWdlT3ZlcmxheUxheWVycy5iZWdpbigpLCBlbmQgPSBtX3BhZ2VPdmVybGF5TGF5ZXJzLmVu ZCgpOyBpdCAhPSBlbmQ7ICsraXQpIHsKKyAgICAgICAgR3JhcGhpY3NMYXllciogbGF5ZXIgPSBp dC0+dmFsdWUuZ2V0KCk7CisgICAgICAgIGxheWVyLT5zZXROZWVkc0Rpc3BsYXkoKTsKKyAgICB9 Cit9CisKIHZvaWQgVGlsZWRDb3JlQW5pbWF0aW9uRHJhd2luZ0FyZWE6OnNldFJvb3RDb21wb3Np dGluZ0xheWVyKEdyYXBoaWNzTGF5ZXIqIGdyYXBoaWNzTGF5ZXIpCiB7CiAgICAgQ0FMYXllciAq cm9vdENvbXBvc2l0aW5nTGF5ZXIgPSBncmFwaGljc0xheWVyID8gZ3JhcGhpY3NMYXllci0+cGxh dGZvcm1MYXllcigpIDogbmlsOwpAQCAtMzI1LDcgKzMzMyw2IEBAIGJvb2wgVGlsZWRDb3JlQW5p bWF0aW9uRHJhd2luZ0FyZWE6OmZsdXNoTGF5ZXJzKCkKICAgICAgICAgdmlzaWJsZVJlY3QuaW50 ZXJzZWN0KGVuY2xvc2luZ0ludFJlY3QobV9leHBvc2VkUmVjdCkpOwogICAgIGZvciAoUGFnZU92 ZXJsYXlMYXllck1hcDo6aXRlcmF0b3IgaXQgPSBtX3BhZ2VPdmVybGF5TGF5ZXJzLmJlZ2luKCk7 IGl0ICE9IGVuZDsgKytpdCkgewogICAgICAgICBHcmFwaGljc0xheWVyKiBsYXllciA9IGl0LT52 YWx1ZS5nZXQoKTsKLSAgICAgICAgbGF5ZXItPnNldE5lZWRzRGlzcGxheSgpOwogICAgICAgICBs YXllci0+Zmx1c2hDb21wb3NpdGluZ1N0YXRlKHZpc2libGVSZWN0KTsKICAgICB9CiAK