111657 2013-03-06 18:11:38 -0800 Don't give PageAllocationAligned the option to allocate executable memory 2013-03-06 20:04:15 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 oliver oliver benjamin cmarcelo jchaffraix ojan.autocc webkit.review.bot oldest_to_newest 849567 0 oliver 2013-03-06 18:11:38 -0800 Don't give PageAllocationAligned the option to allocate executable memory 849568 1 191881 oliver 2013-03-06 18:12:06 -0800 Created attachment 191881 Patch 849573 2 191881 ggaren 2013-03-06 18:14:46 -0800 Comment on attachment 191881 Patch r=me 849575 3 webkit.review.bot 2013-03-06 18:15:49 -0800 Attachment 191881 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/PageAllocationAligned.cpp', u'Source/WTF/wtf/PageAllocationAligned.h']" exit_code: 1 Source/WTF/wtf/PageAllocationAligned.h:44: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WTF/wtf/PageAllocationAligned.h:44: The parameter name "usage" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 849577 4 oliver 2013-03-06 18:16:34 -0800 Committed r145018: <http://trac.webkit.org/changeset/145018> 849603 5 jchaffraix 2013-03-06 18:57:02 -0800 This change broke all the builds (because non Mac platforms used the boolean) but you never saw that because you didn't run the EWS. There is a patch to fix it in bug 111659. But it also broke Apple Win on top of it as the WTF exported symbol changed. Unless you fix this within 30 minutes, I will have to roll this change out. 849606 6 jchaffraix 2013-03-06 19:00:23 -0800 > But it also broke Apple Win on top of it as the WTF exported symbol changed. > > Unless you fix this within 30 minutes, I will have to roll this change out. Actually scratch that, Ryosuke corrected me. It will be corrected by bug 111659. Thanks for wasting everybody's time. 849678 7 oliver 2013-03-06 20:04:15 -0800 (In reply to comment #6) > > But it also broke Apple Win on top of it as the WTF exported symbol changed. > > > > Unless you fix this within 30 minutes, I will have to roll this change out. > > Actually scratch that, Ryosuke corrected me. It will be corrected by bug 111659. Thanks for wasting everybody's time. That's the one of least professional comments i've seen yet. Obviously I did not deliberately break other builds (i thought i had removed the use of the executable parameter for other builds). 191881 2013-03-06 18:12:06 -0800 2013-03-06 18:14:46 -0800 Patch bug-111657-20130306180811.patch text/plain 3404 oliver U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1MDAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDY2NmJkMDY1NmVkMDdjMjQ0MmI3MDFk YjEwOTMyOTM5YzZjZjk2YWEuLmNlOTQwMmRiM2Y3ZWZjOGE4OGFjNGU2MGI0MzQyMzZhZjkzYTZm YjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTMtMDMtMDYgIE9saXZlciBIdW50ICA8b2xpdmVy QGFwcGxlLmNvbT4KKworICAgICAgICBEb24ndCBnaXZlIFBhZ2VBbGxvY2F0aW9uQWxpZ25lZCB0 aGUgb3B0aW9uIHRvIGFsbG9jYXRlIGV4ZWN1dGFibGUgbWVtb3J5CisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTE2NTcKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHd0Zi9QYWdlQWxsb2NhdGlvbkFsaWdu ZWQuY3BwOgorICAgICAgICAoV1RGOjpQYWdlQWxsb2NhdGlvbkFsaWduZWQ6OmFsbG9jYXRlKToK KyAgICAgICAgKiB3dGYvUGFnZUFsbG9jYXRpb25BbGlnbmVkLmg6CisgICAgICAgIChQYWdlQWxs b2NhdGlvbkFsaWduZWQpOgorCiAyMDEzLTAzLTA0ICBPbGl2ZXIgSHVudCAgPG9saXZlckBhcHBs ZS5jb20+CiAKICAgICAgICAgTWFrZSBmYXN0bWFsbG9jIHVzZSBndWFyZHBhZ2VzCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV1RGL3d0Zi9QYWdlQWxsb2NhdGlvbkFsaWduZWQuY3BwIGIvU291cmNlL1dU Ri93dGYvUGFnZUFsbG9jYXRpb25BbGlnbmVkLmNwcAppbmRleCA2ZjU0NzEwZDBiZDcwN2JkNjJj NGIxNTE1NTZmNGNhZjI1MTYxYjMwLi40ODUyM2NkMWJjYTQxZjM4Y2VjYzE0MWRjZWRjMTBlNmZh NGE1NDVkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9QYWdlQWxsb2NhdGlvbkFsaWduZWQu Y3BwCisrKyBiL1NvdXJjZS9XVEYvd3RmL1BhZ2VBbGxvY2F0aW9uQWxpZ25lZC5jcHAKQEAgLTI4 LDcgKzI4LDcgQEAKIAogbmFtZXNwYWNlIFdURiB7CiAKLVBhZ2VBbGxvY2F0aW9uQWxpZ25lZCBQ YWdlQWxsb2NhdGlvbkFsaWduZWQ6OmFsbG9jYXRlKHNpemVfdCBzaXplLCBzaXplX3QgYWxpZ25t ZW50LCBPU0FsbG9jYXRvcjo6VXNhZ2UgdXNhZ2UsIGJvb2wgd3JpdGFibGUsIGJvb2wgZXhlY3V0 YWJsZSkKK1BhZ2VBbGxvY2F0aW9uQWxpZ25lZCBQYWdlQWxsb2NhdGlvbkFsaWduZWQ6OmFsbG9j YXRlKHNpemVfdCBzaXplLCBzaXplX3QgYWxpZ25tZW50LCBPU0FsbG9jYXRvcjo6VXNhZ2UgdXNh Z2UsIGJvb2wgd3JpdGFibGUpCiB7CiAgICAgQVNTRVJUKGlzUGFnZUFsaWduZWQoc2l6ZSkpOwog ICAgIEFTU0VSVChpc1BhZ2VBbGlnbmVkKGFsaWdubWVudCkpOwpAQCAtNDMsMTEgKzQzLDkgQEAg UGFnZUFsbG9jYXRpb25BbGlnbmVkIFBhZ2VBbGxvY2F0aW9uQWxpZ25lZDo6YWxsb2NhdGUoc2l6 ZV90IHNpemUsIHNpemVfdCBhbGlnbm0KICAgICBpbnQgcHJvdGVjdGlvbiA9IFBST1RfUkVBRDsK ICAgICBpZiAod3JpdGFibGUpCiAgICAgICAgIHByb3RlY3Rpb24gfD0gUFJPVF9XUklURTsKLSAg ICBpZiAoZXhlY3V0YWJsZSkKLSAgICAgICAgcHJvdGVjdGlvbiB8PSBQUk9UX0VYRUM7CiAKICAg ICB2bV9hZGRyZXNzX3QgYWRkcmVzcyA9IDA7Ci0gICAgdm1fbWFwKGN1cnJlbnRfdGFzaygpLCAm YWRkcmVzcywgc2l6ZSwgYWxpZ25tZW50TWFzaywgZmxhZ3MsIE1FTU9SWV9PQkpFQ1RfTlVMTCwg MCwgRkFMU0UsIHByb3RlY3Rpb24sIFBST1RfUkVBRCB8IFBST1RfV1JJVEUgfCBQUk9UX0VYRUMs IFZNX0lOSEVSSVRfREVGQVVMVCk7CisgICAgdm1fbWFwKGN1cnJlbnRfdGFzaygpLCAmYWRkcmVz cywgc2l6ZSwgYWxpZ25tZW50TWFzaywgZmxhZ3MsIE1FTU9SWV9PQkpFQ1RfTlVMTCwgMCwgRkFM U0UsIHByb3RlY3Rpb24sIFBST1RfUkVBRCB8IFBST1RfV1JJVEUsIFZNX0lOSEVSSVRfREVGQVVM VCk7CiAgICAgcmV0dXJuIFBhZ2VBbGxvY2F0aW9uQWxpZ25lZChyZWludGVycHJldF9jYXN0PHZv aWQqPihhZGRyZXNzKSwgc2l6ZSk7CiAjZWxzZQogICAgIHNpemVfdCBhbGlnbm1lbnREZWx0YSA9 IGFsaWdubWVudCAtIHBhZ2VTaXplKCk7CkBAIC02MCw3ICs1OCw3IEBAIFBhZ2VBbGxvY2F0aW9u QWxpZ25lZCBQYWdlQWxsb2NhdGlvbkFsaWduZWQ6OmFsbG9jYXRlKHNpemVfdCBzaXplLCBzaXpl X3QgYWxpZ25tCiAgICAgdm9pZCogYWxpZ25lZEJhc2UgPSByZWludGVycHJldF9jYXN0PHVpbnRw dHJfdD4ocmVzZXJ2YXRpb25CYXNlKSAmIGFsaWdubWVudE1hc2sKICAgICAgICAgPyByZWludGVy cHJldF9jYXN0PHZvaWQqPigocmVpbnRlcnByZXRfY2FzdDx1aW50cHRyX3Q+KHJlc2VydmF0aW9u QmFzZSkgJiB+YWxpZ25tZW50TWFzaykgKyBhbGlnbm1lbnQpCiAgICAgICAgIDogcmVzZXJ2YXRp b25CYXNlOwotICAgIE9TQWxsb2NhdG9yOjpjb21taXQoYWxpZ25lZEJhc2UsIHNpemUsIHdyaXRh YmxlLCBleGVjdXRhYmxlKTsKKyAgICBPU0FsbG9jYXRvcjo6Y29tbWl0KGFsaWduZWRCYXNlLCBz aXplLCB3cml0YWJsZSwgZmFsc2UpOwogCiAgICAgcmV0dXJuIFBhZ2VBbGxvY2F0aW9uQWxpZ25l ZChhbGlnbmVkQmFzZSwgc2l6ZSwgcmVzZXJ2YXRpb25CYXNlLCByZXNlcnZhdGlvblNpemUpOwog I2VuZGlmCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9QYWdlQWxsb2NhdGlvbkFsaWduZWQu aCBiL1NvdXJjZS9XVEYvd3RmL1BhZ2VBbGxvY2F0aW9uQWxpZ25lZC5oCmluZGV4IGMwMThkYWJk OGUzNDVjYTMzMzVjNzk3YWZlODc4MDFjYTQ4ODNlMGQuLjIxMWE2MWI4YjVmMGJlNzYwZmVmM2Vj YzIyZmRkOWY2OTEzYjdhYmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL1BhZ2VBbGxvY2F0 aW9uQWxpZ25lZC5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL1BhZ2VBbGxvY2F0aW9uQWxpZ25lZC5o CkBAIC00MSw3ICs0MSw3IEBAIHB1YmxpYzoKICAgICB1c2luZyBQYWdlQmxvY2s6OnNpemU7CiAg ICAgdXNpbmcgUGFnZUJsb2NrOjpiYXNlOwogCi0gICAgc3RhdGljIFBhZ2VBbGxvY2F0aW9uQWxp Z25lZCBhbGxvY2F0ZShzaXplX3Qgc2l6ZSwgc2l6ZV90IGFsaWdubWVudCwgT1NBbGxvY2F0b3I6 OlVzYWdlIHVzYWdlID0gT1NBbGxvY2F0b3I6OlVua25vd25Vc2FnZSwgYm9vbCB3cml0YWJsZSA9 IHRydWUsIGJvb2wgZXhlY3V0YWJsZSA9IGZhbHNlKTsKKyAgICBzdGF0aWMgUGFnZUFsbG9jYXRp b25BbGlnbmVkIGFsbG9jYXRlKHNpemVfdCBzaXplLCBzaXplX3QgYWxpZ25tZW50LCBPU0FsbG9j YXRvcjo6VXNhZ2UgdXNhZ2UgPSBPU0FsbG9jYXRvcjo6VW5rbm93blVzYWdlLCBib29sIHdyaXRh YmxlID0gdHJ1ZSk7CiAKICAgICB2b2lkIGRlYWxsb2NhdGUoKTsKIAo=