111656 2013-03-06 18:02:12 -0800 OpenGLShims: fix check for ANGLE GLES2 extensions 2013-03-07 07:56:42 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 sergio webkit-unassigned hausmann sergio webkit.review.bot oldest_to_newest 849556 0 sergio 2013-03-06 18:02:12 -0800 OpenGLShims: fix check for ANGLE GLES2 extensions 849562 1 191878 sergio 2013-03-06 18:06:50 -0800 Created attachment 191878 Proposed patch 849576 2 sergio 2013-03-06 18:16:30 -0800 The check for ANGLE GLES2 extensions is currently being overriden with checks for APPLE extensions in lookupOpenGLFunctionAddress() 850044 3 191878 hausmann 2013-03-07 06:48:06 -0800 Comment on attachment 191878 Proposed patch Good catch! r- due to missing ChangeLog though. 850050 4 sergio 2013-03-07 07:01:07 -0800 (In reply to comment #3) > (From update of attachment 191878 [details]) > Good catch! > > r- due to missing ChangeLog though. Sure, I will update this :) 850072 5 191993 sergio 2013-03-07 07:30:30 -0800 Created attachment 191993 Patch Proposed patch 850093 6 191993 webkit.review.bot 2013-03-07 07:56:38 -0800 Comment on attachment 191993 Patch Clearing flags on attachment: 191993 Committed r145079: <http://trac.webkit.org/changeset/145079> 850095 7 webkit.review.bot 2013-03-07 07:56:42 -0800 All reviewed patches have been landed. Closing bug. 191878 2013-03-06 18:06:50 -0800 2013-03-07 07:30:24 -0800 Proposed patch openglshims.patch text/plain 952 sergio Y29tbWl0IDkyMzViZDQ3MDQ2MzQwYmI2YmFhZWU4YmY5OTFmMWNlZTViMzI1ZmUKQXV0aG9yOiBT ZXJnaW8gQ29ycmVpYSA8c2VyZ2lvLmNvcnJlaWFAb3BlbmJvc3NhLm9yZz4KRGF0ZTogICBXZWQg TWFyIDYgMjE6NDQ6MzcgMjAxMyAtMDQwMAoKICAgIE9wZW5HTFNoaW1zOiBmaXggY2hlY2sgZm9y IEFOR0xFIEdMRVMyIGV4dGVuc2lvbnMKICAgIAogICAgVGhlIGNoZWNrIGZvciBBTkdMRSBHTEVT MiBleHRlbnNpb25zIGlzIGN1cnJlbnRseSBiZWluZyBvdmVycmlkZW4KICAgIHdpdGggY2hlY2tz IGZvciBBUFBMRSBleHRlbnNpb25zIGluIGxvb2t1cE9wZW5HTEZ1bmN0aW9uQWRkcmVzcygpCgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvT3BlbkdMU2hpbXMu Y3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvT3BlbkdMU2hpbXMuY3BwCmlu ZGV4IDczZWY0M2QuLmNhMzI4NjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL09wZW5HTFNoaW1zLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9PcGVuR0xTaGltcy5jcHAKQEAgLTg0LDYgKzg0LDggQEAgc3RhdGljIHZvaWQqIGxv b2t1cE9wZW5HTEZ1bmN0aW9uQWRkcmVzcyhjb25zdCBjaGFyKiBmdW5jdGlvbk5hbWUsIGJvb2wq IHN1Y2Nlc3MKICAgICBmdWxsRnVuY3Rpb25OYW1lID0gZnVuY3Rpb25OYW1lOwogICAgIGZ1bGxG dW5jdGlvbk5hbWUuYXBwZW5kKCJBTkdMRSIpOwogICAgIHRhcmdldCA9IGdldFByb2NBZGRyZXNz KGZ1bGxGdW5jdGlvbk5hbWUudXRmOCgpLmRhdGEoKSk7CisgICAgaWYgKHRhcmdldCkKKyAgICAg ICAgcmV0dXJuIHRhcmdldDsKIAogICAgIGZ1bGxGdW5jdGlvbk5hbWUgPSBmdW5jdGlvbk5hbWU7 CiAgICAgZnVsbEZ1bmN0aW9uTmFtZS5hcHBlbmQoIkFQUExFIik7Cg== 191993 2013-03-07 07:30:30 -0800 2013-03-07 07:56:38 -0800 Patch bug-111656-20130307112632.patch text/plain 1567 sergio U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1MDE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzFjYjI0YTJjNGU3NDFl NGQ5YzkzNGU1ZTQ2MzU4ZThlN2ZkZjQzZS4uMTI3ZjI5NmNlZDYyNjMzYWFiNWNlMGM0ODI4NTE0 MWZhYWE3ODdhMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTAzLTA3ICBTZXJn aW8gQ29ycmVpYSAgPHNlcmdpby5jb3JyZWlhQG9wZW5ib3NzYS5vcmc+CisKKyAgICAgICAgT3Bl bkdMU2hpbXM6IGZpeCBjaGVjayBmb3IgQU5HTEUgR0xFUzIgZXh0ZW5zaW9ucworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTExNjU2CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGNoZWNrIGZvciBBTkdM RSBHTEVTMiBleHRlbnNpb25zIGlzIGN1cnJlbnRseSBiZWluZyBvdmVycmlkZW4KKyAgICAgICAg d2l0aCBjaGVja3MgZm9yIEFQUExFIGV4dGVuc2lvbnMgaW4gbG9va3VwT3BlbkdMRnVuY3Rpb25B ZGRyZXNzKCkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBObyB1c2VyIHZpc2libGUgYmVoYXZp b3IgY2hhbmdlZC4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL09wZW5HTFNoaW1zLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6Omxvb2t1cE9wZW5HTEZ1bmN0aW9uQWRkcmVzcyk6CisKIDIw MTMtMDMtMDYgIEFiaGlzaGVrIEFyeWEgIDxpbmZlcm5vQGNocm9taXVtLm9yZz4KIAogICAgICAg ICBDcmFzaCBpbiBTVkdWaWV3U3BlYzo6dmlld1RhcmdldApkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvT3BlbkdMU2hpbXMuY3BwIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvT3BlbkdMU2hpbXMuY3BwCmluZGV4IDczZWY0M2Q0MDYzYTVlMTk4 YzExOTNmYzQ4MjQ5N2JhYTQ1YjYwZjguLmNhMzI4NjI4YjAwYWU2NWFhMWRlMTljMWZlOTY2NjNm N2QxYzVkZTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL09w ZW5HTFNoaW1zLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9PcGVu R0xTaGltcy5jcHAKQEAgLTg0LDYgKzg0LDggQEAgc3RhdGljIHZvaWQqIGxvb2t1cE9wZW5HTEZ1 bmN0aW9uQWRkcmVzcyhjb25zdCBjaGFyKiBmdW5jdGlvbk5hbWUsIGJvb2wqIHN1Y2Nlc3MKICAg ICBmdWxsRnVuY3Rpb25OYW1lID0gZnVuY3Rpb25OYW1lOwogICAgIGZ1bGxGdW5jdGlvbk5hbWUu YXBwZW5kKCJBTkdMRSIpOwogICAgIHRhcmdldCA9IGdldFByb2NBZGRyZXNzKGZ1bGxGdW5jdGlv bk5hbWUudXRmOCgpLmRhdGEoKSk7CisgICAgaWYgKHRhcmdldCkKKyAgICAgICAgcmV0dXJuIHRh cmdldDsKIAogICAgIGZ1bGxGdW5jdGlvbk5hbWUgPSBmdW5jdGlvbk5hbWU7CiAgICAgZnVsbEZ1 bmN0aW9uTmFtZS5hcHBlbmQoIkFQUExFIik7Cg==