111650 2013-03-06 17:13:05 -0800 REGRESSION (r143931): set-cookie-on-redirect.html still breaking subsequent tests 2013-08-21 13:57:33 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dino ap ap commit-queue eric lforschler svillar oldest_to_newest 849505 0 dino 2013-03-06 17:13:05 -0800 After https://bugs.webkit.org/show_bug.cgi?id=110844 we're still seeing flakiness on http/tests/cookies/third-party-cookie-relaxing.html http/tests/plugins/third-party-cookie-accept-policy.html e.g. http://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK1%20(Tests)/r144995%20(6142)/results.html I'm going to skip them for now because our bot is backed up. Sergio, could you remove the skip if you can fix this? Thanks. 849512 1 dino 2013-03-06 17:18:26 -0800 Flakiness added https://trac.webkit.org/r145010 849644 2 ap 2013-03-06 19:31:40 -0800 Dean, did you confirm that it's set-cookie-on-redirect.html? I was also seeing this flakiness a few days ago locally, but it seemed to me that this was some other test, possibly from another directory. I did not have an opportunity to investigate. I don't know why this would affect bot performance though. The failing tests are re-run, but that should be orders of magnitude faster than running all tests. Or is it something in EWS logic that makes us re-run all the tests? 849830 3 svillar 2013-03-07 00:40:44 -0800 (In reply to comment #2) > Dean, did you confirm that it's set-cookie-on-redirect.html? I was also seeing this flakiness a few days ago locally, but it seemed to me that this was some other test, possibly from another directory. I did not have an opportunity to investigate. > > I don't know why this would affect bot performance though. The failing tests are re-run, but that should be orders of magnitude faster than running all tests. Or is it something in EWS logic that makes us re-run all the tests? As Alexey mentions first of all we must ensure that the new test is causing the flakiness. Looks like the cookies' testing infrastructure easily leads to flaky results. In any case, if you find that the test I added is indeed the culprit I'll be happy to help. BTW I have just remembered that the relaxing test did not have the typical cleanAllCookies() at the beginning, so any test leaving a cookie in the jar by mistake could be compromising its behavior. 852594 4 ap 2013-03-11 12:43:36 -0700 Dean, did the change help? Note that one of the paths you added is non-existent, there is no http/tests/cookies/third-party-cookie-accept-policy.html test. 919575 5 ap 2013-08-21 12:27:18 -0700 This is actually the case, and the underlying reason is a lower level issue, <rdar://problem/10080130>. I'm looking into whether I can devise a workaround. 919587 6 209294 ap 2013-08-21 12:52:57 -0700 Created attachment 209294 proposed fix 919618 7 209294 commit-queue 2013-08-21 13:57:31 -0700 Comment on attachment 209294 proposed fix Clearing flags on attachment: 209294 Committed r154410: <http://trac.webkit.org/changeset/154410> 919619 8 commit-queue 2013-08-21 13:57:33 -0700 All reviewed patches have been landed. Closing bug. 209294 2013-08-21 12:52:57 -0700 2013-08-21 13:57:31 -0700 proposed fix CookiesRedirect.txt text/plain 1879 ap SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE1NDQwMykKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEzLTA4LTIxICBBbGV4ZXkgUHJvc2t1cnlh a292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMTE2NTAKKyAgICAgICAgUkVHUkVTU0lPTiAocjE0MzkzMSk6IHNldC1j b29raWUtb24tcmVkaXJlY3QuaHRtbCBzdGlsbCBicmVha2luZyBzdWJzZXF1ZW50IHRlc3RzCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV29yayBhcm91 bmQgPHJkYXI6Ly9wcm9ibGVtLzEwMDgwMTMwPiBieSBtYWtpbmcgdGhlIGNvb2tpZSBwZXJzaXN0 ZW50LCBzZXNzaW9uCisgICAgICAgIGNvb2tpZXMgYXJlIGRlbGV0ZWQgaW4gYSB3YXkgdGhhdCBj b25mdXNlcyBzb21lIGNvZGUgcGF0aHMgaW4gQ0ZOZXR3b3JrLgorCisgICAgICAgIEknbGwgdW5z a2lwIHRlc3RzIGxhdGVyLCB3aXRoIGFub3RoZXIgY29va2llIHJlbGlhYmlsaXR5IGZpeC4KKwor ICAgICAgICAqIGh0dHAvdGVzdHMvY29va2llcy9yZXNvdXJjZXMvc2V0LWNvb2tpZS1vbi1yZWRp cmVjdC5waHA6CisKIDIwMTMtMDgtMjAgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4K IAogICAgICAgICBERkcgc2hvdWxkIGlubGluZSBuZXcgdHlwZWRBcnJheSgpCkluZGV4OiBMYXlv dXRUZXN0cy9odHRwL3Rlc3RzL2Nvb2tpZXMvcmVzb3VyY2VzL3NldC1jb29raWUtb24tcmVkaXJl Y3QucGhwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2h0dHAvdGVzdHMvY29va2llcy9yZXNv dXJjZXMvc2V0LWNvb2tpZS1vbi1yZWRpcmVjdC5waHAJKHJldmlzaW9uIDE1NDMwNCkKKysrIExh eW91dFRlc3RzL2h0dHAvdGVzdHMvY29va2llcy9yZXNvdXJjZXMvc2V0LWNvb2tpZS1vbi1yZWRp cmVjdC5waHAJKHdvcmtpbmcgY29weSkKQEAgLTQsMTMgKzQsMTMgQEAgaWYgKCRfR0VUWydzdGVw J10gPT0gMSkgewogICBoZWFkZXIoJ0xvY2F0aW9uOiBodHRwOi8vbG9jYWxob3N0OjgwMDAvY29v a2llcy9yZXNvdXJjZXMvc2V0LWNvb2tpZS1vbi1yZWRpcmVjdC5waHA/c3RlcD0yJyk7CiB9IGVs c2UgaWYgKCRfR0VUWydzdGVwJ10gPT0gMikgewogICBoZWFkZXIoIkhUVFAvMS4wIDMwMiBGb3Vu ZCIpOwotICBzZXRjb29raWUoInRlc3RfY29va2llIiwgIjEiKTsKKyAgc2V0Y29va2llKCJ0ZXN0 X2Nvb2tpZSIsICIxIiwgdGltZSgpICsgODY0MDApOwogICBoZWFkZXIoJ0xvY2F0aW9uOiBodHRw Oi8vbG9jYWxob3N0OjgwMDAvY29va2llcy9yZXNvdXJjZXMvc2V0LWNvb2tpZS1vbi1yZWRpcmVj dC5waHA/c3RlcD0zJyk7CiB9IGVsc2UgaWYgKCRfR0VUWydzdGVwJ10gPT0gMykgewogICBoZWFk ZXIoIkhUVFAvMS4wIDIwMCBPSyIpOwogICBpZiAoaXNzZXQoJF9DT09LSUVbJ3Rlc3RfY29va2ll J10pKSB7CiAgICAgLyogQ2xlYXIgY29va2llIGluIG9yZGVyIG5vdCB0byBhZmZlY3Qgb3RoZXIg dGVzdHMuICovCi0gICAgc2V0Y29va2llKCJ0ZXN0X2Nvb2tpZSIsICIiLCB0aW1lKCkgLSAxKTsK KyAgICBzZXRjb29raWUoInRlc3RfY29va2llIiwgIiIsIHRpbWUoKSAtIDg2NDAwKTsKIAogICAg IGVjaG8gIlBBU1NFRDogQ29va2llIHN1Y2Nlc3NmdWxseSBzZXRcbiI7CiAgIH0gZWxzZSB7Cg==