111638 2013-03-06 16:03:58 -0800 [chromium] Don't get callbacks or create GrContext from unowned WebGraphicsContext3D 2013-03-06 16:31:41 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 danakj danakj backer jamesr piman webkit.review.bot oldest_to_newest 849402 0 danakj 2013-03-06 16:03:58 -0800 [chromium] Don't get callbacks or create GrContext from unowned WebGraphicsContext3D 849405 1 191858 danakj 2013-03-06 16:06:00 -0800 Created attachment 191858 Patch 849407 2 danakj 2013-03-06 16:06:27 -0800 With this patch, the renderer no longer crashes if I kill the GPU process while watching a flash video. 849420 3 danakj 2013-03-06 16:15:25 -0800 (I have no idea how to test this with a test, if you have an idea I can persue that) 849421 4 danakj 2013-03-06 16:15:52 -0800 Oh, and after https://codereview.chromium.org/12506003/ flash won't hit this path anymore. 849441 5 191858 webkit.review.bot 2013-03-06 16:31:38 -0800 Comment on attachment 191858 Patch Clearing flags on attachment: 191858 Committed r145004: <http://trac.webkit.org/changeset/145004> 849442 6 webkit.review.bot 2013-03-06 16:31:41 -0800 All reviewed patches have been landed. Closing bug. 191858 2013-03-06 16:06:00 -0800 2013-03-06 16:31:38 -0800 Patch bug-111638-20130306190205.patch text/plain 4837 danakj U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0OTkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDE1MmFmMmE5NDFhMzFk NGQyMTAxYzZjMjc0OTQwOTllZDk1MWUwYi4uZDNhOWZhMWMxZjc0MGJiNjY2NDI4MTY2MjNkMzcz ZjUyYzhjNWRmOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEzLTAzLTA2ICBEYW5h IEphbnNlbnMgIDxkYW5ha2pAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0gRG9u J3QgZ2V0IGNhbGxiYWNrcyBvciBjcmVhdGUgR3JDb250ZXh0IGZyb20gdW5vd25lZCBXZWJHcmFw aGljc0NvbnRleHQzRAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTExNjM4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgSWYgdGhlIGNvbnRleHQgaXMgbm90IG93bmVkLCBpdCdzIGxpZmV0aW1lIGlzIG5vdCBn dWFyYW50ZWVkLCBhbmQgYnkgdGhlIHRpbWUKKyAgICAgICAgdGhlIEdyYXBoaWNzQ29udGV4dDNE IGlzIGRlc3Ryb3llZCwgdGhlIFdHQzNEIGNhbiBhbHJlYWR5IGJlIGRlbGV0ZWQuCisKKyAgICAg ICAgV2hlbiB0aGUgY29udGV4dCBpcyBub3Qgb3duZWQgYnkgdGhlIEdyYXBoaWNzQ29udGV4dDNE LCB0aGVuIGRvbid0IGNsZWFuIGl0IHVwCisgICAgICAgIGluIHRoZSBkZXN0cnVjdG9yIG9yIHNl dCB1cCBjYWxsYmFja3MsIGFzIHRoZXNlIGFyZSB0aGUgb3duZXIncyByZXNwb25zaWJpbGl0eS4K KworICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVtL3N1cHBvcnQvR3JhcGhpY3NDb250ZXh0M0RQ cml2YXRlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dDNEUHJpdmF0ZTo6 fkdyYXBoaWNzQ29udGV4dDNEUHJpdmF0ZSk6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0Nv bnRleHQzRFByaXZhdGU6OmdyQ29udGV4dCk6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0Nv bnRleHQzRFByaXZhdGU6OnNldENvbnRleHRMb3N0Q2FsbGJhY2spOgorICAgICAgICAoV2ViQ29y ZTo6R3JhcGhpY3NDb250ZXh0M0RQcml2YXRlOjpzZXRFcnJvck1lc3NhZ2VDYWxsYmFjayk6CisK IDIwMTMtMDMtMDYgIEFua3VyIFRhbHkgIDxhdGFseUBnb29nbGUuY29tPgogCiAgICAgICAgIE1v ZGlmeSBsb2cgbWV0aG9kIGluIFY4RE9NQWN0aXZpdHlMb2dnZXIgc28gdGhhdCB0aGUgYXBpTmFt ZSBhbmQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL3N1cHBv cnQvR3JhcGhpY3NDb250ZXh0M0RQcml2YXRlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2Nocm9taXVtL3N1cHBvcnQvR3JhcGhpY3NDb250ZXh0M0RQcml2YXRlLmNwcAppbmRleCAwOWMw NjYzYWNmZDQxMDBjNzRiOWUyMjg0MDE5OTVhNjAwODk3OTMxLi4xNjFiMTY2NmFlZmQ2MjM5OWRl ZTYxYjJmN2UxMmY1MjM3YTY3NzY0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9jaHJvbWl1bS9zdXBwb3J0L0dyYXBoaWNzQ29udGV4dDNEUHJpdmF0ZS5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vc3VwcG9ydC9HcmFwaGljc0NvbnRleHQzRFBy aXZhdGUuY3BwCkBAIC04MCw5ICs4MCw5IEBAIEdyYXBoaWNzQ29udGV4dDNEUHJpdmF0ZTo6R3Jh cGhpY3NDb250ZXh0M0RQcml2YXRlKFdlYktpdDo6V2ViR3JhcGhpY3NDb250ZXh0M0QqCiAKIEdy YXBoaWNzQ29udGV4dDNEUHJpdmF0ZTo6fkdyYXBoaWNzQ29udGV4dDNEUHJpdmF0ZSgpCiB7Ci0g ICAgaWYgKG1fZ3JDb250ZXh0KSB7Ci0gICAgICAgIG1faW1wbC0+c2V0TWVtb3J5QWxsb2NhdGlv bkNoYW5nZWRDYWxsYmFja0NIUk9NSVVNKDApOwotICAgICAgICBtX2dyQ29udGV4dC0+Y29udGV4 dERlc3Ryb3llZCgpOworICAgIGlmIChtX293bmVkR3JDb250ZXh0KSB7CisgICAgICAgIG1fb3du ZWRXZWJDb250ZXh0LT5zZXRNZW1vcnlBbGxvY2F0aW9uQ2hhbmdlZENhbGxiYWNrQ0hST01JVU0o MCk7CisgICAgICAgIG1fb3duZWRHckNvbnRleHQtPmNvbnRleHREZXN0cm95ZWQoKTsKICAgICB9 CiB9CiAKQEAgLTE0NSwxMyArMTQ1LDE1IEBAIEdyQ29udGV4dCogR3JhcGhpY3NDb250ZXh0M0RQ cml2YXRlOjpnckNvbnRleHQoKQogewogICAgIGlmIChtX2dyQ29udGV4dCkKICAgICAgICAgcmV0 dXJuIG1fZ3JDb250ZXh0OworICAgIGlmICghbV9vd25lZFdlYkNvbnRleHQpCisgICAgICAgIHJl dHVybiAwOwogCi0gICAgU2tBdXRvVFVucmVmPEdyR0xJbnRlcmZhY2U+IGludGVyZmFjZShtX2lt cGwtPmNyZWF0ZUdyR0xJbnRlcmZhY2UoKSk7CisgICAgU2tBdXRvVFVucmVmPEdyR0xJbnRlcmZh Y2U+IGludGVyZmFjZShtX293bmVkV2ViQ29udGV4dC0+Y3JlYXRlR3JHTEludGVyZmFjZSgpKTsK ICAgICBpZiAoIWludGVyZmFjZSkKICAgICAgICAgcmV0dXJuIDA7CiAKICAgICBpbnRlcmZhY2Ut PmZDYWxsYmFjayA9IGJpbmRXZWJHcmFwaGljc0NvbnRleHQzREdMQ29udGV4dENhbGxiYWNrOwot ICAgIGludGVyZmFjZS0+ZkNhbGxiYWNrRGF0YSA9IHJlaW50ZXJwcmV0X2Nhc3Q8R3JHTEludGVy ZmFjZUNhbGxiYWNrRGF0YT4obV9pbXBsKTsKKyAgICBpbnRlcmZhY2UtPmZDYWxsYmFja0RhdGEg PSByZWludGVycHJldF9jYXN0PEdyR0xJbnRlcmZhY2VDYWxsYmFja0RhdGE+KG1fb3duZWRXZWJD b250ZXh0LmdldCgpKTsKIAogICAgIG1fb3duZWRHckNvbnRleHQucmVzZXQoR3JDb250ZXh0OjpD cmVhdGUoa09wZW5HTF9HckJhY2tlbmQsIHJlaW50ZXJwcmV0X2Nhc3Q8R3JCYWNrZW5kQ29udGV4 dD4oaW50ZXJmYWNlLmdldCgpKSkpOwogICAgIG1fZ3JDb250ZXh0ID0gbV9vd25lZEdyQ29udGV4 dDsKQEAgLTE2MCw3ICsxNjIsNyBAQCBHckNvbnRleHQqIEdyYXBoaWNzQ29udGV4dDNEUHJpdmF0 ZTo6Z3JDb250ZXh0KCkKIAogICAgIG1fZ3JDb250ZXh0LT5zZXRUZXh0dXJlQ2FjaGVMaW1pdHMo bWF4R2FuZXNoVGV4dHVyZUNhY2hlQ291bnQsIG1heEdhbmVzaFRleHR1cmVDYWNoZUJ5dGVzKTsK ICAgICBtX2dyQ29udGV4dE1lbW9yeUFsbG9jYXRpb25DYWxsYmFja0FkYXB0ZXIgPSBhZG9wdFB0 cihuZXcgR3JNZW1vcnlBbGxvY2F0aW9uQ2hhbmdlZENhbGxiYWNrQWRhcHRlcihtX2dyQ29udGV4 dCkpOwotICAgIG1faW1wbC0+c2V0TWVtb3J5QWxsb2NhdGlvbkNoYW5nZWRDYWxsYmFja0NIUk9N SVVNKG1fZ3JDb250ZXh0TWVtb3J5QWxsb2NhdGlvbkNhbGxiYWNrQWRhcHRlci5nZXQoKSk7Cisg ICAgbV9vd25lZFdlYkNvbnRleHQtPnNldE1lbW9yeUFsbG9jYXRpb25DaGFuZ2VkQ2FsbGJhY2tD SFJPTUlVTShtX2dyQ29udGV4dE1lbW9yeUFsbG9jYXRpb25DYWxsYmFja0FkYXB0ZXIuZ2V0KCkp OwogCiAgICAgcmV0dXJuIG1fZ3JDb250ZXh0OwogfQpAQCAtMjQ4LDggKzI1MCwxMCBAQCBwcml2 YXRlOgogCiB2b2lkIEdyYXBoaWNzQ29udGV4dDNEUHJpdmF0ZTo6c2V0Q29udGV4dExvc3RDYWxs YmFjayhQYXNzT3duUHRyPEdyYXBoaWNzQ29udGV4dDNEOjpDb250ZXh0TG9zdENhbGxiYWNrPiBj YWxsYmFjaykKIHsKLSAgICBtX2NvbnRleHRMb3N0Q2FsbGJhY2tBZGFwdGVyID0gYWRvcHRQdHIo bmV3IEdyYXBoaWNzQ29udGV4dDNEQ29udGV4dExvc3RDYWxsYmFja0FkYXB0ZXIoY2FsbGJhY2sp KTsKLSAgICBtX2ltcGwtPnNldENvbnRleHRMb3N0Q2FsbGJhY2sobV9jb250ZXh0TG9zdENhbGxi YWNrQWRhcHRlci5nZXQoKSk7CisgICAgaWYgKG1fb3duZWRXZWJDb250ZXh0KSB7CisgICAgICAg IG1fY29udGV4dExvc3RDYWxsYmFja0FkYXB0ZXIgPSBhZG9wdFB0cihuZXcgR3JhcGhpY3NDb250 ZXh0M0RDb250ZXh0TG9zdENhbGxiYWNrQWRhcHRlcihjYWxsYmFjaykpOworICAgICAgICBtX293 bmVkV2ViQ29udGV4dC0+c2V0Q29udGV4dExvc3RDYWxsYmFjayhtX2NvbnRleHRMb3N0Q2FsbGJh Y2tBZGFwdGVyLmdldCgpKTsKKyAgICB9CiB9CiAKIGNsYXNzIEdyYXBoaWNzQ29udGV4dDNERXJy b3JNZXNzYWdlQ2FsbGJhY2tBZGFwdGVyIDogcHVibGljIFdlYktpdDo6V2ViR3JhcGhpY3NDb250 ZXh0M0Q6OldlYkdyYXBoaWNzRXJyb3JNZXNzYWdlQ2FsbGJhY2sgewpAQCAtMjY5LDggKzI3Mywx MCBAQCBwcml2YXRlOgogCiB2b2lkIEdyYXBoaWNzQ29udGV4dDNEUHJpdmF0ZTo6c2V0RXJyb3JN ZXNzYWdlQ2FsbGJhY2soUGFzc093blB0cjxHcmFwaGljc0NvbnRleHQzRDo6RXJyb3JNZXNzYWdl Q2FsbGJhY2s+IGNhbGxiYWNrKQogewotICAgIG1fZXJyb3JNZXNzYWdlQ2FsbGJhY2tBZGFwdGVy ID0gYWRvcHRQdHIobmV3IEdyYXBoaWNzQ29udGV4dDNERXJyb3JNZXNzYWdlQ2FsbGJhY2tBZGFw dGVyKGNhbGxiYWNrKSk7Ci0gICAgbV9pbXBsLT5zZXRFcnJvck1lc3NhZ2VDYWxsYmFjayhtX2Vy cm9yTWVzc2FnZUNhbGxiYWNrQWRhcHRlci5nZXQoKSk7CisgICAgaWYgKG1fb3duZWRXZWJDb250 ZXh0KSB7CisgICAgICAgIG1fZXJyb3JNZXNzYWdlQ2FsbGJhY2tBZGFwdGVyID0gYWRvcHRQdHIo bmV3IEdyYXBoaWNzQ29udGV4dDNERXJyb3JNZXNzYWdlQ2FsbGJhY2tBZGFwdGVyKGNhbGxiYWNr KSk7CisgICAgICAgIG1fb3duZWRXZWJDb250ZXh0LT5zZXRFcnJvck1lc3NhZ2VDYWxsYmFjayht X2Vycm9yTWVzc2FnZUNhbGxiYWNrQWRhcHRlci5nZXQoKSk7CisgICAgfQogfQogCiBFeHRlbnNp b25zM0QqIEdyYXBoaWNzQ29udGV4dDNEUHJpdmF0ZTo6Z2V0RXh0ZW5zaW9ucygpCg==