111633 2013-03-06 15:24:44 -0800 [GTK] Return m_inspectorFilesPath if it is not null 2013-03-06 16:30:01 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 naginenis naginenis mrobinson webkit.review.bot oldest_to_newest 849368 0 naginenis 2013-03-06 15:24:44 -0800 There is a missing return in InspectorClient::inspectorFilesPath(). 849372 1 191851 naginenis 2013-03-06 15:29:13 -0800 Created attachment 191851 Patch 849373 2 191851 mrobinson 2013-03-06 15:30:48 -0800 Comment on attachment 191851 Patch Nice catch! I don't think this one needs owner review. 849436 3 191851 webkit.review.bot 2013-03-06 16:29:58 -0800 Comment on attachment 191851 Patch Clearing flags on attachment: 191851 Committed r145002: <http://trac.webkit.org/changeset/145002> 849437 4 webkit.review.bot 2013-03-06 16:30:01 -0800 All reviewed patches have been landed. Closing bug. 191851 2013-03-06 15:29:13 -0800 2013-03-06 16:29:58 -0800 Patch 111633.patch text/plain 1383 naginenis ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv Z3RrL0NoYW5nZUxvZwppbmRleCBlYTQwZGU5Li42MGM4MmI2IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2d0ay9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTMtMDMtMDYgIFN1ZGFyc2FuYSBOYWdpbmVuaSAgPHN1ZGFyc2Fu YS5uYWdpbmVuaUBpbnRlbC5jb20+CisKKyAgICAgICAgW0dUS10gUmV0dXJuIG1faW5zcGVjdG9y RmlsZXNQYXRoIGlmIGl0IGlzIG5vdCBudWxsCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMTE2MzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBBZGRlZCBtaXNzaW5nIHJldHVybiBpbiBJbnNwZWN0b3JDbGll bnQ6Omluc3BlY3RvckZpbGVzUGF0aCgpLgorCisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvSW5z cGVjdG9yQ2xpZW50R3RrLmNwcDoKKyAgICAgICAgKFdlYktpdDo6SW5zcGVjdG9yQ2xpZW50Ojpp bnNwZWN0b3JGaWxlc1BhdGgpOgorCiAyMDEzLTAzLTA2ICBEb21pbmlxdWUgTGV1ZW5iZXJnZXIg IDxkaW1zdGFyQG9wZW5zdXNlLm9yZz4KIAogICAgICAgICBMaW5rIHRoZSB3ZWJraXRfdGVzdHMg dG8gWFJFTkRFUl9MSUJTLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ndGsvV2ViQ29yZVN1 cHBvcnQvSW5zcGVjdG9yQ2xpZW50R3RrLmNwcCBiL1NvdXJjZS9XZWJLaXQvZ3RrL1dlYkNvcmVT dXBwb3J0L0luc3BlY3RvckNsaWVudEd0ay5jcHAKaW5kZXggYjEyOWM2Zi4uY2Y3MzE1NiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvSW5zcGVjdG9yQ2xpZW50 R3RrLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9JbnNwZWN0b3JD bGllbnRHdGsuY3BwCkBAIC0xNjAsNyArMTYwLDcgQEAgYm9vbCBJbnNwZWN0b3JDbGllbnQ6OnNl bmRNZXNzYWdlVG9Gcm9udGVuZChjb25zdCBTdHJpbmcmIG1lc3NhZ2UpCiBjb25zdCBjaGFyKiBJ bnNwZWN0b3JDbGllbnQ6Omluc3BlY3RvckZpbGVzUGF0aCgpCiB7CiAgICAgaWYgKG1faW5zcGVj dG9yRmlsZXNQYXRoKQotICAgICAgICBtX2luc3BlY3RvckZpbGVzUGF0aC5nZXQoKTsKKyAgICAg ICAgcmV0dXJuIG1faW5zcGVjdG9yRmlsZXNQYXRoLmdldCgpOwogCiAgICAgY29uc3QgY2hhciog ZW52aXJvbm1lbnRQYXRoID0gZ2V0ZW52KCJXRUJLSVRfSU5TUEVDVE9SX1BBVEgiKTsKICAgICBp ZiAoZW52aXJvbm1lbnRQYXRoICYmIGdfZmlsZV90ZXN0KGVudmlyb25tZW50UGF0aCwgR19GSUxF X1RFU1RfSVNfRElSKSkK