111625 2013-03-06 14:17:29 -0800 [V8] Preprocess constant values to avoid a "static_cast<signed int>" in CodeGeneratorV8. 2013-03-07 03:46:12 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mkwst mkwst abarth dcarney dglazkov haraken japhet jochen ossy webkit.review.bot oldest_to_newest 849292 0 mkwst 2013-03-06 14:17:29 -0800 When generating code for constants in IDL files, we're currently pushing the values through "static_cast<signed int>" in order to ensure that values like "0xFFFFFFFF" are properly handled as "-1". There's no reason to do this work in C when Perl is perfectly capable of manipulating text. The FIXME at http://trac.webkit.org/browser/trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm?rev=144976#L2933 has been around since 2009. Now's as good a time as any to take care of it. 849301 1 191832 mkwst 2013-03-06 14:30:07 -0800 Created attachment 191832 Patch 849303 2 mkwst 2013-03-06 14:31:44 -0800 Starting to dabble in bindings. Jochen, Dan, mind taking a look? 849340 3 191832 webkit.review.bot 2013-03-06 15:02:39 -0800 Comment on attachment 191832 Patch Attachment 191832 did not pass chromium-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/17027132 New failing tests: fast/canvas/webgl/css-webkit-canvas-repaint.html fast/canvas/webgl/error-reporting.html fast/canvas/webgl/gl-getstring.html fast/canvas/webgl/copy-tex-image-and-sub-image-2d.html fast/canvas/webgl/drawingbuffer-test.html fast/canvas/webgl/gl-pixelstorei.html fast/canvas/webgl/constants.html http/tests/cache/subresource-failover-to-network.html fast/canvas/webgl/functions-returning-strings.html fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html fast/canvas/webgl/buffer-data-array-buffer.html fast/canvas/webgl/gl-enable-enum-test.html fast/canvas/webgl/get-active-test.html fast/canvas/webgl/context-lost-restored.html fast/canvas/webgl/context-release-upon-reload.html fast/canvas/webgl/buffer-bind-test.html fast/canvas/webgl/gl-get-calls.html fast/canvas/webgl/draw-arrays-out-of-bounds.html fast/canvas/webgl/gl-bind-attrib-location-test.html fast/canvas/webgl/framebuffer-test.html fast/canvas/webgl/canvas-zero-size.html fast/canvas/webgl/context-lost.html fast/canvas/webgl/attrib-location-length-limits.html fast/canvas/webgl/bad-arguments-test.html compositing/webgl/webgl-reflection.html fast/canvas/webgl/gl-enum-tests.html fast/canvas/webgl/draw-elements-out-of-bounds.html fast/canvas/webgl/canvas-2d-webgl-texture.html fast/canvas/webgl/css-webkit-canvas.html fast/canvas/webgl/gl-getshadersource.html 849374 4 191852 mkwst 2013-03-06 15:34:38 -0800 Created attachment 191852 Patch 849549 5 191852 haraken 2013-03-06 17:56:01 -0800 Comment on attachment 191852 Patch ok 849777 6 191852 mkwst 2013-03-06 23:18:27 -0800 Comment on attachment 191852 Patch Thanks. 849800 7 191852 webkit.review.bot 2013-03-06 23:51:10 -0800 Comment on attachment 191852 Patch Clearing flags on attachment: 191852 Committed r145043: <http://trac.webkit.org/changeset/145043> 849801 8 webkit.review.bot 2013-03-06 23:51:14 -0800 All reviewed patches have been landed. Closing bug. 849939 9 ossy 2013-03-07 03:43:32 -0800 (In reply to comment #7) > (From update of attachment 191852 [details]) > Clearing flags on attachment: 191852 > > Committed r145043: <http://trac.webkit.org/changeset/145043> It broke the bindings generation tests. Could you fix it? 849940 10 haraken 2013-03-07 03:46:12 -0800 (In reply to comment #9) > It broke the bindings generation tests. Could you fix it? Sorry every week... Fixed in r145060. 191832 2013-03-06 14:30:07 -0800 2013-03-06 15:34:33 -0800 Patch bug-111625-20130306232543.patch text/plain 3141 mkwst U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0OTcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTI0ZjZiZjg0MmJjOTYy MTJhYmMxNmU1MTU0ZDc5NDc2NDY1MTQyMi4uMWM3NzdhNDY3ZmJiM2E5N2I4NjRmNDdlM2JhYzFj ZjlkYmI1ODZlZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI5IEBACisyMDEzLTAzLTA2ICBNaWtl IFdlc3QgIDxta3dzdEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW1Y4XSBQcmVwcm9jZXNzIGNv bnN0YW50IHZhbHVlcyB0byBhdm9pZCBhICJzdGF0aWNfY2FzdDxzaWduZWQgaW50PiIgaW4gQ29k ZUdlbmVyYXRvclY4LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTExNjI1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgV2hlbiBwcm9jZXNzaW5nIGNvbnN0YW50cyBpbiBJREwgZmlsZXMsIENvZGVHZW5lcmF0 b3JWOCBjdXJyZW50bHkgcnVucworICAgICAgICB0aGUgdmFsdWVzIHRocm91Z2ggJ3N0YXRpY19j YXN0PHNpZ25lZCBpbnQ+JyBpbiB0aGUgZ2VuZXJhdGVkIGNvZGUuIFdlCisgICAgICAgIGNhbiBh dm9pZCB0aGlzIG1pbmlzY3VsZSBiaXQgb2Ygb3ZlcmhlYWQgYnkgcHJlcHJvY2Vzc2luZyB0aGUg aGV4IHZhbHVlCisgICAgICAgIGluIFBlcmwgd2hlbiBnZW5lcmF0aW5nIHRoZSBjb2RlLgorCisg ICAgICAgIFRoZSBGSVhNRSBoYXMgYmVlbiBpbiB0aGUgY29kZSBzaW5jZSBpdCBvcmlnaW5hbGx5 IGxhbmRlZCBpbiAyMDA5WzFdLgorICAgICAgICBOb3cncyBhcyBnb29kIGEgdGltZSBhcyBhbnkg dG8gdGFrZSBjYXJlIG9mIGl0LgorCisgICAgICAgIFsxXTogaHR0cDovL3RyYWMud2Via2l0Lm9y Zy9icm93c2VyL3RydW5rL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVy YXRvclY4LnBtP3Jldj0xNDQ5NzYjTDI5MzMKKworICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMv Q29kZUdlbmVyYXRvclY4LnBtOgorICAgICAgICAoR2VuZXJhdGVJbXBsZW1lbnRhdGlvbik6Cisg ICAgICAgICAgICBJZiB3ZSdyZSBwcmVzZW50ZWQgd2l0aCBhIHN0cmluZyB3aGljaCBiZWdpbnMg d2l0aCAnMHgnLCBydW4gaXQKKyAgICAgICAgICAgIHRocm91Z2ggc29tZSBmYWlybHkgb2J0dXNl IFBlcmxpc21zIHRvIGZpcnN0IGNvbnZlcnQgZnJvbSBhIGhleAorICAgICAgICAgICAgc3RyaW5n IHRvIGFuIGludGVnZXIgKCdoZXgoJHZhbHVlKScpLCAicGFjayIgdGhlIGludGVnZXIgYXMgYW4K KyAgICAgICAgICAgIHVuc2lnbmVkIHZhbHVlICgncGFjaygiUyIsIC4uLiknKSwgYW5kIHRoZW4g InVucGFjayIgaXQgYXMgYQorICAgICAgICAgICAgc2lnbmVkIGludGVnZXIgKCd1bnBhY2soInMi LCAuLi4pJykuIEJlY2F1c2UgdGhhdCdzIF9vZiBjb3Vyc2VfCisgICAgICAgICAgICBob3cgeW91 IHdvdWxkIGRvIHRoaW5ncy4KKwogMjAxMy0wMy0wNiAgQWxwaGEgTGFtICA8aGNsYW1AY2hyb21p dW0ub3JnPgogCiAgICAgICAgIE1vcmUgY2xlYW51cCBpbiBHSUZJbWFnZVJlYWRlcgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0g Yi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQppbmRl eCBlOWFjNTFmYzA0YzBjNWY4ZDExMmViZDI1ZGZlMWQ4MWJmNjJiNTM5Li45OTU4YWQxZGVhYmQ5 MWNjYWExMTZmN2M0MDMxMTYzYzFiY2EwNzJlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9i aW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9i aW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQpAQCAtMjkzMCwxNSArMjkzMCwxNyBA QCBFTkQKICAgICAgICAgaWYgKCRhdHRyRXh0LT57IlY4RW5hYmxlZEF0UnVudGltZSJ9KSB7CiAg ICAgICAgICAgICBwdXNoKEBjb25zdGFudHNFbmFibGVkQXRSdW50aW1lLCAkY29uc3RhbnQpOwog ICAgICAgICB9IGVsc2UgewotICAgICAgICAgICAgIyBGSVhNRTogd2UgbmVlZCB0aGUgc3RhdGlj X2Nhc3QgaGVyZSBvbmx5IGJlY2F1c2Ugb2Ygb25lIGNvbnN0YW50LCBOb2RlRmlsdGVyLmlkbAot ICAgICAgICAgICAgIyBkZWZpbmVzICJjb25zdCB1bnNpZ25lZCBsb25nIFNIT1dfQUxMID0gMHhG RkZGRkZGRiIuICBJdCB3b3VsZCBiZSBiZXR0ZXIgaWYgd2UKLSAgICAgICAgICAgICMgaGFuZGxl ZCB0aGlzIGhlcmUsIGFuZCBjb252ZXJ0ZWQgaXQgdG8gYSAtMSBjb25zdGFudCBpbiB0aGUgYysr IG91dHB1dC4KICAgICAgICAgICAgIGlmICgkY29uZGl0aW9uYWwpIHsKICAgICAgICAgICAgICAg ICBteSAkY29uZGl0aW9uYWxTdHJpbmcgPSAkY29kZUdlbmVyYXRvci0+R2VuZXJhdGVDb25kaXRp b25hbFN0cmluZ0Zyb21BdHRyaWJ1dGVWYWx1ZSgkY29uZGl0aW9uYWwpOwogICAgICAgICAgICAg ICAgIHB1c2goQGltcGxDb250ZW50LCAiI2lmICR7Y29uZGl0aW9uYWxTdHJpbmd9XG4iKTsKICAg ICAgICAgICAgIH0KKyAgICAgICAgICAgICMgSWYgdGhlIHZhbHVlIHdlJ3JlIGRlYWxpbmcgd2l0 aCBpcyBhIGhleCBudW1iZXIsIHByZXByb2Nlc3MgaXQgaW50byBhIHNpZ25lZCBpbnRlZ2VyCisg ICAgICAgICAgICAjIGhlcmUsIHJhdGhlciB0aGFuIHJ1bm5pbmcgc3RhdGljX2Nhc3Q8c2lnbmVk IGludD4gaW4gdGhlIGdlbmVyYXRlZCBjb2RlLgorICAgICAgICAgICAgaWYgKHN1YnN0cigkdmFs dWUsIDAsIDIpIGVxICIweCIpIHsKKyAgICAgICAgICAgICAgJHZhbHVlID0gdW5wYWNrKCdzJywg cGFjaygnUycsIGhleCgkdmFsdWUpKSk7CisgICAgICAgICAgICB9CiAgICAgICAgICAgICBwdXNo KEBpbXBsQ29udGVudCwgPDxFTkQpOwotICAgIHsiJHtuYW1lfSIsIHN0YXRpY19jYXN0PHNpZ25l ZCBpbnQ+KCR2YWx1ZSl9LAorICAgIHsiJHtuYW1lfSIsICR2YWx1ZX0sCiBFTkQKICAgICAgICAg ICAgIHB1c2goQGltcGxDb250ZW50LCAiI2VuZGlmXG4iKSBpZiAkY29uZGl0aW9uYWw7CiAgICAg ICAgIH0K 191852 2013-03-06 15:34:38 -0800 2013-03-06 23:51:10 -0800 Patch bug-111625-20130307003013.patch text/plain 3143 mkwst U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0OTcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTI0ZjZiZjg0MmJjOTYy MTJhYmMxNmU1MTU0ZDc5NDc2NDY1MTQyMi4uODEwMjg0MzlhYTQ4OWI4Y2NlNWM4MzliMDhiMThh NjEzMmMyODBmNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI5IEBACisyMDEzLTAzLTA2ICBNaWtl IFdlc3QgIDxta3dzdEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW1Y4XSBQcmVwcm9jZXNzIGNv bnN0YW50IHZhbHVlcyB0byBhdm9pZCBhICJzdGF0aWNfY2FzdDxzaWduZWQgaW50PiIgaW4gQ29k ZUdlbmVyYXRvclY4LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTExNjI1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgV2hlbiBwcm9jZXNzaW5nIGNvbnN0YW50cyBpbiBJREwgZmlsZXMsIENvZGVHZW5lcmF0 b3JWOCBjdXJyZW50bHkgcnVucworICAgICAgICB0aGUgdmFsdWVzIHRocm91Z2ggJ3N0YXRpY19j YXN0PHNpZ25lZCBpbnQ+JyBpbiB0aGUgZ2VuZXJhdGVkIGNvZGUuIFdlCisgICAgICAgIGNhbiBh dm9pZCB0aGlzIG1pbmlzY3VsZSBiaXQgb2Ygb3ZlcmhlYWQgYnkgcHJlcHJvY2Vzc2luZyB0aGUg aGV4IHZhbHVlCisgICAgICAgIGluIFBlcmwgd2hlbiBnZW5lcmF0aW5nIHRoZSBjb2RlLgorCisg ICAgICAgIFRoZSBGSVhNRSBoYXMgYmVlbiBpbiB0aGUgY29kZSBzaW5jZSBpdCBvcmlnaW5hbGx5 IGxhbmRlZCBpbiAyMDA5WzFdLgorICAgICAgICBOb3cncyBhcyBnb29kIGEgdGltZSBhcyBhbnkg dG8gdGFrZSBjYXJlIG9mIGl0LgorCisgICAgICAgIFsxXTogaHR0cDovL3RyYWMud2Via2l0Lm9y Zy9icm93c2VyL3RydW5rL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVy YXRvclY4LnBtP3Jldj0xNDQ5NzYjTDI5MzMKKworICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMv Q29kZUdlbmVyYXRvclY4LnBtOgorICAgICAgICAoR2VuZXJhdGVJbXBsZW1lbnRhdGlvbik6Cisg ICAgICAgICAgICBJZiB3ZSdyZSBwcmVzZW50ZWQgd2l0aCBhIHN0cmluZyB3aGljaCBiZWdpbnMg d2l0aCAnMHgnLCBydW4gaXQKKyAgICAgICAgICAgIHRocm91Z2ggc29tZSBmYWlybHkgb2J0dXNl IFBlcmxpc21zIHRvIGZpcnN0IGNvbnZlcnQgZnJvbSBhIGhleAorICAgICAgICAgICAgc3RyaW5n IHRvIGFuIGludGVnZXIgKCdoZXgoJHZhbHVlKScpLCAicGFjayIgdGhlIGludGVnZXIgYXMgYW4K KyAgICAgICAgICAgIHVuc2lnbmVkIGludGVnZXIgKCdwYWNrKCJJIiwgLi4uKScpLCBhbmQgdGhl biAidW5wYWNrIiBpdCBhcyBhCisgICAgICAgICAgICBzaWduZWQgaW50ZWdlciAoJ3VucGFjaygi aSIsIC4uLiknKS4gQmVjYXVzZSB0aGF0J3MgX29mIGNvdXJzZV8KKyAgICAgICAgICAgIGhvdyB5 b3Ugd291bGQgZG8gdGhpbmdzLgorCiAyMDEzLTAzLTA2ICBBbHBoYSBMYW0gIDxoY2xhbUBjaHJv bWl1bS5vcmc+CiAKICAgICAgICAgTW9yZSBjbGVhbnVwIGluIEdJRkltYWdlUmVhZGVyCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5w bSBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCmlu ZGV4IGU5YWM1MWZjMDRjMGM1ZjhkMTEyZWJkMjVkZmUxZDgxYmY2MmI1MzkuLmUzOGFmNGQxNTY1 ZGQ5YmU1ZGY0YmY1MDdmM2YyOGY2ZGZjMDE0M2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCkBAIC0yOTMwLDE1ICsyOTMwLDE3 IEBAIEVORAogICAgICAgICBpZiAoJGF0dHJFeHQtPnsiVjhFbmFibGVkQXRSdW50aW1lIn0pIHsK ICAgICAgICAgICAgIHB1c2goQGNvbnN0YW50c0VuYWJsZWRBdFJ1bnRpbWUsICRjb25zdGFudCk7 CiAgICAgICAgIH0gZWxzZSB7Ci0gICAgICAgICAgICAjIEZJWE1FOiB3ZSBuZWVkIHRoZSBzdGF0 aWNfY2FzdCBoZXJlIG9ubHkgYmVjYXVzZSBvZiBvbmUgY29uc3RhbnQsIE5vZGVGaWx0ZXIuaWRs Ci0gICAgICAgICAgICAjIGRlZmluZXMgImNvbnN0IHVuc2lnbmVkIGxvbmcgU0hPV19BTEwgPSAw eEZGRkZGRkZGIi4gIEl0IHdvdWxkIGJlIGJldHRlciBpZiB3ZQotICAgICAgICAgICAgIyBoYW5k bGVkIHRoaXMgaGVyZSwgYW5kIGNvbnZlcnRlZCBpdCB0byBhIC0xIGNvbnN0YW50IGluIHRoZSBj Kysgb3V0cHV0LgogICAgICAgICAgICAgaWYgKCRjb25kaXRpb25hbCkgewogICAgICAgICAgICAg ICAgIG15ICRjb25kaXRpb25hbFN0cmluZyA9ICRjb2RlR2VuZXJhdG9yLT5HZW5lcmF0ZUNvbmRp dGlvbmFsU3RyaW5nRnJvbUF0dHJpYnV0ZVZhbHVlKCRjb25kaXRpb25hbCk7CiAgICAgICAgICAg ICAgICAgcHVzaChAaW1wbENvbnRlbnQsICIjaWYgJHtjb25kaXRpb25hbFN0cmluZ31cbiIpOwog ICAgICAgICAgICAgfQorICAgICAgICAgICAgIyBJZiB0aGUgdmFsdWUgd2UncmUgZGVhbGluZyB3 aXRoIGlzIGEgaGV4IG51bWJlciwgcHJlcHJvY2VzcyBpdCBpbnRvIGEgc2lnbmVkIGludGVnZXIK KyAgICAgICAgICAgICMgaGVyZSwgcmF0aGVyIHRoYW4gcnVubmluZyBzdGF0aWNfY2FzdDxzaWdu ZWQgaW50PiBpbiB0aGUgZ2VuZXJhdGVkIGNvZGUuCisgICAgICAgICAgICBpZiAoc3Vic3RyKCR2 YWx1ZSwgMCwgMikgZXEgIjB4IikgeworICAgICAgICAgICAgICAkdmFsdWUgPSB1bnBhY2soJ2kn LCBwYWNrKCdJJywgaGV4KCR2YWx1ZSkpKTsKKyAgICAgICAgICAgIH0KICAgICAgICAgICAgIHB1 c2goQGltcGxDb250ZW50LCA8PEVORCk7Ci0gICAgeyIke25hbWV9Iiwgc3RhdGljX2Nhc3Q8c2ln bmVkIGludD4oJHZhbHVlKX0sCisgICAgeyIke25hbWV9IiwgJHZhbHVlfSwKIEVORAogICAgICAg ICAgICAgcHVzaChAaW1wbENvbnRlbnQsICIjZW5kaWZcbiIpIGlmICRjb25kaXRpb25hbDsKICAg ICAgICAgfQo=