111620 2013-03-06 13:43:23 -0800 [GTK][WK2] Add webkit_uri_request_set_uri to WebKit2 GTK+ API 2013-03-07 00:08:38 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 83681 P2 Normal --- 0 rego webkit-unassigned cgarcia gustavo gyuyoung.kim mrobinson rakuco webkit.review.bot oldest_to_newest 849265 0 rego 2013-03-06 13:43:23 -0800 This is required to fix the following bug in Epiphany https://bugzilla.gnome.org/show_bug.cgi?id=695300 849271 1 191825 rego 2013-03-06 13:50:07 -0800 Created attachment 191825 Patch 849277 2 webkit.review.bot 2013-03-06 13:58:17 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 849770 3 191825 cgarcia 2013-03-06 23:11:35 -0800 Comment on attachment 191825 Patch Thanks for the patch, but this has already been added, see patch in bug #83681, it hasn't landed in trunk yet because it's waiting for a WebKit2 owner, but landed in the stable branch already. In any case your patch has some issues, you are allowing the API to modify a construct only property, you should change the property to not be construct only, and use webkit_uri_request_set_uri()in the GObject setter too, emitting the notify signal when it changes. 849811 4 rego 2013-03-07 00:08:38 -0800 (In reply to comment #3) > (From update of attachment 191825 [details]) > Thanks for the patch, but this has already been added, see patch in bug #83681, it hasn't landed in trunk yet because it's waiting for a WebKit2 owner, but landed in the stable branch already. In any case your patch has some issues, you are allowing the API to modify a construct only property, you should change the property to not be construct only, and use webkit_uri_request_set_uri()in the GObject setter too, emitting the notify signal when it changes. Ok, sorry for the noise then. Closing as duplicated. *** This bug has been marked as a duplicate of bug 83681 *** 191825 2013-03-06 13:50:07 -0800 2013-03-06 23:11:35 -0800 Patch bug-111620-20130306224612.patch text/plain 3583 rego U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0NjY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZTFhYTI4OTg0ZDUyNGMz NjNhOWZhODA3ODQzNDM3MjhlNGQ2MjdhNC4uMTQ1YTY4OTUzNTgwMzMyNGI5YzMwMmEwNWM3MTY4 NzlmZjlhZmRiZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDEzLTAzLTA2ICBNYW51 ZWwgUmVnbyBDYXNhc25vdmFzICA8cmVnb0BpZ2FsaWEuY29tPgogCisgICAgICAgIFtHVEtdW1dL Ml0gQWRkIHdlYmtpdF91cmlfcmVxdWVzdF9zZXRfdXJpIHRvIFdlYktpdDIgR1RLKyBBUEkKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMTYyMAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEltcGxlbWVudCBt ZXRob2QgdG8gYWxsb3cgbW9kaWZ5IHRoZSBVUkkgb2YgYSBXZWJLaXRVUklSZXF1ZXN0LgorCisg ICAgICAgICogVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0VVJJUmVxdWVzdC5jcHA6CisgICAgICAg ICh3ZWJraXRfdXJpX3JlcXVlc3Rfc2V0X3VyaSk6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9n dGsvV2ViS2l0VVJJUmVxdWVzdC5oOgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZ3RrL2RvY3Mv d2Via2l0Mmd0ay1zZWN0aW9ucy50eHQ6CisKKzIwMTMtMDMtMDYgIE1hbnVlbCBSZWdvIENhc2Fz bm92YXMgIDxyZWdvQGlnYWxpYS5jb20+CisKICAgICAgICAgW1dLMl1bR1RLXSBGaXggdW5pdCB0 ZXN0IFdlYktpdDJBUElUZXN0cy9XZWJLaXRXZWJWaWV3L21vdXNlLXRhcmdldAogICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODI4NjYKIApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0VVJJUmVxdWVzdC5jcHAg Yi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRVUklSZXF1ZXN0LmNwcApp bmRleCAyMTlmMzRmZmZkYzQwODA4ZWIxOGJmODE3MjUxMzRmNWJlZmQxNjVhLi5hYzA2NzRkNGM1 OTRkNjQ4OGE2MDFiNGM2NzNmNjc1OGY2MjM2N2Y4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRVUklSZXF1ZXN0LmNwcAorKysgYi9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRVUklSZXF1ZXN0LmNwcApAQCAtNDIsNiArNDIs OCBAQCB1c2luZyBuYW1lc3BhY2UgV2ViQ29yZTsKICAqIHdlYmtpdF91cmlfcmVxdWVzdF9uZXco KSBtZXRob2QsIGFuZCB5b3UgY2FuIGdldCB0aGUgVVJJIG9mIGFuCiAgKiBleGlzdGluZyByZXF1 ZXN0IHdpdGggdGhlIHdlYmtpdF91cmlfcmVxdWVzdF9nZXRfdXJpKCkgb25lLgogICoKKyAqIElm IHlvdSBuZWVkIHRvIG1vZGlmeSB0aGUgVVJJIHlvdSBjYW4gdXNlIHdlYmtpdF91cmlfcmVxdWVz dF9zZXRfdXJpKCkuCisgKgogICovCiAKIHN0cnVjdCBfV2ViS2l0VVJJUmVxdWVzdFByaXZhdGUg ewpAQCAtMTI1LDYgKzEyNywyNSBAQCBjb25zdCBnY2hhciogd2Via2l0X3VyaV9yZXF1ZXN0X2dl dF91cmkoV2ViS2l0VVJJUmVxdWVzdCogcmVxdWVzdCkKICAgICByZXR1cm4gcmVxdWVzdC0+cHJp di0+dXJpLmRhdGEoKTsKIH0KIAorLyoqCisgKiB3ZWJraXRfdXJpX3JlcXVlc3Rfc2V0X3VyaToK KyAqIEByZXF1ZXN0OiBhICNXZWJLaXRVUklSZXF1ZXN0CisgKiBAdXJpOiBhIG5ldyB1cmkKKyAq CisgKiBTZXQgYSBuZXcgVVJJIGZvciB0aGUgI1dlYktpdFVSSVJlcXVlc3QuCisgKi8KK3ZvaWQg d2Via2l0X3VyaV9yZXF1ZXN0X3NldF91cmkoV2ViS2l0VVJJUmVxdWVzdCogcmVxdWVzdCwgY29u c3QgZ2NoYXIqIHVyaSkKK3sKKyAgICBnX3JldHVybl9pZl9mYWlsKFdFQktJVF9JU19VUklfUkVR VUVTVChyZXF1ZXN0KSk7CisgICAgZ19yZXR1cm5faWZfZmFpbCh1cmkpOworCisgICAgV2ViS2l0 VVJJUmVxdWVzdFByaXZhdGUqIHByaXYgPSByZXF1ZXN0LT5wcml2OworICAgIGlmIChwcml2LT51 cmkgPT0gdXJpKQorICAgICAgICByZXR1cm47CisKKyAgICBwcml2LT51cmkgPSB1cmk7Cit9CisK IFdlYktpdFVSSVJlcXVlc3QqIHdlYmtpdFVSSVJlcXVlc3RDcmVhdGVGb3JSZXNvdXJjZVJlcXVl c3QoY29uc3QgV2ViQ29yZTo6UmVzb3VyY2VSZXF1ZXN0JiByZXNvdXJjZVJlcXVlc3QpCiB7CiAg ICAgV2ViS2l0VVJJUmVxdWVzdCogdXJpUmVxdWVzdCA9IFdFQktJVF9VUklfUkVRVUVTVChnX29i amVjdF9uZXcoV0VCS0lUX1RZUEVfVVJJX1JFUVVFU1QsIE5VTEwpKTsKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFVSSVJlcXVlc3QuaCBiL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFVSSVJlcXVlc3QuaAppbmRleCA1MjM2 MDY5YjM3YmEyYWNkYTEwZDBmYzZhYTI3ZmQyMDI4MTIzYmVhLi5iM2IyYjZlN2JkYmEyN2I4MWIx ODI3ZWJkODFiNjg0ODU5NWRmM2IwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL2d0ay9XZWJLaXRVUklSZXF1ZXN0LmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9ndGsvV2ViS2l0VVJJUmVxdWVzdC5oCkBAIC02MSw2ICs2MSwxMCBAQCB3ZWJraXRf dXJpX3JlcXVlc3RfbmV3ICAgICAgKGNvbnN0IGdjaGFyICAgICAgKnVyaSk7CiBXRUJLSVRfQVBJ IGNvbnN0IGdjaGFyICoKIHdlYmtpdF91cmlfcmVxdWVzdF9nZXRfdXJpICAoV2ViS2l0VVJJUmVx dWVzdCAqcmVxdWVzdCk7CiAKK1dFQktJVF9BUEkgdm9pZAord2Via2l0X3VyaV9yZXF1ZXN0X3Nl dF91cmkgIChXZWJLaXRVUklSZXF1ZXN0ICpyZXF1ZXN0LAorICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBjb25zdCBnY2hhciAgICAgICp1cmkpOworCiBHX0VORF9ERUNMUwogCiAjZW5kaWYK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL2RvY3Mvd2Via2l0 Mmd0ay1zZWN0aW9ucy50eHQgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9kb2Nz L3dlYmtpdDJndGstc2VjdGlvbnMudHh0CmluZGV4IGY2ZThhODQ3NzdiZTI3YjQ1YmVkZTMwMzY1 YjI0NDA5ZmIyYTI5Y2EuLmViMmJiMTdhNGRlOTRmMGI2YTY0ZDgxZDQxOTVlZDNkZTFiZWNiZGMg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL2RvY3Mvd2Via2l0 Mmd0ay1zZWN0aW9ucy50eHQKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsv ZG9jcy93ZWJraXQyZ3RrLXNlY3Rpb25zLnR4dApAQCAtMzMwLDYgKzMzMCw3IEBAIHdlYmtpdF9z ZXR0aW5nc19nZXRfdHlwZQogV2ViS2l0VVJJUmVxdWVzdAogd2Via2l0X3VyaV9yZXF1ZXN0X25l dwogd2Via2l0X3VyaV9yZXF1ZXN0X2dldF91cmkKK3dlYmtpdF91cmlfcmVxdWVzdF9zZXRfdXJp CiAKIDxTVUJTRUNUSU9OIFN0YW5kYXJkPgogV2ViS2l0VVJJUmVxdWVzdENsYXNzCg==