11162 2006-10-05 05:00:09 -0700 WebFrame calls Frame::begin() too early when loading requests 2006-10-06 12:10:09 -0700 1 1 1 Unclassified WebKit Platform 420+ PC Windows XP RESOLVED FIXED P2 Normal --- 11190 1 fishd fishd oldest_to_newest 54450 0 fishd 2006-10-05 05:00:09 -0700 WebFrame calls Frame::begin() too early when loading requests. It currently calls Frame::begin() from WebFrame::loadDataSource, but it should hold off until it gets the receivedResponse callback from the ResourceLoader. Doing so will make it easy to feed mime type information into the Frame code. 54451 1 10920 fishd 2006-10-05 05:05:42 -0700 Created attachment 10920 patch Note, this patch gets us setup to specify the actual mime type of the response once we have that information available via the PlatformResponse object. For now, this patch just feeds WebCore with "text/html" ... I will gladly comment out that part of the patch (or remove it) if that is desired. 54471 2 10920 darin 2006-10-05 07:40:02 -0700 Comment on attachment 10920 patch Looks fine. r=me 54115 3 mrowe 2006-10-05 14:47:08 -0700 Landed in r16822. 53930 4 occupant4 2006-10-06 12:09:06 -0700 This change causes a crash. Frame::begin() creates the document, which is accessed in WebFrame::loadDataSource(). Without the call to Frame::begin() in that function, we get a NULL dereference. 10920 2006-10-05 05:05:42 -0700 2006-10-05 07:40:02 -0700 patch fix-1.diff text/plain 2240 fishd SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE2ODAx KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDYtMTAt MDUgIE1vcmdhbkwgIDxtb3JnYW5sLndlYmtpdEB5YWhvby5jb20+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4ZXMgaHR0cDovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTExNjIKKworICAgICAgICAqIENPTS9XZWJGcmFtZS5jcHA6 CisgICAgICAgIChXZWJGcmFtZTo6bG9hZERhdGFTb3VyY2UpOgorICAgICAgICAoV2ViRnJhbWU6 OnJlY2VpdmVkUmVzcG9uc2UpOgorCiAyMDA2LTEwLTA0ICBNYXJrIFJvd2UgIDxiZGFzaEB3ZWJr aXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoYnVpbGQgZml4KS4KSW5kZXg6 IENPTS9XZWJGcmFtZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gQ09NL1dlYkZyYW1lLmNwcAkocmV2aXNp b24gMTY4MDEpCisrKyBDT00vV2ViRnJhbWUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNzIsNyAr MzcyLDYgQEAgSFJFU1VMVCBXZWJGcmFtZTo6bG9hZERhdGFTb3VyY2UoV2ViRGF0YQogICAgICAg ICAgICAgaWYgKFNVQ0NFRURFRChocikpIHsKICAgICAgICAgICAgICAgICBLVVJMIGt1cmwoRGVw cmVjYXRlZFN0cmluZygoRGVwcmVjYXRlZENoYXIqKXVybCwgU3lzU3RyaW5nTGVuKHVybCkpKTsK ICAgICAgICAgICAgICAgICBkLT5mcmFtZS0+ZGlkT3BlblVSTChrdXJsKTsKLSAgICAgICAgICAg ICAgICBkLT5mcmFtZS0+YmVnaW4oa3VybCk7CiAgICAgICAgICAgICAgICAgU3RyaW5nIG1ldGhv ZFN0cmluZyhtZXRob2QsIFN5c1N0cmluZ0xlbihtZXRob2QpKTsKICAgICAgICAgICAgICAgICBS ZXNvdXJjZUxvYWRlciogam9iOwogICAgICAgICAgICAgICAgIGNvbnN0IEZvcm1EYXRhKiBmb3Jt RGF0YSA9IDA7CkBAIC00ODksMTMgKzQ4OCwzMiBAQCB2b2lkIFdlYkZyYW1lOjpyZWNlaXZlZFJl ZGlyZWN0KFJlc291cmNlCiAKIHZvaWQgV2ViRnJhbWU6OnJlY2VpdmVkUmVzcG9uc2UoUmVzb3Vy Y2VMb2FkZXIqLCBQbGF0Zm9ybVJlc3BvbnNlKQogeworICAgIC8vIENvbW1pdCB0aGUgcHJvdmlz aW9uYWwgZGF0YSBzb3VyY2UKKwogICAgIGlmIChtX3Byb3Zpc2lvbmFsRGF0YVNvdXJjZSkgewog ICAgICAgICBtX2RhdGFTb3VyY2UgPSBtX3Byb3Zpc2lvbmFsRGF0YVNvdXJjZTsKICAgICAgICAg bV9wcm92aXNpb25hbERhdGFTb3VyY2UgPSAwOwogICAgIH0KIAotICAgIC8vIEZJWE1FOiBwYXNz IG1pbWUgdHlwZSBvZiByZXNwb25zZSB0byBmcmFtZS4gIHBlcmhhcHMgdGhlIEZyYW1lOjpiZWdp bigpIAotICAgIC8vIHNob3VsZCBiZSBtYWRlIGZyb20gaGVyZS4KKyAgICAvLyBUZWxsIHRoZSBG cmFtZSB0byBleHBlY3QgbmV3IGRhdGEuICBXZSB1c2UgdGhlIFVSTCBvZiB0aGUgZGF0YSBzb3Vy Y2UgaW4KKyAgICAvLyBvcmRlciB0byBhY2NvdW50IGZvciByZWRpcmVjdHMuCisKKyAgICBJV2Vi TXV0YWJsZVVSTFJlcXVlc3QqIHJlcXVlc3Q7CisgICAgbV9kYXRhU291cmNlLT5yZXF1ZXN0KCZy ZXF1ZXN0KTsKKworICAgIEJTVFIgdXJsOworICAgIHJlcXVlc3QtPlVSTCgmdXJsKTsKKyAgICBy ZXF1ZXN0LT5SZWxlYXNlKCk7CisKKyAgICBLVVJMIGt1cmwoRGVwcmVjYXRlZFN0cmluZygoRGVw cmVjYXRlZENoYXIqKXVybCwgU3lzU3RyaW5nTGVuKHVybCkpKTsKKyAgICBTeXNGcmVlU3RyaW5n KHVybCk7CisKKyAgICAvLyBVcGRhdGUgTUlNRSBpbmZvCisgICAgUmVzb3VyY2VSZXF1ZXN0IHIo ZC0+ZnJhbWUtPnJlc291cmNlUmVxdWVzdCgpKTsgICAgCisgICAgci5tX3Jlc3BvbnNlTUlNRVR5 cGUgPSAidGV4dC9odG1sIjsgIC8vIEZJWE1FOiBnZXQgZnJvbSBQbGF0Zm9ybVJlc3BvbnNlCisg ICAgZC0+ZnJhbWUtPnNldFJlc291cmNlUmVxdWVzdChyKTsKKworICAgIGQtPmZyYW1lLT5iZWdp bihrdXJsKTsKIAogICAgIElXZWJGcmFtZUxvYWREZWxlZ2F0ZSogZnJhbWVMb2FkRGVsZWdhdGU7 CiAgICAgaWYgKFNVQ0NFRURFRChkLT53ZWJWaWV3LT5mcmFtZUxvYWREZWxlZ2F0ZSgmZnJhbWVM b2FkRGVsZWdhdGUpKSkgewo=