111618 2013-03-06 13:13:46 -0800 [BlackBerry] Selection handles don't drag to expand correctly for RTL languages 2013-03-06 14:14:33 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 nghanavatian nghanavatian mifenton rwlbuis tonikitoo webkit.review.bot oldest_to_newest 849231 0 nghanavatian 2013-03-06 13:13:46 -0800 SSIA 849234 1 191816 nghanavatian 2013-03-06 13:15:04 -0800 Created attachment 191816 Patch 849238 2 191816 mifenton 2013-03-06 13:19:05 -0800 Comment on attachment 191816 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=191816&action=review > Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp:76 > + , m_isDirectionalOffsetSetToRTL(false) Is this variable needed? It's not used in this patch. 849250 3 191820 nghanavatian 2013-03-06 13:32:22 -0800 Created attachment 191820 Patch 849259 4 191820 rwlbuis 2013-03-06 13:39:38 -0800 Comment on attachment 191820 Patch LGTM. 849284 5 191820 webkit.review.bot 2013-03-06 14:14:30 -0800 Comment on attachment 191820 Patch Clearing flags on attachment: 191820 Committed r144977: <http://trac.webkit.org/changeset/144977> 849285 6 webkit.review.bot 2013-03-06 14:14:33 -0800 All reviewed patches have been landed. Closing bug. 191816 2013-03-06 13:15:04 -0800 2013-03-06 13:32:20 -0800 Patch bug-111618-20130306160439.patch text/plain 3754 nghanavatian U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0MzU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCBkYmU5ZDU2ZGVkYWY0YWU0Mzk0YTEzZjFmNDFhNzZiMGQwNWM4OTlkLi4zNjIwMmE3NTRl MmExNzU4MmU4ZGJhZWZlOWFhOGEyZjg3Nzk5ZjA4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyMyBAQAorMjAxMy0wMy0wMSAgTmltYSBHaGFuYXZhdGlhbiAgPG5n aGFuYXZhdGlhbkByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBTZWxlY3Rpb24gaGFu ZGxlcyBkb24ndCBkcmFnIHRvIGV4cGFuZCBjb3JyZWN0bHkgZm9yIFJUTCBsYW5ndWFnZXMKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMTYxOAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFBSIDMwMzcxMgor ICAgICAgICBJZiB3ZSBhcmUgdXNpbmcgYSBSVEwgbGFuZ3VhZ2UsIHdlIHNob3VsZCBlbnN1cmUg dGhhdCB0aGUgc2VsZWN0aW9uIGhhbmRsZXMgYXJlIGFuZ2xlZCB0aGUgcmlnaHQgd2F5LgorICAg ICAgICBGdXJ0aGVyLCB3aGVuIGV4cGFuZGluZyB0aGUgc2VsZWN0aW9uLCB0aGUgc3RhcnQgYW5k IGVuZCBoYW5kbGVzIHNob3VsZCBiZSBhcHByb3ByaWF0ZWx5IHNldCBzbyB0aGF0CisgICAgICAg IGV4cGFuc2lvbiBpbiB0aGUgbmF0dXJhbCBkaXJlY3Rpb24gaXMgcG9zc2libGUuCisKKyAgICAg ICAgSW50ZXJuYWxseSByZXZpZXdlZCBieQorCisgICAgICAgICogV2ViS2l0U3VwcG9ydC9TZWxl Y3Rpb25IYW5kbGVyLmNwcDoKKyAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6U2VsZWN0aW9u SGFuZGxlcjo6U2VsZWN0aW9uSGFuZGxlcik6CisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6 OlNlbGVjdGlvbkhhbmRsZXI6OnNlbGVjdGlvblBvc2l0aW9uQ2hhbmdlZCk6CisgICAgICAgICog V2ViS2l0U3VwcG9ydC9TZWxlY3Rpb25IYW5kbGVyLmg6CisgICAgICAgIChTZWxlY3Rpb25IYW5k bGVyKToKKwogMjAxMy0wMi0yOCAgTWlrZSBGZW50b24gIDxtaWZlbnRvbkByaW0uY29tPgogCiAg ICAgICAgIFtCbGFja0JlcnJ5XSBNYWludGFpbiB0aGUgZGlyZWN0aW9uYWxpdHkgb2YgdGhlIHNl bGVjdGlvbiBhZnRlciBtb2RpZnlpbmcgdGhlIHNlbGVjdGlvbiB1c2luZyBrZXkgZXZlbnRzLgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvU2VsZWN0 aW9uSGFuZGxlci5jcHAgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9T ZWxlY3Rpb25IYW5kbGVyLmNwcAppbmRleCBiOTZjYzNjMzNmZmJmM2ZkZGY4Y2MxM2QyZTZiMzAz NzdhNTg0Mzc3Li5hNzAxYzg4ODFhODA0NjA5MGQwNmIzZTI3MGY1NzQxNjQ3MDA4N2I5IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9TZWxlY3Rpb25I YW5kbGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9T ZWxlY3Rpb25IYW5kbGVyLmNwcApAQCAtNzMsNiArNzMsNyBAQCBTZWxlY3Rpb25IYW5kbGVyOjpT ZWxlY3Rpb25IYW5kbGVyKFdlYlBhZ2VQcml2YXRlKiBwYWdlKQogICAgICwgbV9jYXJldEFjdGl2 ZShmYWxzZSkKICAgICAsIG1fbGFzdFVwZGF0ZWRFbmRQb2ludElzVmFsaWQoZmFsc2UpCiAgICAg LCBtX2RpZFN1cHByZXNzQ2FyZXRQb3NpdGlvbkNoYW5nZWROb3RpZmljYXRpb24oZmFsc2UpCisg ICAgLCBtX2lzRGlyZWN0aW9uYWxPZmZzZXRTZXRUb1JUTChmYWxzZSkKIHsKIH0KIApAQCAtMTIx MCw3ICsxMjExLDcgQEAgdm9pZCBTZWxlY3Rpb25IYW5kbGVyOjpzZWxlY3Rpb25Qb3NpdGlvbkNo YW5nZWQoYm9vbCBmb3JjZVVwZGF0ZVdpdGhvdXRDaGFuZ2UpCiAgICAgICAgIH0KICAgICB9CiAK LSAgICBpZiAoIWZyYW1lLT5zZWxlY3Rpb24oKS0+c2VsZWN0aW9uKCkuaXNCYXNlRmlyc3QoKSB8 fCBpc1JUTCApIHsKKyAgICBpZiAoIWZyYW1lLT5zZWxlY3Rpb24oKS0+c2VsZWN0aW9uKCkuaXNC YXNlRmlyc3QoKSkgewogICAgICAgICAvLyBFbmQgaGFuZGxlIGNvbWVzIGJlZm9yZSBzdGFydCwg aW52ZXJ0IHRoZSBjYXJldCByZWZlcmVuY2UgcG9pbnRzLgogICAgICAgICBXZWJDb3JlOjpJbnRS ZWN0IHRtcENhcmV0KHN0YXJ0Q2FyZXQpOwogICAgICAgICBzdGFydENhcmV0ID0gZW5kQ2FyZXQ7 CkBAIC0xMjMyLDEwICsxMjMzLDkgQEAgdm9pZCBTZWxlY3Rpb25IYW5kbGVyOjpzZWxlY3Rpb25Q b3NpdGlvbkNoYW5nZWQoYm9vbCBmb3JjZVVwZGF0ZVdpdGhvdXRDaGFuZ2UpCiAgICAgICAgIG1f d2ViUGFnZS0+bV9zZWxlY3Rpb25PdmVybGF5LT5kcmF3KHNlbGVjdGlvbik7CiAgICAgfQogCi0K ICAgICBWaXNpYmxlU2VsZWN0aW9uIGN1cnJlbnRTZWxlY3Rpb24gPSBmcmFtZS0+c2VsZWN0aW9u KCktPnNlbGVjdGlvbigpOwogICAgIFNlbGVjdGlvbkRldGFpbHMgZGV0YWlscyhzdGFydENhcmV0 LCBlbmRDYXJldCwgdmlzaWJsZVNlbGVjdGlvblJlZ2lvbiwgaW5wdXROb2RlT3ZlcnJpZGVzVG91 Y2goKSwKLSAgICAgICAgbV9sYXN0U2VsZWN0aW9uICE9IGN1cnJlbnRTZWxlY3Rpb24sIHJlcXVl c3RlZFNlbGVjdGlvbkhhbmRsZVBvc2l0aW9uKGZyYW1lLT5zZWxlY3Rpb24oKS0+c2VsZWN0aW9u KCkpKTsKKyAgICAgICAgbV9sYXN0U2VsZWN0aW9uICE9IGN1cnJlbnRTZWxlY3Rpb24sIHJlcXVl c3RlZFNlbGVjdGlvbkhhbmRsZVBvc2l0aW9uKGZyYW1lLT5zZWxlY3Rpb24oKS0+c2VsZWN0aW9u KCkpLCBpc1JUTCk7CiAKICAgICBtX3dlYlBhZ2UtPm1fY2xpZW50LT5ub3RpZnlTZWxlY3Rpb25E ZXRhaWxzQ2hhbmdlZChkZXRhaWxzKTsKICAgICBtX2xhc3RTZWxlY3Rpb24gPSBjdXJyZW50U2Vs ZWN0aW9uOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBv cnQvU2VsZWN0aW9uSGFuZGxlci5oIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1 cHBvcnQvU2VsZWN0aW9uSGFuZGxlci5oCmluZGV4IGVhYmU1ODNiNTM1ODA2N2IyM2M2NmFjNzY0 N2RiZWMxZWJmNzI4ZGUuLjhhMDc1NGQ5NDcxNjhiNzg3Yjg1NWJhNjM2YzFjNmNiZDJhNDUzMzYg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L1NlbGVj dGlvbkhhbmRsZXIuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9y dC9TZWxlY3Rpb25IYW5kbGVyLmgKQEAgLTExMyw2ICsxMTMsNyBAQCBwcml2YXRlOgogICAgIGJv b2wgbV9jYXJldEFjdGl2ZTsKICAgICBib29sIG1fbGFzdFVwZGF0ZWRFbmRQb2ludElzVmFsaWQ7 CiAgICAgYm9vbCBtX2RpZFN1cHByZXNzQ2FyZXRQb3NpdGlvbkNoYW5nZWROb3RpZmljYXRpb247 CisgICAgYm9vbCBtX2lzRGlyZWN0aW9uYWxPZmZzZXRTZXRUb1JUTDsKICAgICBCbGFja0JlcnJ5 OjpQbGF0Zm9ybTo6SW50UmVjdFJlZ2lvbiBtX2xhc3RTZWxlY3Rpb25SZWdpb247CiAgICAgV2Vi Q29yZTo6VmlzaWJsZVBvc2l0aW9uIG1fYW5pbWF0aW9uT3ZlcmxheVN0YXJ0UG9zOwogICAgIFdl YkNvcmU6OlZpc2libGVQb3NpdGlvbiBtX2FuaW1hdGlvbk92ZXJsYXlFbmRQb3M7Cg== 191820 2013-03-06 13:32:22 -0800 2013-03-06 14:14:30 -0800 Patch bug-111618-20130306162158.patch text/plain 2784 nghanavatian U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0MzU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCBkYmU5ZDU2ZGVkYWY0YWU0Mzk0YTEzZjFmNDFhNzZiMGQwNWM4OTlkLi4zZGE2OWViNGRh ZThhNGJmYzZlMWRkODRjZjQ4ZDMyNGNjNGQwNGVhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyMyBAQAorMjAxMy0wMy0wMSAgTmltYSBHaGFuYXZhdGlhbiAgPG5n aGFuYXZhdGlhbkByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBTZWxlY3Rpb24gaGFu ZGxlcyBkb24ndCBkcmFnIHRvIGV4cGFuZCBjb3JyZWN0bHkgZm9yIFJUTCBsYW5ndWFnZXMKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMTYxOAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFBSIDMwMzcxMgor ICAgICAgICBJZiB3ZSBhcmUgdXNpbmcgYSBSVEwgbGFuZ3VhZ2UsIHdlIHNob3VsZCBlbnN1cmUg dGhhdCB0aGUgc2VsZWN0aW9uIGhhbmRsZXMgYXJlIGFuZ2xlZCB0aGUgcmlnaHQgd2F5LgorICAg ICAgICBGdXJ0aGVyLCB3aGVuIGV4cGFuZGluZyB0aGUgc2VsZWN0aW9uLCB0aGUgc3RhcnQgYW5k IGVuZCBoYW5kbGVzIHNob3VsZCBiZSBhcHByb3ByaWF0ZWx5IHNldCBzbyB0aGF0CisgICAgICAg IGV4cGFuc2lvbiBpbiB0aGUgbmF0dXJhbCBkaXJlY3Rpb24gaXMgcG9zc2libGUuCisKKyAgICAg ICAgSW50ZXJuYWxseSByZXZpZXdlZCBieSBNaWtlIEZlbnRvbi4KKworICAgICAgICAqIFdlYktp dFN1cHBvcnQvU2VsZWN0aW9uSGFuZGxlci5jcHA6CisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJL aXQ6OlNlbGVjdGlvbkhhbmRsZXI6OlNlbGVjdGlvbkhhbmRsZXIpOgorICAgICAgICAoQmxhY2tC ZXJyeTo6V2ViS2l0OjpTZWxlY3Rpb25IYW5kbGVyOjpzZWxlY3Rpb25Qb3NpdGlvbkNoYW5nZWQp OgorICAgICAgICAqIFdlYktpdFN1cHBvcnQvU2VsZWN0aW9uSGFuZGxlci5oOgorICAgICAgICAo U2VsZWN0aW9uSGFuZGxlcik6CisKIDIwMTMtMDItMjggIE1pa2UgRmVudG9uICA8bWlmZW50b25A cmltLmNvbT4KIAogICAgICAgICBbQmxhY2tCZXJyeV0gTWFpbnRhaW4gdGhlIGRpcmVjdGlvbmFs aXR5IG9mIHRoZSBzZWxlY3Rpb24gYWZ0ZXIgbW9kaWZ5aW5nIHRoZSBzZWxlY3Rpb24gdXNpbmcg a2V5IGV2ZW50cy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRT dXBwb3J0L1NlbGVjdGlvbkhhbmRsZXIuY3BwIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dl YktpdFN1cHBvcnQvU2VsZWN0aW9uSGFuZGxlci5jcHAKaW5kZXggYjk2Y2MzYzMzZmZiZjNmZGRm OGNjMTNkMmU2YjMwMzc3YTU4NDM3Ny4uMDYyNjAxN2JkYjIzYTkxNjdmNjBhMTc1N2FlYjVmMjc0 ZDNmZjE3MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBv cnQvU2VsZWN0aW9uSGFuZGxlci5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dl YktpdFN1cHBvcnQvU2VsZWN0aW9uSGFuZGxlci5jcHAKQEAgLTEyMTAsNyArMTIxMCw3IEBAIHZv aWQgU2VsZWN0aW9uSGFuZGxlcjo6c2VsZWN0aW9uUG9zaXRpb25DaGFuZ2VkKGJvb2wgZm9yY2VV cGRhdGVXaXRob3V0Q2hhbmdlKQogICAgICAgICB9CiAgICAgfQogCi0gICAgaWYgKCFmcmFtZS0+ c2VsZWN0aW9uKCktPnNlbGVjdGlvbigpLmlzQmFzZUZpcnN0KCkgfHwgaXNSVEwgKSB7CisgICAg aWYgKCFmcmFtZS0+c2VsZWN0aW9uKCktPnNlbGVjdGlvbigpLmlzQmFzZUZpcnN0KCkpIHsKICAg ICAgICAgLy8gRW5kIGhhbmRsZSBjb21lcyBiZWZvcmUgc3RhcnQsIGludmVydCB0aGUgY2FyZXQg cmVmZXJlbmNlIHBvaW50cy4KICAgICAgICAgV2ViQ29yZTo6SW50UmVjdCB0bXBDYXJldChzdGFy dENhcmV0KTsKICAgICAgICAgc3RhcnRDYXJldCA9IGVuZENhcmV0OwpAQCAtMTIzMiwxMCArMTIz Miw5IEBAIHZvaWQgU2VsZWN0aW9uSGFuZGxlcjo6c2VsZWN0aW9uUG9zaXRpb25DaGFuZ2VkKGJv b2wgZm9yY2VVcGRhdGVXaXRob3V0Q2hhbmdlKQogICAgICAgICBtX3dlYlBhZ2UtPm1fc2VsZWN0 aW9uT3ZlcmxheS0+ZHJhdyhzZWxlY3Rpb24pOwogICAgIH0KIAotCiAgICAgVmlzaWJsZVNlbGVj dGlvbiBjdXJyZW50U2VsZWN0aW9uID0gZnJhbWUtPnNlbGVjdGlvbigpLT5zZWxlY3Rpb24oKTsK ICAgICBTZWxlY3Rpb25EZXRhaWxzIGRldGFpbHMoc3RhcnRDYXJldCwgZW5kQ2FyZXQsIHZpc2li bGVTZWxlY3Rpb25SZWdpb24sIGlucHV0Tm9kZU92ZXJyaWRlc1RvdWNoKCksCi0gICAgICAgIG1f bGFzdFNlbGVjdGlvbiAhPSBjdXJyZW50U2VsZWN0aW9uLCByZXF1ZXN0ZWRTZWxlY3Rpb25IYW5k bGVQb3NpdGlvbihmcmFtZS0+c2VsZWN0aW9uKCktPnNlbGVjdGlvbigpKSk7CisgICAgICAgIG1f bGFzdFNlbGVjdGlvbiAhPSBjdXJyZW50U2VsZWN0aW9uLCByZXF1ZXN0ZWRTZWxlY3Rpb25IYW5k bGVQb3NpdGlvbihmcmFtZS0+c2VsZWN0aW9uKCktPnNlbGVjdGlvbigpKSwgaXNSVEwpOwogCiAg ICAgbV93ZWJQYWdlLT5tX2NsaWVudC0+bm90aWZ5U2VsZWN0aW9uRGV0YWlsc0NoYW5nZWQoZGV0 YWlscyk7CiAgICAgbV9sYXN0U2VsZWN0aW9uID0gY3VycmVudFNlbGVjdGlvbjsK