111605 2013-03-06 11:30:10 -0800 [Qt] QWebSettings::clearMemoryCaches should release FastMalloc's free pages to OS 2013-03-08 05:46:03 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) All All RESOLVED FIXED EasyFix P2 Major --- 111094 0 ararunprasad webkit-unassigned allan.jensen arurajku jbriance webkit.review.bot oldest_to_newest 849124 0 ararunprasad 2013-03-06 11:30:10 -0800 Should behave like MemoryPressureHandler::releaseMemory @ MemoryPressureHandlerMac.mm. + WebCore::StorageThread::releaseFastMallocFreeMemoryInAllThreads(); +#if ENABLE(WORKERS) + WebCore::WorkerThread::releaseFastMallocFreeMemoryInAllThreads(); +#endif + WTF::releaseFastMallocFreeMemory(); 850257 1 ararunprasad 2013-03-07 10:35:55 -0800 WTF's FastMalloc(TCMalloc) logic implements memory management which is optimized for faster allocation and release. FastMalloc maintains free-list for each thread and one central list per process to avoid semaphore locking overhead(lock contention). Periodically thread specific free blocks will be moved to central free-list then it will be released back to system using special thread named "scavenger". Incase of memory pressure free-blocks scattered around threads should be released back to OS, so that other processes can use the memory. So modifying QWebSettings::clearMemoryCaches to call FastMalloc's page release functions. I will upload the patch soon. 850272 2 192045 arurajku 2013-03-07 10:49:09 -0800 Created attachment 192045 Patch 850284 3 192046 arurajku 2013-03-07 10:55:58 -0800 Created attachment 192046 #include <wtf/Functional.h> inclusion is not needed 851095 4 192046 jturcotte 2013-03-08 05:22:40 -0800 Comment on attachment 192046 #include <wtf/Functional.h> inclusion is not needed r=me 851109 5 192046 webkit.review.bot 2013-03-08 05:45:59 -0800 Comment on attachment 192046 #include <wtf/Functional.h> inclusion is not needed Clearing flags on attachment: 192046 Committed r145211: <http://trac.webkit.org/changeset/145211> 851110 6 webkit.review.bot 2013-03-08 05:46:03 -0800 All reviewed patches have been landed. Closing bug. 192045 2013-03-07 10:49:09 -0800 2013-03-07 10:55:47 -0800 Patch bug-111605-20130308001511.patch text/plain 1887 arurajku SW5kZXg6IFNvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJLaXQvcXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAxNDUxMDApCisrKyBTb3VyY2UvV2ViS2l0L3F0 L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEzLTAzLTA3ICBB cnVucHJhc2FkIFJhamt1bWFyICA8YXJ1bnByYXNhZHJAbmRzLmNvbT4KKworICAgICAgICBbUXRd IFFXZWJTZXR0aW5nczo6Y2xlYXJNZW1vcnlDYWNoZXMgc2hvdWxkIHJlbGVhc2UgRmFzdE1hbGxv YydzIGZyZWUgcGFnZXMgdG8gT1MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTExMTYwNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogQXBpL3F3ZWJzZXR0aW5ncy5jcHA6CisgICAgICAgIChRV2ViU2V0dGlu Z3M6OmNsZWFyTWVtb3J5Q2FjaGVzKToKKwogMjAxMy0wMy0wNyAgQXJ1bnByYXNhZCBSYWprdW1h ciAgPGFydW5wcmFzYWRyQG5kcy5jb20+CiAKICAgICAgICAgW1F0XSBRV2ViU2V0dGluZ3M6OmNs ZWFyTWVtb3J5Q2FjaGVzIHNob3VsZCBjbGVhciBKUyBnYXJiYWdlCkluZGV4OiBTb3VyY2UvV2Vi S2l0L3F0L0FwaS9xd2Vic2V0dGluZ3MuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQv cXQvQXBpL3F3ZWJzZXR0aW5ncy5jcHAJKHJldmlzaW9uIDE0NTA4NykKKysrIFNvdXJjZS9XZWJL aXQvcXQvQXBpL3F3ZWJzZXR0aW5ncy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQzLDYgKzQzLDgg QEAKICNpbmNsdWRlICJQbHVnaW5EYXRhYmFzZS5oIgogI2luY2x1ZGUgIlJ1bnRpbWVFbmFibGVk RmVhdHVyZXMuaCIKICNpbmNsdWRlICJTZXR0aW5ncy5oIgorI2luY2x1ZGUgIlN0b3JhZ2VUaHJl YWQuaCIKKyNpbmNsdWRlICJXb3JrZXJUaHJlYWQuaCIKICNpbmNsdWRlIDxRRGlyPgogI2luY2x1 ZGUgPFFGaWxlSW5mbz4KICNpbmNsdWRlIDxRRm9udD4KQEAgLTUxLDYgKzUzLDggQEAKICNpbmNs dWRlIDxRU2hhcmVkRGF0YT4KICNpbmNsdWRlIDxRU3RhbmRhcmRQYXRocz4KICNpbmNsdWRlIDxR VXJsPgorI2luY2x1ZGUgPHd0Zi9GYXN0TWFsbG9jLmg+CisjaW5jbHVkZSA8d3RmL0Z1bmN0aW9u YWwuaD4KICNpbmNsdWRlIDx3dGYvdGV4dC9XVEZTdHJpbmcuaD4KIAogCkBAIC04NDUsNiArODQ5 LDEzIEBAIHZvaWQgUVdlYlNldHRpbmdzOjpjbGVhck1lbW9yeUNhY2hlcygpCiAgICAgV2ViQ29y ZTo6Z2NDb250cm9sbGVyKCkuZGlzY2FyZEFsbENvbXBpbGVkQ29kZSgpOwogICAgIC8vIEdhcmJh Z2UgQ29sbGVjdCB0byByZWxlYXNlIHRoZSByZWZlcmVuY2VzIG9mIENhY2hlZFJlc291cmNlIGZy b20gZGVhZCBvYmplY3RzLgogICAgIFdlYkNvcmU6OmdjQ29udHJvbGxlcigpLmdhcmJhZ2VDb2xs ZWN0Tm93KCk7CisKKyAgICAvLyBGYXN0TWFsbG9jIGhhcyBsb2NrLWZyZWUgdGhyZWFkIHNwZWNp ZmljIGNhY2hlcyB0aGF0IGNhbiBvbmx5IGJlIGNsZWFyZWQgZnJvbSB0aGUgdGhyZWFkIGl0c2Vs Zi4KKyAgICBXZWJDb3JlOjpTdG9yYWdlVGhyZWFkOjpyZWxlYXNlRmFzdE1hbGxvY0ZyZWVNZW1v cnlJbkFsbFRocmVhZHMoKTsKKyNpZiBFTkFCTEUoV09SS0VSUykKKyAgICBXZWJDb3JlOjpXb3Jr ZXJUaHJlYWQ6OnJlbGVhc2VGYXN0TWFsbG9jRnJlZU1lbW9yeUluQWxsVGhyZWFkcygpOworI2Vu ZGlmCisgICAgV1RGOjpyZWxlYXNlRmFzdE1hbGxvY0ZyZWVNZW1vcnkoKTsgICAgICAgIAogfQog CiAvKiEK 192046 2013-03-07 10:55:58 -0800 2013-03-08 05:45:59 -0800 #include <wtf/Functional.h> inclusion is not needed bug-111605-20130308002200.patch text/plain 1858 arurajku SW5kZXg6IFNvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJLaXQvcXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAxNDUxMDApCisrKyBTb3VyY2UvV2ViS2l0L3F0 L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEzLTAzLTA3ICBB cnVucHJhc2FkIFJhamt1bWFyICA8YXJ1bnByYXNhZHJAbmRzLmNvbT4KKworICAgICAgICBbUXRd IFFXZWJTZXR0aW5nczo6Y2xlYXJNZW1vcnlDYWNoZXMgc2hvdWxkIHJlbGVhc2UgRmFzdE1hbGxv YydzIGZyZWUgcGFnZXMgdG8gT1MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTExMTYwNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogQXBpL3F3ZWJzZXR0aW5ncy5jcHA6CisgICAgICAgIChRV2ViU2V0dGlu Z3M6OmNsZWFyTWVtb3J5Q2FjaGVzKToKKwogMjAxMy0wMy0wNyAgQXJ1bnByYXNhZCBSYWprdW1h ciAgPGFydW5wcmFzYWRyQG5kcy5jb20+CiAKICAgICAgICAgW1F0XSBRV2ViU2V0dGluZ3M6OmNs ZWFyTWVtb3J5Q2FjaGVzIHNob3VsZCBjbGVhciBKUyBnYXJiYWdlCkluZGV4OiBTb3VyY2UvV2Vi S2l0L3F0L0FwaS9xd2Vic2V0dGluZ3MuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQv cXQvQXBpL3F3ZWJzZXR0aW5ncy5jcHAJKHJldmlzaW9uIDE0NTA4NykKKysrIFNvdXJjZS9XZWJL aXQvcXQvQXBpL3F3ZWJzZXR0aW5ncy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQzLDYgKzQzLDgg QEAKICNpbmNsdWRlICJQbHVnaW5EYXRhYmFzZS5oIgogI2luY2x1ZGUgIlJ1bnRpbWVFbmFibGVk RmVhdHVyZXMuaCIKICNpbmNsdWRlICJTZXR0aW5ncy5oIgorI2luY2x1ZGUgIlN0b3JhZ2VUaHJl YWQuaCIKKyNpbmNsdWRlICJXb3JrZXJUaHJlYWQuaCIKICNpbmNsdWRlIDxRRGlyPgogI2luY2x1 ZGUgPFFGaWxlSW5mbz4KICNpbmNsdWRlIDxRRm9udD4KQEAgLTUxLDYgKzUzLDcgQEAKICNpbmNs dWRlIDxRU2hhcmVkRGF0YT4KICNpbmNsdWRlIDxRU3RhbmRhcmRQYXRocz4KICNpbmNsdWRlIDxR VXJsPgorI2luY2x1ZGUgPHd0Zi9GYXN0TWFsbG9jLmg+CiAjaW5jbHVkZSA8d3RmL3RleHQvV1RG U3RyaW5nLmg+CiAKIApAQCAtODQ1LDYgKzg0OCwxMyBAQCB2b2lkIFFXZWJTZXR0aW5nczo6Y2xl YXJNZW1vcnlDYWNoZXMoKQogICAgIFdlYkNvcmU6OmdjQ29udHJvbGxlcigpLmRpc2NhcmRBbGxD b21waWxlZENvZGUoKTsKICAgICAvLyBHYXJiYWdlIENvbGxlY3QgdG8gcmVsZWFzZSB0aGUgcmVm ZXJlbmNlcyBvZiBDYWNoZWRSZXNvdXJjZSBmcm9tIGRlYWQgb2JqZWN0cy4KICAgICBXZWJDb3Jl OjpnY0NvbnRyb2xsZXIoKS5nYXJiYWdlQ29sbGVjdE5vdygpOworCisgICAgLy8gRmFzdE1hbGxv YyBoYXMgbG9jay1mcmVlIHRocmVhZCBzcGVjaWZpYyBjYWNoZXMgdGhhdCBjYW4gb25seSBiZSBj bGVhcmVkIGZyb20gdGhlIHRocmVhZCBpdHNlbGYuCisgICAgV2ViQ29yZTo6U3RvcmFnZVRocmVh ZDo6cmVsZWFzZUZhc3RNYWxsb2NGcmVlTWVtb3J5SW5BbGxUaHJlYWRzKCk7CisjaWYgRU5BQkxF KFdPUktFUlMpCisgICAgV2ViQ29yZTo6V29ya2VyVGhyZWFkOjpyZWxlYXNlRmFzdE1hbGxvY0Zy ZWVNZW1vcnlJbkFsbFRocmVhZHMoKTsKKyNlbmRpZgorICAgIFdURjo6cmVsZWFzZUZhc3RNYWxs b2NGcmVlTWVtb3J5KCk7ICAgICAgICAKIH0KIAogLyohCg==