111603 2013-03-06 11:16:45 -0800 Cleanup of code and tests for sending multipart FormData 2013-03-06 13:27:45 -0800 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 111380 0 costan webkit-unassigned webkit.review.bot oldest_to_newest 849109 0 costan 2013-03-06 11:16:45 -0800 This bug will receive the cleanup parts of the patch that I was building for 111380. 849119 1 191800 costan 2013-03-06 11:27:21 -0800 Created attachment 191800 Patch 849247 2 191800 webkit.review.bot 2013-03-06 13:27:42 -0800 Comment on attachment 191800 Patch Clearing flags on attachment: 191800 Committed r144974: <http://trac.webkit.org/changeset/144974> 849248 3 webkit.review.bot 2013-03-06 13:27:45 -0800 All reviewed patches have been landed. Closing bug. 191800 2013-03-06 11:27:21 -0800 2013-03-06 13:27:41 -0800 Patch bug-111603-20130306142329.patch text/plain 6975 costan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0NDk1MSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEzLTAzLTA2ICBWaWN0b3Ig Q29zdGFuIDxjb3N0YW5AZ21haWwuY29tPgorCisgICAgICAgIENsZWFudXAgaW4gbXVsdGlwYXJ0 IEZvcm1EYXRhIHNlbmRpbmcgY29kZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTExMTYwMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gVGhpcyBpcyBjbGVhbnVwLgorCisgICAgICAg ICogcGxhdGZvcm0vbmV0d29yay9Gb3JtRGF0YUJ1aWxkZXIuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6YXBwZW5kUXVvdGVkU3RyaW5nKTogdXNlIHByb3BlciB0eXBlcyAoZS5nLCBzaXplX3QgaW5z dGVhZCBvZgorICAgICAgICB1bnNpZ25lZCBsb25nKQorCiAyMDEzLTAzLTA2ICBSYWZhZWwgV2Vp bnN0ZWluICA8cmFmYWVsd0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9s bGluZyBvdXQgcjE0NDkyNC4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsv Rm9ybURhdGFCdWlsZGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9uZXR3b3JrL0Zvcm1EYXRhQnVpbGRlci5jcHAJKHJldmlzaW9uIDE0NDkzMSkKKysrIFNvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvRm9ybURhdGFCdWlsZGVyLmNwcAkod29ya2luZyBj b3B5KQpAQCAtNTksOSArNTksOSBAQCBzdGF0aWMgdm9pZCBhcHBlbmRRdW90ZWRTdHJpbmcoVmVj dG9yPGNoCiAgICAgLy8gQXBwZW5kIGEgc3RyaW5nIGFzIGEgcXVvdGVkIHZhbHVlLCBlc2NhcGlu ZyBxdW90ZXMgYW5kIGxpbmUgYnJlYWtzLgogICAgIC8vIEZJWE1FOiBJcyBpdCBjb3JyZWN0IHRv IHVzZSBwZXJjZW50IGVzY2FwaW5nIGhlcmU/IE90aGVyIGJyb3dzZXJzIGRvIG5vdCBlbmNvZGUg dGhlc2UgY2hhcmFjdGVycyB5ZXQsCiAgICAgLy8gc28gd2Ugc2hvdWxkIHRlc3QgcG9wdWxhciBz ZXJ2ZXJzIHRvIGZpbmQgb3V0IGlmIHRoZXJlIGlzIGFuIGVuY29kaW5nIGZvcm0gdGhleSBjYW4g aGFuZGxlLgotICAgIHVuc2lnbmVkIGxlbmd0aCA9IHN0cmluZy5sZW5ndGgoKTsKLSAgICBmb3Ig KHVuc2lnbmVkIGkgPSAwOyBpIDwgbGVuZ3RoOyArK2kpIHsKLSAgICAgICAgdW5zaWduZWQgY2hh ciBjID0gc3RyaW5nLmRhdGEoKVtpXTsKKyAgICBzaXplX3QgbGVuZ3RoID0gc3RyaW5nLmxlbmd0 aCgpOworICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwgbGVuZ3RoOyArK2kpIHsKKyAgICAgICAg Y2hhciBjID0gc3RyaW5nLmRhdGEoKVtpXTsKIAogICAgICAgICBzd2l0Y2ggKGMpIHsKICAgICAg ICAgY2FzZSAgMHgwYToKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0NDk1MSkKKysrIExheW91dFRlc3Rz L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEzLTAzLTA2ICBW aWN0b3IgQ29zdGFuICA8Y29zdGFuQGdtYWlsLmNvbT4KKworICAgICAgICBDbGVhbnVwIGluIG11 bHRpcGFydCBGb3JtRGF0YSB0ZXN0cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTExMTYwMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogaHR0cC90ZXN0cy9sb2NhbC9mb3JtZGF0YS9yZXNvdXJjZXMvc2Vu ZC1mb3JtLWRhdGEtY29tbW9uLmpzOgorICAgICAgICAoc2VuZEZvcm1EYXRhKTogSmF2YVNjcmlw dCBzdHlsZSBjbGVhbnVwLgorICAgICAgICAodGVzdFNlbmRpbmdGb3JtRGF0YSk6IEphdmFTY3Jp cHQgc3R5bGUsIGJ1Z2ZpeCBpbiBjaGVja2luZyBpZgorICAgICAgICBldmVudFNlbmRlci5iZWdp bkRyYWdXaXRoRmlsZXMgbmVlZHMgdG8gYmUgY2FsbGVkLgorICAgICAgICAqIGh0dHAvdGVzdHMv bG9jYWwvZm9ybWRhdGEvc2VuZC1mb3JtLWRhdGEtd2l0aC1maWxlbmFtZS1leHBlY3RlZC50eHQ6 IEJldHRlciB0ZXN0IGRlc2NyaXB0aW9uLgorICAgICAgICAqIGh0dHAvdGVzdHMvbG9jYWwvZm9y bWRhdGEvc2VuZC1mb3JtLWRhdGEtd2l0aC1maWxlbmFtZS5odG1sOiBCZXR0ZXIgdGVzdCBkZXNj cmlwdGlvbi4KKwogMjAxMy0wMy0wNiAgUmFmYWVsIFdlaW5zdGVpbiAgPHJhZmFlbHdAY2hyb21p dW0ub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxNDQ5MjQuCkluZGV4 OiBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2xvY2FsL2Zvcm1kYXRhL3NlbmQtZm9ybS1kYXRhLXdp dGgtZmlsZW5hbWUtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2h0dHAv dGVzdHMvbG9jYWwvZm9ybWRhdGEvc2VuZC1mb3JtLWRhdGEtd2l0aC1maWxlbmFtZS1leHBlY3Rl ZC50eHQJKHJldmlzaW9uIDE0NDkzMSkKKysrIExheW91dFRlc3RzL2h0dHAvdGVzdHMvbG9jYWwv Zm9ybWRhdGEvc2VuZC1mb3JtLWRhdGEtd2l0aC1maWxlbmFtZS1leHBlY3RlZC50eHQJKHdvcmtp bmcgY29weSkKQEAgLTEsNCArMSw0IEBACi1UZXN0IGZvciBzZW5kaW5nIEZvcm1EYXRhIHZpYSBY TUxIdHRwUmVxdWVzdC4KK1Rlc3QgdGhhdCBmaWxlbmFtZSBwYXNzZWQgdG8gRm9ybURhdGEuYXBw ZW5kKCkgdGFrZXMgcHJlY2VkZW5jZSBvdmVyIGZpbGVuYW1lIGluIEZpbGUuCiAKIE9uIHN1Y2Nl c3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5 ICJURVNUIENPTVBMRVRFIi4KIApJbmRleDogTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9sb2NhbC9m b3JtZGF0YS9zZW5kLWZvcm0tZGF0YS13aXRoLWZpbGVuYW1lLmh0bWwKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g TGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9sb2NhbC9mb3JtZGF0YS9zZW5kLWZvcm0tZGF0YS13aXRo LWZpbGVuYW1lLmh0bWwJKHJldmlzaW9uIDE0NDkzMSkKKysrIExheW91dFRlc3RzL2h0dHAvdGVz dHMvbG9jYWwvZm9ybWRhdGEvc2VuZC1mb3JtLWRhdGEtd2l0aC1maWxlbmFtZS5odG1sCSh3b3Jr aW5nIGNvcHkpCkBAIC04LDcgKzgsNyBAQAogPGRpdiBpZD0iY29uc29sZSI+PC9kaXY+CiA8c2Ny aXB0IHNyYz0icmVzb3VyY2VzL3NlbmQtZm9ybS1kYXRhLWNvbW1vbi5qcyI+PC9zY3JpcHQ+CiA8 c2NyaXB0PgotZGVzY3JpcHRpb24oIlRlc3QgZm9yIHNlbmRpbmcgRm9ybURhdGEgdmlhIFhNTEh0 dHBSZXF1ZXN0LiIpOworZGVzY3JpcHRpb24oIlRlc3QgdGhhdCBmaWxlbmFtZSBwYXNzZWQgdG8g Rm9ybURhdGEuYXBwZW5kKCkgdGFrZXMgcHJlY2VkZW5jZSBvdmVyIGZpbGVuYW1lIGluIEZpbGUu Iik7CiAKIGZ1bmN0aW9uIHJ1blRlc3QoKQogewpJbmRleDogTGF5b3V0VGVzdHMvaHR0cC90ZXN0 cy9sb2NhbC9mb3JtZGF0YS9yZXNvdXJjZXMvc2VuZC1mb3JtLWRhdGEtY29tbW9uLmpzCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIExheW91dFRlc3RzL2h0dHAvdGVzdHMvbG9jYWwvZm9ybWRhdGEvcmVzb3VyY2Vz L3NlbmQtZm9ybS1kYXRhLWNvbW1vbi5qcwkocmV2aXNpb24gMTQ0OTMxKQorKysgTGF5b3V0VGVz dHMvaHR0cC90ZXN0cy9sb2NhbC9mb3JtZGF0YS9yZXNvdXJjZXMvc2VuZC1mb3JtLWRhdGEtY29t bW9uLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0yOCwxMCArMjgsMTAgQEAgZnVuY3Rpb24gc2VuZEZv cm1EYXRhKGZvcm1EYXRhTGlzdCwgZmlsZQogewogICAgIHZhciBmb3JtRGF0YSA9IG5ldyBGb3Jt RGF0YSgpOwogICAgIGZvciAodmFyIGkgPSAwOyBpIDwgZm9ybURhdGFMaXN0Lmxlbmd0aDsgaSsr KSB7Ci0gICAgICAgIGlmIChmb3JtRGF0YUxpc3RbaV1bJ2ZpbGVuYW1lJ10gIT0gdW5kZWZpbmVk KQotICAgICAgICAgICAgZm9ybURhdGEuYXBwZW5kKGZvcm1EYXRhTGlzdFtpXVsnbmFtZSddLCBm b3JtRGF0YUxpc3RbaV1bJ3ZhbHVlJ10sIGZvcm1EYXRhTGlzdFtpXVsnZmlsZW5hbWUnXSk7Cisg ICAgICAgIGlmIChmb3JtRGF0YUxpc3RbaV0uZmlsZW5hbWUgIT09IHVuZGVmaW5lZCkKKyAgICAg ICAgICAgIGZvcm1EYXRhLmFwcGVuZChmb3JtRGF0YUxpc3RbaV0ubmFtZSwgZm9ybURhdGFMaXN0 W2ldLnZhbHVlLCBmb3JtRGF0YUxpc3RbaV0uZmlsZW5hbWUpOwogICAgICAgICBlbHNlCi0gICAg ICAgICAgICBmb3JtRGF0YS5hcHBlbmQoZm9ybURhdGFMaXN0W2ldWyduYW1lJ10sIGZvcm1EYXRh TGlzdFtpXVsndmFsdWUnXSk7CisgICAgICAgICAgICBmb3JtRGF0YS5hcHBlbmQoZm9ybURhdGFM aXN0W2ldLm5hbWUsIGZvcm1EYXRhTGlzdFtpXS52YWx1ZSk7CiAgICAgfQogCiAgICAgdmFyIHho ciA9IG5ldyBYTUxIdHRwUmVxdWVzdCgpOwpAQCAtNDksMTEgKzQ5LDExIEBAIGZ1bmN0aW9uIHRl c3RTZW5kaW5nRm9ybURhdGEoZGF0YUxpc3QsIHMKIHsKICAgICB2YXIgZmlsZXNUb0RyYWcgPSBb XTsKICAgICBmb3IgKHZhciBpID0gMDsgaSA8IGRhdGFMaXN0Lmxlbmd0aDsgaSsrKSB7Ci0gICAg ICAgIGlmIChkYXRhTGlzdFtpXVsndHlwZSddID09ICdmaWxlJykKLSAgICAgICAgICAgIGZpbGVz VG9EcmFnLnB1c2goZGF0YUxpc3RbaV1bJ3ZhbHVlJ10pOworICAgICAgICBpZiAoZGF0YUxpc3Rb aV0udHlwZSA9PT0gJ2ZpbGUnKQorICAgICAgICAgICAgZmlsZXNUb0RyYWcucHVzaChkYXRhTGlz dFtpXS52YWx1ZSk7CiAgICAgfQogCi0gICAgaWYgKGZpbGVzVG9EcmFnKSB7CisgICAgaWYgKGZp bGVzVG9EcmFnLmxlbmd0aCAhPT0gMCkgewogICAgICAgICBldmVudFNlbmRlci5iZWdpbkRyYWdX aXRoRmlsZXMoZmlsZXNUb0RyYWcpOwogICAgICAgICBtb3ZlTW91c2VUb0NlbnRlck9mRWxlbWVu dChmaWxlSW5wdXQpOwogICAgICAgICBldmVudFNlbmRlci5tb3VzZVVwKCk7CkBAIC02MywyMiAr NjMsMjcgQEAgZnVuY3Rpb24gdGVzdFNlbmRpbmdGb3JtRGF0YShkYXRhTGlzdCwgcwogICAgIHZh ciBmb3JtRGF0YUxpc3QgPSBbXTsKICAgICB2YXIgZmlsZVNsaWNlZCA9IGZhbHNlOwogICAgIGZv ciAodmFyIGkgPSAwOyBpIDwgZGF0YUxpc3QubGVuZ3RoOyBpKyspIHsKLSAgICAgICAgaWYgKGRh dGFMaXN0W2ldWyd0eXBlJ10gPT0gJ2ZpbGUnKSB7Ci0gICAgICAgICAgICB2YXIgZmlsZU5hbWUg PSBnZXRGaWxlTmFtZShkYXRhTGlzdFtpXVsndmFsdWUnXSk7CisgICAgICAgIHZhciBmaWVsZCA9 IHtuYW1lOiBkYXRhTGlzdFtpXS5uYW1lfTsKKyAgICAgICAgaWYgKGRhdGFMaXN0W2ldLnR5cGUg PT09ICdmaWxlJykgeworICAgICAgICAgICAgdmFyIGZpbGVOYW1lID0gZ2V0RmlsZU5hbWUoZGF0 YUxpc3RbaV0udmFsdWUpOwogICAgICAgICAgICAgZm9yICh2YXIgaiA9IDA7IGogPCBmaWxlcy5s ZW5ndGg7IGorKykgewogICAgICAgICAgICAgICAgIGlmIChmaWxlTmFtZSA9PSBmaWxlc1tqXS5u YW1lKSB7CiAgICAgICAgICAgICAgICAgICAgIHZhciBmaWxlID0gZmlsZXNbal07Ci0gICAgICAg ICAgICAgICAgICAgIGlmIChkYXRhTGlzdFtpXVsnc3RhcnQnXSAmJiBkYXRhTGlzdFtpXVsnbGVu Z3RoJ10pIHsKKyAgICAgICAgICAgICAgICAgICAgaWYgKCdzdGFydCcgaW4gZGF0YUxpc3RbaV0g JiYgJ2xlbmd0aCcgaW4gZGF0YUxpc3RbaV0pIHsKICAgICAgICAgICAgICAgICAgICAgICAgIGZp bGVTbGljZWQgPSB0cnVlOwotICAgICAgICAgICAgICAgICAgICAgICAgZmlsZSA9IGZpbGUuc2xp Y2UoZGF0YUxpc3RbaV1bJ3N0YXJ0J10sIGRhdGFMaXN0W2ldWydzdGFydCddICsgZGF0YUxpc3Rb aV1bJ2xlbmd0aCddKTsKKyAgICAgICAgICAgICAgICAgICAgICAgIGZpbGUgPSBmaWxlLnNsaWNl KGRhdGFMaXN0W2ldLnN0YXJ0LCBkYXRhTGlzdFtpXS5zdGFydCArIGRhdGFMaXN0W2ldLmxlbmd0 aCk7CiAgICAgICAgICAgICAgICAgICAgIH0KLSAgICAgICAgICAgICAgICAgICAgZm9ybURhdGFM aXN0LnB1c2goeyduYW1lJzogZGF0YUxpc3RbaV1bJ25hbWUnXSwgJ3ZhbHVlJzogZmlsZSwgJ2Zp bGVuYW1lJzogZGF0YUxpc3RbaV1bJ2ZpbGVuYW1lJ119KTsKKyAgICAgICAgICAgICAgICAgICAg ZmllbGQudmFsdWUgPSBmaWxlOwogICAgICAgICAgICAgICAgICAgICBicmVhazsKICAgICAgICAg ICAgICAgICB9CiAgICAgICAgICAgICB9Ci0gICAgICAgIH0gZWxzZSB7Ci0gICAgICAgICAgICBm b3JtRGF0YUxpc3QucHVzaCh7J25hbWUnOiBkYXRhTGlzdFtpXVsnbmFtZSddLCAndmFsdWUnOiBk YXRhTGlzdFtpXVsndmFsdWUnXX0pOwogICAgICAgICB9CisgICAgICAgIGVsc2UKKyAgICAgICAg ICAgIGZpZWxkLnZhbHVlID0gZGF0YUxpc3RbaV0udmFsdWU7CisgICAgICAgIGlmIChkYXRhTGlz dFtpXVsnZmlsZW5hbWUnXSkKKyAgICAgICAgICAgIGZpZWxkLmZpbGVuYW1lID0gZGF0YUxpc3Rb aV0uZmlsZW5hbWU7CisKKyAgICAgICAgZm9ybURhdGFMaXN0LnB1c2goZmllbGQpOwogICAgIH0K IAogICAgIHNlbmRGb3JtRGF0YShmb3JtRGF0YUxpc3QsIGZpbGVTbGljZWQsIHNlbmRBc0FzeW5j LCBhZGRFdmVudEhhbmRsZXJzKTsK